From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EDD7C4345F for ; Thu, 25 Apr 2024 15:39:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 253986B009B; Thu, 25 Apr 2024 11:39:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 203516B009F; Thu, 25 Apr 2024 11:39:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07DA66B00A0; Thu, 25 Apr 2024 11:39:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DD74B6B009B for ; Thu, 25 Apr 2024 11:39:53 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 194B71605FB for ; Thu, 25 Apr 2024 15:39:53 +0000 (UTC) X-FDA: 82048464666.06.A8D2F25 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by imf19.hostedemail.com (Postfix) with ESMTP id 505A61A000A for ; Thu, 25 Apr 2024 15:39:51 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="kc/uews/"; spf=pass (imf19.hostedemail.com: domain of surenb@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714059591; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e0BChCss6w1nIzeILAtQLE3LhBpW3YXUB4HhPqTq7zU=; b=a3HXiCavIFEZmMc7zUFprJpMTNwSJBGXeOL85b4j4V/PP1hMebeH2y/0Gz7pACq1y+rTaw ExmwY2aewAiwmzIQc7qyzimBPncoeO04WzXd9uQVfS7fGVGyQe74RPwIPmFxxidf6vn1AU lKkT/rxV/wtlSBSnd310AyIQ6oGNZPU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714059591; a=rsa-sha256; cv=none; b=4/oPakkgGX+g9ueEQfepqa3ZIY+edEPmQMFu46Yscqa75UI8kleaYmAnHxTyiUnrrSwn8a mCEga4skB2K54u8lhSdl18E2NyC2FGSGwf01DtvO1rO/S+m/2LE7JImQ/RoJ7PHuMDxIo6 yQhVe4g3stnbYfQ4gfseygBXcenOGbM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="kc/uews/"; spf=pass (imf19.hostedemail.com: domain of surenb@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-db4364ecd6aso1289755276.2 for ; Thu, 25 Apr 2024 08:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714059590; x=1714664390; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=e0BChCss6w1nIzeILAtQLE3LhBpW3YXUB4HhPqTq7zU=; b=kc/uews/5OcxXhgg/qvqsuqkqpqkQfXxsVjCHsMaXjmJ6z3jZyhozR8jtXYLdiDUAa lGr9u4j87KpPTFJJCK4EvpA7e/ql1I1zVUwATmQFWFZxKtEPpSSGvMWdyUj07dFRf+W9 84OQuVL5CzTXyvLiA6LFFyF8Pbi4qLTq8Nm3UJqrA2/neziYBpYjo1lJTuLxcDzFmn8A QBK4B1+r5fdt9AekUrz69bYREm+Dmgr6cLhWy3SbMAX1L/ABjtQ8vFlIXk3PKlDMeU+8 um8Jl/2hdSVSaCeMb7r946zeaFrvPLmQhEKJVbj2XRSw6oeFHHT+BCCnEMxZQwIxSZfZ 9KCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714059590; x=1714664390; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e0BChCss6w1nIzeILAtQLE3LhBpW3YXUB4HhPqTq7zU=; b=eqfo5cY7pVTJXBtZFCEXkRcQsZFpsOAR/c1HD8c3GDRb86T1bhvNsReO4GXWPF1CiR jwh6d5uSn3uU+ZeT3FHKHsDrkd0sz14/DSysoMFwBDwanpsPLzGOQ5NGo2Bjy8uNizes GcNzAVpqS6RBIkeJuVwydAHsvWePiWzb9mqTIjIX3l2wpHgiXwJNeSGNreX7sPTcWxhm qs0AwQaD+uVmqaoNGcsb3hqmCqfxlQKHw8QqaeUZ5zg4Px4rVMYCNlzZgpILHGUI7/6G gKP+oxgOIrBBpRrzYshc2rbf4hyW09/FvVPAu0/E0/FgBBWmihoHFTXW3ut5QWSATP9L oAww== X-Forwarded-Encrypted: i=1; AJvYcCXyrDCR2ridFSdcoFNVv0AnDYDjqifZ4iuAEy+sN+1x1BHi4frJGLjaJn7Rrs6zXR/MGIdRIBUUH+fcFsRbkId5/wQ= X-Gm-Message-State: AOJu0YwAUSdld6Q1VHOpwneC2yCVRMKSUaEHS0uIlInmRz1NpsnsFsUl Imbg3Ej5bWt+b3TWG9CwSQfMAlGEye5VyZZEmIpo7oOxnczJ6gE5at1n4qOAbuJiD/oR1dJbv4A Qw3gnjeFORrLpdwCuq0ctJpyevEFjiGUsl7nJ X-Google-Smtp-Source: AGHT+IHMmrQCod73kiqRAvCkDsnHTcOLVG7U0Dhn6OWsLE5Eza4GBBk8ZEiq+Ddus8vlXjyfwMqyLLjmcyn5VeI1piA= X-Received: by 2002:a05:6902:54b:b0:de1:849:a6f3 with SMTP id z11-20020a056902054b00b00de10849a6f3mr5525501ybs.7.1714059589879; Thu, 25 Apr 2024 08:39:49 -0700 (PDT) MIME-Version: 1.0 References: <20240321163705.3067592-1-surenb@google.com> <202404241852.DC4067B7@keescook> <3eyvxqihylh4st6baagn6o6scw3qhcb6lapgli4wsic2fvbyzu@h66mqxcikmcp> In-Reply-To: <3eyvxqihylh4st6baagn6o6scw3qhcb6lapgli4wsic2fvbyzu@h66mqxcikmcp> From: Suren Baghdasaryan Date: Thu, 25 Apr 2024 08:39:37 -0700 Message-ID: Subject: Re: [PATCH v6 00/37] Memory allocation profiling To: Kent Overstreet Cc: Kees Cook , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: oepois5hmemo4cyprnzmwp5agdyzrf1p X-Rspamd-Queue-Id: 505A61A000A X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1714059591-98410 X-HE-Meta: U2FsdGVkX1/sQZA/B2oeljqiynWrV8d9OtPpqoZmW0NLYIQKJvljhfI92pyBU2T57MI/hT/I4WNYDelJ1CLX0FZ7MVwApQzSUgN+glhV0fG/ObvMFvgAmGIrcEQhvASleH6jYOyRM3UlVGSxpzvGnPeKCDfcTiHaxugTM71q5F7MBo1+FvxcmbLd0Rhw6T07EqoINFi+KCURqG1dnGOJ5TT2bdARAbBI1d2VeHNjeAZ94VUH4htC/GLBfDn13t2FRBPk8mzcCs6/JaOL5hX0c0oo9tjuhggD7XafMIwRwTlzJgOejARd3otWxQtPzHIxisS0x9m3ty2KXh+jMhkG9Vyt404RNJIefD8a2ot43VQnEy1IfJ3Jp1ZmH6RMhxoPsp2033qZzUMUI8L/1/4CKjoup6biZXoJY65ntKythl/tDRrzKFrLSnQmVZSt5stk6DtoHQx5UBzSlIFSBKeaohwV/dVBpRjWv831KWCk99NqUGuMtrIyfxRXpP8ZboZPbR/08VVE3OmSsu97/Qw7CnIuZpjKCyTugX7ToKSfRqOojGSnn4imueEXe19g/DBk+dT2jfq0G6SzddYn5NU7pcIcX0lriKMIZVRGuhP3gzrnU9pxLcAwQEjBuKYuIEL2n+QIjV+jKa+7+/BSeT+wH6pV7XORGf599pD+pAS65Jxq3KOomZwmbVc29MW2VpPN2UXbP2OzIhAVHflwlO80HRrb4d6ldRK9UVpB0maS0blIEj3gSkz91qQkVa1nkPMN7TMir4WytpMSpaE3YDyQDyWkJjfw/n6g3EG1mloMPk4KVEG2HDP3oti3Eyl6mvvJDihDKmM/6UqcEv2U1FWQy1cUGSKC7WBqdlRVFMmL2G3yoh3Qs/Ea2h2+oOYDVQlIGEW+9/38SwUiGv8j0YRjdPtM0weZkhM4Wqy2p3/sjfTdNkpJbM9TYJW8CawH1Ypa82et9mWlC1Sfa3VQaOh 77h55dpT RjJwwz3kc2Gc/tWNg8LCpPJT1h4mhmFf2Q8ZUudzzTS3xvlbnr2E0O6qM8mSg3/pbJBEoZbANulWBk2rJyyX4sIbdlG9rEwt0SzFNC8QraWNHzkpuTDdG6J7xchtuYPAh2yJTjlntGaB8tYCyRJ5cN0CwDo8Wgns1bRLXFGK/l8XwcYZbRdzk6qcMyK3I32TXmnbihMOhAxqMmUgCMSLGegAFFhCZigs9kG9RRbkq7NrZcGaDdkUSfPySgGF15vBUkqanTC6r3XOa3e+XEwHYNOltrTvdPLj6A1ZZJZTyRnbRNx8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 24, 2024 at 8:26=E2=80=AFPM Kent Overstreet wrote: > > On Wed, Apr 24, 2024 at 06:59:01PM -0700, Kees Cook wrote: > > On Thu, Mar 21, 2024 at 09:36:22AM -0700, Suren Baghdasaryan wrote: > > > Low overhead [1] per-callsite memory allocation profiling. Not just f= or > > > debug kernels, overhead low enough to be deployed in production. > > > > Okay, I think I'm holding it wrong. With next-20240424 if I set: > > > > CONFIG_CODE_TAGGING=3Dy > > CONFIG_MEM_ALLOC_PROFILING=3Dy > > CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT=3Dy > > > > My test system totally freaks out: > > > > ... > > SLUB: HWalign=3D64, Order=3D0-3, MinObjects=3D0, CPUs=3D4, Nodes=3D1 > > Oops: general protection fault, probably for non-canonical address 0xc3= 88d881e4808550: 0000 [#1] PREEMPT SMP NOPTI > > CPU: 0 PID: 0 Comm: swapper Not tainted 6.9.0-rc5-next-20240424 #1 > > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06= /2015 > > RIP: 0010:__kmalloc_node_noprof+0xcd/0x560 > > > > Which is: > > > > __kmalloc_node_noprof+0xcd/0x560: > > __slab_alloc_node at mm/slub.c:3780 (discriminator 2) > > (inlined by) slab_alloc_node at mm/slub.c:3982 (discriminator 2) > > (inlined by) __do_kmalloc_node at mm/slub.c:4114 (discriminator 2) > > (inlined by) __kmalloc_node_noprof at mm/slub.c:4122 (discriminator 2) > > > > Which is: > > > > tid =3D READ_ONCE(c->tid); > > > > I haven't gotten any further than that; I'm EOD. Anyone seen anything > > like this with this series? > > I certainly haven't. That looks like some real corruption, we're in slub > internal data structures and derefing a garbage address. Check kasan and > all that? Hi Kees, I tested next-20240424 yesterday with defconfig and CONFIG_MEM_ALLOC_PROFILING enabled but didn't see any issue like that. Could you share your config file please? Thanks, Suren.