From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B0B8EB64DA for ; Wed, 5 Jul 2023 22:15:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F28258D0002; Wed, 5 Jul 2023 18:15:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EAFED8D0001; Wed, 5 Jul 2023 18:15:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D77E88D0002; Wed, 5 Jul 2023 18:15:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C5A848D0001 for ; Wed, 5 Jul 2023 18:15:22 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 912CF140BC0 for ; Wed, 5 Jul 2023 22:15:22 +0000 (UTC) X-FDA: 80978965284.15.181639A Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf28.hostedemail.com (Postfix) with ESMTP id B8ADFC0010 for ; Wed, 5 Jul 2023 22:15:20 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=OnkwbGDh; spf=pass (imf28.hostedemail.com: domain of surenb@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688595320; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/foICnSFKccIQpyaos0x0fdIsu9W/nVV1GEq/n44hwQ=; b=hApZcE/j6sxmcn+u+PbVheleGyB5hHy+6crvX267lXNZ+l+hQx3+R/cXKp+0iFgxrq7Lcf zYIBLpRucjdVxgsuNhfclc9UgHz3MIcLMnNB67p8umU7ymJWTuQmYXcGuKNMrH5mWSeCcA 8tCTKp9fKZ258QUsmL4DCPgGqEJTkjI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688595320; a=rsa-sha256; cv=none; b=11IMSU8Oi4+bhFZcXN7BXrWXSFMijRaKWg9ptT77ixaTWNPN/CsSTWhkZ2Z+O5jV41lVPu eMT2bB+vI0IonK+onDtedFFzzQ9B5O0D24Bk7SYvX/oIlLaW8xxw6HpwMij6+knh63KK1s wJtxfbCwNbtuoiUu767sjqOvA7cI+ro= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=OnkwbGDh; spf=pass (imf28.hostedemail.com: domain of surenb@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-bd61dd9a346so8058165276.2 for ; Wed, 05 Jul 2023 15:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688595320; x=1691187320; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/foICnSFKccIQpyaos0x0fdIsu9W/nVV1GEq/n44hwQ=; b=OnkwbGDh/xcvC/syBCDLmTD2+SvGOCwVOaLrLxPRia7+rBbLfVi6uQONmBpYXII5Ap DWizohdzUUH9zsH0w4Z/KV5j5aV8bv5+QYaiKeQQCdQXRyWfx/4+J2zaUjL1vZBGhVzu A3k/RZYC24sEvNf10o6AeCIrZOuVt5q18Ub1RhdBt+5Gg+Ci5PfxyrNjODeH4JUnFUII b+kdJED+hMwGTQqRrOt+HILmfMSXMWahDbu1b73tc6VuNzjlNxttCaxbPXXcSs0d+MEd 3AcrgAlXtXZ7OGm/FJHViK6YbW6e0l4KzIMW+cOsnVpjsXxnMubQNKMYfuCOJ+gFd6Q3 oeCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688595320; x=1691187320; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/foICnSFKccIQpyaos0x0fdIsu9W/nVV1GEq/n44hwQ=; b=J1vE2lYAWbMgblQ67OOgFJRT9vrkubPN3qjn0Q2QtplRF1fb8LlaHjOsgkUYv9T/ce s/67dQ7B/Pp2xTyIa5qql9C/toWuLF9nrtUr6exBod+QwHe3ItoH/wN/h42aAdgf8rSZ tEpHsPG4xAw+v96he8ALkAOyXc4BH3QyscLBFKKfOhXQ+WWz81nNC45oOCn/fc3Iwwaf r38Ohnmk/vxOQTeVHolgUSEHmrYuPpCem1MttKFbRSv+60/Wx4WpHBGqnipGF1RI/VNq Dh90Vfn9zk5faXmAwihHk/Rb1wqslwqP+HHuyO+CgGfDIEvanS+3H3Fx3yT85nJcYV6B Y/kA== X-Gm-Message-State: ABy/qLYIxd3ajI9izkHsTLSCdDQpjRs1liPPJYfCqtHHJsG9MjoOPhHw S0NZ9ab/jMde2rLEwYH17MTfqggKlpXGiK10ZyCpTA== X-Google-Smtp-Source: APBJJlHPzZ4f0wnlVfbrbVhKrEtQzgcMd/ozYnoOif2G23HTlGDx15GkyI+w8VjTQpvfduP3YYy4TeyDI6zPCSF42+g= X-Received: by 2002:a25:cf05:0:b0:c37:f0b4:4062 with SMTP id f5-20020a25cf05000000b00c37f0b44062mr271997ybg.0.1688595319692; Wed, 05 Jul 2023 15:15:19 -0700 (PDT) MIME-Version: 1.0 References: <20230227173632.3292573-1-surenb@google.com> <20230227173632.3292573-30-surenb@google.com> <9a8d788c-b8ba-1b8a-fd79-0e25b1b60bed@kernel.org> <2f150512-e460-a9ae-65db-39dc54fe99d6@kernel.org> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 5 Jul 2023 15:15:08 -0700 Message-ID: Subject: Re: [PATCH v4 29/33] x86/mm: try VMA lock-based page fault handling first To: =?UTF-8?Q?Holger_Hoffst=C3=A4tte?= Cc: Jiri Slaby , akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, linux-mm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B8ADFC0010 X-Rspam-User: X-Stat-Signature: 1ej1j66tdehnz5ritc9tt4iwp4adhgct X-Rspamd-Server: rspam03 X-HE-Tag: 1688595320-122626 X-HE-Meta: U2FsdGVkX1/CoM/8s7WB4/ElnBqhxgsCe204yRXAn9qkBYlD3aecL3lFqeaPk4N0qrVZ/Q/C1iXK96db+MQ+WSfKYEOQtiplCTXpkzX/hoUrbzsLNld4yplmHp2A/n19CdQ4SnHveqXJdz9BlGEC4f35CNtB/aMJ53krklfsALkKYwLNILROCU7nTGvXx1EYvtmxcnEW5mvrHKUQlxSVWwveihALNfFHDcwRuQOEieph0eKI1KpB8YFZ9FgISFg50hLOk+wEXxJVAj0QXhtlNVdYh/J00XrzYLDOetRThzRPhfqGI6i/UBBfshKTI1cqfh7GJYLV1YnnSLe68XaB+t97+ZiFX1Drhl+dLXYyQ+BcR1Ie7bTfe7shDTBDYw1hBlg36vok9EGfE7fKd7M+SoWiOssu9izZ5pFG4n5wDBejVVnlGtxLEiZFVVpRpwMAiGzIQ6M6IMvhpZZSJPQSaQDJ7bd2PUoSDROzOmSKb3SUJ2EL43pzwAqzZB8HckkIjfuRPrBtCOTQpXDgUmu8nufS6Wnx23adQElZToWdl9+RyCRiWmZzouGzEcj9cWg0pKIyDgprK45+2+UT0UyfJFLgW5JiSlwpTBAIFKepjPPKRVquar75xop63X91X6v5ICk7lI47uWrrMaG+EggS0fzKLw4sXDl6KkeS5F+lnbqNIvlFOBE1iEPvJw7nkkoQ8dcp0YPZPFfu1Ky4hvxrdrt3lbuOclr8tRCuiTBN1cHYU/oThIgCBzBNos7rBcHfLgiD17No9j/nDFLgWlrkIIw0abot5u0bArI8kX8NddaPNvzBCsF/iK2ybvbLkpy2beQDhPTevyKQDREob2Spdvt7VNx1eMAYyOWN1J/9KACWdQmiIum+nX1+PbF9pV4mGz6jjYPgANrxCZYS6iHXppENCYjSu00ZNZcgHy1iY4KTWdqqaUem9S1Mqqz3JWCyeKx8wKL5xuX2k7TsdtK 9pMuv4K+ flvvxgjeeJ4uhyAM6v2U5+IyND1k1P7zaWVBYL98nobjoL2XuXgVPxyKKN3lrvMfZtxxQw1n0EWJeD/cY9uDxyufyFRuBkDTNfIEB5B2IS6mC6FieluCtpZtmnZv/cykOtuZJe8Gv7JaqDDIdQ/ZEQ9AJCqJDDDdKp+Ln2Pl4JVetEwuWBmEfceiVGumE402/C4KyWPksBTjv0vYgInQ+ANLldopYyfAO5wb8OtciwTVnBigPIe1UiCgf0uwhBJDd1RCKdkaZrbpsUf9k254Wh4qA+VLXXnJw5F+aVYfF+SxfNJ7ZbGNYgHgFmoq6JU+QhzCY2OMZu2FFsK0xyrTlCABhoBTBhkjgW8SoilQjVXf9AiRze4hjwo/lZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 3, 2023 at 6:52=E2=80=AFAM Holger Hoffst=C3=A4tte wrote: > > On 2023-07-03 12:47, Jiri Slaby wrote: > > Cc Jacob Young (from kernel bugzilla) > > > > On 30. 06. 23, 19:40, Suren Baghdasaryan wrote: > >> On Fri, Jun 30, 2023 at 1:43=E2=80=AFAM Jiri Slaby wrote: > >>> > >>> On 30. 06. 23, 10:28, Jiri Slaby wrote: > >>>> > 2348 > >>>> clone3({flags=3DCLONE_VM|CLONE_FS|CLONE_FILES|CLONE_SIGHAND|CLONE_TH= READ|CLONE_SYSVSEM|CLONE_SETTLS|CLONE_PARENT_SETTID|CLONE_CHILD_CLEARTID, c= hild_tid=3D0x7fcaa5882990, parent_tid=3D0x7fcaa5882990, exit_signal=3D0, st= ack=3D0x7fcaa5082000, stack_size=3D0x7ffe00, tls=3D0x7fcaa58826c0} =3D> {pa= rent_tid=3D[2351]}, 88) =3D 2351 > >>>> > 2350 <... clone3 resumed> =3D> {parent_tid=3D[2372]}, 88) =3D 2= 372 > >>>> > 2351 <... clone3 resumed> =3D> {parent_tid=3D[2354]}, 88) =3D 2= 354 > >>>> > 2351 <... clone3 resumed> =3D> {parent_tid=3D[2357]}, 88) =3D 2= 357 > >>>> > 2354 <... clone3 resumed> =3D> {parent_tid=3D[2355]}, 88) =3D 2= 355 > >>>> > 2355 <... clone3 resumed> =3D> {parent_tid=3D[2370]}, 88) =3D 2= 370 > >>>> > 2370 mmap(NULL, 262144, PROT_READ|PROT_WRITE, > >>>> MAP_PRIVATE|MAP_ANONYMOUS, -1, 0 > >>>> > 2370 <... mmap resumed>) =3D 0x7fca68249000 > >>>> > 2372 <... clone3 resumed> =3D> {parent_tid=3D[2384]}, 88) =3D 2= 384 > >>>> > 2384 <... clone3 resumed> =3D> {parent_tid=3D[2388]}, 88) =3D 2= 388 > >>>> > 2388 <... clone3 resumed> =3D> {parent_tid=3D[2392]}, 88) =3D 2= 392 > >>>> > 2392 <... clone3 resumed> =3D> {parent_tid=3D[2395]}, 88) =3D 2= 395 > >>>> > 2395 write(2, "runtime: marked free object in s"..., 36 >>>> ...> > >>>> > >>>> I.e. IIUC, all are threads (CLONE_VM) and thread 2370 mapped ANON > >>>> 0x7fca68249000 - 0x7fca6827ffff and go in thread 2395 thinks for som= e > >>>> reason 0x7fca6824bec8 in that region is "bad". > >> > >> Thanks for the analysis Jiri. > >> Is it possible from these logs to identify whether 2370 finished the > >> mmap operation before 2395 tried to access 0x7fca6824bec8? That access > >> has to happen only after mmap finishes mapping the region. > > > > Hi, > > > > it's hard to tell, but I assume so. > > > > For now, forget about this go's overly complicated, hard to reproduce c= ase and concentrate on the very nice reduced testcase in: > > https://bugzilla.kernel.org/show_bug.cgi?id=3D217624 > > ;) > > > > FWIW, I can reproduce using the test case too. > > > > thanks, > > As another (admittedly correlation-only) data point, I noticed at least h= ourly crashes > of Firefox-114 after upgrading to 6.4.1, which had never happened before = with 6.3.x. > After reverting 0bff0aaea03e2a3ed6 - with a bit of context fixup due to f= ollow-up > commits in 6.4.1 - it has been rock stable again, for several hours now. Jiri, Holger, would you be able to try https://lore.kernel.org/all/20230705171213.2843068-2-surenb@google.com/ and see if your issues still exist? > > cheers > Holger