From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92E40C6FD1F for ; Thu, 21 Mar 2024 21:13:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB0616B007B; Thu, 21 Mar 2024 17:13:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C39B56B0083; Thu, 21 Mar 2024 17:13:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB33D6B0087; Thu, 21 Mar 2024 17:13:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 987406B007B for ; Thu, 21 Mar 2024 17:13:24 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 36FA4140A67 for ; Thu, 21 Mar 2024 21:13:24 +0000 (UTC) X-FDA: 81922297128.29.ED82E30 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) by imf22.hostedemail.com (Postfix) with ESMTP id C8DB0C0023 for ; Thu, 21 Mar 2024 21:13:15 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hFC9+EE1; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711055595; a=rsa-sha256; cv=none; b=DaLdlEwNjnLHlLgQjTcC5kpxbncT/xwGl8+qw7MhhzJOZqtGbN8f3VAgvgT5F9++gZy5qt n5nhsovimO7gMyvAYYpxXxeBcTH7nIqU1yOzYQ2ccgCqrCn0QVjGN8rKjudtK3gnzhVy4E ootz5NXTWUHZN7asrdrhFk3oXjYWfXk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hFC9+EE1; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711055595; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ebQxy1c2E58rfYFrtDF0LlwrADqhUaZL+Ah6PQaZrV4=; b=5SdFqFPGMoPEHGKkKlqTS3QeeaswiF3dmwrzKdrqbiQkOItIk9FecIFURDjKlMnDBtSagB lK8Z4RDZVD9MTgKmL9BVv4o4hDdWX3c/LIiEvUHdn03TD1KtS2oiCQHxlKMUn2OCsNFUVk LknzME+wi9sFjHwNWq3QSrky+nfmpNk= Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-609f359b7b1so16209927b3.1 for ; Thu, 21 Mar 2024 14:13:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711055595; x=1711660395; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ebQxy1c2E58rfYFrtDF0LlwrADqhUaZL+Ah6PQaZrV4=; b=hFC9+EE1PXmQUV3Ptim4sgf+KUE31nE3iCR66DScnQy6gqpWYh7l3eUsf+cqs7va8I p7PY7PR7uupz2ZGzCo75CY01iRA/YRFMfx3C6KUbItNqJfTThl2/yTI0DDRQE9RIR3Eo EulROQPsR3oRzAHjAGm8Dp/x2hSnrDLbKS4kwiig3ERBRDpIvawkTZJF11ZWUFNReM2a Hmiq4OCmi+Sg+G5nIJzxyWEl8cdjxzpHbm/wPJ2y2iSKqwZdOoGaFxrG6OrWRoVW8+KU 86Lco1iWKJZueLGXV/McLEViVhMdmvcQ3HeHUqqeHwtJ2SdluO04FqLwRJSE1GpOjZhT I+qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711055595; x=1711660395; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ebQxy1c2E58rfYFrtDF0LlwrADqhUaZL+Ah6PQaZrV4=; b=djyRIWeMwaBjKqWu1pSvFc8+gn/WfSpLYXljtZLy7oQ67RNWjwpRWLElHImfZ/0RZq Z5YIVsPY2xs20A21P8YgZZw/pulC5Lf2uQZTods9CgIL5gofkZ6ItEXhFctdiJsh3RxL H/KF7YaU7pmx3OEBSbLcOAgYTethOLy7LxtiXOmecusUsgckW59q8cznaPVSkMi85ESh DmbRPpE0KLBCnpdWNN2LUtyDnplkIxbB3QonVxuwzfW0M1sIzzHVTZyr1rSKtwWe4DFO N1pRdvwNG9WpP/fUGIvNaA9iW4K3mBeP+jSkzGXdAhHYOEAa/xtGH2oyXgwyl6wEZgpR Ccqg== X-Forwarded-Encrypted: i=1; AJvYcCW3+lN3Sn2HOjb6XsWj2vT/OFjOw1CRxRdw6bUMJZWo79yrxto+Nk3G4OvJ+yuXs/7fcD+HNP2detAxQjmlTs4Nlqc= X-Gm-Message-State: AOJu0Yz2RTZP57XhGy6rvn6uOdfZGA4CFsoGvquYvrBc7qm+tT4JHKR3 PgpZKpv2aoF9mNXpMThj6RnbJxV/enhX5WKj0MFZwj51T1TUHjOPLOltZrHk4UD5iY0qkWijknD hr80sqbzxvfjw+E2bjSh5MkcVwJR8y1tUfT17 X-Google-Smtp-Source: AGHT+IGpQFVT0N1V6MSTPFGK3hczVIPcNsqNEuin7eWXL8IMpmHm2qxsutqSmIFxZ5BpkxVe8WmaXZz7+fehjNgm2MU= X-Received: by 2002:a25:f40f:0:b0:dc7:4367:2527 with SMTP id q15-20020a25f40f000000b00dc743672527mr366083ybd.49.1711055594451; Thu, 21 Mar 2024 14:13:14 -0700 (PDT) MIME-Version: 1.0 References: <20240321163705.3067592-1-surenb@google.com> <20240321163705.3067592-6-surenb@google.com> <20240321133147.6d05af5744f9d4da88234fb4@linux-foundation.org> In-Reply-To: <20240321133147.6d05af5744f9d4da88234fb4@linux-foundation.org> From: Suren Baghdasaryan Date: Thu, 21 Mar 2024 14:13:03 -0700 Message-ID: Subject: Re: [PATCH v6 05/37] fs: Convert alloc_inode_sb() to a macro To: Andrew Morton Cc: kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Alexander Viro Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C8DB0C0023 X-Stat-Signature: 13s1kb54n5n76p7ermd3e396zwrcfhpe X-HE-Tag: 1711055595-572908 X-HE-Meta: U2FsdGVkX1/M+U+p+f3gNfo8lHagI3k9Oc6smPTx5VAxvb/G6FX/i3t9+/rcxhWsK+qYqOZuk+JI49hX5Ju8F28sdObrzCrHvCMKIeYuC6qX/MKoyVoWlGiSPcLTmfqAMK/okXGjsMlw5SvjMuyY/KjqIbpOoAt8smYMspuEXXYLA6GkO0/0JT293zhrKFLkHlrNwFf66Nyw69gSPSYosnMZHsN5UDp2OaamW3t1D/pqFAabn+5Z2VDKDMOzaR5cEA7Oc9fKS7CZtzyp7hG2nM/a5QHCfYLs6oN9TRAoXShJCtgats7xCh0dlTsjW6C3hOnoLPXspQDqANjUqjRa/rzq5IAWLuKWEyLqCRBY2NwKaC3YxjaIZ19KaemFB0xUGFHUbVUAn2PdtoAyqRSN+b1XB1aziKWoZY3BdZAoQmNV9tAeu3o9QnUxNSjIrYCK2Ox15daqCFcAcDJTM+bSqapZNauqVsY7bdxs0PGmFnixKL/v0XYBEhHjw3XKXynrdc7kg8CPsuyNR/MbAyDKrEHqZ951xHrsQPjjfz65w9PTozh58xWe6je7ORCJoTLj43lU2zbS5ZyRqVhjpH1fFBssMtdlzaBtWQ1Cu3V0qLwOZlnKw0O9kjf35gmx+y1eZZFbjf31SAuUeRMpy9dHyEdnGeHTosZ7phm4jSsAs6cxckAR5DEF+kzb2shli8Icn7qEAGll094setEQxC8wDI+6XVBbU3asiHXEyYJIjUM02b18e+JAcGpoxV7meEuysCCMWXmwoXmlz/869jtzGw35Fg7SDj6WQaxYxP0doqXCRXOanaLQGnyjZn5KbYKDZ6UvflZ3lNmULMVBz87wLc3onZxgF5ldHquWSJoY9iJ1LPsQ5CuCeSy6xa1z+NL5g+cOFjkMr2cSYY8Mgg3+vcan4fkh8VlF0HBzDU1GVk4O5Bms9iPIy28EoL4JludonKEcq9Fmwe5Cy/nqNZZ Is6zW+8q qFhRjMHXUuffh4tE3bsyBQ0dmOAKxl/LmtEUUmYLX9IWAhpvXh8dOYBIEa9pA4g8cXVHYI+00n9+SpwgvU06qET+R3wXYvrlN6TnF9SNfKYqRlmhEAcXEap2+zaFUYwbf6AEFthgjzkR4BzMXvR3idu8mLUrIZwJ3ftusGn9vXEX6YSieuqKRsRCSL0s9862ALPZOY05DeeoheF7W6Owupi3Mzus0SJdXcEzZWcMm4yzGLa59xddhEGFeCdREq5zojH9PjeThNIqa0BPHCZ/oHbyYQVbp+/4IbDCBTP+j+cOnPnMzCLIqv55bKX2R5M4xLACwMvA3RBygW9rVVo6BDTPMG3yl8BJwZRMtwL16SdVTDo470GncUE2F6Eg6KHN3nnD4hm0q082u/12OJFBT4vC5lZtvdKcMnVPFs8OCuI6RDuw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 21, 2024 at 1:31=E2=80=AFPM Andrew Morton wrote: > > On Thu, 21 Mar 2024 09:36:27 -0700 Suren Baghdasaryan = wrote: > > > From: Kent Overstreet > > > > We're introducing alloc tagging, which tracks memory allocations by > > callsite. Converting alloc_inode_sb() to a macro means allocations will > > be tracked by its caller, which is a bit more useful. > > I'd have thought that there would be many similar > inlines-which-allocate-memory. Such as, I dunno, jbd2_alloc_inode(). > Do we have to go converting things to macros as people report > misleading or less useful results, or is there some more general > solution to this? Yeah, that's unfortunately inevitable. Even if we had compiler support we would have to add annotations for such inlined functions. For the given example of jbd2_alloc_inode() it's not so bad since it's used only from one location but in general yes, that's something we will have to improve as we find more such cases. > > > --- a/include/linux/fs.h > > +++ b/include/linux/fs.h > > @@ -3083,11 +3083,7 @@ int setattr_should_drop_sgid(struct mnt_idmap *i= dmap, > > * This must be used for allocating filesystems specific inodes to set > > * up the inode reclaim context correctly. > > */ > > -static inline void * > > -alloc_inode_sb(struct super_block *sb, struct kmem_cache *cache, gfp_t= gfp) > > -{ > > - return kmem_cache_alloc_lru(cache, &sb->s_inode_lru, gfp); > > -} > > +#define alloc_inode_sb(_sb, _cache, _gfp) kmem_cache_alloc_lru(_cache,= &_sb->s_inode_lru, _gfp) > > Parenthesizing __sb seems sensible here? Ack. Let's wait for more comments and then I'll post fixes. Thanks!