From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D260C02180 for ; Mon, 13 Jan 2025 17:56:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5C9A6B0085; Mon, 13 Jan 2025 12:56:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B0C186B0089; Mon, 13 Jan 2025 12:56:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D3E46B008A; Mon, 13 Jan 2025 12:56:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 763DD6B0085 for ; Mon, 13 Jan 2025 12:56:31 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1BCD2C0170 for ; Mon, 13 Jan 2025 17:56:31 +0000 (UTC) X-FDA: 83003183382.07.7F1CB87 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf13.hostedemail.com (Postfix) with ESMTP id 471BB20009 for ; Mon, 13 Jan 2025 17:56:29 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=AhbOTS2y; spf=pass (imf13.hostedemail.com: domain of surenb@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736790989; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iwdunmyEgD4eGVjGrUJ4iYmqoGOBTcVI0c7l1bxrO24=; b=DOvcbeNwenOHe1CnFPQric03HST8q6e8B+OZbi9Nq6iL0OmvZhsTe2xt8ywZ2LyTDEl+k9 rwzfNo+lvhaIfGQUJhZaRuk9B59WLRo1OGw9zGPZ9jlBlsHspdY/aOcA5RNYj/BuyqVwK5 lwDDHU6TuL8WFamTljVVMzXK3skrRQE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736790989; a=rsa-sha256; cv=none; b=iVYBwTq3p73ogiKi2KjTP+ktbPLjewLFVUSekOo/irMJVszja2XHbuVnpcwoYjSLeXrN25 0fAvjSasOh7co8xUae0+1r58LN1+UfsTJbTm9nF3FnswyHFSKfBkX1i590DZ2K1ww1UmeV emstBHljJwI0Z6dE1WcD9nw5Z7kJRwo= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=AhbOTS2y; spf=pass (imf13.hostedemail.com: domain of surenb@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-467abce2ef9so4451cf.0 for ; Mon, 13 Jan 2025 09:56:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736790988; x=1737395788; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iwdunmyEgD4eGVjGrUJ4iYmqoGOBTcVI0c7l1bxrO24=; b=AhbOTS2yPGsE9GN4EOzgs4MSgaDcNWUhJEdIzSX7xKsrBqFDtehDdnuhmmQw/JXO4P uPANKGl6vgVpHtHIbsNpuaexNVnflNFFS71P51/oM34YNtlc7qXLjEbK7eKRXJ5sncC/ hftpF+6MTTr1oXGRUubYhuKII+r6HqmPIKXW+0Hq0v4qraUFRKEBAvp6V1fWOZqbK1KN TA+Eup83yn+KAMsYNwUKEUvf6VJbjAZO9HJc2F95at9fmgD2w/uu7BNccyTf49jVFFFs brP2PKXPYMEWhLqAz/JhW3XX6TuO+0g9kT67IeY0WEYLanZ79Omrb6GPu2tj5lLunn+F 9ZeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736790988; x=1737395788; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iwdunmyEgD4eGVjGrUJ4iYmqoGOBTcVI0c7l1bxrO24=; b=T63e1cZLh3oKNljqq1PEtyHWUC3Q/CBh4Qx3qqiuXQqRsxHhos2E3GEWj/IlOASycY nTm7MG9LQQ2STdFaZElaomaAuTgm+aw24rEOtY/lFlYeEKwm7vzt3KvYirROY7LCh3zw O+IYQNwMbUXlEglNd0hTCcMUOljyMRwEq3q5IBPTF3Mq5jr+s2RhVmJwCEgApcWVmj5F jFpWyocDqzac5JyzdB9L65ooHnyfQ2XVE5XCCfpbeSmSeYlr5aG1Zq+xN+mhj5BfQuzB JJQ4GcTX6+WWAiChp0ikOQgEVhCxHp+nkqBeIIILTVxpdTWCjMd76/R73BKp7VC5+5RV Ojwg== X-Forwarded-Encrypted: i=1; AJvYcCXfRnyYYgKTH0J2De8eohe/AdUML85qVr7vmPaEJEcKulQBhtXQSdNR+d0YImo+f6UoKC6bV+9MyQ==@kvack.org X-Gm-Message-State: AOJu0YziLfjrCaKr4vxhYuSADfALeYUwnavKZM9o+nZcM/dj1ygzzDIw ZJdg4578M0S65gMwvPO7Z1o2NWHAEB8U7Sz4SKe+8Ha4sT8Bhg+jk/XpEV+PDcCT4DWGUBPYfMr M0Ylz10WJEqwmtDtlLeyO7vn0FH3li/QZuX0i X-Gm-Gg: ASbGnctopBlwS3DQG0ssycQD4Mi6TKV0EEVjRnjpGNq3rW5gndwTGKL+JKDRpFWW9OH qOTOpydSFwZWrcxGNze/bJW9zB9mwi1ZSSYUyPw== X-Google-Smtp-Source: AGHT+IGlRLcr2NLrZwcstPg2fFrJr8j6xR/0O4XvFSm7OjRNUPhxrCrSKVu8b9zkaYl7F3H4ms/rSpd+4496bclLehI= X-Received: by 2002:a05:622a:342:b0:46c:726a:14dc with SMTP id d75a77b69052e-46c87f3c1c8mr14205071cf.28.1736790988160; Mon, 13 Jan 2025 09:56:28 -0800 (PST) MIME-Version: 1.0 References: <20250111042604.3230628-1-surenb@google.com> <20250111042604.3230628-15-surenb@google.com> <5b1d82dd-bb30-4a5a-8f3c-949be4a81c45@lucifer.local> In-Reply-To: <5b1d82dd-bb30-4a5a-8f3c-949be4a81c45@lucifer.local> From: Suren Baghdasaryan Date: Mon, 13 Jan 2025 09:56:17 -0800 X-Gm-Features: AbW1kvanmkAnXwIMdSfgJhrYq8_HLelqWwQ5_a52w3MkvQRox77UAx0X_VNTTJw Message-ID: Subject: Re: [PATCH v9 14/17] mm: remove extra vma_numab_state_init() call To: Lorenzo Stoakes Cc: akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, david.laight.linux@gmail.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, richard.weiyang@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 471BB20009 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: zsyoejfcpn3rzkqz4fji5xmbsuqqz5tn X-HE-Tag: 1736790989-646320 X-HE-Meta: U2FsdGVkX1/98sqTgom8NxY30UYdwoIQ3WlSSjTTjO73iIOinfX/jiS2zdchycbKInPmaMvECThg4Ofon1Unyvav8ORII57QJeyqSWxqydMr78k5t9Wkb1WbYNyuIZbn+zuXcoyJYyWgX10+l6ujFsT5G5/OomacNtAt3YtdOKvfUFFY7ChM0v4yKV23/vahBh9Kst3jUzB9h2Nkt/N12GZ2s9q3kSZ0ANZiXi9ygwQ0TnQg2O6gjnioPKC+uqKU7MYXQ5lzzwz2u2DcA6h1mIakRCbqXRqSMSdnDawDg/lSPxFcGim0CH74vGXadue9cPvFQg7sj7QqlfoGcWB92fV4SdM27nO/kEYF3fIe2rtVAI0rccju4hrSaRpWVZaJ+7DysoyW1/49unEeB5bdh+l0FY/QTGKExHs1QzsaDEsUZejmvixS4nbuNzbws4xyogE/6huRoWIe/Q2KcxczyGhPlHO37H7s4HOlXulggAo4Hzx97j7Rn1T2aY2EnaNMnUl5v3ZHT1a0UTkq37/5qJcLVs2bRVLHk+0FZw9u+nzBW+dVHyidtNLc808keX5MShx6v49nB1Hs8ff0wTiN/ozlCU3ELrFlNy5Q3+xwCPHROaimy81zp2y9WVMOjycL/3FxuUrusiqeIt328Ss0MUvgc/rY4/Ew62r4JmEsfPedC/KQOR9qB1KrgrF8xn0UFdyp9s+vYwI1It+qIdyAoYJ8/30IWhTLgSw7jmoXabBNj05njAxvUVfOyzk28d44xrRbj6FFHFBRfdf/w3dIIMtt9rjlRGqinfDZnKvg1s1kCLilBfPqyD4LNoRFvUpTO08QLJT7LGHf/r2gL7wS7KYCiQTDS189SZHqTxed1dRQ1zQcBIpTavpPPpcLt1FIjCB+0QGFIRRmPtCRQlb9turlBtxyiuBdSgmLULu8tDG6SPnUnbkP9xjEd7diPRgQYPrVBkr7wDUarcU+0RP +V2Ieuru 4aOkIwAyWOI5gu7t6d54DmLIxZySrVNrUYLUYzrcgvNMi+p/of++MFn/ki3JiAlO1OBiIIevXEprqdP6dnnlQ6/hRLPX6bdPpu7hdRUyAz7xjnchVa+hGLLcvySulSTkJalsrTl2oiOBE7J/1vFVWrGiu77ywAOI2LLP5SYONwZDtekY6dgKT5WCNmud4Nl+23J5cgmaTatxdibWTEbeGebX2+BZ0N/W0dSQowPPJ9M+VkT8VpkpcwEfPngPU7h/IM1ICL2NQS9HOZ0czJDLJ2g9E4yYeItBRkcFQ1BJEa+7py3+VdaBbTs7c8FRdi89v+nKnycPXUF2NpZfvha1QHDW6F4U1W7ZhpKdpsxfS8BTLxJI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000249, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 13, 2025 at 8:28=E2=80=AFAM Lorenzo Stoakes wrote: > > On Fri, Jan 10, 2025 at 08:26:01PM -0800, Suren Baghdasaryan wrote: > > vma_init() already memset's the whole vm_area_struct to 0, so there is > > no need to an additional vma_numab_state_init(). > > Hm strangely random change :) I'm guessing this was a pre-existing thing? Yeah, I stumbled on it while working on an earlier version of this patchset which involved ctor usage. > > > > > Signed-off-by: Suren Baghdasaryan > > Reviewed-by: Vlastimil Babka > > I mean this looks fine, so fair enough just feels a bit incongruous with > series. But regardless: > > Reviewed-by: Lorenzo Stoakes > > > --- > > include/linux/mm.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index a99b11ee1f66..c8da64b114d1 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -948,7 +948,6 @@ static inline void vma_init(struct vm_area_struct *= vma, struct mm_struct *mm) > > vma->vm_mm =3D mm; > > vma->vm_ops =3D &vma_dummy_vm_ops; > > INIT_LIST_HEAD(&vma->anon_vma_chain); > > - vma_numab_state_init(vma); > > vma_lock_init(vma, false); > > } > > This leaves one other caller in vm_area_dup() (I _hate_ that this lives i= n > the fork code... - might very well look at churning some VMA stuff over > from there to an appropriate place). > > While we're here, I mean this thing seems a bit of out scope for the seri= es > but if we're doing it, can we just remove vma_numab_state_init() and > instead edit vm_area_init_from() to #ifdef ... this like the other fields > now? > > I's not exactly urgent though as this stuff in the fork code is a bit of = a > mess anyway... Yeah, let's keep the cleanup out for now. The series is already quite big. I included this one-line cleanup since it was uncontroversial and simple. > > > > > -- > > 2.47.1.613.gc27f4b7a9f-goog > >