From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F192BD3E2A0 for ; Mon, 28 Oct 2024 18:53:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89EB36B00A1; Mon, 28 Oct 2024 14:53:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84E776B00A2; Mon, 28 Oct 2024 14:53:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EF616B00A3; Mon, 28 Oct 2024 14:53:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5236F6B00A1 for ; Mon, 28 Oct 2024 14:53:52 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 150A4160BC4 for ; Mon, 28 Oct 2024 18:53:52 +0000 (UTC) X-FDA: 82723909842.04.199C236 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 26508C000E for ; Mon, 28 Oct 2024 18:53:20 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Fs9pd+MA; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730141550; a=rsa-sha256; cv=none; b=caoOd+zfiFXs2tYrv/39U8rQ1JbvhM5fa0QjPbiYIuT9ti+S2yWdFWOMw23zyGnF2eUfzq GcKPfYNqfRFytE6W2JaS1ye84UrKPTSGUDkRmLPbq+X/ews3RbInU2j4ZoCGctSPdQAf0i eqUwhlw/wv3Xo6lRIVXLBPvsO3d+6Ng= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Fs9pd+MA; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730141550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0WYzRLqjtoNVpnvujNH3r86fmSnTKoOusQ6Ao6DO1IE=; b=3YYArDvVsPBf9QJJnZpfmSpuB9nS2wrtjnu9vxF0eYoxPi3/t6x0yCJ1o0h3ldhtInZ87B K3Ion6lKt51VqZ/cpT6H7uNLowTyvJWP3eKtRAZtN/cOGeTOxrxPzk7e521U5Ky87qGLBV Y0n7mnenBwncTM0Nqo5+CHEsk4K5hWA= Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-4608dddaa35so53671cf.0 for ; Mon, 28 Oct 2024 11:53:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730141629; x=1730746429; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0WYzRLqjtoNVpnvujNH3r86fmSnTKoOusQ6Ao6DO1IE=; b=Fs9pd+MA6s1WLwsMelrmNxT+rspQyp5+VFaj+KlmSqb2yssSFVnypauKqizdGckhPM YhBXcGQWlXHX+0RwPWhkyCdgUx8cMuCkA03R5sOHWajSoBBHT/u5pgCcWQ30fP+X/4ND 3KoaE2kDSMfRciEWFEPDnwrEudaPZhVFZetY9Ks/cpaS745teXHN+hdv/abL1OqBT6Od qedRmTbURol+Q0BQW4eVK5cADv237KvmsI9QUACLSExC5poq2S8E72bogVRVt6bnMW3e VjW/slsBptOnBBRAkD28te8zR6a60VbzmzZ+Ij2+6c19eu9kupPPVs2MRzRRrvO80foZ SUkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730141629; x=1730746429; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0WYzRLqjtoNVpnvujNH3r86fmSnTKoOusQ6Ao6DO1IE=; b=BzV9hR8xqYL6b4O0yIYKhkjFsl/b9Zfu3s64s1r3WzTP6jYQ6B+SM72s9j9tCpiwla cci1DW1LEoH19IMfAc+CeIHynKD93NmmLU8iPnZiW7kbB0QWESufclebe8KVuXWTmxCt Dyr+zLwJFTCipNBIPBEvBpFuRrObGf2MqYtnaADsqiV3ns5ALSidlEUrjWSGLg0JTRpI 3zlJYbowMfVpP26vk0xDOVcmSkZ2DyIsyPHog7ExwHzNBfBWbHJ2IHnoooacYmIfnn87 QQg/h0pYd4irDPGU+wW9QNUfP5dBDqLxGXPjPTzVQcTVujpY6I98u8XH+NqF2J/6yt1d Eosw== X-Forwarded-Encrypted: i=1; AJvYcCUQ99hfWJKe/PNKmgI9BMpYlmAPGhug3TRBK1QvfeQUf2gneb0cSgkArXGowoIIt9jGMjpMyjJ9lg==@kvack.org X-Gm-Message-State: AOJu0YweEZKgPCFvj4h8pWbeESovNnmnezTrbKJuJp5a+wNbMt0aDAYA FIJjPKbcpGRiBb4P44VdhJrqjvK+nC9PDEStSiyqUofF4ratprwIzVgjZFHUSwXAkdODYWwRPXH T4BU/fVt82DquI9cgfH6aKjh4OLHIZjmXdCTo X-Google-Smtp-Source: AGHT+IHOcJzO/GxOF61GZqPQpmPwZnfinL5k+ypLPUEksqRc2JZLbUVkl/3HRPaq20wnCeXp5eLhCJB+1QFa+hA9KW0= X-Received: by 2002:a05:622a:5d3:b0:460:4aa1:78d6 with SMTP id d75a77b69052e-46164fcea00mr456441cf.20.1730141629162; Mon, 28 Oct 2024 11:53:49 -0700 (PDT) MIME-Version: 1.0 References: <20241028150355.2574425-1-arnd@kernel.org> In-Reply-To: <20241028150355.2574425-1-arnd@kernel.org> From: Suren Baghdasaryan Date: Mon, 28 Oct 2024 11:53:38 -0700 Message-ID: Subject: Re: [PATCH] [v2] alloc_tag: hide execmem_vmap() on !MMU To: Arnd Bergmann Cc: Andrew Morton , Pasha Tatashin , Arnd Bergmann , Mike Rapoport , Luis Chamberlain , Song Liu , "Masami Hiramatsu (Google)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: ze4kmae93jc3dsyp6mr7imt913fs5q3p X-Rspamd-Queue-Id: 26508C000E X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1730141600-410581 X-HE-Meta: U2FsdGVkX19Bvrv4uEkgP6PtCMX1iJ86v86PXibg44qxyTYGRxyO8nTpgqs644+zr2luOAowKVarMG71lKnUylSFRQZocIxb02cFXS5OKS/IvIyA/D17NNbLMoJiioNTgCRaUAPS7QDtFlSdXBjGJ6WL7Lv6st3fXB3K03rH6fuuLJCB0iI9GGRgTYZwcv4cWsoq4BvVNDsSibL3bOcmU95KUoRBAAwa6TtxQ5RbRblMTOoF/ztxvzAspm7qgDu9Kxt9Q3N1SECnLo2xl1tu2omZLuNlS2kuAwTav4wgE+JRrTridigG5qAB/qVQEF7eNjKDldSuN0LcCNuNGqQZnEj6/orAT4GY0/zt+NHH1XwcPDoq85dr8Ed+qr2QXqPboMUdsRRENYSNFLEbDPdN9eHzrE6UIH0wC3l9yQdSex934/bbuwARqbmnjdAZ7biyOgksBjwGG6MkqumMND/r5qf8+dfWljUKMCkMq/PYipc8bdqqVJg/nNabFFKPwuX4QP/9awfkyozfEDLtPQzPyWtD1oH2efTBhG2ZYuHG91vPqI03ApJ5fCefwnXl8QANZqRP2NHBFebltYrDqSLlt1adA+pEo8IHPTK8upfaU4LA4XromYDHX54GgRXOnn301fRHkdCZAl+1WeAk1Klgy/6qe+inx4nNA+3+3f7JnBTaKACsS9OST361Gx919h7QjFNfYgZukYSP+5nSX6uKiDZ3ZeC+P/14Pw35MiEcGScDt/Q2a6ma8NpsOBCE7MeZ8zXun1YtLoNiuZkfkWVa+thdcTS1fSWZQqRCDJg7KYVMYK5PG2NXY3Wy/yJLB5/gy5D80GuTzUvigmagUBS96IZI1GJVELz81Pr2Evt6icH3idRUSGMbHr0OquJkdYMG6vRODJAkC2RPYLJk0atgp9gA9U8vBXg80diPBVjkMOaThnKJiz4bl0iLFUJN243p46wM3lH+ScD+yFnYMEI sbYl7DIT 0yQpn+25PK0GWUpDPbsYJPTPqnCa6rT4V/+F3nMZ4kiN4kNSC/krDnoxpdNZHPh01nIQXwTcFcHNr4cfUnsJVyUZI41z6jj0Y69yWVZns8O8pvC6ZPLs3QOpFyE6iDwLCyZi4FCUGzXxctHbB+T7Hc8YGoJmcyCpytv20y4/CVbhFRWqZCJx4Fmry9BoMu1GzB4XwJXZHlYY/xnYc31jNryZ0KMBqGYI+ftLI2ORLbVOOGOfnxNcfUKzLC5tkWdOGOpQDF0DD2D8k+HTJbXnjysDtmEJ9RaAKlXb4KLu5l0mRdYQ0cETY+IAnRA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000047, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 28, 2024 at 8:04=E2=80=AFAM Arnd Bergmann wro= te: > > From: Arnd Bergmann > > The newly added function fails to link on nommu kernels, but is also > not needed there: > > ld.lld-20: error: undefined symbol: __get_vm_area_node > >>> referenced by execmem.c > >>> mm/execmem.o:(execmem_vmap) in archive vmlinux.a > >>> referenced by execmem.c > >>> mm/execmem.o:(execmem_vmap) in archive vmlinux.a > > Move it into the #ifdef block along with execmem_vmalloc(). > > Fixes: 57bc3834fb6f ("alloc_tag: populate memory for module tags as neede= d") > Acked-by: Mike Rapoport (Microsoft) > Signed-off-by: Arnd Bergmann Sorry, replied to your older version. Copying here: Thanks for the fix but execmem_vmap() is used if CONFIG_MEM_ALLOC_PROFILING=3Dy. Please give me an hour to post a fix dealing with that. > --- > mm/execmem.c | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/mm/execmem.c b/mm/execmem.c > index 5c0f9f2d6f83..317b6a8d35be 100644 > --- a/mm/execmem.c > +++ b/mm/execmem.c > @@ -64,6 +64,22 @@ static void *execmem_vmalloc(struct execmem_range *ran= ge, size_t size, > > return p; > } > + > +struct vm_struct *execmem_vmap(size_t size) > +{ > + struct execmem_range *range =3D &execmem_info->ranges[EXECMEM_MOD= ULE_DATA]; > + struct vm_struct *area; > + > + area =3D __get_vm_area_node(size, range->alignment, PAGE_SHIFT, V= M_ALLOC, > + range->start, range->end, NUMA_NO_NODE, > + GFP_KERNEL, __builtin_return_address(0)= ); > + if (!area && range->fallback_start) > + area =3D __get_vm_area_node(size, range->alignment, PAGE_= SHIFT, VM_ALLOC, > + range->fallback_start, range->f= allback_end, > + NUMA_NO_NODE, GFP_KERNEL, __bui= ltin_return_address(0)); > + > + return area; > +} > #else > static void *execmem_vmalloc(struct execmem_range *range, size_t size, > pgprot_t pgprot, unsigned long vm_flags) > @@ -368,22 +384,6 @@ void execmem_free(void *ptr) > vfree(ptr); > } > > -struct vm_struct *execmem_vmap(size_t size) > -{ > - struct execmem_range *range =3D &execmem_info->ranges[EXECMEM_MOD= ULE_DATA]; > - struct vm_struct *area; > - > - area =3D __get_vm_area_node(size, range->alignment, PAGE_SHIFT, V= M_ALLOC, > - range->start, range->end, NUMA_NO_NODE, > - GFP_KERNEL, __builtin_return_address(0)= ); > - if (!area && range->fallback_start) > - area =3D __get_vm_area_node(size, range->alignment, PAGE_= SHIFT, VM_ALLOC, > - range->fallback_start, range->f= allback_end, > - NUMA_NO_NODE, GFP_KERNEL, __bui= ltin_return_address(0)); > - > - return area; > -} > - > void *execmem_update_copy(void *dst, const void *src, size_t size) > { > return text_poke_copy(dst, src, size); > -- > 2.39.5 >