From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2221ECAAD3 for ; Thu, 1 Sep 2022 23:18:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A6928007D; Thu, 1 Sep 2022 19:18:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4564E8000D; Thu, 1 Sep 2022 19:18:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31EB68007D; Thu, 1 Sep 2022 19:18:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 22E348000D for ; Thu, 1 Sep 2022 19:18:17 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E358B1208AA for ; Thu, 1 Sep 2022 23:18:16 +0000 (UTC) X-FDA: 79865082192.18.5CA5458 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by imf12.hostedemail.com (Postfix) with ESMTP id A64A84005F for ; Thu, 1 Sep 2022 23:18:16 +0000 (UTC) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-33dba2693d0so1771877b3.12 for ; Thu, 01 Sep 2022 16:18:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=rjiF9dcJ/mORZlmNTO18kEduhbATdpbM6SHMK6U+ruY=; b=miInjSJE+fzo5gS/eKt5cfKejZWjk/URgt0UsOF5yFYhBi4SW0mjlLLL/BxcWNS7q1 ZbX9dW3k1PQz07RhMq4TY0IKX8uDz5gqWib15fn/ENu8F4BQEoeMpBqRR4aXJyehSLYL rlX+s6DOoRRQDDNJOyrdh0XgYf16gCuBQ8/5nYMEbXay2V4G5ElxQsF4iKh7ls3v0nku D6GH4AzNn0lGwU6+bKnN6gfpnyUHAp3BKdNloRCyIKDJYsKSeK4d/tInEIryGNWiC42i SC0dR4U7pJvq0mNT8d7KhoSD0pTCfW3Ka8zPz/CWyWvVkBglY+I9aRF6ESuk5tijxW2i 1vog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=rjiF9dcJ/mORZlmNTO18kEduhbATdpbM6SHMK6U+ruY=; b=vnxZasWDLiOGbPLS4wDgZovHhF/fXv+n1TgX9lwG2N4pcbAP5SdSuUuV2TdplNBBt/ ZCzG/qsEqgh2Yi7u8S0YPvjBhAmI4Kkih46KfWA63yiSYhvPbw20YgeBpG9TmtQ8GDTW V/SuYJxtrJSFg0/ixGdlqsCvCOTrM3RcnacUAargPF2iTXTaXwkrk2RBv3WT/8IG+ATp sBCHL+HFA8LBJ4cV0lezRUDKJNC3c6RDjU99l0yH4OjY8CzXf42g22AbKkKiOigpeC/q GxGvbeb1lOukVFyZcfae7Ik5qIgSvNyfJxgAr8SxSQAZ0Vx7aMIVfKEXaz8H+V/+Giuk 1l4Q== X-Gm-Message-State: ACgBeo1Mz65916eqiMCmiViWRNYZTb8BpVCWte9wVSt2pI5ZKFK8w//y /rn3q1uxpm6j7RZ8wyG8Cl5C1coRqzxs58RBhLADeQ== X-Google-Smtp-Source: AA6agR6m7scNwFemz6Af1WoGTDIcSPP5pnTPi8sC0t6BGCdPYrcUbrHz9JxtFN2qOLjSTkeI4M1Lodd/jngX9vslX64= X-Received: by 2002:a0d:c981:0:b0:330:dc03:7387 with SMTP id l123-20020a0dc981000000b00330dc037387mr25164956ywd.380.1662074295806; Thu, 01 Sep 2022 16:18:15 -0700 (PDT) MIME-Version: 1.0 References: <20220901173516.702122-1-surenb@google.com> <20220901173516.702122-4-surenb@google.com> <20220901202239.tnnzlbermiyvkmih@moria.home.lan> In-Reply-To: <20220901202239.tnnzlbermiyvkmih@moria.home.lan> From: Suren Baghdasaryan Date: Thu, 1 Sep 2022 16:18:04 -0700 Message-ID: Subject: Re: [RFC PATCH RESEND 03/28] mm: introduce __find_vma to be used without mmap_lock protection To: Kent Overstreet Cc: Andrew Morton , Michel Lespinasse , Jerome Glisse , Michal Hocko , Vlastimil Babka , Johannes Weiner , Mel Gorman , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , Peter Zijlstra , Laurent Dufour , Laurent Dufour , "Paul E . McKenney" , Andy Lutomirski , Song Liu , Peter Xu , David Hildenbrand , dhowells@redhat.com, Hugh Dickins , bigeasy@linutronix.de, David Rientjes , Axel Rasmussen , Joel Fernandes , Minchan Kim , kernel-team , linux-mm , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, LKML Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662074296; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rjiF9dcJ/mORZlmNTO18kEduhbATdpbM6SHMK6U+ruY=; b=ZhHvFFs91D2Pu+fAOizC4nFPGgx38/fI9aQOqgTRdZaJF8alO6NxOnirJIMKDwsFc3plYo QHGWTE7KscvHFAH9uObVS96afX3UGN/dnO5tQg4grtTVWaSOHjsdRzdmcYKukLDh85xwr4 YKyptDbls5eRrfewNdckQ5fyfmytXRU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=miInjSJE; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662074296; a=rsa-sha256; cv=none; b=pqbRHMz+Eor5mxYTQOgyy1+DjCDorqi6cxETnLITTQU5zqbwLJ6IaokJ4Oxx+cUG/lUxmm 9I5E5hnBiWnNC1H/1cZYeNaM0lRK2XM5M0f8+rEkqXn8w6OjrFs01eH1+dSveYLj0NlU3Z bux74WleXRS2L7+qosTvj0dmz7sNwdw= Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=miInjSJE; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam11 X-Stat-Signature: er15mnffix57kjofoh7pdc4imjnidbda X-Rspamd-Queue-Id: A64A84005F X-Rspam-User: X-HE-Tag: 1662074296-602021 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 1, 2022 at 1:22 PM Kent Overstreet wrote: > > On Thu, Sep 01, 2022 at 10:34:51AM -0700, Suren Baghdasaryan wrote: > > Add __find_vma function to be used for VMA lookup under rcu protection. > > So it was news to me that the rb tree code can be used for lockless lookups - > not having looked at lib/rbtree.c in over 10 years :) - I still think it should > be mentioned in the commit message that that's what you're doing and why it's > safe, because it's not exactly common knowledge and lockless stuff deserves > extra scrutiny. > > Probably worth a comment, too. Ack. > > Reviewed-by: Kent Overstreet Thanks! > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. >