From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28BB0C6379F for ; Tue, 14 Feb 2023 19:14:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B8CB6B007D; Tue, 14 Feb 2023 14:14:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7692C6B0080; Tue, 14 Feb 2023 14:14:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 658766B0081; Tue, 14 Feb 2023 14:14:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 54DDE6B007D for ; Tue, 14 Feb 2023 14:14:01 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 150928097D for ; Tue, 14 Feb 2023 19:14:01 +0000 (UTC) X-FDA: 80466847482.24.AFA42CF Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by imf17.hostedemail.com (Postfix) with ESMTP id 36D7640019 for ; Tue, 14 Feb 2023 19:13:59 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=sBkTngIV; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676402039; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pXcppXk4sqKzMfvrWIcFdUhO+LBg/Sx5HjhK9InjLrM=; b=pYceRu7NNhio/xtvt0NIRBVMquvQLw6iFWSZ5oNCxFcPCxMsKs40XG7yESfHh8WlHivWD2 f8QQh26nCRO4QEOpJcxrSJ0M1SfE1prUiSvqboLaiH0WJcGYgS5v6kMiOaABICSHRe7PXU 83gDrUwy1aNZuEJTdBUV6oNgbM4++us= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=sBkTngIV; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676402039; a=rsa-sha256; cv=none; b=En+YyS26zr3OSoGO/XCaSUsnw7nUKg8gvB0tUPmu6+bT/hxi7e6lgsu1rMft/gq1RkJMOo KLnVIwoyfc66JMQ/9DomH3AnxSn2Xg6nw0661DkxBIVjCaGtEwHQVqbjrgCPvGNhH3YgIn n5I9YcVt5CRmP1cdhm3efZiZhrALP88= Received: by mail-yb1-f173.google.com with SMTP id s203so14281293ybc.11 for ; Tue, 14 Feb 2023 11:13:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pXcppXk4sqKzMfvrWIcFdUhO+LBg/Sx5HjhK9InjLrM=; b=sBkTngIVAaqz5LH/0bWPS1DnkXZldvsO+retgT7Ci5Lu8G9n+PTbmVAvcUKVBDw/0s yr4M5LhS2p2umzeK2YE6SV7FZxw+TJomxo1C4DJH4wrUtr/ZzAmCYmb3yiRG2fmgofR9 tPscLBX1kz1bsG6af6H5UgRXWhb1m3OLym5NycwHqh6yAZDiqJooWbKEd7RCIou8Ax/j 4VzDpPIjRFRh6ParORPWhbPgZE3N5JWcdeGEkBlFFQWYEcmu776E1AjtjFEELYosaVDw d/roJISxnfdtGmea00pPM2nW5penJlU69skXybwsP/5ZLsFNQ0mc/Bh1yFluW3wog9/M O1+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pXcppXk4sqKzMfvrWIcFdUhO+LBg/Sx5HjhK9InjLrM=; b=hfx8EmW4viZqt118RIy9eFx0M7Ysz9yA8m/6GzQTrcLAdQB9uCav9ywXF7kUb2Nsmo M38lXUpDfvQvZIvHu9cuC2/I5A8XzgHgBZb7/wndKS/JLxNzL9pzv3JIF/f12azKDfBV EkLxG0PCaC20H+l8p3sSEzisiDQ9Q7keLAEWSfwspuCB4UdlKJSfs8pV/dBkzf4RiByi kYXTW2wyTKnChaBtIp1SpTGcluu3cKu45hzJUiKLcap/BSOe6UwxexIzz2imA8KQthvE 33LyJlavUzIR9MjnZXKvoRPRCanFShGXiRYMYNIOAZpSskcdGuvVrmm8ZN1qELJUI8/L K5og== X-Gm-Message-State: AO0yUKUf+MVXUF59cis2ruyX0iiG7kqu/+fNK2zuD8TmKXHwPLbtPrYS Gt/1VLaitsNS46E5/oHnCqTWBgecHsSbLxfkzAP39w== X-Google-Smtp-Source: AK7set/tHwV6zaeaEHX7+c7voFKH8GjEjjky3i2eoCFFjx8yJ27ervyaGd6XZj+X5EmG0hBWTzNbXzKZK+X/oIAX0Zg= X-Received: by 2002:a25:e303:0:b0:925:6e:c676 with SMTP id z3-20020a25e303000000b00925006ec676mr430727ybd.179.1676402038198; Tue, 14 Feb 2023 11:13:58 -0800 (PST) MIME-Version: 1.0 References: <20230214181335.3946674-1-kamatam@amazon.com> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 14 Feb 2023 11:13:45 -0800 Message-ID: Subject: Re: [PATCH v3] sched/psi: fix use-after-free in ep_remove_wait_queue() To: Eric Biggers Cc: Munehisa Kamata , hannes@cmpxchg.org, hdanton@sina.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mengcc@amazon.com, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 36D7640019 X-Rspam-User: X-Stat-Signature: mpqkq1k3izryxx8robbm4y8f6j89hyba X-HE-Tag: 1676402039-880233 X-HE-Meta: U2FsdGVkX1/8WpMEDeOaubFhsh133KDrtexCyz+ihrfVVRbgYJqgmQPX6Oaj+MUCRbZS2yAd1RmGD17pS0mmF9uszKrO11qAtDnphqB57se67XOqow+KmZvreQWuAKGyO882hDB38YM9/1it2ElFrs3Sfi72gVH7Y/iCSENxC3CnlJP1oWyw8MSwVub2Diz2lk8Wx5Zgts3Rd4tqUX9k6HXBECUgwO+33ql1L2UE98u/uSppAQMkGWxS3Xh8S3JfCMX8jURQQyfiKwMrTGb78bnCcO9nLJXrvVEKJ/EB+lFr+9cR65vlQpojd1M09wHXyGyWQ3xoNFOsf+Twt168W32DkY7jRuIigjC7iU4gP0/UXUmIunJ0jCkW5CbIoJ6RS523F7mWsjVuxAKZfpnO5flhkfEhYKdHm8GjOoQxCA/3jE6t3umMzxhyqhTebkpVIq+NZRJvakRqc6e14tkzufEZLQSseWTqvrnDVVT3ZwqDKnA/WC3KOoiXRD0wapIoLQf0eSBRd+V3D5fqCr8QRXGdsi/10nYVf4pt4nbylOGcnEoEErQF9a8cFZ8hxm+tShpIBPhZe7u0QcFygxbOdmXmzcu0g5KnUQ2eBmhn8LLShSQzh042f1jDPbSqRJPs8JjXdmKSMZnUGM7pT7lZpzDH3cUEJh9xYuPKw+p/alk+JWDDnhNIu9LKCLLSTS+RElAWRM1Pu0Cm6yyFQGO6WBthRTKeZb9ES6in3P33GNHh082Gsh3LbukmBNFMRsNbwVDYVbeyOuHmnqn2KUxSFkE8Jf4tJu+UIHfoIc0X/JxWnhVK9kIBrq08wMicnrCi9/usRbX1WIRkPaBxFHCFkLjs19GtE9GBNOPr9lZs66BALYc5+G4xr27Kwu5KxgqXL3zGjVoK4bnndx7CUGWr5OSNYWDhgUXce2LN2pCnITrfzhXfxLmulbMmzBfn5Cd4bz8KkVGDyEyOBPiuTgc iflLRtyo wzNF3z9wPBY5q2JOIBPPUcxw3KaYlhqPBzew9pb4uPwTlds9eEKILaCOyzetsWiUxa7oBNX/9ZIh2RN9pD2/Q5l/7YBDi7fFSktRD+LDVpArvaqbRsuyZNRc/YkQZYen/0OQgV0Bommg8BI5aoNSEl2aHlD+R5Rs/cElkjJAbWQtyN8R7uF0AwG30B/2A+uNVs6o+Szhw0rCHOLkZOYShD3mmSR/csDbDrvTA19L5BUpR1JP0/BMSPzZnrtuvMJzc4SKH+vRN+yChShlgqFISIWwqcOF4J9WskmkRzs+46MUh/ycugOVejPDcH9sTd4eQuujFvwHVPi3yicjhXf7ht6CTJm6dM9MjIyUD X-Bogosity: Ham, tests=bogofilter, spamicity=0.001573, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 14, 2023 at 10:55 AM Eric Biggers wrote: > > On Tue, Feb 14, 2023 at 10:13:35AM -0800, Munehisa Kamata wrote: > > Using wake_up_pollfree() here might be less than ideal, but it also is not > > fully contradicting the comment at commit 42288cb44c4b ("wait: add > > wake_up_pollfree()") since the waitqueue's lifetime is not tied to file's > > one and can be considered as another special case. > > If that comment is outdated now, then please update the comment too. We can do > better than "not fully contradicting". Agree. I don't see it contradicting that comment. > > - Eric