From: Suren Baghdasaryan <surenb@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tejun Heo <tj@kernel.org>,
lizefan@huawei.com, Johannes Weiner <hannes@cmpxchg.org>,
axboe@kernel.dk, dennis@kernel.org,
Dennis Zhou <dennisszhou@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
cgroups@vger.kernel.org, linux-mm <linux-mm@kvack.org>,
linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
kernel-team@android.com
Subject: Re: [PATCH 6/6] psi: introduce psi monitor
Date: Mon, 17 Dec 2018 17:22:35 -0800 [thread overview]
Message-ID: <CAJuCfpFp7v4oc9LL0TVMiYavOMOvDs5y=kQ8S7URtKojkWmH7Q@mail.gmail.com> (raw)
In-Reply-To: <20181217162713.GE2218@hirez.programming.kicks-ass.net>
On Mon, Dec 17, 2018 at 8:37 AM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Fri, Dec 14, 2018 at 09:15:08AM -0800, Suren Baghdasaryan wrote:
> > @@ -358,28 +526,23 @@ static void psi_update_work(struct work_struct *work)
> > {
> > struct delayed_work *dwork;
> > struct psi_group *group;
> > + u64 next_update;
> >
> > dwork = to_delayed_work(work);
> > group = container_of(dwork, struct psi_group, clock_work);
> >
> > /*
> > + * Periodically fold the per-cpu times and feed samples
> > + * into the running averages.
> > */
> >
> > + psi_update(group);
> >
> > + /* Calculate closest update time */
> > + next_update = min(group->polling_next_update,
> > + group->avg_next_update);
> > + schedule_delayed_work(dwork, min(PSI_FREQ,
> > + nsecs_to_jiffies(next_update - sched_clock()) + 1));
>
> See, so I don't at _all_ like how there is no idle option..
Copy that. Will see what we can do to bring it back.
Thanks!
> > }
>
>
> --
> You received this message because you are subscribed to the Google Groups "kernel-team" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com.
>
next prev parent reply other threads:[~2018-12-18 1:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 17:15 [PATCH 0/6] psi: pressure stall monitors Suren Baghdasaryan
2018-12-14 17:15 ` [PATCH 1/6] fs: kernfs: add poll file operation Suren Baghdasaryan
2018-12-14 17:15 ` [PATCH 2/6] kernel: cgroup: " Suren Baghdasaryan
2018-12-14 17:15 ` [PATCH 3/6] psi: eliminate lazy clock mode Suren Baghdasaryan
2018-12-17 14:57 ` Peter Zijlstra
2018-12-18 1:10 ` Suren Baghdasaryan
2018-12-14 17:15 ` [PATCH 4/6] psi: introduce state_mask to represent stalled psi states Suren Baghdasaryan
2018-12-17 15:55 ` Peter Zijlstra
2018-12-18 1:14 ` Suren Baghdasaryan
2018-12-18 10:17 ` Peter Zijlstra
2018-12-14 17:15 ` [PATCH 5/6] psi: rename psi fields in preparation for psi trigger addition Suren Baghdasaryan
2018-12-14 17:15 ` [PATCH 6/6] psi: introduce psi monitor Suren Baghdasaryan
2018-12-17 16:22 ` Peter Zijlstra
2018-12-18 1:21 ` Suren Baghdasaryan
2018-12-18 10:46 ` Peter Zijlstra
2018-12-18 11:20 ` Peter Zijlstra
2018-12-18 17:30 ` Johannes Weiner
2018-12-18 17:58 ` Suren Baghdasaryan
2018-12-18 19:18 ` Joel Fernandes
2018-12-18 20:29 ` Suren Baghdasaryan
2018-12-17 16:27 ` Peter Zijlstra
2018-12-18 1:22 ` Suren Baghdasaryan [this message]
2018-12-18 16:51 ` kbuild test robot
2018-12-22 14:12 ` kbuild test robot
2018-12-22 14:12 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJuCfpFp7v4oc9LL0TVMiYavOMOvDs5y=kQ8S7URtKojkWmH7Q@mail.gmail.com' \
--to=surenb@google.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=dennis@kernel.org \
--cc=dennisszhou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox