From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 411A4EB64DC for ; Mon, 3 Jul 2023 15:24:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF85A280012; Mon, 3 Jul 2023 11:24:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA8EB280001; Mon, 3 Jul 2023 11:24:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 970B2280012; Mon, 3 Jul 2023 11:24:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 88A6E280001 for ; Mon, 3 Jul 2023 11:24:28 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2291AC078D for ; Mon, 3 Jul 2023 15:24:28 +0000 (UTC) X-FDA: 80970672216.12.F229321 Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by imf22.hostedemail.com (Postfix) with ESMTP id 31295C0015 for ; Mon, 3 Jul 2023 15:24:25 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=VchqeeVA; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688397866; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JSSoNEuWLvjsGt2snF40RSrVJcAu0eLTumyB4IL173Q=; b=Or0qXS78erRX/Z0oKBddk/akeKVxo5rdDUO8tEM4nwV1K+yV0KuS2dxOlvFZ26//PxCt5K FQ4ahoSPzQZ4CGyyeBtU1tMpxkcyDvGlqpei559rQY7pJB2ErXaKXoJLryUdxWKFe4ekPS vWRL2rF9OsQplz49vN7ZkPPfaazCsdU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688397866; a=rsa-sha256; cv=none; b=iupFhZwrQYvh+XhcGnul4Y3tT4n4f8ablhGl51bMs9NrdqLQzKFuBGkvVwEO7k2Ti2J48j Ov5NWCzmVZX0MOVS7/FuAx00/kDlojnyD/Je0iUhTUEkJepBtwh7Ap42fDIT5NM4iN9iCH 80gKZL92TJMtvS59Vnyks3SAGAaXvho= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=VchqeeVA; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f177.google.com with SMTP id 3f1490d57ef6-c50c797c31bso1796519276.0 for ; Mon, 03 Jul 2023 08:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688397865; x=1690989865; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JSSoNEuWLvjsGt2snF40RSrVJcAu0eLTumyB4IL173Q=; b=VchqeeVAkdY4O0oN+VWYLsy9gC9EuBVebuw6Td+DYKLTLiqIoz/NJkithhpaPpJenA 9cBG2EgR9N3FGROTh1Ekv7M1O2eraaTxbFh3jb9j55eSAyDbcfUfIZv8CYWQg93VhYR7 flbo/c/dwZNGGdolpBmFk9Jh6Kp9LdDPM1zLpxFuZGxo920ygbK3kSmyA2iVDnei1Nt2 d3Bm0mRe0p4+04Jy0sIIvLpf95++0aP8ginkyn+HlplmuwqgA7IX86LKJTds1KO35aet x4qyUk0YzUSUEEaFzyxdXPYO3xF4cIC5fByB6NUsf8wMCd3wsN7b7Klm5Jhnq00MR1zL E0EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688397865; x=1690989865; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JSSoNEuWLvjsGt2snF40RSrVJcAu0eLTumyB4IL173Q=; b=QnsfP4wWi0EY8SiamXzXH10rlrPtthu1/k19yYBZb6YbFTY+ghNNfzrZbysQAn2E+Y XATZPdJCrnRXwm1yXQurK3h5mBduYCjb6LDUdFfGlny8vXQ1so+exHDEo19BKXyW6sTv TPVnmznSTzGJcRdYysc9I9v0/TNtpzQMyecGNrYGWKn8jmEhNLvT6xYfl67I//M3hoKP LeljOW4cl9VYplIVuayiMBHgDuHSkFOMs9/Bs5ZJh7ehfqPL1Xm2Enkqvqb04Ny0Uvhe sqRlO1SGKESqNMvAi68oUxTuaW9ngJrEGlweX8nVntGGZRJ8BKZQFyuDewuofkgDFxMU pcpQ== X-Gm-Message-State: ABy/qLarHlz4nXS9g/J6vZTQYkifaQYptz6iO/q3ErLKf/rul6orbiQT IhrKKAQ4+OzI7uTkNNXxEZluS9lFzJZKJiKRxjWtcw== X-Google-Smtp-Source: APBJJlH4+3qD2xM8jFw/CE+zGKmpbqr2lEnaRAx0bqE9Sy/QVLNds+H0Ci951YJKgZpDaSldOn8uFrNZr59CV9WKA6E= X-Received: by 2002:a25:f602:0:b0:c10:7a9f:a96a with SMTP id t2-20020a25f602000000b00c107a9fa96amr11237209ybd.16.1688397864939; Mon, 03 Jul 2023 08:24:24 -0700 (PDT) MIME-Version: 1.0 References: <20230227173632.3292573-1-surenb@google.com> <20230227173632.3292573-30-surenb@google.com> <9a8d788c-b8ba-1b8a-fd79-0e25b1b60bed@kernel.org> <2f150512-e460-a9ae-65db-39dc54fe99d6@kernel.org> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 3 Jul 2023 15:24:13 +0000 Message-ID: Subject: Re: [PATCH v4 29/33] x86/mm: try VMA lock-based page fault handling first To: =?UTF-8?Q?Holger_Hoffst=C3=A4tte?= Cc: Jiri Slaby , akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, linux-mm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 31295C0015 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ffrmbcdn18nzuto44wqrmohwc4znnzd8 X-HE-Tag: 1688397865-926000 X-HE-Meta: U2FsdGVkX1+UqUCFIivR12B2X9nhRONQWARTekIQ15NpzAgs0Xk9nUIfzWbmh8khNVNUqmNRkLqwBnIO5ozsvI+r2e0sIbWgvTZ2Hi73Yb8gZ+nJyWyOv/T0xMAb/lqVQz6yeFDASMC8WZV1aVa44n4xHsqgS2MFMk/KvEMQmBjGy/N6rEcSxjcBaOZsb55RFkr371DPJlm8ZeyIp5VhwJ9bLfYSMt2p6jhuUbhWd+vdp2nFmYLuTPKC5E32VIkYWMk9nYjzZC8S3qnlgQQYcw3Ah8MiOh3khTzN88sbNtL/Wjk6dPWnF4zQc3DNNp0yrl8FGj47PiJxBzYslOwAZXzc9U9YPlPy6u9GQPAUez12X3KbTjC91VWFRODdegCouNRfrU/5xuNJVXJZ5WG5J1KufihGKi/ZaPjG1BFsg5E2z4h0HMxqVjHRShCrFq+BkQoSSCqXwEi6SQ2T0d625YcZVtOSYWIHycigMrAxBmF0YFwoItpY6aMWoSK4UGhIA0PPij/37a0lyKQBWi4Lz6H9X6FZPr5i/zM8PJIkkdk/l33ouQhtK+g7A02Ct4rujr9dDqAeu4PAGIeuf+JpctYkJxa+2szqL7ZLuBDhcod2ZPni1h+jE+DajwCEKJT8ys0doTU2awxqZgzRNGpGq8+OUlGYiGj0r90cXQA+yeIwwrQJ1XUbBG9K7gOyVnGXwfBLd9attLUnSMtbLuJoVDI7fuu6u4uYz7QqD/ePSJCZjoLcUm3QubLv9Mo5OiAmUGe8wDslIZD1o1eW4BL/brLxJr7F4uKU7dHNtMwqW2Un36zXybBrm6M8vrRgMNdLAAAPgEsKhVYVUQ/pyBXTkMEx41cRQia+UdVu8GKvlzTMpLg5PV98zC81hweQZwyFsnz+QbFW4TzUAuhUXH+EBh6q6Wmnxfjt3BYpRXWeSGdzvixHTm3rWhkVVRjTTcRRyLlz1B8j/DYy2QfOgnU HP7PlJuh Et+S64EiCJ55Un/GOYG6ataiNLeAuDUuWbPtoPTSBzAEyz4Zo3tizfInBrV5mam6ifwc9Yic+7IyeuxMV/H55GysKnNaYx+2iO7m5zrsHzecNySYFshXHu2HU9oRFJIQLgOo+SRR0Ip7lomK48ZioheZvBH92hqFc1h6+HxYQ95xG2uBEpBG0nY+y8nXL1qbJYGY0E/E0apeaO5xZQFia4D8zETH6wX+HUbPvVVdVZD8sTPT850pE8/zZbiedxzZ1ZqIWuYQYHI8qkaM89EmGhcCFbs6gc1dPivzR7r7g0mzy8o+Nz7Iz57vqtna7zqSdvr/gjBXh/cgzqmcqlIZayM3zA/MkjGGeGtCo+IB3zMRq4fg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 3, 2023 at 2:45=E2=80=AFPM Suren Baghdasaryan wrote: > > On Mon, Jul 3, 2023 at 6:52=E2=80=AFAM Holger Hoffst=C3=A4tte > wrote: > > > > On 2023-07-03 12:47, Jiri Slaby wrote: > > > Cc Jacob Young (from kernel bugzilla) > > > > > > On 30. 06. 23, 19:40, Suren Baghdasaryan wrote: > > >> On Fri, Jun 30, 2023 at 1:43=E2=80=AFAM Jiri Slaby wrote: > > >>> > > >>> On 30. 06. 23, 10:28, Jiri Slaby wrote: > > >>>> > 2348 > > >>>> clone3({flags=3DCLONE_VM|CLONE_FS|CLONE_FILES|CLONE_SIGHAND|CLONE_= THREAD|CLONE_SYSVSEM|CLONE_SETTLS|CLONE_PARENT_SETTID|CLONE_CHILD_CLEARTID,= child_tid=3D0x7fcaa5882990, parent_tid=3D0x7fcaa5882990, exit_signal=3D0, = stack=3D0x7fcaa5082000, stack_size=3D0x7ffe00, tls=3D0x7fcaa58826c0} =3D> {= parent_tid=3D[2351]}, 88) =3D 2351 > > >>>> > 2350 <... clone3 resumed> =3D> {parent_tid=3D[2372]}, 88) =3D= 2372 > > >>>> > 2351 <... clone3 resumed> =3D> {parent_tid=3D[2354]}, 88) =3D= 2354 > > >>>> > 2351 <... clone3 resumed> =3D> {parent_tid=3D[2357]}, 88) =3D= 2357 > > >>>> > 2354 <... clone3 resumed> =3D> {parent_tid=3D[2355]}, 88) =3D= 2355 > > >>>> > 2355 <... clone3 resumed> =3D> {parent_tid=3D[2370]}, 88) =3D= 2370 > > >>>> > 2370 mmap(NULL, 262144, PROT_READ|PROT_WRITE, > > >>>> MAP_PRIVATE|MAP_ANONYMOUS, -1, 0 > > >>>> > 2370 <... mmap resumed>) =3D 0x7fca68249000 > > >>>> > 2372 <... clone3 resumed> =3D> {parent_tid=3D[2384]}, 88) =3D= 2384 > > >>>> > 2384 <... clone3 resumed> =3D> {parent_tid=3D[2388]}, 88) =3D= 2388 > > >>>> > 2388 <... clone3 resumed> =3D> {parent_tid=3D[2392]}, 88) =3D= 2392 > > >>>> > 2392 <... clone3 resumed> =3D> {parent_tid=3D[2395]}, 88) =3D= 2395 > > >>>> > 2395 write(2, "runtime: marked free object in s"..., 36 > >>>> ...> > > >>>> > > >>>> I.e. IIUC, all are threads (CLONE_VM) and thread 2370 mapped ANON > > >>>> 0x7fca68249000 - 0x7fca6827ffff and go in thread 2395 thinks for s= ome > > >>>> reason 0x7fca6824bec8 in that region is "bad". > > >> > > >> Thanks for the analysis Jiri. > > >> Is it possible from these logs to identify whether 2370 finished the > > >> mmap operation before 2395 tried to access 0x7fca6824bec8? That acce= ss > > >> has to happen only after mmap finishes mapping the region. > > > > > > Hi, > > > > > > it's hard to tell, but I assume so. > > > > > > For now, forget about this go's overly complicated, hard to reproduce= case and concentrate on the very nice reduced testcase in: > > > https://bugzilla.kernel.org/show_bug.cgi?id=3D217624 > > > ;) > > > > > > FWIW, I can reproduce using the test case too. > > Thanks for the reproducer, Jiri! > Let me try it and see if I can figure this one out. Interestingly I can't reproduce it with qemu emulator (reproducer returns 1) but my host machine with the same kernel reproduces it every time. Will try tracing the major code paths to see what's going on. I have to leave for a day but will resume in the evening once I'm home. Thanks, Suren. > > > > > > > thanks, > > > > As another (admittedly correlation-only) data point, I noticed at least= hourly crashes > > of Firefox-114 after upgrading to 6.4.1, which had never happened befor= e with 6.3.x. > > After reverting 0bff0aaea03e2a3ed6 - with a bit of context fixup due to= follow-up > > commits in 6.4.1 - it has been rock stable again, for several hours now= . > > > > cheers > > Holger