From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B519FC3DA59 for ; Wed, 17 Jul 2024 01:22:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D4D96B0092; Tue, 16 Jul 2024 21:22:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45D406B0099; Tue, 16 Jul 2024 21:22:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D7076B009A; Tue, 16 Jul 2024 21:22:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0C4706B0092 for ; Tue, 16 Jul 2024 21:22:27 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9CD5C14071B for ; Wed, 17 Jul 2024 01:22:26 +0000 (UTC) X-FDA: 82347494292.24.C18CC8D Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by imf09.hostedemail.com (Postfix) with ESMTP id D617714000A for ; Wed, 17 Jul 2024 01:22:24 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=X+gO+KTk; spf=pass (imf09.hostedemail.com: domain of surenb@google.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721179314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UZUI7FJG9zfLb/AEzcLaJN+U3HH2U+41STHrzAi6Mvk=; b=XTWjDeCJXfsaADMwO2ASPOCEwV6ygflX3V2bSy0PJ3uEguNKT2oaT5OhB7X56uX1HBHVEp Wp7MaXkCL3TWgCMPNZiwv+wl9xxethRzTXeRkRI+Fd+KK4BgOTU4nPfjPJ80Idsbqk9o9G TuvHzJ8mxtx0BdQMdLN6PQsTyxtT3X4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=X+gO+KTk; spf=pass (imf09.hostedemail.com: domain of surenb@google.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721179314; a=rsa-sha256; cv=none; b=yU1LPlEJ292gOM/FTZZf1YvSP1IQXY3es8I3YO6Xw6b8UVezbD+DUS5Lj9gbcdepzcCpcU SlrEKCIOCwmVuV4V/Lg3W3p/bnTh/z5+G1Ee12s+YKHZXY5bCI44HOFoBdegITXUJInGPY kTyKH3Js9Dl84r67fTz332gp48StQAs= Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-e03caab48a2so255309276.1 for ; Tue, 16 Jul 2024 18:22:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1721179344; x=1721784144; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UZUI7FJG9zfLb/AEzcLaJN+U3HH2U+41STHrzAi6Mvk=; b=X+gO+KTkeI5I6PKgK9e5KbLsd8OHHUPPSrAJCIkGkjzB3Hfx2EsLHcNs5H01/EvRRB vpPTpcHh6c53A3aYH2iafvu1/TmuvtQVvOtvU65pQm7sAoAXEjZr9Six6Dtb+6f5dEZy qSDIqJ3ex8vlCB9YHDI76JhlMuVudzWuDcyMewSdqVCbNDzVYlctJSohYWyeDSKOo8XF lSV9JcWyrr9Y27xZtS3P3Sl3faR2Vzn2tpqwsgyxKr9iLtrmPc7iOWj986O9I8Aoh0qZ OwaLYG67Afps1KMHcbDjMzB+jVEnkvubCkzXKNaVG9zdEIj6QgjfaYXqWn0H6Qq2bv/w ZUDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721179344; x=1721784144; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UZUI7FJG9zfLb/AEzcLaJN+U3HH2U+41STHrzAi6Mvk=; b=ewgVcshKsDdD9AnA8y8K77pYtA2alEbZLnXeytnPuNxgKpYpanwe9NOdS/30XquqG3 VaotRPtmoiMEoLJhw0Art+nbtH+Lh46HUc/Be8kFpa2gFFH4wG55XoODjxHT9d+y0ROt aQ2JAMH2H8ewyIOO030IModAzLaSoHAd/uj/tdl5WLgG9aLegPrV4icZGMVUrqeuIeWb 1gvd5pHja71CLoQSxG0e9jZwXGmW60NecDqa/hKw8EHcFass32mDVn9Eoe0TrmOCSGbs UhuUpPrbwTaHICy5Vy96OXkAuOADd45NBfwXklMxxahiBLZSlhcrAkJ/KS9p4gpGflTX VGrw== X-Forwarded-Encrypted: i=1; AJvYcCVwX/dP4dI/IWLJl8V3VU5+ZA6P4lFsLWocKrYW4L2fRsx0mAewTsiPqrt7EAlFBeGlwEz699wb6sLLP20gb3JLGR0= X-Gm-Message-State: AOJu0YxKYpGvvYcJ0irzj2hNkNTTH4BRmKA4p0ERWxLEe+ICd4rIAr9W edNc+pYzYCr9FSa97exFjnK0kOxtFWjhm6O9SQuOZCYo38tf/MaoxcrCH7zRvuLSon4XSWrmKiI rCoK2Bx7BUg6X+NBf/wCJxq7IIcQxU0BYmPgP X-Google-Smtp-Source: AGHT+IH7H0lu+6NNAxh1bFNPzp0/m26YBTmH4JeTpQTaooazXAIaLFqjmsBHamMvor1xI+mX4AJv81vFwtlasdSGI+k= X-Received: by 2002:a05:6902:c0b:b0:dff:2c27:c019 with SMTP id 3f1490d57ef6-e05ed705177mr166528276.13.1721179343430; Tue, 16 Jul 2024 18:22:23 -0700 (PDT) MIME-Version: 1.0 References: <20240711204626.1669138-1-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 16 Jul 2024 18:22:10 -0700 Message-ID: Subject: Re: [PATCH 1/1] alloc_tag: Export memory allocation profiling symbols used by modules To: Christoph Hellwig Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, vbabka@suse.cz, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel test robot Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 859pzwr6o5zmode5jpr1rpjzraqxdoxp X-Rspam-User: X-Rspamd-Queue-Id: D617714000A X-Rspamd-Server: rspam02 X-HE-Tag: 1721179344-647662 X-HE-Meta: U2FsdGVkX18p+buMIyKuN7OW4DxSLVNxr4GqBQzOirgrtJ5GTMsBn5z/KgNwKLcPu4yPJPIZJDvYDmH/xDZhZF6s5x44witfRmEnfKWGExdhREoxaT/eumbipdDzPX5vimWDm2DLrnRtS2s54g/pRDN+Uu6ATCiIu0M35FZzzUa/AHSIhRRJthjJJwhqslQswuZHPoLBRDWXhiRv/J5C54yWE6MZ8MkEmspgC4kMnK9XL11FTDFn/POOowz4IrFa+vzRHBbqHJ4jvHVmmkgGgIMwKwkqPAzqL3XU/z4wgW/6ZmXm66VWg8se1sHjc1dlyv+lsS9HyGIypOaSJhenpLvZH8Xb2fJk2Ovxd7K2ZrqKznaKcCb7QrTbqOqXWLaAu0erJ+UXrPmGzUgkIvUZfKiP6zCyOZbIsQx9ropSFxvL0CmwiPahIl2oGbcU7dk6WyHGzTi5Qi7NuiXtGcwelF2Kk8q807yB2Jg7H/XScYwSJDQH7XDmSxiOATJuJuNQn90vt4vZHOD5Ye6u3cxy0mnWyIoK4cAss6uNvTNCkXwD1kj08h5EjXMVQQ+U40o9xaMwrrxD/PW59E/0Mt0KXE8jQmCFaDz+2vK/EZjkdI5N97kl6hzhAXoiHNXmebTn+V9sdyRON4ncP7sItxy5BgHFJqB3zCgCHMwyxWfJMfdj+EjucvKXwbuY/q5VBCfwE0ALJrIR9Z9F+uOmdhrpOxxKDn/uGGldSTDg/5dES2e1wYexIpyzwIPKF6vRCWJa3K7PhutsZVxOXAkaKI7hKT77ALT6jWbWx0uiTPg9SDOntuGKOdJm3Ia0DYjMfhOITFRk0gyJc93HX1EhOkJ1JRVmXDZSt1HG8tOshIIGRNNjlg+H/kVGVROMpJdX9m+GxpoRNkdNNWrbxs6KnWSadUu5qdFE/4XkTB41Eq7Qga9rhWbOyOH+S6NV2FOOcuBH4evpP5GOvIm7MRUQh8T iGSYw+b+ 4kPshB1f6ck1q2IyJrfHjZg8IfNjF6/HCzd5RTvM8E5Oqwf+y/9tpQp7P62RBT6C1uYR1bpZarnflif2ROgpRIGB8n5YjU4OmFq8NBtmVRN//4n1ENwuLKiBOajhl1wILF9yOtAp1EOI8fiwyJNkTwzJNdDox5NQOgzQ6V61qyqZmiaTV2KNSQS1TqTg+bj+C3lcERTC6lCKh6njK972z2yynCgwwwOO1C6+uHJioMB3Wpc6TufbEqJX8B8APoGtU78HMOmhlnlyqq3EiTKG69PjFfbIprwdy2pW8uyrrW6vmOAKK/68CB9FdFQcobzcrCBgK5R7BJjW8p19VzLIiGcqzu9zld9XHifrR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000144, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 12, 2024 at 6:27=E2=80=AFAM Suren Baghdasaryan wrote: > > On Thu, Jul 11, 2024 at 9:25=E2=80=AFPM Christoph Hellwig wrote: > > > > On Thu, Jul 11, 2024 at 01:46:26PM -0700, Suren Baghdasaryan wrote: > > > +EXPORT_SYMBOL(page_ext_get); > > > > > +EXPORT_SYMBOL(page_ext_put); > > > > These really have no business being exported, especially non-GPL. > > Please rework whatever interfaces need them to be be moved out of line. > > Ok, I can do that. Thanks for the feedback! Replacement patches are posted at https://lore.kernel.org/all/20240717011631.2150066-1-surenb@google.com Andrew, could you please replace this older patch with the new patchset (2 patches now)? I can see the old patch in mm-unstable as ac5ca7954e4e ("alloc_tag: export memory allocation profiling symbols used by modules") and I think it's also in your mm-hotfixes-stable. Please replace it with new patches. Thanks, Suren. > > >