From: Suren Baghdasaryan <surenb@google.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Markus Elfring <Markus.Elfring@web.de>,
linux-mm@kvack.org, kernel-janitors@vger.kernel.org,
kernel-team@android.com,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Axel Rasmussen <axelrasmussen@google.com>,
David Hildenbrand <david@redhat.com>,
David Rientjes <rientjes@google.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Greg Thelen <gthelen@google.com>,
Hugh Dickins <hughd@google.com>, Jann Horn <jannh@google.com>,
Jerome Glisse <jglisse@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Laurent Dufour <ldufour@linux.ibm.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Lorenzo Stoakes <lstoakes@gmail.com>,
Michal Hocko <mhocko@kernel.org>,
Michel Lespinasse <michel@lespinasse.org>,
Pasha Tatashin <tatashin@google.com>,
Peter Xu <peterx@redhat.com>,
Punit Agrawal <punit.agrawal@bytedance.com>,
Shakeel Butt <shakeelb@google.com>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH 1/2] mm: lock a vma before stack expansion
Date: Fri, 7 Jul 2023 20:08:29 +0000 [thread overview]
Message-ID: <CAJuCfpFj_OWi=SRgUp=f3MAhb988fZL46oWKpL1jM15i91x5Yw@mail.gmail.com> (raw)
In-Reply-To: <ZKhvgm6geUvLPQKk@casper.infradead.org>
On Fri, Jul 7, 2023 at 8:03 PM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Fri, Jul 07, 2023 at 10:00:42PM +0200, Markus Elfring wrote:
> > …
> > > write-locked to prevent page faults into the VMA being expanded. Add
> > > the necessary locking.
> >
> > 1. Would it a bit nicer to put the second sentence on a separate line
> > in such a change description?
Maybe. Will do if there is a need to post a v2.
> >
> > 2. I noticed that you put the address “stable@vger.kernel.org”
> > into the message field “Cc”.
> > Would you like to specify such a hint as a tag?
> >
> > See also:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n264
Yeah, I always forget that :(
> >
> > 3. How do you think about to add the tag “Fixes”?
I thought about it but was not sure which patch I should list under
such tag because the rules for stack expansion changed recently.
> >
> > 4. Will a cover letter become helpful also for the presented small patch series?
Not much to say other than "add some missing locking" :)
>
> Markus, your nitpicking is not useful. Please stop.
I'll fix the nits, at least the ones I can, if there is a need for v2.
next prev parent reply other threads:[~2023-07-07 20:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 4:32 Suren Baghdasaryan
2023-07-07 4:32 ` [PATCH 2/2] mm: lock newly mapped VMA which can be modified after it becomes visible Suren Baghdasaryan
2023-07-07 19:48 ` Liam R. Howlett
2023-07-07 20:15 ` Suren Baghdasaryan
2023-07-07 19:27 ` [PATCH 1/2] mm: lock a vma before stack expansion Andrew Morton
2023-07-07 20:03 ` Suren Baghdasaryan
2023-07-07 20:00 ` Markus Elfring
2023-07-07 20:03 ` Matthew Wilcox
2023-07-07 20:08 ` Suren Baghdasaryan [this message]
2023-07-08 5:55 ` [1/2] " Markus Elfring
2023-07-08 6:18 ` Suren Baghdasaryan
2023-07-08 6:33 ` Markus Elfring
2023-07-08 5:30 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJuCfpFj_OWi=SRgUp=f3MAhb988fZL46oWKpL1jM15i91x5Yw@mail.gmail.com' \
--to=surenb@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=Markus.Elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jannh@google.com \
--cc=jglisse@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=mhocko@kernel.org \
--cc=michel@lespinasse.org \
--cc=peterx@redhat.com \
--cc=punit.agrawal@bytedance.com \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=tatashin@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox