From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BFEDC433EF for ; Tue, 7 Dec 2021 17:05:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E2546B00B7; Tue, 7 Dec 2021 12:05:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 092486B00B8; Tue, 7 Dec 2021 12:05:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9D086B00BB; Tue, 7 Dec 2021 12:05:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0090.hostedemail.com [216.40.44.90]) by kanga.kvack.org (Postfix) with ESMTP id DB1CD6B00B7 for ; Tue, 7 Dec 2021 12:05:09 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9C6C418147567 for ; Tue, 7 Dec 2021 17:04:59 +0000 (UTC) X-FDA: 78891623118.25.B838622 Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf19.hostedemail.com (Postfix) with ESMTP id 2ED85B0000AD for ; Tue, 7 Dec 2021 17:04:58 +0000 (UTC) Received: by mail-yb1-f179.google.com with SMTP id d10so42887106ybn.0 for ; Tue, 07 Dec 2021 09:04:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O73Ze+VaZ72yqZEQS/KFQihGyU4Mm5AKKp2/1/GYgVA=; b=KrByQ0JfoqCtbQKA/SPw4hrXd2hut53v8cVXeumIKc3jsfhmQy+eu+jBSjFhMOZO5N qFeO9hBpT0uyME6t11z11b1Q48aIYpnkk8+J2oMf275wKThdmf3t6bfm8Cd6HqRs07EQ IA/OeE3VQsz6f26MEfyaWVBqROeIU1N+JGYxx95CFhdsNifoX2cts0O3D8tzXJBCr6TF csw89OCuXY5pilyURgMjZGe34oy2xuj1GJ4VniStv9aEFI57agr1bn0E5sA+WTxxUgTj VGbwhA6J8aUjrf01dyebrbaAaksUlAm5CD+DvdtfpEg2YUbZ83DdSfqHvw+oETsMioTz Wo+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O73Ze+VaZ72yqZEQS/KFQihGyU4Mm5AKKp2/1/GYgVA=; b=6F114t2AhM2zAcgabEVP9E7P+2cgo87JH8587S3rMKeIEIKljk288+ZSMwnDWrFvKV pdcz2I2GIvet1rzv1VdwcqPB2A2feLrjxIbOYo95mHCgJgPDUYGmxZmomDxFsRz7Lc3p m1FW5sVQ0QWQhOiQnfK/HNz2ReJJHdWWvePyjl//ViZGmvSPGGAp4x1qxkXn5Ptaw1tQ tyN9noaI3vLygBJ3PW1GaylloJcHy9dQ3c8JAxQqVhot3DbKeNqmFE9fv5UiKTvCoy3/ Z9kDn4NBhaz9OXYmMxT0BM2WHrWV//CWBs1DBslEgjn0osKDs8kCFzp8JtBoJBTxpiO4 z/xA== X-Gm-Message-State: AOAM532dUFAYed/4lpNfExijH9PisbxAn1d0tnFYQhHY/Tsg6b82D9AV ePwr9a0X4R33e9XzcT3owI5PD6JOptxrU9pIkm2LIw== X-Google-Smtp-Source: ABdhPJwp9DybShWds517wP/lVihTekfcDrGzA+mDrpQ8/7v2KoG0f6RJNuvIBdbUpi9vbxnyaKQN6XHRMU+yLNoUsxs= X-Received: by 2002:a25:6ec5:: with SMTP id j188mr52542171ybc.602.1638896698078; Tue, 07 Dec 2021 09:04:58 -0800 (PST) MIME-Version: 1.0 References: <20211207032202.6022-1-xiaofeng5@xiaomi.com> In-Reply-To: <20211207032202.6022-1-xiaofeng5@xiaomi.com> From: Suren Baghdasaryan Date: Tue, 7 Dec 2021 09:04:47 -0800 Message-ID: Subject: Re: [PATCH] mm/madvise: break reclaim when lock race To: xf2017140389@gmail.com Cc: akpm@linux-foundation.org, christian@brauner.io, linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhangcang@xiaomi.com, wangju@xiaomi.com, fangzhirong@xiaomi.com, xiaofeng , Minchan Kim Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2ED85B0000AD X-Stat-Signature: 3ggduip7je47cdyffp9pwmw46oe9kjcb Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=KrByQ0Jf; spf=pass (imf19.hostedemail.com: domain of surenb@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1638896698-472021 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 6, 2021 at 7:22 PM wrote: > > From: xiaofeng > > When the process_madvise() system call is being used, it takes mmap_lock and blocks the application from allocating memory, leading to unreasonable delays. This patchset aims to fix it. Please use checkpatch.pl script before posting (see this blog for example: http://nickdesaulniers.github.io/blog/2017/05/16/submitting-your-first-patch-to-the-linux-kernel-and-responding-to-feedback/). Could you please describe your usecase a bit more? Which MADV is being used specifically (MADV_COLD or MADV_PAGEOUT)? CC'ing Minchan as he might be interested in learning more about this. > > Signed-off-by: xiaofeng > --- > mm/madvise.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 8c927202bbe6..8f1e325873e0 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -322,6 +322,9 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, > if (fatal_signal_pending(current)) > return -EINTR; > > + if (mmap_lock_is_contended(mm)) > + return -EINTR; > + > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > if (pmd_trans_huge(*pmd)) { > pmd_t orig_pmd; > -- > 2.17.1 >