From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 951A6C3DA7F for ; Mon, 12 Aug 2024 19:26:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27AC86B00B3; Mon, 12 Aug 2024 15:26:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 252546B00B7; Mon, 12 Aug 2024 15:26:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CB8B6B00BA; Mon, 12 Aug 2024 15:26:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DFCF16B00B3 for ; Mon, 12 Aug 2024 15:26:17 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6237180343 for ; Mon, 12 Aug 2024 19:26:17 +0000 (UTC) X-FDA: 82444574394.09.CFE8768 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) by imf15.hostedemail.com (Postfix) with ESMTP id A2289A0009 for ; Mon, 12 Aug 2024 19:26:15 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XUVA4GU5; spf=pass (imf15.hostedemail.com: domain of surenb@google.com designates 209.85.128.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723490741; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9qOTNxJuDi4l+kkwsANOYH20hBs3wkhnJKGca4BkDSE=; b=1rRAcgQfQOtGeCBp37aML9O0g3sZQXPqx7sSzMYrI53P9nn03jYsLOs/7OdO3QJ2DjgP0L wGG3FxZbDbM1CbAwibaRbYbZXuRwsKrtFacHOTnXd50ibtIK0Dwn5tdHFxUCAtdIQu24B7 hyWSVs+ldLa7QigPIAHV79VWNf9eTp4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XUVA4GU5; spf=pass (imf15.hostedemail.com: domain of surenb@google.com designates 209.85.128.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723490741; a=rsa-sha256; cv=none; b=T+21LdIIA8SIZm2wexX9ZnPqc67YWSCZ/oxiCmEj1jFaybn5BD0IhooqsCPNdZhydH42bs PaAiAhiFkkHcRe24BPOX7/DbK2cgBk5IDWb9ywRHZ2FpR6dVPTD5JWYpBgcFWupwH0/SiG TKYBKYssso3FedBpb2+kzWPpCcW/thU= Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-65fdfd7b3deso43345527b3.0 for ; Mon, 12 Aug 2024 12:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723490775; x=1724095575; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9qOTNxJuDi4l+kkwsANOYH20hBs3wkhnJKGca4BkDSE=; b=XUVA4GU5CFqWwcM1glFJsdgr3EqXhKrGlbVe/gAPphzKGgqoOghO8oTvWnZ836nayU /qCwRC2ylCDBcRyVeFoTKqMzrYhKVLjbe3BkxXepjHmGsLIkPw8uq4fZtweZ65QTkgB2 K2/UqaP29eobIZYLocgMLACO+Q66xVyBd89RJ5pUnf4oOFZ/Sj/c7EpfR7MXP+8W//lT bFvbc676mxE/b2XedFxrPvyWQayXhpUnu1A7nJH39O0tCXBenjunnTKUNtx+D7f2l58+ jQSYCyd06qub2esk+r5lt5ZoxUj+5CNpqMOhIIR/q+Cp4Vf8MN9UDYSrwOPS6ScRl5B8 /oiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723490775; x=1724095575; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9qOTNxJuDi4l+kkwsANOYH20hBs3wkhnJKGca4BkDSE=; b=aknQc2jdJUUiCmvUU8PEEzmuLOEc6vP9UDForXokLYjr928mEtaMWqA+J8237qrwRm RIKEqELiUsesHyMIirCNwrpwHtDRiGMIJ7J3B1bMGpMW4AjAWw3CN73/vAmVlQbSV3Zf ZasBu04sE0rYmdJWKANSCzf7xCff2iAjQgnZKOuZzVzYuybpx0jnfTUSjX9aOKtE8QvT fA05iQDQbEXytdmKOyM/I+WyeLcqPWoXFZwN7FZ1Vg1QjXfdL2kTBawt40VDDlXHm2Fj M81gj4NFtRxY5hYz2Ck8VMV1vAMGKXAlEgtmHsendPfk4penkDVk3BL3XrlMxDchaiY1 zceg== X-Forwarded-Encrypted: i=1; AJvYcCVnQ20T2vFZUfrLBRHYbhFkBFWuHaj1UF9KeCL08wka5I1Hyavixn5IADmQjQ4sLWjqv+rezl/u5wsZInWdjoyAUAk= X-Gm-Message-State: AOJu0YwWk6tjzylfa4S/lsRJ2fPnb02NQTWwA2DFAZLpOVe0UJlSm0UZ SCT6GPZaoNZF9UtDxuTXB2tEmL5wotVYcabOKFwbLXcxxQJ0Zdm1kQEs7DV+aIxQQV/NQ/N+tSb 6BQFHVUA+QqOjr+JLb+dObR1r8mB8AqPhw3+H X-Google-Smtp-Source: AGHT+IFGf0WycWYbTvNVHWKDUUMcMceyv4Kuc59J35T7TEhghacRgHCE3k3Dm4XPQhix0qKukNFnNbUSv4OHcf60U58= X-Received: by 2002:a05:690c:f0c:b0:664:badf:5a8c with SMTP id 00721157ae682-6a9718f3671mr15973087b3.3.1723490774408; Mon, 12 Aug 2024 12:26:14 -0700 (PDT) MIME-Version: 1.0 References: <20240812184455.86580-1-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 12 Aug 2024 12:26:03 -0700 Message-ID: Subject: Re: [PATCH 1/1] alloc_tag: mark pages reserved during CMA activation as not tagged To: akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, hch@infradead.org, vbabka@suse.cz, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: A2289A0009 X-Stat-Signature: 963oybk5nj9pbqf188efgwywbtzmxn6e X-HE-Tag: 1723490775-927572 X-HE-Meta: U2FsdGVkX19V5AeFqPEPEEPGF9mbRnPxStca0fKnCZtNvkv8Jxblhkhwq2bBDJZc43Hog0Y+xZQYnWiJcdtyKg9PaDf/1cZwhF05fL63mXkBQrRy4TdfZFnQBF3Y2OJCgTYXgO7Em6DylKN332sCL/2nEuiCNBcFVY3rfh90InJTeVOxi4h3xxv5Lg+FB+E6MnI1s7KKrU//KT8PqLk3xbX1btBodfgK4nUnnlIXATIFRDRPq9FmWzdZg5csf53bfGm4YuMHnKXBOR3uJM+3p+Kd2sTZGCwJAiheXYZPJsR4r4Gcafr0SoOmw8aQXYZUZIwtyFlD1ypavMj3Sj2Vbq0NPLXYiVlZ8c+zpwQZYaeGuX0nT7Eus/WHI4PVMu3TgsUzebHv9nIzx1S/kKfYFjJDn7x2g13Mwklgnt9FBNIjDsO9a35KYLI4qcPEqaWwl2VJwHGoGUak33Zytvi/9o2IxrD/Dbz7zlnih+HwAI/1Yh/HjH9jIuuUT1Inday1TM54LYVOLGOdbv3rARXax8jMgNR0DenrtgKS9zwTmbr8q3oZk1KW6IV12CnuGneB9Ti2krBjnF9ki4LHUGwAdDnP6tppWVRp9kJ07u7rOAtOUTs3rFEAB4jVN3MHxqqPBeUabcdYRdN4aJH6ld5fCYq0lbDoygNlvGfs2oYRdFjJ1plY0PPUOImNAiKn9PpD1NdLdvOPDyks+O2cjNyifGoThz5iWnNfXKYdsj6U4Z4u0EEvIRVSvR6w3adSnVeM7RK4vZp+SpL+4Z9Ikl2/oq5JUmjSgOsdXLJHj7MzrHfTDTJdkyUfjfkBJzWcOcAG7L9OH1REXuRqJndPiCbNYVtuREqzXFNSVOWd00PzSzzZa2RCvQtmY3nR2ApC61OcyS1futtO6Anh+TVIv+tUUOR+uW9L7S84ctKjgyd9EIt5qnNjB6w1s8qyxR5kFasGKfCxuozt26FN2KWgJml /Yo9GGJF 2aHXfxsJ/oK5n5NsPG6cQueABjtoLaaZMY5v3OAzUkD1X3PmxAi/54ZDfMOsm98M3R2hGm3eL4NL5imb+jCe9Hw+nSFu9QBiLXvcs3weHl+3R66PGk0OZBZ+1yIIOZM0NQcplVtPOS7PYxA/lOuVhnS4FufbY7evcTu+f4RCevIsaBnKrZYnCkvyYwnj8D0WWsDuks+TiiKe/1rScIv9/+ICo64MPCJ8PUZ8Wr3BWiY5GqM8KLM1CnuZVibDEBSzcMZ+tRNxY2On31/V/Go1zDapuJ7zBMDIWrWhq81N83mPYH6U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 12, 2024 at 12:13=E2=80=AFPM Suren Baghdasaryan wrote: > > On Mon, Aug 12, 2024 at 12:11=E2=80=AFPM Suren Baghdasaryan wrote: > > > > On Mon, Aug 12, 2024 at 11:44=E2=80=AFAM Suren Baghdasaryan wrote: > > > > > > During CMA activation, pages in CMA area are prepared and then freed > > > without being allocated. This triggers warnings when memory allocatio= n > > > debug config (CONFIG_MEM_ALLOC_PROFILING_DEBUG) is enabled. Fix this > > > by marking these pages not tagged before freeing them. > > > > This should also have: > > > > Fixes: d224eb0287fb "codetag: debug: mark codetags for reserved pages a= s empty" > > And Cc: stable@vger.kernel.org # v6.10 > > Let me post v2 with these corrections... v2 with corrections posted at https://lore.kernel.org/all/20240812192428.151825-1-surenb@google.com/ > > > > > > > > > Signed-off-by: Suren Baghdasaryan > > > --- > > > mm/mm_init.c | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git a/mm/mm_init.c b/mm/mm_init.c > > > index 75c3bd42799b..ec9324653ad9 100644 > > > --- a/mm/mm_init.c > > > +++ b/mm/mm_init.c > > > @@ -2245,6 +2245,16 @@ void __init init_cma_reserved_pageblock(struct= page *page) > > > > > > set_pageblock_migratetype(page, MIGRATE_CMA); > > > set_page_refcounted(page); > > > + > > > + /* pages were reserved and not allocated */ > > > + if (mem_alloc_profiling_enabled()) { > > > + union codetag_ref *ref =3D get_page_tag_ref(page); > > > + > > > + if (ref) { > > > + set_codetag_empty(ref); > > > + put_page_tag_ref(ref); > > > + } > > > + } > > > __free_pages(page, pageblock_order); > > > > > > adjust_managed_page_count(page, pageblock_nr_pages); > > > > > > base-commit: d74da846046aeec9333e802f5918bd3261fb5509 > > > -- > > > 2.46.0.76.ge559c4bf1a-goog > > >