From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D35CDECAAD4 for ; Wed, 31 Aug 2022 15:56:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 715446B0071; Wed, 31 Aug 2022 11:56:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C43F8D0002; Wed, 31 Aug 2022 11:56:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58C528D0001; Wed, 31 Aug 2022 11:56:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 47E936B0071 for ; Wed, 31 Aug 2022 11:56:23 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1E67580ABD for ; Wed, 31 Aug 2022 15:56:23 +0000 (UTC) X-FDA: 79860339846.05.E47BD8B Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by imf11.hostedemail.com (Postfix) with ESMTP id BFBB84003B for ; Wed, 31 Aug 2022 15:56:22 +0000 (UTC) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-3376851fe13so311623787b3.6 for ; Wed, 31 Aug 2022 08:56:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=cCRpuq5ugrZCMPNASqLzmnmQqSHwIbDaqesnsW6hpVY=; b=dp7ag/s/XswteEOQhIlZJ0Nr9OSh2piBWOaxYRC3sJJA1h7P9YiBLyTj5ZbqtTA5s/ QVBATN/coisioHRuuIpGq3gJNfqJZeq14BoEa/ktEy7OjVkakgw2dN07PvsjfH2DKU0B bxLma1WzIl4FKw+quVea/qjMwPtAOmq0TevZHzdNCNncQhM1PD4uyKVu4HWZvLI6BqTx H7kaRy09fBu1xgcDeDqWrzFeKvin7yA3AAOKZ6MQsBsn3T/kb8YICvKVh7LgyXMq+5Bi FLuEciavzkBG7ruhxzyjiDdwLtfbNolH0swGrGj9z+IyuUE/sK6RMxqKOGNWiAhwfBa3 5mXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=cCRpuq5ugrZCMPNASqLzmnmQqSHwIbDaqesnsW6hpVY=; b=lAJDvqKnGWCeQ7RMFzwC7kZRIRE8y0bMIf3zU/tENsVePCqg/TBu9UTbeq7xaHGHC0 BVvSMK1TXKRZTEfKiOrhcpu5lSwQUMrAox2HIThHPf1RZkpWdtClxikHbJozOaZmMPTo MNUnmAXN+/5yPcMn4CoN5Njg8MdLHZgcU1nQlATBtoTkRJsVt7ezdwv6mtFgBb7spLDy 6KeI0rYE7XgFRR3GzEl/is5txcybi4O/sJ4p5dQDzh1si5OZpeNb+ttHRYkngpw5GzT7 ylT/83awIN84jX/axLsehjAZx5CNLAiXcibHSNrUHEl4pxN00KolU3uxFEuHKbYZpFvS rLdQ== X-Gm-Message-State: ACgBeo345IfuuyrlYlD5N8dQrqrNvjzipibR1xkFvih26LQxs0ymaUjd veG4YXguqnyL8NMmR5vkAefhFppF/kc4S8HWh3AxQw== X-Google-Smtp-Source: AA6agR7Lu6PK9CdXu23xIn3AG3MYNgxqZ4pzHv7Fy3xw9o0fL/gGGSH+N2uXtSf2ZsqL9IuP0dnF/6Y/gY//h7qjU0c= X-Received: by 2002:a81:85c3:0:b0:33d:a4d9:4599 with SMTP id v186-20020a8185c3000000b0033da4d94599mr18562781ywf.237.1661961381492; Wed, 31 Aug 2022 08:56:21 -0700 (PDT) MIME-Version: 1.0 References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-23-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 31 Aug 2022 08:56:10 -0700 Message-ID: Subject: Re: [RFC PATCH 22/30] Code tagging based fault injection To: Randy Dunlap Cc: Andrew Morton , Kent Overstreet , Michal Hocko , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Mel Gorman , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Peter Zijlstra , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , dvyukov@google.com, Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661961382; a=rsa-sha256; cv=none; b=zK1erMSZu0NH3kCJJhg/jC5tZ1x4dFqeFunaiMaqOgSV8RTn5Y/6ApHjjY6pzYRAdbBG/L 89u5Mzl/KI/iYi1PxP54XflUaEU/tgRKUXYQotvDwKn2uNE9nMZj7cXyQLJNfOZ25CkZoC JBz8/0YgcEb//mRjpMlDA8oB+YCkZr0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="dp7ag/s/"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of surenb@google.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661961382; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cCRpuq5ugrZCMPNASqLzmnmQqSHwIbDaqesnsW6hpVY=; b=aXBXI75TjR7zW/iYFJzWg0QpQH5VUaGdhK4f95CJr6ziUEzZCOG388uREeccecDwTRewNt adasmwVYZLHA+foTf1IhouBpLkrrB9SvuH+d/VjrGBTy6u+PrOCBj52QHgsFKN+dkHD2C0 vJgnE+G7Yc6RY9c0ET6p6Xdv7NKv/KE= X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="dp7ag/s/"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of surenb@google.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=surenb@google.com X-Rspamd-Server: rspam07 X-Stat-Signature: pidi4y16rek3y5h8ygysw7ocuwt7i9py X-Rspamd-Queue-Id: BFBB84003B X-HE-Tag: 1661961382-656026 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 30, 2022 at 6:52 PM Randy Dunlap wrote: > > > > On 8/30/22 14:49, Suren Baghdasaryan wrote: > > From: Kent Overstreet > > > > This adds a new fault injection capability, based on code tagging. > > > > To use, simply insert somewhere in your code > > > > dynamic_fault("fault_class_name") > > > > and check whether it returns true - if so, inject the error. > > For example > > > > if (dynamic_fault("init")) > > return -EINVAL; > > > > There's no need to define faults elsewhere, as with > > include/linux/fault-injection.h. Faults show up in debugfs, under > > /sys/kernel/debug/dynamic_faults, and can be selected based on > > file/module/function/line number/class, and enabled permanently, or in > > oneshot mode, or with a specified frequency. > > > > Signed-off-by: Kent Overstreet > > Missing Signed-off-by: from Suren. > See Documentation/process/submitting-patches.rst: > > When to use Acked-by:, Cc:, and Co-developed-by: > ------------------------------------------------ > > The Signed-off-by: tag indicates that the signer was involved in the > development of the patch, or that he/she was in the patch's delivery path. Thanks for the note! Will fix in the next respin. > > > -- > ~Randy