From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32F79C4829E for ; Thu, 15 Feb 2024 22:19:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFB8E8D000E; Thu, 15 Feb 2024 17:19:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B84058D0006; Thu, 15 Feb 2024 17:19:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A246E8D000E; Thu, 15 Feb 2024 17:19:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8DDC08D0006 for ; Thu, 15 Feb 2024 17:19:55 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 631CFC0874 for ; Thu, 15 Feb 2024 22:19:55 +0000 (UTC) X-FDA: 81795456750.19.7BF9997 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by imf08.hostedemail.com (Postfix) with ESMTP id 962BF160006 for ; Thu, 15 Feb 2024 22:19:53 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=4ttPrV5H; spf=pass (imf08.hostedemail.com: domain of surenb@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708035593; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EIA+RVykCQtMd4uKP0jMkGSiYfomHvLOKfcmRsJzzt8=; b=7Wm1+jhyuhkrr2q2QwrV+jiV9sZh0m7CDl+IY9sG2surwmUyTXG89RmBylb2kkwR6SmweR K2+vmWBJ88zZTaS8BlJpB2HSUElUSxNqeUeuDfN6jTub6Q7oFMFqVrJjhVXUsC0844V+Ph b9bmeyTtw9R26DzD4MQnBT4zlVDOATs= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=4ttPrV5H; spf=pass (imf08.hostedemail.com: domain of surenb@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708035593; a=rsa-sha256; cv=none; b=7vbCyu5SjxN7U+9YCENAoxyBz3eWp20WQmAC5KoLXZ42hbFlJrOsKYqrarAyUV8gcJVgJa xWa6YY208fOO8C8jTTm1WWVyJ0TQsAiwo/qXUQRf2fbaRel0owzw0bZkF2AFZ5w0Fkb+6a tAZY+nkUHOrCIRomFoIzW+NvQukZ6fo= Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-60495209415so14635547b3.3 for ; Thu, 15 Feb 2024 14:19:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708035593; x=1708640393; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EIA+RVykCQtMd4uKP0jMkGSiYfomHvLOKfcmRsJzzt8=; b=4ttPrV5HWloRiQwwJsXRLOb4ugxzQp46GaMNxI7bip/Lc27mNgm3kiDurk47lf+Wg9 83a21LvnIyoUU1n/L+Ejz+oAvsNE3IO5OHg8Qq3AR5QefJuo2ZFxBHFPzCHJovW5DksF 1A5Z28mJcqg8iOUExOaAhRvdmOvzCkjm8nyKRNvLN01LCHAF4ohXNfEQ25iRBuITXXCv 0fZSCkLXbBXPpd/YZI9AAfClVA78W6tgvcBFRwPwhXAyxc6MoFELi/c1qKKGQrzW+kYY SKo6YGXaksI/0LTdZaiL50Bhz94cRHlvrKLJ37W8lw1Yk9cn/qPeXuUlVFWQ4bjyoZKV KjBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708035593; x=1708640393; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EIA+RVykCQtMd4uKP0jMkGSiYfomHvLOKfcmRsJzzt8=; b=ujVijK/7evpGjDJIHaj98z45JFpn8Pm2z58+2eWis1qGYk0Th3ER7gHQm+4bLKuwAi NFZpx5eMNU1eBb4inqd/3Nj65pBazKkZ5wHtEz3IdN/Rf8KhO3UDJD81/yxY6NNoc+hl FHJFHNROqzKNtFa+HJvJfYN/oU2J9oHao75vBzrkrovDf6OVg1qX529ktmwL8038fErs XMh+jwBF0CxtKEISMFsjn4053EIppAC7VhrQPaGKSC7DibQzm//CJpKd+CanEKNwOPzg 1t3LfmxHEZVefJuH+1Ig7XbLBw+3PCksYJpf59z76mKJHd1+hgU9q4KPsepzCS7TKtVs 4OEg== X-Forwarded-Encrypted: i=1; AJvYcCURZeZy0DIWyIw1xhyrWPa1pwh6ugUi/ERosw1tdXhL1Uc+8u+lB9RiB2wjRl2tblGSWA+l9BMKf28KSgPO0Kzzc48= X-Gm-Message-State: AOJu0YyE8cYnVXYYcWRThLz7cx74IIm9bUwx6npigC9RXnyCpQPp5Dv7 tnTyI5mQKQg03R1X4Xw0h73yyX2bZhVQqkjVRIhPQH5Sy5T5IQ2latiWk/SvWTk8P+qR8uO4y37 YArnKB5/P66kRb0ldF813ow0qMzLv4vCWI+Bi0cYEQI4CgdR5Q3ag X-Google-Smtp-Source: AGHT+IH5Y8G4M+psLtl5ozUOu2RjeWfSvT5C53fM4Wva+peYjIwy6mOS42gzLlAZlpmBSbzeIubfKTtWZadUROXeA8I= X-Received: by 2002:a81:a103:0:b0:607:c8fe:c4c3 with SMTP id y3-20020a81a103000000b00607c8fec4c3mr3441262ywg.30.1708035592344; Thu, 15 Feb 2024 14:19:52 -0800 (PST) MIME-Version: 1.0 References: <20240215182756.3448972-1-lokeshgidra@google.com> <20240215182756.3448972-4-lokeshgidra@google.com> In-Reply-To: <20240215182756.3448972-4-lokeshgidra@google.com> From: Suren Baghdasaryan Date: Thu, 15 Feb 2024 14:19:41 -0800 Message-ID: Subject: Re: [PATCH v7 3/4] mm: add vma_assert_locked() for !CONFIG_PER_VMA_LOCK To: Lokesh Gidra Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, selinux@vger.kernel.org, kernel-team@android.com, aarcange@redhat.com, peterx@redhat.com, david@redhat.com, axelrasmussen@google.com, bgeffon@google.com, willy@infradead.org, jannh@google.com, kaleshsingh@google.com, ngeoffray@google.com, timmurray@google.com, rppt@kernel.org, Liam.Howlett@oracle.com, ryan.roberts@arm.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 962BF160006 X-Rspam-User: X-Stat-Signature: tihte3iofyw9nantb5t14p4zcx8pr8ii X-Rspamd-Server: rspam01 X-HE-Tag: 1708035593-856592 X-HE-Meta: U2FsdGVkX1+rgjdVzVCfqdBq7GikqKSvr3EoDnu7BljLlxZnoWiuEVRx0a8+3Z/bK+0L3b2b090GeKUzYbaRw6T5w6wUXE3QUSw/+8yKh76nYPR0+kjkyNjnQ4a8TpEv/H6Qi9b7njEi7zvhkitRS1/O0OBMUfvI9wI7tw58a7XS9zKlHCCzGWbANNpiZ45OFXMp+TAH4wiTjtJdQ7SETCAPOWR8tdi2hgatHpMVA+fEfF/H/XWneLOyLAAxCc5fzzYkx6sQtwiZto3kHqHlMEe2OxroAK0t4WiobZCfi1ukjt8bcUnHfciGbRHpzuU5+XfhBdt6f/3yI4Of7my7HjG3dmorfiwVdJ9UVrcJsF4IAMxttUHrjS3h1CZG6NAn7463bRX9x/BPVA9LpDYWIX2SxfJhHEp0BK4a7klJ00muFNHeb9r9MIzYLsUKp0DSipodhp/LqT05LwGp2TJKYKtabRdhfyWzYGvGy9YuWVpz1mPmEIfWQdChQswNglC3j4K0oFkX5kQwzOLN4hRZytZG+hG7WGLALB/gbSyW7SyOZFygixFS0FXZbL0PM1F21xn34Y7Y0EfUHzKE/c9bQyT/lnx4HkgZy7eoaAs9h74EFwIq/UnVVyVS8Emc/R25uIqrPYrhIaT9Ek2iX8drrKx3MYgNGKjZggjoig6p0kGwDa60krrHPc/iMbSo9gTUBscw39uFJwRORPoHpK/vf0LP0zIt0fseFLA3phmUfh/uZcyza9SwLeP6g+AtR+X/waek94xoln0DHCgQ0ZNgerEGVvVip39elXaih6cNECIQbtIK55KIp7ktsUp1tWsyW0UodyyQqRbNInmbexyVmMEN6rx4uMGXleq9i6tMqUnGS7RFQaAJOY0lFDvLXR7gTWMg6i5KOgC37yNgxYq37zzrFlgZmLXaa1fZN2xpThCporsgG/A0AnRmUV4/hNDTZJbrvQQKHRhPS28s10l jD0Iag6h wrOCLG29GXfhz5re7ZqrvnlB7QZLJMvTErfCGS31+tLouV3+yg+JkI/jDX39qIVPvrw2JMqL7seVswLBaml0HCfTUZ76rnCuhu1g49/besiA5tNmC2aTiMK8LBHY8eWvCW8tfrQ0VeHCBCKSvcKT4YrSbwAgvc42J3nHEhbjuF8LyW++BWrH0giNgCdpK7ZAqnV3QREPhNQBx/8Cj07DTmhBApOufZ2+1hdReZz4wvFE8WspgBDtnAFAZL38r/+Lz7PXmHfHc4vinSjxye27tJv0pU+WX28jG0eTISct9whM94crWAdeP6O5jpHk9dN1b7NWK6ulSGnxAHreq0bMdWqof1A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000151, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 10:28=E2=80=AFAM Lokesh Gidra wrote: > > vma_assert_locked() is needed to replace mmap_assert_locked() once we > start using per-vma locks in userfaultfd operations. > > In !CONFIG_PER_VMA_LOCK case when mm is locked, it implies that the > given VMA is locked. Yes, makes sense. With per-vma locks used in more places, this makes replacing mmap_assert_locked() with vma_assert_locked() very straight-forward. > > Signed-off-by: Lokesh Gidra Reviewed-by: Suren Baghdasaryan > --- > include/linux/mm.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 3c85634b186c..5ece3ad34ef8 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -781,6 +781,11 @@ static inline struct vm_area_struct *lock_vma_under_= rcu(struct mm_struct *mm, > return NULL; > } > > +static inline void vma_assert_locked(struct vm_area_struct *vma) > +{ > + mmap_assert_locked(vma->vm_mm); > +} > + > static inline void release_fault_lock(struct vm_fault *vmf) > { > mmap_read_unlock(vmf->vma->vm_mm); > -- > 2.43.0.687.g38aa6559b0-goog >