From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CAF2C3ABCC for ; Tue, 13 May 2025 16:27:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA62E6B00C6; Tue, 13 May 2025 12:27:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A554C6B00D2; Tue, 13 May 2025 12:27:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F6FF6B00C8; Tue, 13 May 2025 12:27:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 707766B0083 for ; Tue, 13 May 2025 12:27:09 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 820EFC1139 for ; Tue, 13 May 2025 16:27:09 +0000 (UTC) X-FDA: 83438414178.04.00E3DF0 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf13.hostedemail.com (Postfix) with ESMTP id ABDBE2000B for ; Tue, 13 May 2025 16:27:07 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=uhGqgB8i; spf=pass (imf13.hostedemail.com: domain of surenb@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747153627; a=rsa-sha256; cv=none; b=PCMKU9rgR26jAukcQpVmsUPtacF/ynNqEkrbdf+3lkby3vIeK4hfu0WNEVowwyFRJdQTiq it6T82p2goqfMrHJnDEUIDJ993Ibrff1ngCWJLCbfj1w/36zP05mGkFWgJ1jFWfb4CfihC g/ANa/I88r79Kn7Oz9dO/LcBEi6byeE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=uhGqgB8i; spf=pass (imf13.hostedemail.com: domain of surenb@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747153627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NuQTz0TAR0J0k0d+kCbHLEjYkbcSIL6zDuG3L4sBNQ8=; b=w1NIvrhpqabjGyisiS6OZpZER9Mc7UlqQvLTJSQCFIEYbQsBeel7lOag0mzvpgVm1l3hkb jAyZo9pv383QzEecb71o97s6JVfvz+j1Rw3f09KflgWqX0lmOhd8VyG5oCDRZyJO+ZaaOz SmyOBGZ5wQlee83sA3qW3uYhF2MaOtA= Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-48b7747f881so382571cf.1 for ; Tue, 13 May 2025 09:27:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747153627; x=1747758427; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NuQTz0TAR0J0k0d+kCbHLEjYkbcSIL6zDuG3L4sBNQ8=; b=uhGqgB8igJk+saIKlx/NbrAMc9VcFprvE83NgbrFSeXSqpQEGTGJYHxlJjbSLX8c3x Ydi/8tVTOVLjPlsw+eebC2fI5i8oxnnGvQ96Qhrc781kfem19HXMITRRjI5SO+i1ecBf h3/MCX4q97f/AubpyIc4anDIJ/nOcb0CbwnPhaVjK/s3DeJFhGr6ETlmiqhRlIaCEI3y ygmhmhcB9xfxJagPbXIf0UUjix4NA/LsPNhADxySnzt6tQpCLuSw4Vqn1tS08dktFARY szrTF2t9zrwV0hsGr5bfbD8tsI3BP/bEwnRWlllapXIhPfvhsaKmwpNb8/5Y4vIEoUKu oo8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747153627; x=1747758427; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NuQTz0TAR0J0k0d+kCbHLEjYkbcSIL6zDuG3L4sBNQ8=; b=moXcneqOT/6swTL7c+rNs/yAeS1WsUPFNtzrZQBNf2yvsX4ivoTS33mEJhOuoAVHrI yLx3nv898dgH9lTUfb0ZAmfd/BvAEWSJ4NIfkdsKi5uEthEKgtT/20qk835Fhb3Oe/cX v28WrWy5yQM0dKyaGDWSxEIb1eNHqIKawq3Yu62c2ExpTF5ej2hWC124BDi6YumVbJ0r XKxIaqWTTJLrDdWknIEyoMf3nld0dliQUUdS5r47EphPWxElIE55OFVmvHf5ArJb3pTC d0v5P1yU3PwnbBEHvftWgX5c0kTUOBL0/PCNuHG7nt0TMJAsu60oaTVDIGWqz5RhA18R sU8g== X-Forwarded-Encrypted: i=1; AJvYcCUq4Sj5irmYOePaDCD7tnUbbL6XxDT/hGaybCnC0+fmlfPJzSgACoDEfw1drR0xIzk6eQNm6lI6MQ==@kvack.org X-Gm-Message-State: AOJu0Yx+t5NXr5JD4Dzi23VtyD93RjoxC/mVgh5gaQCoDo3941auIipu eZDSshwwTzxqaXcc6cchu45+aCxOJVaF1927omjnD+GwuAFpcCZE7xSdSG4jysWr1+47fjON01f ZvExH427/ldqKh4a+KBZOg+z0jf4+5Y7N/wR9cPL5 X-Gm-Gg: ASbGncudXe8kuzWbQ6Ido27pwao8g6al0cAvTWy4q+Uaa0QY3pt7DFd2L3X8cDf9hxH ilV3Qf5krjemc7Vlyp6daLUtYGBzOKvVyy9FS57RcpjiYrnX6/Z01YoMpLIbVvkhlfnent/XVUK 2zc16RG8vlf6rLfwNB2ti7E4AoUCCh1kbe06f+dO8aS5FeOXCBEwOMRpKSz70e X-Google-Smtp-Source: AGHT+IGX7Kqbc/9iS6oAhft81hs/6vUWLIjSWsLx/2g2xLA2lhit/YesUfUX8TJwqOvXCB7ryvQgeS0j4JHMcc4+Cdg= X-Received: by 2002:a05:622a:190a:b0:477:1f86:178c with SMTP id d75a77b69052e-494880f4d18mr4807641cf.26.1747153626350; Tue, 13 May 2025 09:27:06 -0700 (PDT) MIME-Version: 1.0 References: <20250416082405.20988-1-zhangtianyang@loongson.cn> <025e3f51-2ab5-bc58-5475-b57103169a82@loongson.cn> <20250422171116.f3928045a13205dc1b9a46ea@linux-foundation.org> <20250510200740.b7de2408e40be7ad5392fed9@linux-foundation.org> In-Reply-To: <20250510200740.b7de2408e40be7ad5392fed9@linux-foundation.org> From: Suren Baghdasaryan Date: Tue, 13 May 2025 09:26:53 -0700 X-Gm-Features: AX0GCFt6vJVoKJRdrVpwo3tcFnZXDX33w-FdV7zGJCqzg0tjXGvAgkiCFXMIJ4E Message-ID: Subject: Re: [PATCH] mm/page_alloc.c: Avoid infinite retries caused by cpuset race To: Andrew Morton Cc: Tianyang Zhang , Harry Yoo , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: ABDBE2000B X-Stat-Signature: 8wz3pxe3kic3cydt6yf8fch3zi66skg3 X-HE-Tag: 1747153627-975193 X-HE-Meta: U2FsdGVkX19P4usWE3Q55XZxvKTFL4djh660Qm+aXEBzyCQZ1VP18PHZVfZfY/x083m6uDILpUxIhVT+SIb/Mzh/268xOfAbkJeR+TChaQbjKcmImJfP2uwLWhlrxSkheM4mc0eINeGff+lVwl/VPcy8I1NndKr0uuZPtASl9yZ5HNyTcfhTJC2SE9SadqN2PpD7SRLZeUBJkDXO5SLhItmTM/S4ebVjySWnPiw9mkgbOC988A/ZJagcrGiqFRjXceptrl2pTkxsHsizkE0w3X/CDn97vbV7qHRPlkTEedorJsYupyXc+fkNCw8Xe2m2UFX0DYgp9jhh8xi+Anmuj9gQJwXr2aaEHiRe17SiWhugYnP++1Ex+bgXKvGDvDn4ZtDxd4o24sM8Ow3h6RE6z9Om3xoXUVfm5efrsmw+WlJRFQMSxhkkp9DkaJKpc89j0i5Wzvu4HtMrS/8fAV3X2huRd4cnd3GHpdU5IFqNA/bwk28RSGLafpVN+NA5JB0+c9XTfVRFYvvbxEkj0Vte7K1WwmZlmVcK5YdhQhxvwVmR2lLyr1qy5GzvvJdbtfYOBPtr4p/jMBBsm7gJy7JiTtKGryVGUuvzoxoDt4LtSnIWfnNS0O4rUKLH6+psJK8aXNs6saV+lzOn2v3SZWF5azgLerJ+RyT2H0h8N4j5N4j2TAWnNE2ZqMFUcSgBhebW0jTzz7kJYsqFCCVYSkSpCH5SQuWWvNRXEJPpV9s5y4rBiLS7ovzD1Mzi15ID+yzNbU7N+ftnILw5CDaK+qRhhLAQ8bJ1vETbrFDpHx3rwof9FGH3fwVgTuu1GL7rBlT2lrBmQrjyWe6V8rBLDHx2/nHwVZXH5jRcA5jsVBRg7T00ypkXJ0gac1U7TzGh6n3Tdvr4iLEjqNCcr/9IUFl5xC+PiPsV+v9mgEfUO+0hHHA+yDSuQ9aBVaM1a3W/BDxFJn6jUAdUFkeQmMA2v4N p/jsr9br cadaL0BthK3EiWSFgVPsr5MlH/7TwvQ9PP8meKNlkgC2l1C+8JKtqS/zTzC+HCzX8iLQBf0faywd2MbeZvAZbfGA3dt4k1aAdWJ+16ZyIVlJqSbVKtEwhQtKTwDjQKxrDIYPEhMgnyg7jdMWxTH5Buq7I6E4RYLuo4uAN+V8Fgq6MVS39w2aLoHghWEf1pCcRa9DxMlwRyLUmXeR7vATjOXqvoLzawozEIR56vOR0v9JTA7VMsj0xSXQ+n3WuxL/3V5DVvp3JxP6PrakOip3bVpi8qcGOdXu+xKcC43m6laanLBhJEvWrgoIm7a0DrO6K4tdV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, May 10, 2025 at 8:07=E2=80=AFPM Andrew Morton wrote: > > On Tue, 22 Apr 2025 17:22:04 -0700 Suren Baghdasaryan = wrote: > > > On Tue, Apr 22, 2025 at 5:11=E2=80=AFPM Andrew Morton wrote: > > > > > > On Tue, 22 Apr 2025 20:10:06 +0800 Tianyang Zhang wrote: > > > > > > > > > > > ... > > > > > > > > >> > > > > >> Simultaneously starting multiple cpuset01 from LTP can quickly > > > > >> reproduce this issue on a multi node server when the maximum > > > > >> memory pressure is reached and the swap is enabled > > > > >> > > > > >> Signed-off-by: Tianyang Zhang > > > > >> --- > > > > > What commit does it fix and should it be backported to -stable? > > > > > > > > > > There's a new 'MEMORY MANAGEMENT - PAGE ALLOCATOR' entry (only in > > > > > Andrew's mm.git repository now). > > > > > > > > > > Let's Cc the page allocator folks here! > > > > > > > > We first identified this issue in 6.6.52-stable , and through root = cause > > > > analysis, > > > > > > > > it appears the problem may have existed for a significant period. > > > > > > > > However It is recommended that the fix should be backported to at l= east > > > > Linux kernel versions after 6.6-stable > > > > > > OK, thanks, > > > > > > This has been in mm-hotfixes-unstable for six days. Hopefully we'll > > > see some review activity soon (please). > > > > I reviewed and provided my feedback but saw neither a reply nor a > > respin with proposed changes. > > OK, thanks. Do you have time to put together a modified version of this? I think the code is fine as is. Would be good to add Fixes: tag but it will require some investigation to find the appropriate patch to reference here.