From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0BE4E95A67 for ; Sun, 8 Oct 2023 22:06:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 510FF6B0199; Sun, 8 Oct 2023 18:06:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C1546B019A; Sun, 8 Oct 2023 18:06:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 389616B019B; Sun, 8 Oct 2023 18:06:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 26AF06B0199 for ; Sun, 8 Oct 2023 18:06:40 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E736AA00EC for ; Sun, 8 Oct 2023 22:06:39 +0000 (UTC) X-FDA: 81323679318.24.F299496 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by imf23.hostedemail.com (Postfix) with ESMTP id 4173F14001E for ; Sun, 8 Oct 2023 22:06:38 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="p7oF/c9r"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of surenb@google.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696802798; a=rsa-sha256; cv=none; b=5ZQvRtcNtzMAoB3RObFz0YmzU82aJdRKx+A3IAyVV9UMXGCgENp2z9koRRBFq3N1yVzF06 8f4xoSEh242n4BDuDeJ2Qvv65KWA6c949kxH6qVr87KvNSd6suk/etHIeYc+2q/QwOOJYX FEaOb4IUaFacymdJrGoeYdL55IzpYRU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="p7oF/c9r"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of surenb@google.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696802798; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JaPzxVU3zxygHfHBRiUWb6H3Fa3vlky3NluQGmCwA4Q=; b=WFvq/za1/uVQO2X7jdlRdpEmC3ELrXxooAPAZYx9SBQsjHmxjCla9TjJKt0T5lbs4lCxkE bmwprjXuVSLeGk/jZJOsqwK5Pl2vT8ogT+Lbmz+F16PG1L37JRXnMJ4onj3qKvchkL8fi2 qPwJNR3T3tqI6q039QpPNLaAexeEp58= Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-579de633419so48284687b3.3 for ; Sun, 08 Oct 2023 15:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696802797; x=1697407597; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JaPzxVU3zxygHfHBRiUWb6H3Fa3vlky3NluQGmCwA4Q=; b=p7oF/c9rFFNwc5d3ue5B7F35yk4OwBrBZzvOc3t+xdb8mQ4580u6ucERKkYl3Gv7WX ljr8v2jNcJiafTKsUcGW5E+cP4GHMywKEN68a/EFf7IJ5cKktNNsdKnoU48S74KOnkn6 +pVcCPiV+Lm5KljcZpt+gGZyns1phhYl/IgV6XiabNOAWQ2XLHRtFZiPVo1OiEhlQ09+ XMCeIPPxz+KD3LZJ6n9RsegLUyEBj+HSu8vb8Ph0jGHiUcDZr50GKYfDNDFVsVh8LkyD iFa2CWbYYs+iYgB84nxvwMVpE5TN2Le4tgWJ0trHzBS+hy9+B5NFqyMpe1lYuymaOVxj gwBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696802797; x=1697407597; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JaPzxVU3zxygHfHBRiUWb6H3Fa3vlky3NluQGmCwA4Q=; b=AodbDpxq8vIyCdjo/YHOX7od4aS/qPDzopBjvVPmu8EMvsWG3WeJrwwjnUdnDLKewt WX6apNNOhYM/MUt/fE/LN4AqWUv6PohOaKtaeWKNzalKO7IMOvqPNcxhKU2eqMspI19P ffmMAAXet7eQLPlmO3StFnNMWmMyGhnq4rQ5mjwrgAcveVOvk13VZT/1ibjQWczDOhpN CBFDT/15zxRn4ZWaQXe1Ku3lU9M+ywZyQcdaXuEnicQueS4onxVULWQLjtaTFBYWmk2t QVRR+ipizyCxKNimOYV1hPrxq5KIlhY+UybvfWlXf65a8cyJmqHQpw9Zs1n5oreVnI2C sMXA== X-Gm-Message-State: AOJu0Yz+VbwLCXzhHDOAdhS2BNkyITHhgx/uOSxNFbTjJzN42m3oD4rD Gv1K5lSEHLQlgcW/TukAFDAOafy+Cg3zD3Qbim4/ZA== X-Google-Smtp-Source: AGHT+IHPucUSyIPmbkHJCRpX6KVpIRtMhKoklZfPPm2AKngqvBEvkIYQEb79lGtlLowDH6lvTOPl1VWkvYxAiRYP6a8= X-Received: by 2002:a81:6d46:0:b0:59b:d7d9:266a with SMTP id i67-20020a816d46000000b0059bd7d9266amr13366142ywc.5.1696802797205; Sun, 08 Oct 2023 15:06:37 -0700 (PDT) MIME-Version: 1.0 References: <20231006195318.4087158-1-willy@infradead.org> <20231006195318.4087158-6-willy@infradead.org> In-Reply-To: <20231006195318.4087158-6-willy@infradead.org> From: Suren Baghdasaryan Date: Sun, 8 Oct 2023 15:06:26 -0700 Message-ID: Subject: Re: [PATCH v2 5/6] mm: Handle read faults under the VMA lock To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4173F14001E X-Stat-Signature: idmd3a319zuiozkesmxfjkhbc51695u7 X-HE-Tag: 1696802798-872647 X-HE-Meta: U2FsdGVkX19s4aagzFCwI3lfxkGA22z4hy6ETvEMszP1bSTexIczFYXkBD6dGfWBbMvbfx6X5Lt8NzAfB7P0hv6TS+vCVv7vgwi+MWKImNmsoOuyVn2u4nTcBMu6YO+SvTYcqTHhDr5j9M0ikBB0lvxG6A1RHV5wyH0CwWFydMHuSUpzDnxXGmx5eEhCMUND2/4NHGtWd7/B/1WYghLuXif/0zfbfirfjZNANeyoqM8zHldJ8vLEDsdBRhhStFrJdOb7TjYHQQlLIhDvM3lXPLEPiTmA5ZphrLPZCtp0mXzzVydmksWZAglmYvQSCYH/vlpvzf/zf2223U29HEzQ3/iNjeBKsLa6qoyixizOp6f7B8eg1OO+AzCkpsaH2jjL4A4JnzRA1cm6rDqKmzO9bVfOOeWa+mLkbfyv3xtS3IlMSpHItV8c6CFd4WAOTQ3ijs9hH4d9akCp3sWJHXrDxWxBmw21rQ79TrS0gzYtJpI3VwQ8heEdcXHpioZeOjzPcQliOg9EWFGGKW9vGNqBR2VpZeIF3pWmh15Jd3smbhFAVliPf0WuG+Vvvh3JlbJ7ushSHDHopKcjeL2ncFqa9iiaFDG3QHxmTHW+HKAK7tBBANlTrMNEfmjM//hE2B5aCRrATl0VsqGQaHeuhOoYmaUzVDVY8KeOuLTnN1kaIqYRxx16ReIYm5HfzzttQyqWx/ULMgVvidCnZckF+9qoEKuY1NUWtEBgS25TcGF3fNALd9rjntKZJjPRw3NjGD5qt0b8AefXn3fGlXGBQxEAStZqNyDA4iw8EVYpQmG98BU5QMizhMq3BeFmhV4BLnrT3JSIlzwif55kfgaw/J0/SCl5lNuqadlztpL+ELlyV+j4kytK0vwGId/9q3CqVuMNjTiPtYY+TbNH5T6Gupic6MzaIE+J2Bx1sMxc3XpMmnJihyC6zeqHf73b6ukN3wtJv5YTua3XSlZMKWuC8Zb z99uan1f 8fpyz+aaDUn+aoobSS5u9GySlHvJryHN13FlfjUHQQ3CSvX5vJQz7l6CcoOyJGlxcs+BTHrvgZoNfs2xgUMau6s9gbLckHimQKd8cSVncdBWgH7s9rN7/1QVJlOYX0tj0DEw+bbkiC+7zgQgCgAMIx+4+kBWn1K9hdxGFPE+qF+SA3Xo03ELACEIGqhAE7vbNGSgl8E7Urj4pe7uXsCyIlHRYPw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000143, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 6, 2023 at 12:53=E2=80=AFPM Matthew Wilcox (Oracle) wrote: > > Most file-backed faults are already handled through ->map_pages(), > but if we need to do I/O we'll come this way. Since filemap_fault() > is now safe to be called under the VMA lock, we can handle these faults > under the VMA lock now. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Suren Baghdasaryan > --- > mm/memory.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 938f481df0ab..e615afd28db2 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4617,10 +4617,9 @@ static vm_fault_t do_read_fault(struct vm_fault *v= mf) > return ret; > } > > - if (vmf->flags & FAULT_FLAG_VMA_LOCK) { > - vma_end_read(vmf->vma); > - return VM_FAULT_RETRY; > - } > + ret =3D vmf_can_call_fault(vmf); > + if (ret) > + return ret; > > ret =3D __do_fault(vmf); > if (unlikely(ret & (VM_FAULT_ERROR | VM_FAULT_NOPAGE | VM_FAULT_R= ETRY))) > -- > 2.40.1 >