Re: [PATCH 1/1] fixup: alloc_tag: mark inaccurate allocation counters in /proc/allocinfo output

[Suren Baghdasaryan <surenb@google.com>]

On Tue, Sep 16, 2025 at 8:50 PM Usama Arif <usamaarif642@gmail.com> wrote:
>
>
>
> On 16/09/2025 17:01, Suren Baghdasaryan wrote:
> > Document new "accurate:no" marker.
> >
> > Fixes: 39d117e04d15 ("alloc_tag: mark inaccurate allocation counters in /proc/allocinfo output")
> > Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Suren Baghdasaryan <surenb@google.com>
> > ---
> > Based on mm-new
> >
> >  Documentation/filesystems/proc.rst | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
> > index 1776a06571c2..17668f82ff1c 100644
> > --- a/Documentation/filesystems/proc.rst
> > +++ b/Documentation/filesystems/proc.rst
> > @@ -1014,6 +1014,14 @@ If file version is 2.0 or higher then each line may contain additional
> >  For example if the counters are not accurate, the line will be appended with
> >  "accurate:no" pair.
> >
> > +Supported markers in v2:
> > +accurate:no
> > +              Absolute values of the counters in this line are not
>
> s/values/value/ maybe? :)> +              accurate because of the failure to allocate storage required

Maybe... English is not my first or second language, so I'm not really sure...

>
> s/storage required/memory/

I'm fine with the proposed changes. Andrew, if you agree with them,
could you please fold them in when you pick up this patch?

>
> > +              to track some of the allocations made at this location.
> > +              Deltas in these counters are accurate, therefore counters
> > +              can be used to track allocation size and count changes.
> > +
>
> >  Example output.
> >
> >  ::
> >
> > base-commit: 199236646ffd82b5a5bcf2bca1579ea06cb0ae74
>