From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00248C4167B for ; Mon, 11 Dec 2023 01:01:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFD9D6B0085; Sun, 10 Dec 2023 20:01:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EAD456B0087; Sun, 10 Dec 2023 20:01:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D74766B0088; Sun, 10 Dec 2023 20:01:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C63006B0085 for ; Sun, 10 Dec 2023 20:01:32 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 848CAC0619 for ; Mon, 11 Dec 2023 01:01:32 +0000 (UTC) X-FDA: 81552734424.11.ADC38A8 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf12.hostedemail.com (Postfix) with ESMTP id B4C4D4001B for ; Mon, 11 Dec 2023 01:01:30 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VZaI94Sj; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702256490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+WQ5Kl/17KRmeDrnv++dZDxabOnVYumyCPRm9UvxCXU=; b=ifvwbmR3aSWXEU3GMWYkYJBV5xGqQX+iT62DGRFK6F6aHQuD5Xzjmo3X/G/UplbXPxgQSK qrgRJLZ3cqdaG36VAbLJmECX1bnvFhd6VOlGxtcswEJ7tyOxjJ7BclKZqsHy9BTQosHdk1 R+beCW70+A+93nT4LyfGXk6RzWZ569c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702256490; a=rsa-sha256; cv=none; b=vDuKhEHoiq77MMjWcAvXvztSeH2oCBj5RTcG2DBDlDJvHF5tD02sw/MxqzfFn1moWYU1+x F86asmM/NkvGqwMd/y/tzv9g/HHhV2YbySkAnOum06TqQvIM81Y/TWvUPuENg3HyhAOMwA KH9VrPH6s+eI4zPT6mWYbJ6gKnSIxXc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VZaI94Sj; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-5d6b9143782so33383037b3.0 for ; Sun, 10 Dec 2023 17:01:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702256490; x=1702861290; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+WQ5Kl/17KRmeDrnv++dZDxabOnVYumyCPRm9UvxCXU=; b=VZaI94Sjp/QSgNS4wkhMDBnSqzNEtWi+JqBfj10lRSNX5dmHgc8nC1orGRAvRur10F cso7ZJLP4NPNEDBlng2NPtG3XgvKI6xRI47H70xWVZygwPitnwA7zssesvZUVRWIj2YC PjdquyMMpNdlQlpxnDXPHHq1yvc8qKjZug8WequPLobHbT0XJjr9XtqpWMpuRDHrYWPi HiYGs1MkqYxtry7BhZ+25Ym75TjDKbWcaHTNeFmbTm/QmU4RYR8G5fr1v0xU65FJd5vj 5mtHTuNuU2hDmFJCEebzrU8z+5sEj9gPFAuXvK6bgM033pTT22c07Ms/7LilCxVru802 u1Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702256490; x=1702861290; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+WQ5Kl/17KRmeDrnv++dZDxabOnVYumyCPRm9UvxCXU=; b=XXxD4JGTRBDK7/KdFW5AqRJRuIAf5jfr736+tYyNBRvY9YbsTIlcMt38gMaWdeBa7d 5str+bN1E97H1x16BYeEGeB7bZ6pCRRSg/2ApQ9eARjDKV9qo5oWGbcgepRFYHsu0Mae liZJS1aOpjAZMgFhowV7Na369qJ147dgDZz0K+PDuIz8slP5atImHd6zsFHTfOfILPlk nSnPVDNq36zO/EigmbXkFEuLDWbn2ILUdzoCy471pojZTWH5uP0c737VYOKzjwS0b3OA asyoD9/VaR3GbSFGDpUL640DvSXGPWTd07Mpw/boC+kHwh08TrAQo8FebrNl1cGkWXkp adpg== X-Gm-Message-State: AOJu0YzQT4fqyXZU3MKdtbGfDuJ0uDU8PpY/aUHB165cf3rziTOAWyf6 iGHgwlfX5T6qSHG+Q+Il81QfH4IFdsF9wKIyiRzlWQ== X-Google-Smtp-Source: AGHT+IEM06+RRlE/zePs7rbDQZUekYGXrzSDuMym2bE5wBVkl63IhZGe5nggAE5d9SV6vVL4ZhYg6AITCoRBwCXDwDI= X-Received: by 2002:a0d:f9c6:0:b0:5d7:1940:7d92 with SMTP id j189-20020a0df9c6000000b005d719407d92mr2245546ywf.105.1702256489515; Sun, 10 Dec 2023 17:01:29 -0800 (PST) MIME-Version: 1.0 References: <20231206103702.3873743-1-surenb@google.com> <20231206103702.3873743-6-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Sun, 10 Dec 2023 17:01:18 -0800 Message-ID: Subject: Re: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test To: Mark Brown Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, peterx@redhat.com, david@redhat.com, ryan.roberts@arm.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 9cybj4qkqk8ookugouk7bqhsufurast4 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B4C4D4001B X-Rspam-User: X-HE-Tag: 1702256490-92228 X-HE-Meta: U2FsdGVkX1+8YVsff0IRQD3mO7M8YKInHStDVfzhc1qhLxfhxEkJFNqLxC7gPOVsauYodJDmk4SKNP/CNBsdDaeEFT19p2XRiw51Zrdu01cDe83OokuASQ7Aj2fHj1gspwZynnhxQA5+DuKG331XCfghFjhsxifFfAhmavsyuZyuKGWUMMOWkKL+H4qOqRwIah5JpwqEX7N6R/Dlzgvvnf3oefY8T0Ud87PJ0oJERIRIzs+htMikXCM2b/2e/4wHxGAnZafRrZO/18Ed+nhYy2bu6qijtHecwfjHEEblbwXQLkH4IxRbXpNz5A3GwfiIFC//e5pNZqpt5JPe9jJKpXkbTMdtT8dxUXPzH0y+eiFJUAnloaGq8bnyzUZqfLAX3dGuMe1YW2vkXsDSyGozi28/5nD8Pr+xHhdW3WWk2elN0ItUXy7ukKxWesN6LkOBvXZZMvSyXTNXGfWwK7I0mLLWuZCqVKyfHVIi+dZrlq+7vvGDrz3jS5VKd/mcYjFLZB129RMCBDLkL2CAQxaMRzM4FZKf0lyITa6V0UbNC3sBvWwLDlmqfuilEchMxe5mVOKlbRm7jv5sJsif09AA3Spq8wVx9EUP8wSkZm/TZiCC0y2+2BYOHiIgKQ/ilXOlVpKDT2NYoCDEh05QVOgnafxqALMtx6AYGIEaofLrZvHjIiU0aFI7Z1vxUohNw3ktMGI9yq6un/zlMlrHz9gFTfWLsbYgMDMVV5DLme1upIO9nCGbYf1mpPZXRy/0GD5eNuOxLjJh+y0lpYRGYwNlXL7XQxccliAVHl2U0vde/gwP90ntJv2c2fY8xxfWLt6TxFVqxaOtivBkiZlTaFa6Av8sQaBLQLdNz6HGNFcKg4nuV4UyAYroDVIve+1TqPx/kFWRgZ5EcFqxFMgVCUzsQ9n1dUxShq2TXgUrpioEGVMxiSQyYNlsoSkPcUlJGZ2K/NC3+sLhnS4Ay9ihh0t 6g6/GfCs KuqdbdwqiXmjkzDbXln8PF0ZfFkApFAp7kfKPjks48aJu3lbVf/uChu8bSPJDPwL78NIiL7uVEKXUm5fh2eBacjKS9rwfZjqUgcZnT49jw2ncKyWDSy4RFXboKLF5X9lPOGGcNDwSxmdDuk0jGfguG5x7zwT633QMs9q0ZS9YhQHFydGphLY+QPch8BDAOMmYFkZUMUBWsYtQkoIyFtWfNl0DIV4Sdwe0kCovAsbLxDiOyJcpdH8K7uXUMElVLDrCW83ghVExoBEx/Ph+910KA/9pjgGyb2hg3XCylTX01rQwS6JYH48nQnBQymjDFttpoB2hpE14e/Wa94K4W9obdfQVehC5jeSMgAHKXuFjDuvibVuyBlY5BtSgsHXvm8jH8GABOKNK6iFgQoBFPfNwbObj1A0NpKy4wtNI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Dec 10, 2023 at 6:26=E2=80=AFAM Mark Brown wro= te: > > On Wed, Dec 06, 2023 at 02:36:59AM -0800, Suren Baghdasaryan wrote: > > Add tests for new UFFDIO_MOVE ioctl which uses uffd to move source > > into destination buffer while checking the contents of both after > > the move. After the operation the content of the destination buffer > > should match the original source buffer's content while the source > > buffer should be zeroed. Separate tests are designed for PMD aligned an= d > > unaligned cases because they utilize different code paths in the kernel= . > > > > Signed-off-by: Suren Baghdasaryan > > --- > > tools/testing/selftests/mm/uffd-common.c | 24 +++ > > tools/testing/selftests/mm/uffd-common.h | 1 + > > tools/testing/selftests/mm/uffd-unit-tests.c | 189 +++++++++++++++++++ > > 3 files changed, 214 insertions(+) > > This breaks the build in at least some configurations with separate > output directories like those used by KernelCI: > > make KBUILD_BUILD_USER=3DKernelCI FORMAT=3D.xz ARCH=3Darm64 HOSTCC=3Dgcc = CROSS_COMPILE=3Daarch64-linux-gnu- CROSS_COMPILE_COMPAT=3Darm-linux-gnueabi= hf- CC=3D"ccache aarch64-linux-gnu-gcc" O=3D/tmp/kci/linux/build -C/tmp/kci= /linux -j10 kselftest-gen_tar > > (full logs for both arm64 and x86_64 at): > > https://storage.kernelci.org/next/master/next-20231208/arm64/defconfig= /gcc-10/logs/kselftest.log > https://storage.kernelci.org/next/master/next-20231208/x86_64/x86_64_d= efconfig/clang-17/logs/kselftest.log > > or tuxmake: > > make --silent --keep-going --jobs=3D16 O=3D/home/broonie/.cache/tuxmake/b= uilds/25/build INSTALL_PATH=3D/home/broonie/.cache/tuxmake/builds/25/build/= kselftest_install ARCH=3Darm64 CROSS_COMPILE=3Daarch64-linux-gnu- CROSS_COM= PILE_COMPAT=3Darm-linux-gnueabihf- kselftest-install > > The specific failure: > > aarch64-linux-gnu-gcc -Wall -I /tmp/kci/linux/tools/testing/selftests/../= ../.. -isystem /tmp/kci/linux/build/usr/include uffd-stress.c vm_util.= c uffd-common.c -lrt -lpthread -lm -o /tmp/kci/linux/build/kselftest/mm/uff= d-stress > uffd-common.c: In function =E2=80=98move_page=E2=80=99: > uffd-common.c:636:21: error: storage size of =E2=80=98uffdio_move=E2=80= =99 isn=E2=80=99t known > 636 | struct uffdio_move uffdio_move; > | ^~~~~~~~~~~ > uffd-common.c:643:21: error: =E2=80=98UFFDIO_MOVE_MODE_ALLOW_SRC_HOLES=E2= =80=99 undeclared (first use in this function) > 643 | uffdio_move.mode =3D UFFDIO_MOVE_MODE_ALLOW_SRC_HOLES; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > uffd-common.c:643:21: note: each undeclared identifier is reported only o= nce for each function it appears in > uffd-common.c:645:17: error: =E2=80=98UFFDIO_MOVE=E2=80=99 undeclared (fi= rst use in this function); did you mean =E2=80=98UFFDIO_COPY=E2=80=99? > 645 | if (ioctl(ufd, UFFDIO_MOVE, &uffdio_move)) { > | ^~~~~~~~~~~ > | UFFDIO_COPY > uffd-common.c:636:21: warning: unused variable =E2=80=98uffdio_move=E2=80= =99 [-Wunused-variable] > 636 | struct uffdio_move uffdio_move; > | ^~~~~~~~~~~ Thanks for reporting! I'll try that later today. Just to clarify, are you using mm-unstable and if so, has it been rebased since Friday? There was an update to this patchset in mm-unstable which Andrew merged on Friday and the failure does look like something that would happen with the previous version.