From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A72C8C48260 for ; Fri, 16 Feb 2024 08:56:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39F418D0007; Fri, 16 Feb 2024 03:56:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 327DB8D0001; Fri, 16 Feb 2024 03:56:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EEE48D0007; Fri, 16 Feb 2024 03:56:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0D5F48D0001 for ; Fri, 16 Feb 2024 03:56:12 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D1E72A0374 for ; Fri, 16 Feb 2024 08:56:11 +0000 (UTC) X-FDA: 81797060142.27.9BD7098 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf27.hostedemail.com (Postfix) with ESMTP id 17A4340014 for ; Fri, 16 Feb 2024 08:56:09 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=PUf3ue+5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708073770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w/bNm1+I792YdZVlTWr+H7KQ1f6kurFtOITMvEEBO/k=; b=U4LR8pyoP/kN8dTmvCXTmK+PaYhfPNoNxFG6IH1+TvFwbyqJH5KHA/dWpFAK5dLeARPP4h 448I4Z7UCbl24SK7h8sznV7IJtC0gb91rMN8o/kPB0WCPWhSE+uWtwcWhggKQRpjKMSCK+ jB9efIwXYWEl5G0mAorSrs8Ui1PJ9Hw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=PUf3ue+5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708073770; a=rsa-sha256; cv=none; b=CZWImVXGbYWWtmAg/y4hn5ZSRAfLcHnZqiQuVtRV/VZbK7FCwoIMdm6fnYN0qjLn60ouwd EtV2l8CfTdH/AWXsYbEWknLM+CEXLZ5ebCrD2OxE8Z/4NDVSTdjwmRp5XwG6gGKsSvVpqZ cqaBI+RJEOeLgInDhp5o82fi0LC4/7o= Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-607e364c985so12966877b3.1 for ; Fri, 16 Feb 2024 00:56:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708073769; x=1708678569; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=w/bNm1+I792YdZVlTWr+H7KQ1f6kurFtOITMvEEBO/k=; b=PUf3ue+5/Xge95Pvhnt8zf9v1WtZWooHqgWNt0qCIiB6/vQTVrs2906ks7zgz0wdQq DiUrmw0WBgt/idj/5KnJETLXs+BtRJR5kDmTpIJMtOqiWpLKMOpWercMtTehfYvFmdHJ v6Tl1x8hTKhU9B06c7E9J293e6RkSgKmZ5snoSgPQaA3JKRya2GjbbvVUEahH8pctarb XoVPuoXCBUErGuPrB46Xq+tuClmlzMuVTV0X3rkKJxsmQpRR5+N140ewvNkpXt5MBv7t D6tkAme7F/FHvg/KctczrW+oozlZazHnxDmh4OmkTLiCqzRGoGXd5lLLOf6HCbdxVMqG onBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708073769; x=1708678569; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w/bNm1+I792YdZVlTWr+H7KQ1f6kurFtOITMvEEBO/k=; b=Fs6Jfkd26+S1YLM5FnCVy2c3/dinGhlV/BfiMAbckxsWF49NHLKbsUy+22QnuwPJWJ oP3iJEzUIJDPGF4BtMChWohPCYJP9Jcwtz7K0Xep8Fr7jJ1wleyYgOGZVfNZB3M1B1Oc 2rT1xNJHj4B8fdjEpCfftzgJRqPUoGgvYhVMa0MsfacvG1ytRoyBl/gEmYPUadvQEVKX T0ZLYvgMZdQ3cNh677rsFMvJR7eeFvSfFJ374fJi8+yEO5FPiKOQQweOp84rSiYGS0uu Iy4ziTA5w6Ohnr+Og3H3X4dNYEH/1JG540IbcFePSR5Pl7VvWzVVTHiTf5YdzlhGwa0+ 9qSQ== X-Forwarded-Encrypted: i=1; AJvYcCU5d69M00xieLe2SvFcYOlva/21VnhUloG94VjyX1Bowxc1CR9ytboC8KMdWki2Puv4rBeEipfXm+LqTCjPaEVSDC0= X-Gm-Message-State: AOJu0Yy8BuNWDZ5Y8pRnqSTrsH0dZIEtgOHZwxNFyZJbkcemLCpjAT8t HRWdLzdPcwdFgWdF4pVOx/goPMkQNPZ2BHptvNJXG1CMUfVha8ywHKZZXu/LVJLFZVa67jOpd7m SU9hxhTypl0YOxYhfoHGMLb7J/OxAyKpXwbdk X-Google-Smtp-Source: AGHT+IFw3ocFlZSouw+paS1hIeBQ1jvyrkD/y9wwPSet8TNkGfntAT9zTk1byuyak5s5oUNAVQdQpoe3oTLJW/QgCY8= X-Received: by 2002:a0d:e606:0:b0:607:9d64:d68d with SMTP id p6-20020a0de606000000b006079d64d68dmr3931990ywe.11.1708073768807; Fri, 16 Feb 2024 00:56:08 -0800 (PST) MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-14-surenb@google.com> <202402121433.5CC66F34B@keescook> <20240213222859.GE6184@frogsfrogsfrogs> <202402131436.2CA91AE@keescook> In-Reply-To: From: Suren Baghdasaryan Date: Fri, 16 Feb 2024 00:55:55 -0800 Message-ID: Subject: Re: [PATCH v3 13/35] lib: add allocation tagging support for memory allocation profiling To: Vlastimil Babka Cc: Kees Cook , "Darrick J. Wong" , akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 17A4340014 X-Stat-Signature: sner74se31ozhnkm1kts7y6119yqjqmf X-HE-Tag: 1708073769-82243 X-HE-Meta: U2FsdGVkX18qNrqhGIeUiB+muNol7m9KY8TFXqoMAScaga51vIodEkL2i7S9goxK5HyVrO7Af9BL/y8N56GalGNBvUcaohjzVixIrrvU+YOa3jAas3qK7qo+KWDb/yainVjYFHn+YMacwvrYzJwyLnMNxHLntBKqm8hMw2V7kbpHOuWMFqi3hjUAVh+8OOPzU0wnmeMUxyZtIfKkct+NTJm0tVD5Ky7gV/knCDL3sLAhN/P5xv4JsWWYdMSDHeNZrHlO+Z3sdPrHfch+wbz+wTxf0PbJd09kwF8L8IhfQ10HoN0sAzCYBEJCUrQlk1w1Y82bCFWXCi0R+oGIJ2T9gjAy5ntsxkQ9ZWW5IWjD3v6QNeZqDWTq9jpeI/b4yFnrhLkF4/HbM76hp/5+Lk3krfvurnzLg3E7dSV2kK2ydTr6bo1lxhZm80y1xllwglE58ZJZouhgO77Z2/yEZH2GGUGW3SSOKt6OYHZvZRPB+fiN2ZK1+m4+4HpkVNwc5fq4xQdT3Bg3xBhp89ZDzCL1A4Y2m+z4V4rmdseCYOSTZAOxarFIOOSARIaRnAYbBr1fsJJCtGKVzeD/2DP257ko3etz7KNzkBSTJCwh+eEZQ5cKpx9fjXgvtdJC4hxe17uZnL9QZAyqZhXdzuKYfazlU8tJSXaiRzqaGQgtj+vIbY5WAjGHQkPpV3qADpcIX6mUEGPMUrvYheGI+6sLtbtfAfR+ZPfKBhjxiBZjf5uaC1Plmsf9aR9W13StMfajWmHNGSXxWG9HF5LKMZxw6oxeQtg8glwvJVNjX24o1EFMsTqyg1vOlUjLyXjWV9btKVQeSM4Hfmm+fpmRc5XaayS46W1mpOMi3PDsfxQh1CBfYr+13TTKTjEpDr07pizTFZwwIbVLBzG+89Rv13NxT4odx91igRCoAGKVz8hB8s1e0fSItQIDkA/4fjcixGFcM/tWFN+arK0RiUq8/iiFOgv e3VNgq8f kT+xA/lxVqyVrs4yQfUNVRFx2UEXYohU2gbdYWcFgeT6KxeHMyG9WdtoFwWiJW6D2C9oyB5FE8aVcyX2YnJWv/i5Y65DwacMUN11zBjFSxoJcmCiCa4wCaTuSIkLXogFRH+nI5fRep5Z4NbNX1Ve5jDacyFu+j8oNesu5W5UqQoWYwdL+23VLPGpeQvxtlwyAbKav73khKWfcsGiWrg3fEcmJ+PsSPJ9q6iWc4vWtopE0TlNgvIIMBmbLeIs/t4WvdAlTeE1Hxe4o/7yiDWcavTFVTTRBU1r8+pKw+qTB+5a23PELlh6s5bZlpmEjQGD5s9vcsPiH8efRI0sxtn3me+HmxlMXQXzhz4oiOs7Y/AwE/D2P/SJHeRJRq/xKmaV5Zt7ZgnxTnB6waCw2TwO4qZy/zHFmOwtN44n3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 12:50=E2=80=AFAM Vlastimil Babka w= rote: > > On 2/13/24 23:38, Kees Cook wrote: > > On Tue, Feb 13, 2024 at 02:35:29PM -0800, Suren Baghdasaryan wrote: > >> On Tue, Feb 13, 2024 at 2:29=E2=80=AFPM Darrick J. Wong wrote: > >> > > >> > On Mon, Feb 12, 2024 at 05:01:19PM -0800, Suren Baghdasaryan wrote: > >> > > On Mon, Feb 12, 2024 at 2:40=E2=80=AFPM Kees Cook wrote: > >> > > > > >> > > > On Mon, Feb 12, 2024 at 01:38:59PM -0800, Suren Baghdasaryan wro= te: > >> > > > > Introduce CONFIG_MEM_ALLOC_PROFILING which provides definition= s to easily > >> > > > > instrument memory allocators. It registers an "alloc_tags" cod= etag type > >> > > > > with /proc/allocinfo interface to output allocation tag inform= ation when > >> > > > > >> > > > Please don't add anything new to the top-level /proc directory. = This > >> > > > should likely live in /sys. > >> > > > >> > > Ack. I'll find a more appropriate place for it then. > >> > > It just seemed like such generic information which would belong ne= xt > >> > > to meminfo/zoneinfo and such... > >> > > >> > Save yourself a cycle of "rework the whole fs interface only to have > >> > someone else tell you no" and put it in debugfs, not sysfs. Wrangli= ng > >> > with debugfs is easier than all the macro-happy sysfs stuff; you don= 't > >> > have to integrate with the "device" model; and there is no 'one valu= e > >> > per file' rule. > >> > >> Thanks for the input. This file used to be in debugfs but reviewers > >> felt it belonged in /proc if it's to be used in production > >> environments. Some distros (like Android) disable debugfs in > >> production. > > > > FWIW, I agree debugfs is not right. If others feel it's right in /proc, > > I certainly won't NAK -- it's just been that we've traditionally been > > trying to avoid continuing to pollute the top-level /proc and instead > > associate new things with something in /sys. > > Sysfs is really a "one value per file" thing though. /proc might be ok fo= r a > single overview file. I'm preparing v4 and will keep the file it under /proc for now unless there are strong objections.