From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4F59E7AD77 for ; Tue, 3 Oct 2023 16:58:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7454A6B0253; Tue, 3 Oct 2023 12:58:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F52F6B0254; Tue, 3 Oct 2023 12:58:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 548796B0255; Tue, 3 Oct 2023 12:58:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4493E6B0253 for ; Tue, 3 Oct 2023 12:58:06 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1FDA4403D5 for ; Tue, 3 Oct 2023 16:58:06 +0000 (UTC) X-FDA: 81304757772.13.53DAA0A Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by imf10.hostedemail.com (Postfix) with ESMTP id 57295C0026 for ; Tue, 3 Oct 2023 16:58:04 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XavOhT8X; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of surenb@google.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696352284; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fZvT8ncjg0ZRyDoQnM/j59uk5ZJ4wEfWtKw7l31+bQY=; b=5eZrH9On6J5BcmSjDFyEHBuj+74D/bydf5ZG9zwLwttRrdk84irlWtHb9N/KuRKwmWTufM 8lwMDJWtaWYnNY2T7wwml1PtyfTDhBMQdRaFoTlFC9IYVU7X08lhAk8b/LK53hKgSMAlMr ynU+q/PGIYIGPaPmDwjPNhrHXECBM8M= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XavOhT8X; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of surenb@google.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696352284; a=rsa-sha256; cv=none; b=fphpBxxkfX2Rexa5hTA8HV7RIIiE2QukTEeZ4rYudcZ5oBamHlV5bGsC6eIGoit5BQMtc1 Sy9mB38t5IE7ECDyA2mrgoQVF1iqQAi8kiicqB9OmK5RrYZzrWWAZMWhZcQpL1xivaa8kt lmTZNj4sc//bnRSTb0rgpxxR8nk7d4Y= Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-59bebd5bdadso14206377b3.0 for ; Tue, 03 Oct 2023 09:58:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696352283; x=1696957083; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fZvT8ncjg0ZRyDoQnM/j59uk5ZJ4wEfWtKw7l31+bQY=; b=XavOhT8Xn34PSsxO7lHbKJCiYdFA+CBMIgkrMhKE1i6y7sy2QLYmpVCuI5F+tVcOjP j6KavUlDwoHkMsixiCeQwYGELrafuFRYhbVqcn9dBwdgaeaYNPU4Jb4VrqC9E0G17J+u nCRn0Sw09Ay7VFp5Za3TqXg/nQzmmSnqq3XpAv5SERl7EMAO+j2ARozjM2hP1ndyfHIx jkghlJTt28jJysHgHov/KwXsUr67+17jkpy/5OYwBWrL/8SE9U307P5aRxG17erlWiXw l95ocJdqCqScrMJL5NxzPMJEXv+YCm9XF2SgJiso9TzkJxddKdPfM8ZMNnTBWn5HU2Q9 E7NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696352283; x=1696957083; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fZvT8ncjg0ZRyDoQnM/j59uk5ZJ4wEfWtKw7l31+bQY=; b=oC1U6yhmPqmpkPrOwaUhPREjMWkJm1iacyWK/LfnUuifcI2/IvPsgJXdMk1Wp8wNc+ ihMXkzl7F4Ub36pTD9tW0YHFxsrtiWXTWY1opDx9A5ks73lHv/6rAWUgDw5eDB0dNNDz iVAyflG4uLTkiFFqgx4ucA89fI7DZCmXnKubbW9oawC+dhj96nA0VeBsmSo1NHXB+1Gn ZHU62FpzX6DqMfXOuPRSsbFDRp0miNkCueSUAYSg+Zbrwhk9R1Vlqzuc1oXiiMwlFk+C ONUjPC9vYZpDvDLFpmB/mEJzYbxQCg6tzhE4uhv9JSfszzoEiiWpxtXXUuu+IxjPIygw IbTA== X-Gm-Message-State: AOJu0YwxS3zHA4WbofjUnE+HisoGLIr+eaPXC2AXH5onH1T3ZDS3kY/z cOzgxzHWLgfjFvzPeCbt0V6m6pxnhYStSMcAKVDkbw== X-Google-Smtp-Source: AGHT+IHlpMyozoEdc5iDClc28l5sTlqhMCX7P6ooVhNJ5m2DvOLWzBtI6WW9y0ov4pbtTIBiUIT6U6R5wVCkH6wsrfQ= X-Received: by 2002:a0d:d54f:0:b0:5a1:f0f8:4280 with SMTP id x76-20020a0dd54f000000b005a1f0f84280mr218666ywd.22.1696352283288; Tue, 03 Oct 2023 09:58:03 -0700 (PDT) MIME-Version: 1.0 References: <20231002142949.235104-1-david@redhat.com> <20231002142949.235104-3-david@redhat.com> In-Reply-To: <20231002142949.235104-3-david@redhat.com> From: Suren Baghdasaryan Date: Tue, 3 Oct 2023 09:57:50 -0700 Message-ID: Subject: Re: [PATCH v1 2/3] mm/rmap: convert page_move_anon_rmap() to folio_move_anon_rmap() To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Mike Kravetz , Muchun Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 57295C0026 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: tz9kcbwid1f5eujt6ykg1aoaqwi5ugj6 X-HE-Tag: 1696352284-761078 X-HE-Meta: U2FsdGVkX18bNTk1twHw9w1aIKwE5SWYchVHUNdCu+rmdR+NvdEHz6sQZoaE2abreQmbpYbQW0gn4JVj+z4nQhxxk5okNqmryKxM1Dcc+g+qD6/WoTB7Yt023dk6QWKEDGj0r+0tTnUs3hYxmwGw80eXE9PBfpCFJI1MeTtzk8LndZhcNYlfrU/RADUrec7QlZivUtElTndFkel/J6aS6gFMbWCWq1nTKRbbNlhn5lz+Ww1mnE0T0mrEnr9hGQ4V+FVNXfa33HgTvpFU6wr5lFnfaCaHdtSPVBhyKowPnf57V3Y3YQnAa3b8fqDNnDBCbtY4ZTzRn/N9BL3labhCIttavpMfPctLI/cpFocEPTR1hkXKvS1MI4XkpUNxU+O8dvenzBjUeRH9Z/tHkNJ03ufbJTnV6wWKxh13K5U4m13uA6rb/sW1vxs7B11+fraidweUqLWQe27FyyDAdi3kOrQCCzK+rD+TAUNofOlIVmmVc3buIRWTCyito8usWgLsbXdqSZWw3UM48Td99TwHPeyuAIoyxcXJ6ewyLJUs0LSHqM5gjYJrRiswiHtaaAHQi/4uc/l/uFokizRe7CYPYUAPGSlLnll5B5x5LX9jysz4WqViqF2FzmM0jcnty5eWUYMpCSeSJqQOSG/OyqV7my//zpmfFaRzYgNrEXGffnKWZ9purx8PsNc6GIDtNs4MABe4Rj7b+wqG5Hv+PWRXqHiaJaCSDnmk/xWwbK+LlDoeCPnxRgVXdkG8UB+Wq6d8O0faOnGdnJefM1XvyIfOmFs8mI7rAYpglu9rXg3GwsD9UuGvtST7QhJVLKBm98bkHXykl6UgkX0ME7B46cyOs7CuGO1Gjy7noQVU1TsIWFrQ/LxBdwBxdE/JcY21eU1mzyYWYAgc8/g/TUzCSV+CIr+RHGuWzf9wHMiAq79xuyBHOjU2kfSHHLSwKQm/5b4WZLPiwkc/C2z82p6Besl 4jGOHi5O N2WIgNJdI/sLqswIhQc4i1kkhy8fnig9EOvd7glrVvI/RRR79MJytWmxp7YYnwtDDb/2S/gnVxo0tbQHa8CVZK4UQ193hJd+bLEGqrxAmPuf1Ema+OHR2crXzdolWmKLP06gxJKGPt80ApygAHNioMfMTQrmKS1YA3wbYNISs9zwLOQS+Nd2/c0FH42tT7IWDsKLWKBZtIZU/TcZlPyRafSWtbbvO05SSBSC28FYea/WuU4tR8t3Eccu9p0pbXWErfYBR8p8gcE9xFBrXNhB24HTqjQ51qsnnV2NVCe9sAVclj0OV7qAtomq/8Iy7DzM7JGlW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 2, 2023 at 7:29=E2=80=AFAM David Hildenbrand = wrote: > > Let's convert it to consume a folio. > > Signed-off-by: David Hildenbrand Thanks! Reviewed-by: Suren Baghdasaryan > --- > include/linux/rmap.h | 2 +- > mm/huge_memory.c | 2 +- > mm/hugetlb.c | 2 +- > mm/memory.c | 2 +- > mm/rmap.c | 16 +++++++--------- > 5 files changed, 11 insertions(+), 13 deletions(-) > > diff --git a/include/linux/rmap.h b/include/linux/rmap.h > index 064b432a4033..8034eda972e5 100644 > --- a/include/linux/rmap.h > +++ b/include/linux/rmap.h > @@ -194,7 +194,7 @@ typedef int __bitwise rmap_t; > /* > * rmap interfaces called when adding or removing pte of page > */ > -void page_move_anon_rmap(struct page *, struct vm_area_struct *); > +void folio_move_anon_rmap(struct folio *, struct vm_area_struct *); > void page_add_anon_rmap(struct page *, struct vm_area_struct *, > unsigned long address, rmap_t flags); > void page_add_new_anon_rmap(struct page *, struct vm_area_struct *, > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 01d0d65ece13..08245226ccb8 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1505,7 +1505,7 @@ vm_fault_t do_huge_pmd_wp_page(struct vm_fault *vmf= ) > if (folio_ref_count(folio) =3D=3D 1) { > pmd_t entry; > > - page_move_anon_rmap(page, vma); > + folio_move_anon_rmap(folio, vma); > SetPageAnonExclusive(page); > folio_unlock(folio); > reuse: > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 24591fc145ff..e52c6048e74f 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -5461,7 +5461,7 @@ static vm_fault_t hugetlb_wp(struct mm_struct *mm, = struct vm_area_struct *vma, > */ > if (folio_mapcount(old_folio) =3D=3D 1 && folio_test_anon(old_fol= io)) { > if (!PageAnonExclusive(&old_folio->page)) { > - page_move_anon_rmap(&old_folio->page, vma); > + folio_move_anon_rmap(old_folio, vma); > SetPageAnonExclusive(&old_folio->page); > } > if (likely(!unshare)) > diff --git a/mm/memory.c b/mm/memory.c > index 9de231c92769..1f0e3317cbdd 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -3483,7 +3483,7 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf) > * and the folio is locked, it's dark out, and we're wear= ing > * sunglasses. Hit it. > */ > - page_move_anon_rmap(vmf->page, vma); > + folio_move_anon_rmap(folio, vma); > SetPageAnonExclusive(vmf->page); > folio_unlock(folio); > reuse: > diff --git a/mm/rmap.c b/mm/rmap.c > index 854ccbd66954..37f05f33559b 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1141,19 +1141,17 @@ int folio_total_mapcount(struct folio *folio) > } > > /** > - * page_move_anon_rmap - move a page to our anon_vma > - * @page: the page to move to our anon_vma > - * @vma: the vma the page belongs to > + * folio_move_anon_rmap - move a folio to our anon_vma > + * @page: The folio to move to our anon_vma > + * @vma: The vma the folio belongs to > * > - * When a page belongs exclusively to one process after a COW event, > - * that page can be moved into the anon_vma that belongs to just that > - * process, so the rmap code will not search the parent or sibling > - * processes. > + * When a folio belongs exclusively to one process after a COW event, > + * that folio can be moved into the anon_vma that belongs to just that > + * process, so the rmap code will not search the parent or sibling proce= sses. > */ > -void page_move_anon_rmap(struct page *page, struct vm_area_struct *vma) > +void folio_move_anon_rmap(struct folio *folio, struct vm_area_struct *vm= a) > { > void *anon_vma =3D vma->anon_vma; > - struct folio *folio =3D page_folio(page); > > VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio); > VM_BUG_ON_VMA(!anon_vma, vma); > -- > 2.41.0 >