From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C97B9C83F2E for ; Thu, 29 Aug 2024 15:03:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F9DE6B0085; Thu, 29 Aug 2024 11:03:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A9DB6B0088; Thu, 29 Aug 2024 11:03:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 471416B0089; Thu, 29 Aug 2024 11:03:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 27F216B0085 for ; Thu, 29 Aug 2024 11:03:09 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8AC2B160FB6 for ; Thu, 29 Aug 2024 15:03:08 +0000 (UTC) X-FDA: 82505600856.14.A9F9153 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf27.hostedemail.com (Postfix) with ESMTP id 314064014A for ; Thu, 29 Aug 2024 15:02:30 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DMqtJFf9; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724943663; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q8Xok/aj4CcH+x0fW9fszJu1Uo+wA+cbGvy4Plgbunk=; b=cfwdA4N0yojRT7fMtHieLdwHYX0OCQpt5/iDdfNl86ZEiy9P2ChCNs8qjjFEnoUZ88MbBW 1oBV0RNEnOzxFLEJAmmJj+jP9Bo0b+OsYrOxOKyH1HXh4LqLEEUjREaxj2CDVVaRhKkuGN IZT3p4BzD4I+QHTC8CZDjCAavaHGaX8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724943663; a=rsa-sha256; cv=none; b=SZxK3KLendakV+S5iTbUlYIlOXphlUsy92O/NuQTvQfcdrXieGaoTY9jug4Qo6UcRxv2NR DO7ra+auaugFlXtzhrTcSkaJZNVsnI1q64nru1F+2/6EQqSrbT77UlpmGUX8EvYIMzVchV lf07aIgtveky9xJqvtldR3+7Xz14XrM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DMqtJFf9; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-20353e5de9cso229225ad.0 for ; Thu, 29 Aug 2024 08:02:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724943749; x=1725548549; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Q8Xok/aj4CcH+x0fW9fszJu1Uo+wA+cbGvy4Plgbunk=; b=DMqtJFf9MU3ITZ5d/fJNsuRPU+pTyjLrJkY6qp61ia8piieC90RHI9PIkJmq/Ju/HG wFyzaNZHgimF29BhKlvGMuY5OcN1cQ7O5DeYBI1EGEqMYVAunQcRULSgSYAxmw1mt5dU HKA/M+6abuVtlr9cNbfdS+mnt5u7mzuAVio2qy61Trs6tcN83usgIFBMRy7kCgmQM+x6 ucpnBemOUpCcLpEYuClZVXzKe6wcJOrp+8dpPxCtnc7I0+NW1pWqK2siKicY8z9nZgHQ eBRWlbtL2l2uQ8R7paZkUPOnNTEk4EwdbXUzo5DK+TtoBwo3lSzl1PMyjaHz5/fmcCav DNpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724943749; x=1725548549; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q8Xok/aj4CcH+x0fW9fszJu1Uo+wA+cbGvy4Plgbunk=; b=QOyTWSPqv2FwZZEgVVB24VgQ3AkXE+NUJraowQ+pUXev99KAzo7P8fCizY3ePqq3ZW BXB01HYGj8d0YxG/oLQdevJ6gwyw1qEo6h3Jiv/Zc6zjb/+XHcj0iydtpaOx/8SsouVx lrZna2Ob/Tjxf+8Ma+PVaqV88/G/YL1h/1To+jk9p+kfhZsmNLAR0dQkzEX+uW1+Zjv9 daiqox8P1XtakXYzF0xC77eICR22K54AnoWRLOIJ7iorqrJZJO1KOMZbwaIyFVdiLEdO ODJhFahTBUdoQ0gIm+CZtGxQPaNR1acFNrUMYkj0pci7WmpueWEOdAMr2ad/TYltGUEF vnGw== X-Forwarded-Encrypted: i=1; AJvYcCWqCmqtiIOWdXToDaSOlMQ8KCalFBjilx/GVcS88gxtmcUiTVnG2p98+7Sx9VvARsiJV4GZxU6hdw==@kvack.org X-Gm-Message-State: AOJu0Yz8czhOLASrgFoPw/s0VsVwfA3K1EjrgEfYAiHljq+jQtY8Ps4f j6bpaBsOJY2uTHIOwJvXKA1pgeMj5Rb4xne2L12U09UHHfhyc+gnsqJnExvNiibXLSzKRM+0nM+ yH/mE1ymqUuBXyjPTI2IuhYTlyedH8smQ969l X-Google-Smtp-Source: AGHT+IEgzSL7E+FoXmdOkwmpU8nb2C/I8uvJwxWSGmckCGCthEaA8NcbZvddARC4UJaGvXsxQWrx8Ws7gZmgk6Q/SBs= X-Received: by 2002:a17:903:2348:b0:201:daee:6fac with SMTP id d9443c01a7336-2050d20274cmr3489725ad.16.1724943748890; Thu, 29 Aug 2024 08:02:28 -0700 (PDT) MIME-Version: 1.0 References: <20240809072532.work.266-kees@kernel.org> <20240809073309.2134488-2-kees@kernel.org> In-Reply-To: <20240809073309.2134488-2-kees@kernel.org> From: Suren Baghdasaryan Date: Thu, 29 Aug 2024 08:02:13 -0700 Message-ID: Subject: Re: [PATCH 2/5] codetag: Run module_load hooks for builtin codetags To: Kees Cook Cc: Vlastimil Babka , Kent Overstreet , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, "GONG, Ruiqi" , Jann Horn , Matteo Rizzo , jvoisin , Xiu Jianfeng , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 314064014A X-Stat-Signature: 8zy3kxrjm1dpqoxea695isa88rjf31nz X-HE-Tag: 1724943750-82346 X-HE-Meta: U2FsdGVkX1+OlUsKUsA3Nd774rbF6iAodsfPUWXdkyC+jKODllOtvmHs3C/DrF1ee4O3E5uTYMV6yMpxjhsrFi8ZwjQb0SElW6j9EvVOfxD43OjViMScGkyCn7xLVkzklfPOGb9JF163htaSUduF42FpHGIkPU5WL6ZILOZ1TFAnNBmnpi8GURXyNyXAQ0ukN2Vl733sUidDfRH0QpXfthd/7XdIn8O9qE8o4GgoUEzq39UVHE7e28WPzLnQP040CU7p9QU8Q9Qq4I+rbSWvfxSKY5ffQrY8eldnVQ3WHmK1Ddbhx1H6UYSuRNzQa2Slv5X/N6ILbeUq1qfABiCcfaFafnfwGcpcS//az3ooxjVcagMiPQC7pxRKfbSvxIdrP2wK1Tcbb5TVb9WtwLotc+avKWAuQzo6euaAh9tcw2ipA5ne3ozAwK/iDc0ptgfMaVTbB72+B+9XJrzCtOsLfkG21qqN4A6wnQlVCf8ad3b+85YeDvYJy6mu822guzlPgaQCiuLQqbuQ+tSn5qpDwVAOqwUt5nP3xs2xZ1BXtdrgw7adIThpggpb2US7ro4xyIKgIo66pn4gGNrkKkMjrQDB2Y/nbsZHlgkX9K5lQ2jzjoRrbStlELwJR2qOSSaqq1jbi2CDRJu/hB6tN3sf/tsDkewkcliYmiy09CMt51BsgIsM3gQXsPKq0b9cn3Om7kqcV0I2K9k6ZrgG2MGaIA4rADc2PWNIMEQTPgx8JVpkd8qTEsGHrY42a12D4f2Ueb0kKtroSBabrHsN+MzyL5XDfBwCipdJO+szIuI3w7xtEyZxYbDqHt5I3N8vuD+Eox938LhzaFESYSP3ntCTi4yyG6j/8Yzh5uFv18n9FIDCSqs97QdhDD9AHc2zcuau0asVjsbedCyr0ARPeygwUhbGy0b9vyt2i/bVWOASg09/1kFCDmZ26Q2b51AVGtFNqtwa6kcK7NwHDYSMudT zJhNXdDd DnnQS7sDannKf9acZbWG17Q0YeQKfTNJZ7nSEG6kZf3FFQ5FlN65MMaawymUReuntV+P2eh6rlOecT5slyXMcijdfI7IRgOLZLmj0Z8zJDVEoi0YXNqrCJP0kd5kRPey48zUYwzuMLM7HMdZbafYjO1NlMekzuWl5/lqu3dJDGR7MguZA14DCRKZzgaBFA4BJgxw4GVB5N4W+xQXWBF4ve1PqnonrXhAyWfP06SkHaLYTOOrFuRdI7Taq9SplUEQatHNWRtblQQG/7FSKxw+eM/1WVNBx+xtN4FhOcgfd05UcjAY31o6GhAfnc4aFGEcPAHIX6TJm6mm+AUKvd7ETak4LZLgYIDdRv7D+WwxBKXoaXplwjiN3lwVh7sdt9zF8cfkq/gsCm55+ti4SsdG047gjvvm/hutnVDT1n2lte5tNgUPS2OfjMxuUbhnU+7deOpCVJVISQHujLeF67lO/oOyhpa4FIBaHPqTYGhmf5Pyi9n41ZvOOvX5GfjjfDfeZAb0b6c/QiWa3knCkQaWEQZAt7Im/bjsO0cR2brtGKkfTb1WAI96B/8fu4MOPPWOiAQp+D99THpGtArRif+o2OsjcYUsuBPx5nrgRN7dzc1gx305X5A1P7CU5KdyM4Qres/oYG8K27tcGefYKP0GTUGEA/g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 9, 2024 at 12:33=E2=80=AFAM Kees Cook wrote: > > The module_load callback should still run for builtin codetags that > define it, even in a non-modular kernel. (i.e. for the cmod->mod =3D=3D N= ULL > case). > > Signed-off-by: Kees Cook Hi Kees, I finally got some time and started reviewing your patches. Coincidentally I recently posted a fix for this issue at https://lore.kernel.org/all/20240828231536.1770519-1-surenb@google.com/ Your fix is missing a small part when codetag_module_init() is using mod->name while struct module is undefined (CONFIG_MODULES=3Dn) and you should see this build error: In file included from ./include/linux/kernel.h:31, from ./include/linux/cpumask.h:11, from ./include/linux/smp.h:13, from ./include/linux/lockdep.h:14, from ./include/linux/radix-tree.h:14, from ./include/linux/idr.h:15, from lib/codetag.c:3: lib/codetag.c: In function =E2=80=98codetag_module_init=E2=80=99: CC drivers/acpi/acpica/extrace.o lib/codetag.c:167:34: error: invalid use of undefined type =E2=80=98struct = module=E2=80=99 167 | mod ? mod->name : "(built-in)"); | ^~ Thanks, Suren. > --- > Cc: Suren Baghdasaryan > Cc: Kent Overstreet > Cc: Vlastimil Babka > Cc: Christoph Lameter > Cc: Pekka Enberg > Cc: David Rientjes > Cc: Joonsoo Kim > Cc: Andrew Morton > Cc: Roman Gushchin > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Cc: linux-mm@kvack.org > --- > lib/codetag.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/lib/codetag.c b/lib/codetag.c > index 5ace625f2328..ef7634c7ee18 100644 > --- a/lib/codetag.c > +++ b/lib/codetag.c > @@ -125,7 +125,6 @@ static inline size_t range_size(const struct codetag_= type *cttype, > cttype->desc.tag_size; > } > > -#ifdef CONFIG_MODULES > static void *get_symbol(struct module *mod, const char *prefix, const ch= ar *name) > { > DECLARE_SEQ_BUF(sb, KSYM_NAME_LEN); > @@ -199,6 +198,7 @@ static int codetag_module_init(struct codetag_type *c= ttype, struct module *mod) > return 0; > } > > +#ifdef CONFIG_MODULES > void codetag_load_module(struct module *mod) > { > struct codetag_type *cttype; > @@ -248,9 +248,6 @@ bool codetag_unload_module(struct module *mod) > > return unload_ok; > } > - > -#else /* CONFIG_MODULES */ > -static int codetag_module_init(struct codetag_type *cttype, struct modul= e *mod) { return 0; } > #endif /* CONFIG_MODULES */ > > struct codetag_type * > -- > 2.34.1 >