From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4008BC3ABBC for ; Fri, 9 May 2025 15:27:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE7EE6B0130; Fri, 9 May 2025 11:27:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A964C6B0131; Fri, 9 May 2025 11:27:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95E6E6B0132; Fri, 9 May 2025 11:27:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 773AD6B0130 for ; Fri, 9 May 2025 11:27:36 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E225CC02D8 for ; Fri, 9 May 2025 15:27:37 +0000 (UTC) X-FDA: 83423748954.25.A671E49 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by imf06.hostedemail.com (Postfix) with ESMTP id 12C7D18000A for ; Fri, 9 May 2025 15:27:35 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=mrI3UBnD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of surenb@google.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746804456; a=rsa-sha256; cv=none; b=8ig/rGLsd6TPGCYI/czmjJDg27Ij4A9YYD61Q+RDXEWY1kFbZlH35TQRLGFk17TNHrDZm1 iHXsAZ2WLy4t/l4F7EDBpMglnDtV/6JtSACaKzVcXo8/vlswE6/8xq7xkdsjTtpxZVRkrh JzRl6L9fweRkzzcOSkI99k4jcRHoE/4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=mrI3UBnD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of surenb@google.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746804456; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jG9EE6VQeTuEiYsSLxlwDzhKExC7nkCkVw5vNICkPms=; b=WcTZYkw8Xx2FtE436JQ2zBuGl6yvTfmGrBWEyvG6MB1u68v64o14k6BEwwD3tBCJpJjY+k tT85fEcUBkT/tn4SCfaTqKZCzCiSA8iq657JuJxvT/qExOWOlfRuE2C7cxLLQhodA7blKf HY3bi4RIN6Q1cItD+UONqCCXUaWWpq4= Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-47666573242so371691cf.0 for ; Fri, 09 May 2025 08:27:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746804455; x=1747409255; darn=kvack.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jG9EE6VQeTuEiYsSLxlwDzhKExC7nkCkVw5vNICkPms=; b=mrI3UBnDtN9CbV+uQ2XQXZDvWN1Q8ugyiaUsjvX31c5MFkPjperwc7yUchTX55ALsf 4oq4enT82wIs//HUFMAsVKHTTGpuGvMY8mpa1o8/hpX0wH1nBNltbzICrW0smiH4/Fbm d9qAk6LR2zbteMkJz/+EyN0FC0VccPV1gRS/4aEujrQQg5+5OsbrTUyNaEcqwmGi5Klv +eR6zCNl39Bi8YFt9lJO9aNTUHilsvnPQmOlwAZypbudI7n8Ozlfzv+W6uzuGh2v+jFi QNj5IT3udnt9S7N363DyXen7PNFh6i1POCHuIIa2QuGtYQJDvoqyb42tAOz8yNpD2OzD CRyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746804455; x=1747409255; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jG9EE6VQeTuEiYsSLxlwDzhKExC7nkCkVw5vNICkPms=; b=lvV4lp6YuKEygY9OWHl5OSv9KDTL04H1VPc13A2D2uxc7/Ry0+hTbSVSTar92FyHiq SyCXrwPursXv0nTQQ9/q3IfYBLNorDwtoEs699Wtglxaf0lp7nwBaYEvjdpl1MyZGoPU sv/fKOy9wPUgWlhaJrMUVSeJHdInqsNvLB+zj20NPL3gZ2FQFj33WKfmxa4IfYZnHNS2 fFZV5ouVuHAbPT1LHKkYqkGa/sERN2ayU0L6MR/uKmSowrEcflVGJgNES8Vsca9wXBXV FmUO1vizNx+PGxmHGtqEAA7muGpJSZLOAluxITtvWh5L2N5rnLtKxd6Lyhmq85PHKXcp LYtg== X-Forwarded-Encrypted: i=1; AJvYcCUtH7331lOYaHz7wm03/lean9Shwj3LZ7cI2/AHFLaeaTQPu+W+aOb6KJ+lUyPeptj4iJdA1FE82w==@kvack.org X-Gm-Message-State: AOJu0YwkvxJLLwDLfnsoBJw1CDn4sSNxhBw6JD13VON7rISKwo/EWnsh LxAyhG0IyYMafxe+BOq8C7fA4KUbCEnYONjPo0UjIA53L4XIghL2DGCnK3ORuARBRb8TaZ961bt UuS07z6qL/tMxtxf6g5tLnrT2P8F61PvrQij/9DlPLzYTpRcJ6Odn X-Gm-Gg: ASbGncv552r3tH+b3tSMt95n62rAJtKvALTqoJsqtRfUhJe2mUUnzfKeXXHsWQiUR1u t0hj0zZBwNdXruxvgyBS1bZjGlAaE1SL2KXsLyTfGveaCow72noXRfUqZ2+sXTFn/VUeu4ZehhI XTYXsHgWqoW2WSWax5tG4x X-Google-Smtp-Source: AGHT+IHApWir+Vo2/cy0YO8oikkiLlm8XQykhat6pTBhzrhQ/LwUY77hX9i0V/Re8ShFn/hJAzb3YKYGyOXal5OvpBs= X-Received: by 2002:a05:622a:190b:b0:47a:e803:da1 with SMTP id d75a77b69052e-49453c2a4e5mr4115081cf.5.1746804454756; Fri, 09 May 2025 08:27:34 -0700 (PDT) MIME-Version: 1.0 References: <20250429014754.1479118-1-Liam.Howlett@oracle.com> In-Reply-To: From: Suren Baghdasaryan Date: Fri, 9 May 2025 08:27:23 -0700 X-Gm-Features: AX0GCFu18kgfCkdbJqYlBB7hChaHXYsZauHXXbNvU9KC5JGedHdYp6mKPm8QELk Message-ID: Subject: Re: [RFC PATCH v6.6] maple_tree: Fix MA_STATE_PREALLOC flag in mas_preallocate() To: "Liam R. Howlett" , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , Hailong Liu , Lorenzo Stoakes , Suren Baghdasaryan , "zhangpeng . 00 @ bytedance . com" , Steve Kang , Matthew Wilcox , Sidhartha Kumar Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 12C7D18000A X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: n5maqbe4kddj8hpenizirqysp84iafo3 X-HE-Tag: 1746804455-447484 X-HE-Meta: U2FsdGVkX1/xfpDog0cUlyCfOUdqFy7TlOrrIdWpmvc9gSSwsnU7VZwtKWxoduWO2002Q8qkhp8/Z/77NF8LBfFot6pWRHdjod7hD3HfrvgVRDPe9kLTwyWby72EiBQ40LgrBwr7NRRSXwG+c9pHjRiwTgvyqAmweRQIvD5mtczJiljnRYJ79tLT37KBJ5GkQ2hNC2/6XzsUMBir0PRLhuOhURRR8MgcFmwbkP3cM/A7/Su8AcBk77oqUaBywwGYZKAvWe/MC3bGh4VrNzNrsgH2ZgePXp3dPm7Y5/Z/45ZxL/ojUOTYUS/uCKhh8IU7mq/9cnmU+fmB/Rc6om4w6nbqEfcF1+5q9C7RgtWjPqDZmxWszaiyy++aLqksVplVrDwJAAHH/XN64UsTFnbB6NSY3ZPpxAiNPIj0cIYvmOZ3daTqOyC1wWNqU3//+crmqOaqbDRLK/l3UCPxUeBFZFmBPY2jWkBDaxHK0GN3jiuY+TTELcOnZqJ69hqAlJls/UObgTeXWr7B6wlIWxo7qc7EvXU8yCNTd/O+iqn4jOnRe/c2b0Rv3MZ/UoVf92wNFVGo7vG/4aoaPkQd5FvX6EbgxwG+VSEGqwZC4yZNYwXBq3Dy4AaTuA/swne/bzH+mEhk//Tzj8Iu2bqBEjDMOveOR09MFz2gbGwMjCOrr+po4Pw8iOiUPqlwtuE8nkRqCMBXqvkv4S8KXZBmV/kwynQ0B+omv6QrAFpd2Lxmk5YHP2Qy4dgOnXoYO8oEQi8mKLGk6htXBXlyC6dIQ+wkT4RyXnBR03nEztbMcIf4YL87W+mjfX8hX6FWxEwTexQ3xLUPQUYEMnygEJaSmK5yzIFs4WSC9EA+nwLF3N+kBDvblJWoRDmmDfBcbJe2q/O+erMLSfiqskAUfcY3SMPv+6SGNrEqUFb4C4nT/GJhRO37hDWdfqtm0A4NWmwWgSW5jAH/WLWyUGsdXWhVZ0g Ra98JDYf Mn0nfA4lMiS4Kvkzi36jpB5fsRdaiShYEgXrPWxf0b+Eq32ckSju0hOI4mZnjs6eKEWIfUmMehVU+CIUQ4R+RTL6AXYXvxdiPhOzbLrsOJQmescSSW4yRumpRHXGTIUJ6V75lc/JWbDWldaggZR4AipAnlN3z8n5JFQ4ifExqR8nmAbotYnsOulaLTrvWSdplWBFNthMRuIGLK78kOmK08VVMzEq9Q/sY8UZLcPJ67g87eAQSDytpfuBPPiUkfrcTa3cXxbNOTe1Lb4cWE9w0XxWPwgv6nsS0yGwmfiWrffrlu+AWk3KWGAwb5iqJWs/9u/ao/XeGguIPFuthzrJTtELKjW151mVO4IHH1aZb9npoKhsLfQnxImOxY1vagcpNua/mFCJOKXI7yoDeTZYIezu9WL/oU9Dm6kM2aKQ8f8POSC7xMl8EMX0ydD8obFbAm28h/QHwkjXvwS/dqx7e+Wyx6Upr+uu7pIOK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 7, 2025 at 8:50=E2=80=AFAM Liam R. Howlett wrote: > > * Liam R. Howlett [250428 21:48]: > > Temporarily clear the preallocation flag when explicitly requesting > > allocations. Pre-existing allocations are already counted against the > > request through mas_node_count_gfp(), but the allocations will not > > happen if the MA_STATE_PREALLOC flag is set. This flag is meant to > > avoid re-allocating in bulk allocation mode, and to detect issues with > > preallocation calculations. > > > > The MA_STATE_PREALLOC flag should also always be set on zero allocation= s > > so that detection of underflow allocations will print a WARN_ON() durin= g > > consumption. > > > > User visible effect of this flaw is a WARN_ON() followed by a null > > pointer dereference when subsequent requests for larger number of nodes > > is ignored, such as the vma merge retry in mmap_region() caused by > > drivers altering the vma flags. > > > > Reported-by: Zhaoyang Huang > > Reported-by: Hailong Liu > > Fixes: 54a611b605901 ("Maple Tree: add new data structure") > > Link: https://lore.kernel.org/all/1652f7eb-a51b-4fee-8058-c73af63bacd1@= oppo.com/ > > Link: https://lore.kernel.org/all/20250428184058.1416274-1-Liam.Howlett= @oracle.com/ > > Cc: Lorenzo Stoakes > > Cc: Suren Baghdasaryan > > Cc: Hailong Liu > > Cc: zhangpeng.00@bytedance.com > > Cc: Steve Kang > > Cc: Matthew Wilcox > > Cc: Sidhartha Kumar > > Signed-off-by: Liam R. Howlett > > ... > > I have a version of this for mm-new and I'd like to send it out. Once > this is upstream, it will be backported to the stable kernels with > something that looks a lot like what I sent out here. > > Did this fix the issue in the longer running tests? - everyone else Hi Liam, I think the delay is due to the holidays in China. I requested an update from the partners but they will probably provide it next week. Thanks, Suren. > > Thanks, > Liam