From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E64D9C3ABC3 for ; Tue, 13 May 2025 19:39:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 826346B00EC; Tue, 13 May 2025 15:39:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D5F06B00ED; Tue, 13 May 2025 15:39:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69E616B00EE; Tue, 13 May 2025 15:39:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 44AEE6B00EC for ; Tue, 13 May 2025 15:39:41 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5B0AAC1650 for ; Tue, 13 May 2025 19:39:42 +0000 (UTC) X-FDA: 83438899404.24.603C1F7 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf15.hostedemail.com (Postfix) with ESMTP id 6188FA000F for ; Tue, 13 May 2025 19:39:40 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=jRbOmAdJ; spf=pass (imf15.hostedemail.com: domain of surenb@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747165180; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/DMQiE+z4BENZMvvlEfx3w7edbWlEuyP6Pl9raDN4XE=; b=jo3ReaUMlZ6vVxHFyX/MbeJQmMg1GXfdgvQnUHUjIrqu5huqY3zHPlBWc7nghutpFrBH0a JfEeEqeQUaj+wc605ZQDzFpiQNiOp/rre54NigGMdrfYsG4uM6PBi+FUNKg4ZvePk1ecJD wwiAtow2JqnNqsPKbL2chNlWAbeL1lA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=jRbOmAdJ; spf=pass (imf15.hostedemail.com: domain of surenb@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747165180; a=rsa-sha256; cv=none; b=Dwc2+1o38tKtlkeKjDO9Y/6y75g5N4tUD5d4jn7F0TRAodzcEyagwwP+RuUc12dSN4U5d4 UjdZWEVoe5mLoMM0SdJK5h6D+KdL/L/RkR0Jl/TPwfwupx/QWq5C2se2cVTXIR01Qk3bEB xCx4q6/Ih7kCmn8piqwUWcO74tpG5bA= Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-47e9fea29easo78401cf.1 for ; Tue, 13 May 2025 12:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747165179; x=1747769979; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/DMQiE+z4BENZMvvlEfx3w7edbWlEuyP6Pl9raDN4XE=; b=jRbOmAdJrBaHvfWmY9hC4z67OC24cvzXz3pkSQqo5PD41a4RrcIUbp9+ElP/Yo5ECV ehc4COgqF7XXhXKqHMpIs+L5wu3oPu2Sf2v0CCZPaFZRR0gJvAp9SsmU1Fl3E5H3wg59 hwDPdJJy7boiVst/paoAPEgDCekLdA7Of2MBV1ONwq1gY0noaWOoguIwcyaHvrjZScRY FFrmB8s+I90/w7QMaSUEIAVbxTDwN/Ajf3XoXSs5eio2IZg8PAeJxx51ieGd+wtn1Vjr bIb5m26SBpYEOt0WgWhAosQRFsuR0lpX+FPwbTdpQiTOUHzj7PWC3epDH1+1vqLdp7Kj nc8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747165179; x=1747769979; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/DMQiE+z4BENZMvvlEfx3w7edbWlEuyP6Pl9raDN4XE=; b=toLXUXoORqDfSD9oK7Kw0CiANymupqGl5dQmNd6TXbB4DpZ9nhJOmBHRHCMzie/tnC Mj8woxtZygLQ7r3Ngw+Mq+sQsjSooZFCWnlrvaf2U5QGQe1Sy/1ZGgpGFRYxgUwdleEh eefUhz05XfyNhR60UNRGK8eYkGVMGtm9jO1MuatyKKLdqwJIa5HXilMhToZ0XsALLgY2 eVX2kJgtIflO0DOBylGItBGTRptcF3jJy5FoBfAGu3xOMGtp3iQR7zRPPJHwYNIsx3+h zKPcmP6kM3t4EI7MS1bjXzbGoHQopswBLmbU3RaT3KXKNV63X6mw+NWPMmoVn7DwhpEL iUVw== X-Gm-Message-State: AOJu0YyvzCmvZe58GvQdRJ4WNgr5Jw+viUs1ggOTy6ERhPcqDYbc4dYH mGtDTgPSpRPHbRvha2HSWZ74+vXQocYB1QxOiRilf5pgJjv3ZJDOPVdF0jRsGMLOEjBg2RBGh+7 jopq9/XvkvXWC7JUZAEQkIJtwsG0oN7RwxewzjjUcUlGrWpIRTDknorVM X-Gm-Gg: ASbGncv3tbe6jW13Q6tg78gjGQFoiNpD2VHkJstVDPD4FO+G2k2qeffp+RDdOAPsGk8 OxQr9TDdI5UReQ3WGwdYdEX3jQniGODnRWOh2AQY2E6RKUyM7+vdxnWVvfn+MNjQ4IkGSXyXryI Ib0jRWbM6WriTeR5inQRMdpN11plCLSeNYCMGyHST1R85GUlA29yHKOPohT/pO X-Google-Smtp-Source: AGHT+IE7Z0BGzcomeu9oAFzPWJL7hH/JsL9fh3Ve+t3xJMiOeD2x/38PGKy3IWuOMBJSF11Q0MMRkmZ7iWuRZpVXiCE= X-Received: by 2002:a05:622a:2d2:b0:477:7644:b738 with SMTP id d75a77b69052e-49496227266mr553601cf.17.1747165179079; Tue, 13 May 2025 12:39:39 -0700 (PDT) MIME-Version: 1.0 References: <20250513182602.121843-1-cachen@purestorage.com> In-Reply-To: <20250513182602.121843-1-cachen@purestorage.com> From: Suren Baghdasaryan Date: Tue, 13 May 2025 12:39:27 -0700 X-Gm-Features: AX0GCFtPKYCuBzDDgsXDw93pSjTt0jYmUkzCw02qWgXlE57GG_MgOzkqdjiA8ZI Message-ID: Subject: Re: [PATCH v5] alloc_tag: check mem_profiling_support in alloc_tag_init To: Andrew Morton Cc: linux-mm@kvack.org, kent.overstreet@linux.dev, yzhong@purestorage.com, Casey Chen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: shnrxifoi68kft6wm8wyd6yz4gk84cjc X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6188FA000F X-HE-Tag: 1747165180-828279 X-HE-Meta: U2FsdGVkX18LI8Qob+ZIQkatDOlVmrkhjCUN3H61uQzSh5jkwpKyvapJGdWdQF5V3K+7PmSDlwVt8PI6ZhDWaSR+uusLYcc3VcImBMUGxnFF3fC0Ay9gPugdHLrFjLhqKEqns2lL2EHkigy9o9VpxJ4XxRaGSntXMxBo3yR5f1+gIUK6OqeFzi9UlqAd/8vG9AnzJZ+etsXCngbCzHMuHyfUWSwIVhzYNQ+M/rskVNtTk5H234C7574GbxWyCWg1sccmOjByYJZi0pSu+pYN7zKxD1SiZ636SYYLwG8JP9yEGHceDBA7rQ5eJFEjPYk6nCSPhTqHDQqzpX+89hVo4k05JnIhsUJ5jF3OebDUDlQD7ZaGuxeqSEEPo7SnPXeoXVZcfpJlhkMoN8/PUTR2sTyin9VY61aY//bOyGLPOvTntl3APkK2Y1HbV6kgnDvX2sAA/525395CMWfg6dhPZPdnmcU3KQdCMPdyR2b19iF7Xnwya4AuupDb9M5MpV/fWdQLMFEsArA6gUgSmX3cAtg8WbcAyk5vHZNCbYqMka2qNQDCzlsoIiigUGd8PNg17NyHTojHmw22KpX69TXoZYRAzB8CoL7yu+cFVUIFk+akdqtd4kLbKlFNSsipWqYKzZeCBvG+my0VWnrtfPemH4NXjnHd0DP1ZHpJSSne6qRl38gOp/G5snG7M1b1Fs6NP8KE3Rt/U/nDTVeLueqT/7ZkrDSqMYY9L1uYxZ+Rbyg0sN5/xSdZEdAANZHHY44X/gYXb4slDPjBJMsVxO0qTABwmh59J0S09/CoRcxBODSiUhbCV7SybUkPlIMmGvfCuslq9CpSn1n+lFU0obAa+09bYbx5mPrVfM8mmgo+y5XFIAq2x+XIddNQtDYUzlH/BWhqRHkGrddCE5tonTW9uJLyc/6Nb/f69ZrlafTr6/HKkh9Ux8HkTqifPAlOia1/cLUA663xwdsZg9O49TH KgXPrtob f1btrhbB57eOyNXAPCAwH8zI2lfqgyea2WvoNW8xFwvRW/ThsVfD02132eb540HCdevlFcKmpCrw8xaFldrDlmJjpXvYYNGL0mFP2a3QfjL1URVlsGFGIBbDga+FZiUxxcQgYm5LznKd1pUE8Qu970EGBNzEvi2BtW9AYVg84IRWRJr74rk/tKNuxAIQJYbByWglG9ZiYd5NGYWyn3N1SmU5YwsFHxEkT5H2Ov+Bd2f4xZLLMunQ4etbgMALG6nI6FfXzgrbSiPIs0fBWWkgLyDZT1nWsH2WO4kVtSWd4BWgb6si44kx6yHFfWYxC89EMkc6A X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 13, 2025 at 11:26=E2=80=AFAM Casey Chen wrote: > > If mem_profiling_support is false, for example by > sysctl.vm.mem_profiling=3Dnever, alloc_tag_init should skip > module tags allocation, codetag type registration and > procfs init. > > Signed-off-by: Casey Chen > Reviewed-by: Yuanyuan Zhong > Acked-by: Suren Baghdasaryan Sending to Andrew as I just noticed the patch was not sent to him initially= . I don't think we need to CC stable as IMO this is more of an optimization than a bug fix. > --- > lib/alloc_tag.c | 34 +++++++++++++++++++--------------- > 1 file changed, 19 insertions(+), 15 deletions(-) > > diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c > index 25ecc1334b67..3baf19879c8e 100644 > --- a/lib/alloc_tag.c > +++ b/lib/alloc_tag.c > @@ -244,17 +244,6 @@ static void shutdown_mem_profiling(bool remove_file) > mem_profiling_support =3D false; > } > > -static void __init procfs_init(void) > -{ > - if (!mem_profiling_support) > - return; > - > - if (!proc_create_seq(ALLOCINFO_FILE_NAME, 0400, NULL, &allocinfo_= seq_op)) { > - pr_err("Failed to create %s file\n", ALLOCINFO_FILE_NAME)= ; > - shutdown_mem_profiling(false); > - } > -} > - > void __init alloc_tag_sec_init(void) > { > struct alloc_tag *last_codetag; > @@ -762,19 +751,34 @@ static int __init alloc_tag_init(void) > }; > int res; > > + sysctl_init(); > + > + if (!mem_profiling_support) { > + pr_info("Memory allocation profiling is not supported!\n"= ); > + return 0; > + } > + > + if (!proc_create_seq(ALLOCINFO_FILE_NAME, 0400, NULL, &allocinfo_= seq_op)) { > + pr_err("Failed to create %s file\n", ALLOCINFO_FILE_NAME)= ; > + shutdown_mem_profiling(false); > + return -ENOMEM; > + } > + > res =3D alloc_mod_tags_mem(); > - if (res) > + if (res) { > + pr_err("Failed to reserve address space for module tags, = errno =3D %d\n", res); > + shutdown_mem_profiling(true); > return res; > + } > > alloc_tag_cttype =3D codetag_register_type(&desc); > if (IS_ERR(alloc_tag_cttype)) { > + pr_err("Allocation tags registration failed, errno =3D %l= d\n", PTR_ERR(alloc_tag_cttype)); > free_mod_tags_mem(); > + shutdown_mem_profiling(true); > return PTR_ERR(alloc_tag_cttype); > } > > - sysctl_init(); > - procfs_init(); > - > return 0; > } > module_init(alloc_tag_init); > -- > 2.49.0 >