From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFD73C433FE for ; Tue, 9 Nov 2021 20:02:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6FA5F61057 for ; Tue, 9 Nov 2021 20:02:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6FA5F61057 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0463C6B0087; Tue, 9 Nov 2021 15:02:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F37836B0088; Tue, 9 Nov 2021 15:02:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB15D6B008A; Tue, 9 Nov 2021 15:02:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id C6A9B6B0087 for ; Tue, 9 Nov 2021 15:02:50 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8BD1D7B265 for ; Tue, 9 Nov 2021 20:02:50 +0000 (UTC) X-FDA: 78790464900.20.F239BAF Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by imf18.hostedemail.com (Postfix) with ESMTP id E1E5A4001E9D for ; Tue, 9 Nov 2021 20:02:48 +0000 (UTC) Received: by mail-yb1-f176.google.com with SMTP id v138so403241ybb.8 for ; Tue, 09 Nov 2021 12:02:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mNY0y0eA9QFjzP9md2u0evK0gJlRjiM1T7nvr0z7Y1Q=; b=XmpMSGbHisj1bMTeQbWzpoXd566Jd6dd6n20risBDuCFlvhGz1Ka37xSb6eLO7mRqN dSvFoXkqF9JJBFcNtoERd2otIAhGLqbzoceEQ3s/4nOQ2UmJlgxshmVUUOhqIDxl06aZ xxhWUPxXyfRoUQKtl59qgidqVSmuqkJv0g/bjs8k1cAhiUvE7AYVOcPdfiWI5BEZqoSG Ajd2B8TFW80hBcaWql6Q94xBAjmpqzebr7BLvJQKnbMKZ06kvtdK/KRH33IOwF0vB6Yo 1AeYbMUsaBh3erYO3q4ir7rN1eQx3rCn83oc3ohBa2X1s+VqxcFWxrl15cMiIq3Z4VxF 3iCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mNY0y0eA9QFjzP9md2u0evK0gJlRjiM1T7nvr0z7Y1Q=; b=I80y7GATGjM/HPzq87v748fsuVhr3+HjHqOQRKf0Ds6LDkLgZUWQIC637pNQtO1e8N SlIOJBSr3jsKeRfwK4iR0hUk5iFn6fH3LeBylUfrIeA4nTq+MDr9ONT4wUf14duWUan2 J0nD1nWI6R2QSi/vSzXG5dcj6wkPmAiqtpmDeRjUI/zmgC6BJ6HHzxXCu52GUlvQDlyW EHaXg0yT9IIPKQh8J+FVnxy6lBNq3Q1QnlpIulo0xu682ZWnQBNcdzTs++qK2C1Eb1Df iq3XJMiYIPksP5+QLl+7uICMro6ThrmyZWKO50a9TMV9cjZeFuwPDuKLrGLIVQ1xizjj JTmw== X-Gm-Message-State: AOAM533iLXv3/5bt3vYKu0+ALIy44+SCuLfh847RbmPUNwgjWAkKYxX8 6fgHP/EcnQ+1ZOqmT+MX7RWVfyAXGCE4TmH6UH1kYw== X-Google-Smtp-Source: ABdhPJz66wXBO27AG+ywplv4qSiNKTGTTq3yywP5yCUsTUbLTry0vfQQUkbxdnDAz/wUa9ds4L+wp+VX+HKAUUXChRk= X-Received: by 2002:a25:d4d5:: with SMTP id m204mr12480331ybf.418.1636488167925; Tue, 09 Nov 2021 12:02:47 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Suren Baghdasaryan Date: Tue, 9 Nov 2021 12:02:37 -0800 Message-ID: Subject: Re: [PATCH 1/1] mm: prevent a race between process_mrelease and exit_mmap To: Michal Hocko Cc: Andrew Morton , David Rientjes , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Christoph Hellwig , Oleg Nesterov , David Hildenbrand , Jann Horn , Shakeel Butt , Andy Lutomirski , Christian Brauner , Florian Weimer , Jan Engelhardt , Linux API , linux-mm , LKML , kernel-team , "Kirill A. Shutemov" , Andrea Arcangeli Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E1E5A4001E9D X-Stat-Signature: o4ab3fbjskpr1u539df47gdppgp6p757 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=XmpMSGbH; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of surenb@google.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=surenb@google.com X-HE-Tag: 1636488168-398054 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 9, 2021 at 11:50 AM Michal Hocko wrote: > > On Tue 09-11-21 11:37:06, Suren Baghdasaryan wrote: > > On Tue, Nov 9, 2021 at 11:26 AM Michal Hocko wrote: > > > > > > On Tue 09-11-21 11:01:02, Suren Baghdasaryan wrote: > > > [...] > > > > Discussing how the patch I want to post works for maple trees that > > > > Matthew is working on, I've got a question: > > > > > > > > IIUC, according to Michal's post here: > > > > https://lore.kernel.org/all/20170725154514.GN26723@dhcp22.suse.cz, > > > > unmap_vmas() can race with other mmap_lock read holders (including > > > > oom_reap_task_mm()) with no issues. > > > > Maple tree patchset requires rcu read lock or the mmap semaphore be > > > > held (read or write side) when walking the tree, including inside > > > > unmap_vmas(). When asked, he told me that he is not sure why it's > > > > currently "safe" to walk the vma->vm_next list in unmap_vmas() while > > > > another thread is reaping the mm. > > > > Michal (or maybe someone else), could you please clarify why > > > > unmap_vmas() can safely race with oom_reap_task_mm()? Or maybe my > > > > understanding was wrong? > > > > > > I cannot really comment on the mapple tree part. But the existing > > > synchronization between oom reaper and exit_mmap is based on > > > - oom_reaper takes mmap_sem for reading > > > - exit_mmap sets MMF_OOM_SKIP and takes the exclusive mmap_sem before > > > unmap_vmas. > > > > > > The oom_reaper therefore can either unmap the address space if the lock > > > is taken before exit_mmap or it would it would bale out on MMF_OOM_SKIP > > > if it takes the lock afterwards. So the reaper cannot race with > > > unmap_vmas. > > > > I see. So, it's the combination of MMF_OOM_SKIP and mmap_lock working > > as a barrier which prevent them from racing with each other... > > I wasn't sure how > > https://lore.kernel.org/all/20170724072332.31903-1-mhocko@kernel.org/ > > was implementing this synchronization because it would take mmap_sem > > write side after unmap_vmas() and IIUC there was no > > "mmap_lock_write(); mmap_unlock_write();" sequence in exit_mmap at > > that time. I'll need to checkout the old sources to figure this out. > > My memory is rather dimm but AFAIR the main problem was freeing page > tables and freeing vmas not unmap_vmas. That one was no modifying the > vma list. Essentially it was just a slightly modified madvise don't > need. So that part was allowed to race with oom_reaper. So, both unmap_vmas and __oom_reap_task_mm do not modify vma list and therefore can execute concurrently. That makes sense, thanks. Then I guess, if we want to be semantically correct in exit_mmap(), we would have to take mmap_read_lock before unmap_vmas, then drop it and take mmap_write_lock before free_pgtables. > -- > Michal Hocko > SUSE Labs