From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D62BE77188 for ; Thu, 26 Dec 2024 23:07:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B42526B0089; Thu, 26 Dec 2024 18:07:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ACA6E6B0092; Thu, 26 Dec 2024 18:07:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9924E6B0093; Thu, 26 Dec 2024 18:07:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 793026B0089 for ; Thu, 26 Dec 2024 18:07:53 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2D5D9C02F6 for ; Thu, 26 Dec 2024 23:07:53 +0000 (UTC) X-FDA: 82938649122.02.F3692DF Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf22.hostedemail.com (Postfix) with ESMTP id 83F6AC000B for ; Thu, 26 Dec 2024 23:07:07 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hMF+oRbY; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735254427; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bRomBso2hHE7YrImWq0wbVcT1dst09ldMkIN2FASxJ0=; b=VYnMJbncBIgjvr+NMyDpgm3e22CgMV1v3R49a//hOr4bBWBg524hOb2ucc1Hw3zpz+xlf8 7SQVxa4aCLZSx1byhAKzk52kStzeaTbf4LG1iwbgja4+dC9aPr2obGl9b9h7avXtWsBrHI 6KlcKlO0/OnijMnegAI6rGwC4TRe3vs= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hMF+oRbY; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735254427; a=rsa-sha256; cv=none; b=NR9xYq0cPHqQ9HsYNo+0Hv4F2wH0Y9oAn8Of++h4TALhi2J9xTHEopOJ3iA85VM5jH7ntF K4m6xoa3mfPQ8YFRS3muSYbMLCaRGenenkE3VUoI7Ao2bVZvtBQbNbf0zkP+Mepk5LSEbo 4RGu1EjuAOu06Yun5aaBr9yMV5BPKsQ= Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-467896541e1so1709971cf.0 for ; Thu, 26 Dec 2024 15:07:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1735254470; x=1735859270; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bRomBso2hHE7YrImWq0wbVcT1dst09ldMkIN2FASxJ0=; b=hMF+oRbYboQgLAnBubD2BKBQ5MGk9OEPtJSoxd1H7gQitpMghZ5Hz/w9oYRSZXRLEb Jl7vdkUsQ1K9MnjM2HyRKzaKBukaMeYaPiVKPupSmvgfukmvBFmuWOXVD+wv5J3Th8no NQJ1XL8SYkoMc1OLvPix3T23v6VOwBD7qJow6RPWD5fTm/PhBXRGALCUL1oRAzcZiCvO ExeVzkj9xSPeg8S4TNdwi5bmuCd+XOWIHMQ9M3hnLVCSlIHzUwdJ37kXgpx7HjCYCfa3 iJkaaV/63mKgGwswSTCt7VFs4ck1m0SFrxZnkuedXNMBCOqPRp32f4bfq8CRF7YCo4NR CRGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735254470; x=1735859270; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bRomBso2hHE7YrImWq0wbVcT1dst09ldMkIN2FASxJ0=; b=EYeke538f4/gEP3HSLjGdKI+hUuq1k5yNdUS5BP0yaAfUWdJ/v4Ud5h+T0gfo9tCVC Uy3Y+WjBKlBibb5vvE2xN1oV9jZaT0V5VaM3Hc/aJNrOMAwPwSmKDu7G6obJiSRtaBF4 ElrV5prSoQUNFw9v7PAqNnHZ5bhuXL5KjIwpJSrhkJ+X62X+gOlSWZsqlIS5jHumaDWE dCh8kEbuuKG19ttOwFKPvsik+oqit0dyZ/yzqabJmmOhGba8s0KpBAy3sZsZdkBLjffc crPUSxvgzmvVtor2hK6jbY9gU0P4LaMemBz+Iyp9b/SybHSVPG2TRuzsQ2RyBaANaKn8 WciA== X-Forwarded-Encrypted: i=1; AJvYcCWafjYu2O5kg2c8ZsrmMePKyJATxuMJi6xWmyEkjstlNYOuobxr4FKMhicotAomPxP5nAqqLPoJ/w==@kvack.org X-Gm-Message-State: AOJu0Yz+ib1kYXI8lDzZCOge25iAHjU4Eir1ikJlspEDyMBrF8o4HP3J B5HLjb966r1IGHw1ZANotLtIBiiF6QoMA8h9yF5nvq4VVzjNqSICHHf6lqU5eMM7QASpRVLD05Z DIXjSqfvZYJADXTZDa/b1zz6vVNSCNaFNrI42 X-Gm-Gg: ASbGncuk9dJ1l95qtoV50F47QJ059So1sBc47LUlnwKtA8AY4BZnSjPpX0FhJufUAr5 +fSs3nNnxTO3Dqxpi/qdBldKD3fZb/MeR7pgQuQ== X-Google-Smtp-Source: AGHT+IFhjdoMUGCzHBQmzdGdz4JrsyT+H2pqbPiCnL0Gl+iLY8mS0CNjTft2xGk+ZwISn3BwzOAc38wfaZi5URoujxU= X-Received: by 2002:ac8:7f82:0:b0:466:8e4d:e981 with SMTP id d75a77b69052e-46a4bfc6904mr18862911cf.3.1735254470272; Thu, 26 Dec 2024 15:07:50 -0800 (PST) MIME-Version: 1.0 References: <20241226211639.1357704-1-surenb@google.com> <20241226211639.1357704-2-surenb@google.com> <20241226150127.73d1b2a08cf31dac1a900c1e@linux-foundation.org> In-Reply-To: <20241226150127.73d1b2a08cf31dac1a900c1e@linux-foundation.org> From: Suren Baghdasaryan Date: Thu, 26 Dec 2024 15:07:39 -0800 Message-ID: Subject: Re: [PATCH 2/2] alloc_tag: skip pgalloc_tag_swap if profiling is disabled To: Andrew Morton Cc: kent.overstreet@linux.dev, yuzhao@google.com, 00107082@163.com, quic_zhenhuah@quicinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 83F6AC000B X-Rspam-User: X-Stat-Signature: 51ob5ja9w8rweqtf1stzd8weo1jjoyj4 X-HE-Tag: 1735254427-154160 X-HE-Meta: U2FsdGVkX1/w6U9ZlxwFM8XLO/MdadRTwfE9VyZXT0WskKIPmR2UicP10fTG3WPbb+6cauCMJIngURZhUlSN3dOqJpt2EYtTdpMYbKnZUGp5OoeCgQcrmVl/U5R8C/wOFmRpo8AWEVkWCXC/ghwQg0vUI8WnWDhn2q0Mdy83/T8OGYMtH2GDal4fc1nR++2kEoTeiuKR4rSRZP0h6T3U6TeBwL4+oOZ+DsVA4a5jBfbTv2JhBv0YQG1FZQ8mWk8nDUCy6MmMj0U/kZ2MbQBTv6HdDCbbm8U5zWQCgCO8/RUeYBtkJK3SQ+3ip+YdaFL1rEFGAg5Dk6rP6F3IUftcwTxrWbwFpFK3n5IicVfYGKobiMyLxKlwRaxBD5lNea7Zz+0t0pjItfF4SEXFG6HI0seY5vgau4IRxRYHAKMz/EZ9yb40reegLAE41VHDEJ2XyVTpQnmLWurFdNzmbARdWLV4a1pDoVzb/OXb+p34ESOg+FfHeNjRG4sklDj42sRjLhgoxeE3cZr27WZWIsTOSr5Yzjto5leKgIGt+G2Ggv0VNxgeqo5ZcJwHrk6e+Fx2W8ZMXxTbiseFKX03w6IZkLngGcJ4PaoGuWjQ53rH7MNpJeM2DdMcrXEgEzeBfH1JOn+lpKFDDCLGWqLJpGQzTtKT3wRCaK6d2ymP+KaK6d93lXuABxUg94zOFDFsKMLHSMS/gHfs/FzCha2ERFZF5mtLxKl07MWwAzEWeekmtBOOicN2TBK+rX/ymXxJro2+1s7N4yzMLp9IEgIcrWJVsY1jQcxt7nbiwTwXZqkVyNZpuANXiSrNkC5oAMK9XFKNPfh6MovteTkFabnglDdNbYjCHh7G/9yMFAr87O7SFge2tshw73tvznYDxv2Z2b0mA5LDMeto934B5jnmyydit52kyvdW7tS6OSwBhFPJ0vY78fWaAam6+ZzPeK41CSPGGaNd9QhJPzyF5JCq7zt HAfB9GAN gCwHI/s54McfyXprryKX2Vm6j1abpz0gfmp6f2yfsLuuCot5rk50C8LVJScO0sTdpjcUHG32MYLAWr0IhAxRJ5VQV8gfOWrgm3BP7/peTroJWJPuexZDbcvZhTMQTtF5E5LBFZZY/RJ2guuFBXIcms+xM/TMK782ZC0iotkxwlZfqQ0C78bopxNyEvQglvJkVmTg8OHzl3+jhbE793uFrcKWMe60AfkQWjjowyu737Nr61xoPTVWqvKChAzIMuJqYObiHGfU/BqGaLwe1ULYgrZc1b4uaU79mobkCO1WXUlTGyKACXh68Ak/YsAMwGiv5KRcEPtKtneYuTpmmFOuInydv6bzVypafOS1AVlplh8SZLpXbJIAbTl1xbg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000234, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 26, 2024 at 3:01=E2=80=AFPM Andrew Morton wrote: > > On Thu, 26 Dec 2024 13:16:39 -0800 Suren Baghdasaryan = wrote: > > > When memory allocation profiling is disabled, there is no need to swap > > allocation tags during migration. Skip it to avoid unnecessary overhead= . > > > > Fixes: e0a955bf7f61 ("mm/codetag: add pgalloc_tag_copy()") > > Signed-off-by: Suren Baghdasaryan > > Cc: stable@vger.kernel.org > > Are these changes worth backporting? Some indication of how much > difference the patches make would help people understand why we're > proposing a backport. The first patch ("alloc_tag: avoid current->alloc_tag manipulations when profiling is disabled") I think is worth backporting. It eliminates about half of the regression for slab allocations when profiling is disabled. The second one I couldn't really measure, so I think it's not as important. Thanks! >