From: Suren Baghdasaryan <surenb@google.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Liam R. Howlett" <Liam.Howlett@oracle.com>,
akpm@linux-foundation.org, lokeshgidra@google.com,
aarcange@redhat.com, 21cnbao@gmail.com, v-songbaohua@oppo.com,
david@redhat.com, peterx@redhat.com, lorenzo.stoakes@oracle.com,
hughd@google.com, jannh@google.com, kaleshsingh@google.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] userfaultfd: do not block on locking a large folio with raised refcount
Date: Wed, 26 Feb 2025 10:59:01 -0800 [thread overview]
Message-ID: <CAJuCfpFSYG3cTxP+B4XrWY2=jGd3fdEG6h-kb0G4R8n9DGtwcQ@mail.gmail.com> (raw)
In-Reply-To: <CAJuCfpFykPaU0XBPBdfnVzvYGK8k_KW7KAEeh2ROyibkuquJFg@mail.gmail.com>
On Wed, Feb 26, 2025 at 8:22 AM Suren Baghdasaryan <surenb@google.com> wrote:
>
> On Wed, Feb 26, 2025 at 8:16 AM Matthew Wilcox <willy@infradead.org> wrote:
> >
> > On Wed, Feb 26, 2025 at 08:11:25AM -0800, Suren Baghdasaryan wrote:
> > > On Wed, Feb 26, 2025 at 6:59 AM Liam R. Howlett <Liam.Howlett@oracle.com> wrote:
> > > > Reversing the locking/folio_get() is okay because of the src_ptl spin
> > > > lock, right? It might be worth saying something about it in the
> > > > comment?
> > >
> > > That is correct. We take both folio lock and refcount before we drop
> > > PTL. I'll add a comment. Thanks!
> >
> > In the commit message, not in the code, please.
>
> Ack.
I posted v2 at https://lore.kernel.org/all/20250226185510.2732648-2-surenb@google.com/
as part of a pachset which includes the fix for PTE unmapping that
Peter reported. Patchset is rebased over mm-hotfixes-unstable which
includes Barry's fix to the nearby code. This avoids merge conflicts.
prev parent reply other threads:[~2025-02-26 18:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 20:46 Suren Baghdasaryan
2025-02-25 20:56 ` Lokesh Gidra
2025-02-25 21:32 ` Peter Xu
2025-02-25 22:12 ` Suren Baghdasaryan
2025-02-25 22:21 ` Suren Baghdasaryan
2025-02-25 22:48 ` Peter Xu
2025-02-25 23:01 ` Suren Baghdasaryan
2025-02-26 14:59 ` Liam R. Howlett
2025-02-26 16:11 ` Suren Baghdasaryan
2025-02-26 16:16 ` Matthew Wilcox
2025-02-26 16:22 ` Suren Baghdasaryan
2025-02-26 18:59 ` Suren Baghdasaryan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJuCfpFSYG3cTxP+B4XrWY2=jGd3fdEG6h-kb0G4R8n9DGtwcQ@mail.gmail.com' \
--to=surenb@google.com \
--cc=21cnbao@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jannh@google.com \
--cc=kaleshsingh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lokeshgidra@google.com \
--cc=lorenzo.stoakes@oracle.com \
--cc=peterx@redhat.com \
--cc=v-songbaohua@oppo.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox