From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46795C3F2CD for ; Fri, 28 Feb 2020 22:22:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F061020637 for ; Fri, 28 Feb 2020 22:22:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QqFkXbni" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F061020637 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7C3D36B0005; Fri, 28 Feb 2020 17:22:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 799366B0006; Fri, 28 Feb 2020 17:22:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D55C6B0007; Fri, 28 Feb 2020 17:22:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id 534336B0005 for ; Fri, 28 Feb 2020 17:22:53 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1A90C5820 for ; Fri, 28 Feb 2020 22:22:53 +0000 (UTC) X-FDA: 76540961826.16.space02_5358e77046455 X-HE-Tag: space02_5358e77046455 X-Filterd-Recvd-Size: 5913 Received: from mail-vs1-f65.google.com (mail-vs1-f65.google.com [209.85.217.65]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Fri, 28 Feb 2020 22:22:52 +0000 (UTC) Received: by mail-vs1-f65.google.com with SMTP id g15so3005296vsf.1 for ; Fri, 28 Feb 2020 14:22:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3leODBZgI1wn5rT6+IG8JL0u+wwlT+mFgWEDYIowxnM=; b=QqFkXbni803CbMFsPllFF8VtTlmkShHFA0dBvma1pHpI17Ow/D6B3s8kfNeZ1W8Qks UeIOZ3z5ogst2O0WGHULt8GfrR2MFyniXs5Tic7mTIICJGgi2VO0J2Crwiokrw4vcR6m 3YeRgKcluhVO8rIamGWPRwE48ofPWx3iYlQfXUcdlYRXdVufOY1RwlOdIFftRpLdHN68 vYTAP1QeN/JaSnnEOzCNZjsJXmf5bObEavHcEljWuC+V8MK2uoP/JJ4VQkXLLsIxamSq 0JMyyeZ+JnFUH05Bh8wdNrJrwWVL8nQNIHhCesC7vrJ9au4a6fj07MD7++eTZPFNfDUi Mzmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3leODBZgI1wn5rT6+IG8JL0u+wwlT+mFgWEDYIowxnM=; b=QQy2Lf1n2BwvwOGx89/O4MT0+5JrpIa2PEnRY9O1EbQNis3Tni8MZiQEDHobNteS0w a2agUaKMBjBox2fW6YmfkdXEYivJqbwGbb5tDtj8T8syb9YtufJi9227yJFjoYVu9kja bfwK2fk3nc4eTuctRCo/NHnj+/6mJqE2kxTImflsxi1oTbqvvMw+3TOML9XhGgGeOaBa Ck9XsG9xCXV4SuRI+LfHwKW6twiqOg1KDxRa4nkkmCPOqf4wsxXVFiXOIwpYw7HIqe21 IJLsZzOcl/8EQfaNQjSEaellxRBrDSEtPgD4pXJblZjiz9xm6Kg5Qm81jvuZobKkGTSR sGkw== X-Gm-Message-State: ANhLgQ2UZItngMuSR41FjhVKVPLHVnM3tV0dUnz3V+PJ8Se4Sbm37gCu gq2ahHZZbKUP4AKmoZ78WbzHilF0br68cmPnKdUNnA== X-Google-Smtp-Source: ADFU+vulVMRO9hqXsq6DyGOcza2Ezp8x3iGhT2uVR5PRNG8Bbs+pnvNbGwRXw0H365h7s7hHAKh2ma/PAcAGP/kQ/6I= X-Received: by 2002:a05:6102:303a:: with SMTP id v26mr3987849vsa.119.1582928571863; Fri, 28 Feb 2020 14:22:51 -0800 (PST) MIME-Version: 1.0 References: <20200219014433.88424-1-minchan@kernel.org> <20200219014433.88424-5-minchan@kernel.org> In-Reply-To: <20200219014433.88424-5-minchan@kernel.org> From: Suren Baghdasaryan Date: Fri, 28 Feb 2020 14:22:40 -0800 Message-ID: Subject: Re: [PATCH v6 4/7] pid: move pidfd_get_pid function to pid.c To: Minchan Kim Cc: Andrew Morton , LKML , linux-mm , linux-api@vger.kernel.org, oleksandr@redhat.com, Tim Murray , Daniel Colascione , Sandeep Patil , Sonny Rao , Brian Geffon , Michal Hocko , Johannes Weiner , Shakeel Butt , John Dias , Joel Fernandes , sj38.park@gmail.com, alexander.h.duyck@linux.intel.com, Jann Horn , Christoph Hellwig , Christian Brauner Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 18, 2020 at 5:44 PM Minchan Kim wrote: > > process_madvise syscall needs pidfd_get_pid function to translate > pidfd to pid so this patch move the function to kernel/pid.c. > > Cc: Christoph Hellwig > Cc: Christian Brauner > Suggested-by: Alexander Duyck > Reviewed-by: Alexander Duyck > Signed-off-by: Minchan Kim > --- > include/linux/pid.h | 1 + > kernel/exit.c | 17 ----------------- > kernel/pid.c | 17 +++++++++++++++++ > 3 files changed, 18 insertions(+), 17 deletions(-) > > diff --git a/include/linux/pid.h b/include/linux/pid.h > index 998ae7d24450..993f68cb45c2 100644 > --- a/include/linux/pid.h > +++ b/include/linux/pid.h > @@ -75,6 +75,7 @@ extern const struct file_operations pidfd_fops; > struct file; > > extern struct pid *pidfd_pid(const struct file *file); > +struct pid *pidfd_get_pid(unsigned int fd); > > static inline struct pid *get_pid(struct pid *pid) > { > diff --git a/kernel/exit.c b/kernel/exit.c > index 0b81b26a872a..43375f9d8bbc 100644 > --- a/kernel/exit.c > +++ b/kernel/exit.c > @@ -1470,23 +1470,6 @@ static long do_wait(struct wait_opts *wo) > return retval; > } > > -static struct pid *pidfd_get_pid(unsigned int fd) > -{ > - struct fd f; > - struct pid *pid; > - > - f = fdget(fd); > - if (!f.file) > - return ERR_PTR(-EBADF); > - > - pid = pidfd_pid(f.file); > - if (!IS_ERR(pid)) > - get_pid(pid); > - > - fdput(f); > - return pid; > -} > - > static long kernel_waitid(int which, pid_t upid, struct waitid_info *infop, > int options, struct rusage *ru) > { > diff --git a/kernel/pid.c b/kernel/pid.c > index 0f4ecb57214c..360ba480a2a9 100644 > --- a/kernel/pid.c > +++ b/kernel/pid.c > @@ -496,6 +496,23 @@ struct pid *find_ge_pid(int nr, struct pid_namespace *ns) > return idr_get_next(&ns->idr, &nr); > } > > +struct pid *pidfd_get_pid(unsigned int fd) > +{ > + struct fd f; > + struct pid *pid; > + > + f = fdget(fd); > + if (!f.file) > + return ERR_PTR(-EBADF); > + > + pid = pidfd_pid(f.file); > + if (!IS_ERR(pid)) > + get_pid(pid); > + > + fdput(f); > + return pid; > +} > + > /** > * pidfd_create() - Create a new pid file descriptor. > * > -- > 2.25.0.265.gbab2e86ba0-goog > Reviewed-by: Suren Baghdasaryan