From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88E5DC47077 for ; Thu, 11 Jan 2024 23:23:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFF466B008C; Thu, 11 Jan 2024 18:23:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AAF706B0092; Thu, 11 Jan 2024 18:23:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 976806B0095; Thu, 11 Jan 2024 18:23:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8506D6B008C for ; Thu, 11 Jan 2024 18:23:42 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 48FB6140BB2 for ; Thu, 11 Jan 2024 23:23:42 +0000 (UTC) X-FDA: 81668609484.04.2E61728 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) by imf10.hostedemail.com (Postfix) with ESMTP id 82694C0009 for ; Thu, 11 Jan 2024 23:23:40 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=o7paqTQY; spf=pass (imf10.hostedemail.com: domain of surenb@google.com designates 209.85.128.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705015420; a=rsa-sha256; cv=none; b=RvQ2OkgDi0+Pth6jn67GBTUAu5aMghvIL9od6evhaSpwY9ubetAN640MOKGYMjwHrACr3q /UGOZmkmjBi9B5i0fSaJEZAx5YIukAXJLWXnnHjGB/mAdKB6vtDdMGS5QgR1B2ngPcLNUs w4hGhy6a6xfczS7USp3mnh6sP4947CU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=o7paqTQY; spf=pass (imf10.hostedemail.com: domain of surenb@google.com designates 209.85.128.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705015420; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M/2c/q3CBvBFI+OFez7rYBbZUMG36kUjDthdO2cC1Iw=; b=xzQn4xkM1sMv8phog4JEdRzPaegc4gJUh+K3gB9WeE3LHLs99jP0XcMOgUpCFOj2BZp2b1 B4bl+wlXxU3oUuXVrWDUQV4NKQAFY/eaigQ1aam3IHDWNbgYpATYKeebJ2ZqRp7XWYPyhn gYBJNQAZuQU791K1IWVESTftdkg4Fno= Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-5efb0e180f0so61673427b3.1 for ; Thu, 11 Jan 2024 15:23:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1705015419; x=1705620219; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=M/2c/q3CBvBFI+OFez7rYBbZUMG36kUjDthdO2cC1Iw=; b=o7paqTQYVRHKW9fe25NZJQYUSzKQShO3BX+fbSljipGNiIU1AfA0OTBlcNw1gUlnG8 fCieq9UPwP5ra/tTGEzwF7mpqw2erXL1gm6PjEYP8+RX17gF5QUCABevMvfU2mvbv+Jr wUaDgUoyIawpGdCxyErUR+obnXNPUvYxmKi80FLngC8Dbj0D+Dlg7lAgr104mLXsQ4LY EPyitRqqwDlyjY5S3OZoZMQj7icp7xg9/DCarkQsrc5V7FWWcenF8dcsh5Ezzka3F+KR vhkFNITzPG56Rt4pMzyfROm7U7sgVNMQdurRz7khEH8yk/NqIYohX1Vp2+p8PiYP5m4g ZL9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705015419; x=1705620219; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M/2c/q3CBvBFI+OFez7rYBbZUMG36kUjDthdO2cC1Iw=; b=PldzKVmwgWq1mhRHJuPbRSfoD+C+rSj/RAmENpP1wQKOYh+okB5TI/5EFbIaIBAofg OMK/VQWHbnY8Bd6pUtBvLQYz3F3WvsR9KmLOKRUuVsjdtbFhI0f3uNc3RKYtb4mdEb3X hCzvS79LQArH4O/FpYDbe0m5cMenDmRTjqkVrYQG2pIaeZl6ipPBdOiuy1VT68lpRCS5 HjWbzKjux7PvUUMdJHQOS70hZ/ocBJp3tyux7OFdF241VYYhV3qv7PHDg9Cd5G5EsX+Z qwykOBNVmSlJx1/DcKCmiBuGHcT0AVQWyS/5zzt5ottYkip9CXaCqJbrQ92+id42RRlN AHlw== X-Gm-Message-State: AOJu0YysHtlOdJPkXaKNn5/kTGylfVBcnL9sq56zONUBrWbbIC8hey6t dTQhc4Y+c2BTKy8MqIN/f+TvDv0u2Dr6LVq/9z8Z2GRAm69b X-Google-Smtp-Source: AGHT+IFW049Ciaek6MLXkM6yns9ULFYBY0oYlSBwi9vJA/vwZqYKUccputGMMZPW4gdxCl8JracxooyfmSYw/4xLKO8= X-Received: by 2002:a0d:eb96:0:b0:5fb:503:7f40 with SMTP id u144-20020a0deb96000000b005fb05037f40mr639128ywe.3.1705015419321; Thu, 11 Jan 2024 15:23:39 -0800 (PST) MIME-Version: 1.0 References: <00000000000011d709060eadffd3@google.com> <5ed23cf3-eedd-44aa-a498-d2a9ab046535@redhat.com> <15ce90cd-ff0b-4bc3-bee4-880bee3200ae@redhat.com> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 11 Jan 2024 23:23:27 +0000 Message-ID: Subject: Re: [syzbot] [mm?] kernel BUG in move_pages To: David Hildenbrand Cc: syzbot , Peter Xu , aarcange@redhat.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 82694C0009 X-Stat-Signature: ynqbg14tspusxqwusy3u67ph76eyx43n X-Rspam-User: X-HE-Tag: 1705015420-995308 X-HE-Meta: U2FsdGVkX1+GEuP7q+3bk///0/1F28Zzi2asNpgHc4anr6CgXArry6wwPiIGPrl7m5yvrPsjyIm0aZnsGejmNBZIN1Zieem1szdJoyrbPa3eL9bycoQGlVF3HFKm6OOVlbnKM7ZNmevaJ6y2VfzYgd8dV8aNKJcQa29jmusHSwBbjtzC5S0DOkUrR/oVEUzbIgcqDLXk1ib3tsCADGPh9S4j2/WnvU+WQADRUn7GmseWrkEZO2vp16ffCRNFPN1kOMIgcapbxtjNHsVCzJqRhy/xagB5u4Rs5Cpu454aOVY+9HJ6JGRpK2TZYVInO9TjvlghjxgUea5UBoGmrFoK9Oyo4WNqKxSeDnufQvQU92wvcPwNLKVOvuxXF+eFs4oFYUlr9wEm5QFXbmNgKaF4mvbsqLHjFMRQrE9PF0gaCqrax+fXRsHu2TwNS97jYyaD8repjvvBUXNvqHPECRPMI0GC1XupZ/DTPUelI+x7FUi0crIlaWhCZ9rN035Jv+9KBmmw2ltvsfiXNbgrf57NkbW1u68xQEMUYML+Ld9g74Zlg1LlwWRHn+sUCsGE1fuvN55vA2M5/cSNg0foYHcSTQrtVnNJtOcwm55shyRQPokqBesDEwMNO7m20355s7atBbhDYDIR7Av0golQz/QY3FlezjvkX++V/oN0yvnmlKnBq4HxUXm+zVLgPSRQ7dkTLZw5W5u9zqwKPmjbkUXOE9WKT4aWDcrG0nWlPFR2FtmLth8L3Qsy5PcQKsWp+dM3vxTYdq0qAGh7UPsaJvHMFL/cyUPbRpJmPhKGKMybXBQgJJG/X5+u5L/iTz6K1FdXDqw3ME413HQnAupFLWc0X1O9Zr1ZxS4Lal+bb1Qr71O5y/zyZROIf0HPQQYqIhLqNjZbmdzlrkSFASxZLkTYmc+Ar+A2ebKMDnqDj302QZTLwPe7iGRqsRQODwKjZvbKbdY6FuMcvO7r93BH4+Z dfBYytGa /Oa6LLTflO16efxl06eKTRkr1lqp8+/Gp7lmviG/gVPFfiP/mxdotFEc9TVAP/iqwfbEs65G1BQhG9pI/KVLz/+XokgkHsoyNjsIoRZwGmxAYU/KauiLEvlXxzQTQuogEV6vMKvZ1YVS9I3vjS99hcd4YwWkzGBCuBYLKDTm19bYZlqpy1CwlafTsVOycYnOQGTTXY/kxOsaCF3t3YC4/4f6Z45pCvuiXxBGLI796EYGLiAVxMqQfej5icJceEBqy6R1Exodd6j+pit0ZujY427sBZEUtGReCw1i+2sSfhlyQ/XlVetEz4skxmbKD2ShaPl6t0UAahJKpfdjHJ8rqqzikm3QlUBh+jza+//v23zDZbIrw/LWN+2uEFpSFhPFgnGVBu7T7WqsOMM5jNCNyXJRvqLspVLSDNyiDHxtG+9gB6QFM7Uo0bxRgeMKwvyKs9O0AewY2ChGxcP6e9Omfh/trLmvEUdpx/4tu8HH1QElrNzRQpxD36Gl66Vw98wxsW8eRTiF6RkNEgUg2OrDcd8aE6E+8kCuJp2QwRKsSQzRSAfxiK6p0E2X2K/2xM3NKyOJmZ1eYUdFwHVZQ3VAs6QNMrPBbryTZJbpJ/pnKfToWopPSJ1Pr1R6h+BPmIIgFdOXrwKeTxIX6jjOHBRFDI2RT+vadCEHGzOZb3CtPUvb40/YnXbmxAo1OIXAUbKR3X0ZE9bViJWTH+fJEtZFBUi/OR/NtTbJtvOohhmfPfHgzLrbWaQtv1MN/gzCnYZpRreGHn2+/LzzhsSikXU57ZIgyW60RY9RO2DyXCVYSW771l+dt3d5muAFhw/SRhZFjGFpTSn+7a+Yq2OzdSglcjgwY4IFwaFw+g+jZHnVUph5H+C7AyX2jLJm83IVmXNAU2CJBhVLfqjQ6uhc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 11, 2024 at 9:13=E2=80=AFPM Suren Baghdasaryan wrote: > > On Thu, Jan 11, 2024 at 1:06=E2=80=AFPM David Hildenbrand wrote: > > > > On 11.01.24 22:04, Suren Baghdasaryan wrote: > > > On Thu, Jan 11, 2024 at 9:00=E2=80=AFPM David Hildenbrand wrote: > > >> > > >> On 11.01.24 21:20, Suren Baghdasaryan wrote: > > >>> On Thu, Jan 11, 2024 at 6:58=E2=80=AFPM David Hildenbrand wrote: > > >>>> > > >>>> On 11.01.24 19:34, Suren Baghdasaryan wrote: > > >>>>> On Thu, Jan 11, 2024 at 8:44=E2=80=AFAM Suren Baghdasaryan wrote: > > >>>>>> > > >>>>>> On Thu, Jan 11, 2024 at 8:40=E2=80=AFAM Suren Baghdasaryan wrote: > > >>>>>>> > > >>>>>>> On Thu, Jan 11, 2024 at 8:25=E2=80=AFAM syzbot > > >>>>>>> wrote: > > >>>>>>>> > > >>>>>>>> Hello, > > >>>>>>>> > > >>>>>>>> syzbot found the following issue on: > > >>>>>>>> > > >>>>>>>> HEAD commit: e2425464bc87 Add linux-next specific files for= 20240105 > > >>>>>>>> git tree: linux-next > > >>>>>>>> console+strace: https://syzkaller.appspot.com/x/log.txt?x=3D14= 941cdee80000 > > >>>>>>>> kernel config: https://syzkaller.appspot.com/x/.config?x=3D40= 56b9349f3da8c9 > > >>>>>>>> dashboard link: https://syzkaller.appspot.com/bug?extid=3D7052= 09281e36404998f6 > > >>>>>>>> compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Bin= utils for Debian) 2.40 > > >>>>>>>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=3D= 125d0a09e80000 > > >>>>>>>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=3D15= bc7331e80000 > > >>>>>>>> > > >>>>>>>> Downloadable assets: > > >>>>>>>> disk image: https://storage.googleapis.com/syzbot-assets/2f738= 185e2cf/disk-e2425464.raw.xz > > >>>>>>>> vmlinux: https://storage.googleapis.com/syzbot-assets/b248fcf4= ea46/vmlinux-e2425464.xz > > >>>>>>>> kernel image: https://storage.googleapis.com/syzbot-assets/a99= 45c8223f4/bzImage-e2425464.xz > > >>>>>>>> > > >>>>>>>> The issue was bisected to: > > >>>>>>>> > > >>>>>>>> commit adef440691bab824e39c1b17382322d195e1fab0 > > >>>>>>>> Author: Andrea Arcangeli > > >>>>>>>> Date: Wed Dec 6 10:36:56 2023 +0000 > > >>>>>>>> > > >>>>>>>> userfaultfd: UFFDIO_MOVE uABI > > >>>>>>>> > > >>>>>>>> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x= =3D11cb6ea9e80000 > > >>>>>>>> final oops: https://syzkaller.appspot.com/x/report.txt?x= =3D13cb6ea9e80000 > > >>>>>>>> console output: https://syzkaller.appspot.com/x/log.txt?x=3D15= cb6ea9e80000 > > >>>>>>>> > > >>>>>>>> IMPORTANT: if you fix the issue, please add the following tag = to the commit: > > >>>>>>>> Reported-by: syzbot+705209281e36404998f6@syzkaller.appspotmail= .com > > >>>>>>>> Fixes: adef440691ba ("userfaultfd: UFFDIO_MOVE uABI") > > >>>>>>>> > > >>>>>>>> do_one_initcall+0x128/0x680 init/main.c:1237 > > >>>>>>>> do_initcall_level init/main.c:1299 [inline] > > >>>>>>>> do_initcalls init/main.c:1315 [inline] > > >>>>>>>> do_basic_setup init/main.c:1334 [inline] > > >>>>>>>> kernel_init_freeable+0x692/0xc30 init/main.c:1552 > > >>>>>>>> kernel_init+0x1c/0x2a0 init/main.c:1442 > > >>>>>>>> ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:147 > > >>>>>>>> ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:242 > > >>>>>>>> ------------[ cut here ]------------ > > >>>>>>>> kernel BUG at include/linux/page-flags.h:1035! > > >>>>>>>> invalid opcode: 0000 [#1] PREEMPT SMP KASAN > > >>>>>>>> CPU: 0 PID: 5068 Comm: syz-executor191 Not tainted 6.7.0-rc8-n= ext-20240105-syzkaller #0 > > >>>>>>>> Hardware name: Google Google Compute Engine/Google Compute Eng= ine, BIOS Google 11/17/2023 > > >>>>>>>> RIP: 0010:PageAnonExclusive include/linux/page-flags.h:1035 [i= nline] > > >>>>>>> > > >>>>>>> From a quick look, I think the new ioctl is being used again= st a > > >>>>>>> file-backed page and that's why PageAnonExclusive() throws this= error. > > >>>>>>> I'll confirm if this is indeed the case and will add checks for= that > > >>>>>>> case. Thanks! > > >>>>>> > > >>>>>> Hmm. Looking at the reproducer it does not look like a file-back= ed > > >>>>>> memory... Anyways, I'm on it. > > >>>>> > > >>>>> Looks like the test is trying to move the huge_zero_page. Wonder = how > > >>>>> we should handle this. Just fail or do something else? Adding Dav= id > > >>>>> and Peter for feedback. > > >>>> > > >>>> You'll need some special-casing to handle that. But it should be f= airly > > >>>> easy. > > >>> > > >>> Ok, so should we treat zeropage the same as PAE and map destination > > >>> PTE/PMD to zeropage while clearing source PTE/PMD? > > >> > > >> Likely yes. So it's transparent for user space what we are moving. (= this > > >> sounds like an easy case to not require a prior write access just to > > >> move it) > > > > > > Ok, working on it. split_huge_pmd() already knows how to split > > > huge_zero_page but I think I'll need special handling in both > > > move_pages_pte() and move_pages_huge_pmd(). > > > > A PTE-mapped huge zeropage is just a page table populated with the > > ordinary shared zeropage. Are you moving the ordinary shared zeropage a= s > > well? If not, you should do so for consistency (or not do either :) ). > > Yes, I think I should move ordinary zeropages as well. I have a version that seems to work but I want to test it more and it's too heavy to be considered a quick fix for linux-next. I'll post a simple one-line fix which takes care of this crash and keeps the behavior for zeropages the same (ioctl returns -EBUSY). Later will post a separate patch to move huge and ordinary zeropages. > > > > > -- > > Cheers, > > > > David / dhildenb > >