From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3901C433F5 for ; Wed, 10 Nov 2021 17:48:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4568761159 for ; Wed, 10 Nov 2021 17:48:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4568761159 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 86CB46B006C; Wed, 10 Nov 2021 12:48:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 81CF16B0071; Wed, 10 Nov 2021 12:48:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70AAF6B0072; Wed, 10 Nov 2021 12:48:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0046.hostedemail.com [216.40.44.46]) by kanga.kvack.org (Postfix) with ESMTP id 5D4526B006C for ; Wed, 10 Nov 2021 12:48:24 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1B1391834C115 for ; Wed, 10 Nov 2021 17:48:24 +0000 (UTC) X-FDA: 78793754928.25.FCC57BB Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by imf11.hostedemail.com (Postfix) with ESMTP id B0E18F00020D for ; Wed, 10 Nov 2021 17:48:23 +0000 (UTC) Received: by mail-yb1-f177.google.com with SMTP id u60so8418488ybi.9 for ; Wed, 10 Nov 2021 09:48:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kNHVVa6gv7z3dFlgEcituEPBx6aIWi4uliGKTG3gzjI=; b=qLmXdLt4YOVMgrzsS5BXEUYiJevmzqMjguHecWqoDcWTEsy74/p4NvsXb/LRZFkqGJ KhCWxNDSNHskY6KB2iMjRPfe5Y3fqFyPGxIytmN+X0UAayfYz6lOPXpDfqtRvdGdHmzi FtF0aZ5WCHIP3ioTdmDGtdqhYagHRZjSY8+p0rMVnVsMSfymyS/fXWqdGZnsf42PNfgE mNQw8LAQCVeiTEquV2CIvo9/bLSPNT0zxilW25HhKQu21qKwI/DTvxEWCzOQidlHTyY3 RL5T2R6A2hNmaBfGnO3ZDvB7UGeuWCeqOy7HkG1FKg7y+9C69m7/xZJGTyPrdXquocIS NFIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kNHVVa6gv7z3dFlgEcituEPBx6aIWi4uliGKTG3gzjI=; b=2gJ3RTZNBt7ap1n1Cy9y9ViqfVHyHJ7lYvFc3ivop6AC0mODPx8XE2RxiK0QAeE4ZY OoKQfbkVha0n5kEbyqUgoqRRfxZDUyZ62IS4FGAw7ApALxgazHapqhohZcvUqFkP2NZ7 KxWDPjclDfRGTvL+oubZ2M/e6tAthTed6v8MYVd3ilEVlORq+wsOMrN8S41nYIrS/sDR UJCWrRDaEmug5xe2sQVap0oF7eh61G4lxh87ze9+vOHt/xsfDLS5rBzi13EiFGi3McXu EOZ10skphofLHjTITDZi+MFZi0ptvWNoI5dCUaUl92kIv4up+a48VEzJ/hJiuaH+F/qp cgQg== X-Gm-Message-State: AOAM531QTSTfDnjcaT+ZyOqGoadNSfFMYlB1eAn1E5y+b7HpLqlY//kK vJACComyyGVLLAf9EdHbKN+2nSmnO1wq8lLQpEruZw== X-Google-Smtp-Source: ABdhPJzrykT3dyEuXyJOwpTgNgF1rS/2Zem47Hc09Yaees7H87Arp4lp7y5GOAaNmY0j3HE0mpPOPMhKiENFNoOsu3w= X-Received: by 2002:a25:2f58:: with SMTP id v85mr1047967ybv.487.1636566502780; Wed, 10 Nov 2021 09:48:22 -0800 (PST) MIME-Version: 1.0 References: <1636558597-248294-1-git-send-email-quic_c_gdjako@quicinc.com> <20211110161402.GB174703@worktop.programming.kicks-ass.net> <1fd2d97b-7c83-3a82-ada3-46ec5025c3b1@kernel.org> In-Reply-To: <1fd2d97b-7c83-3a82-ada3-46ec5025c3b1@kernel.org> From: Suren Baghdasaryan Date: Wed, 10 Nov 2021 09:48:10 -0800 Message-ID: Subject: Re: [RFC] psi: Add additional PSI counters for each type of memory pressure To: Georgi Djakov Cc: Peter Zijlstra , Georgi Djakov , hannes@cmpxchg.org, vincent.guittot@linaro.org, juri.lelli@redhat.com, mingo@redhat.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, mhocko@kernel.org, vdavydov.dev@gmail.com, tj@kernel.org, axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B0E18F00020D X-Stat-Signature: wu3t1f8hih5qcwh4z189gdwini38cdg8 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=qLmXdLt4; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of surenb@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=surenb@google.com X-HE-Tag: 1636566503-498532 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 10, 2021 at 8:46 AM Georgi Djakov wrote: > > > On 10.11.21 18:14, Peter Zijlstra wrote: > > On Wed, Nov 10, 2021 at 07:36:37AM -0800, Georgi Djakov wrote: > >> @@ -21,7 +19,18 @@ enum psi_task_count { > >> * don't have to special case any state tracking for it. > >> */ > >> NR_ONCPU, > >> - NR_PSI_TASK_COUNTS = 4, > >> + NR_BLK_CGROUP_THROTTLE, > >> + NR_BIO, > >> + NR_COMPACTION, > >> + NR_THRASHING, > >> + NR_CGROUP_RECLAIM_HIGH, > >> + NR_CGROUP_RECLAIM_HIGH_SLEEP, > >> + NR_CGROUP_TRY_CHARGE, > >> + NR_DIRECT_COMPACTION, > >> + NR_DIRECT_RECLAIM, > >> + NR_READ_SWAPPAGE, > >> + NR_KSWAPD, > >> + NR_PSI_TASK_COUNTS = 16, > >> }; > >> > > > >> @@ -51,9 +80,20 @@ enum psi_states { > >> PSI_MEM_FULL, > >> PSI_CPU_SOME, > >> PSI_CPU_FULL, > >> + PSI_BLK_CGROUP_THROTTLE, > >> + PSI_BIO, > >> + PSI_COMPACTION, > >> + PSI_THRASHING, > >> + PSI_CGROUP_RECLAIM_HIGH, > >> + PSI_CGROUP_RECLAIM_HIGH_SLEEP, > >> + PSI_CGROUP_TRY_CHARGE, > >> + PSI_DIRECT_COMPACTION, > >> + PSI_DIRECT_RECLAIM, > >> + PSI_READ_SWAPPAGE, > >> + PSI_KSWAPD, > >> /* Only per-CPU, to weigh the CPU in the global average: */ > >> PSI_NONIDLE, > >> - NR_PSI_STATES = 7, > >> + NR_PSI_STATES = 18, > >> }; > > > > Have you considered what this does to psi_group_cpu's size and layout > > and the impact thereof on performance? > > Thanks, i will definitely add some numbers in case there are no other > major arguments against this RFC patch. Please CC me too in the future postings. Thanks, Suren. > > BR, > Georgi >