From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25EB2C4320E for ; Mon, 9 Aug 2021 18:56:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D350961056 for ; Mon, 9 Aug 2021 18:56:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D350961056 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3E16F6B0071; Mon, 9 Aug 2021 14:56:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3917E6B0072; Mon, 9 Aug 2021 14:56:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 259606B0073; Mon, 9 Aug 2021 14:56:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id 0C1486B0071 for ; Mon, 9 Aug 2021 14:56:41 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id ACD541812C28D for ; Mon, 9 Aug 2021 18:56:40 +0000 (UTC) X-FDA: 78456448560.08.3603507 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf13.hostedemail.com (Postfix) with ESMTP id 5D41C1011D7E for ; Mon, 9 Aug 2021 18:56:40 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id pj14-20020a17090b4f4eb029017786cf98f9so1430308pjb.2 for ; Mon, 09 Aug 2021 11:56:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rZnS5Yg8Ungl0NoSfe0iR6+HFsdNXlz+2LHGqQJxvwo=; b=bwoE5zejhZCxyq+WyMKCe4nXWa5tO89iRvDhnlFHiCRzHi8k4EyOEpcvSOKWw8ui9t IOHeyYKndJnQwJhk7IkL6+dil9dvBZ9jKtZyMkUuKUjgVpkbJOFjWytz+vBp5EeOp0FA vzHcolzrdP/9CjzGPAY0oGu72yGbpfm5Gn6h55tOlldPTsuV6BMlA/irMvUnQ+aqQoZW 0p72/A/xm7ZYKBiyli/ctS30ECBO4FD/LfeDjwoC7UiBeiQa750HX3UeQkFPAN0FN5ZF 9rys4gNBkRwSxpR/fOIawV5651K6f7jV/G+lZfpaVJxlSTDfyFbSV0i5Yq1DqG5PgxOe JL0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rZnS5Yg8Ungl0NoSfe0iR6+HFsdNXlz+2LHGqQJxvwo=; b=nCPeMRmYd7mGakHtcC4KKiWbmkcO3FJ5iSi5f9UmsfoU6Fi8LWGd9wu0EZ0bkRibeE t+VOzaWqThNN95YI6sNlv/7Hzjl6YqrWluJTNVT4x8og4p0HSkHk+9YcSzpYG0I25TxC a61+w5TYv5hLflqPF15FFNvXxzUe5zPmlBVSkfWkXJXYZNA26xFn+jU0IZm18HvU4SbW a70IjEfC0SOzn4DZZbod634rMhDfU4PBmD2rxnjBc+tjZC+ukSabUJTe1xUyfiTsyjxo 9TqGUwHj/QYmXuzPqOKqZBD2pc2hd5ZB+Ogrs1xoYRi7eHF+E5nCvvdyyaNW4zTh0lQf gy6A== X-Gm-Message-State: AOAM532Fhdds1ZQwNUAIQSwACama72/nntfE2IDy5hJcSJVIJ2/MzLZg c7SS307OXnCjPSN1S8L59kit3TDSGqj1JBj8WcVKxQ== X-Google-Smtp-Source: ABdhPJxjaqkLW6MmJ+c8T9DwC9JWTtlsFJVi3w9OFPIZvA0UgCpNZOngvNOAK/gUwWSpb8bAkZyYtzuh0uESzMCUs3g= X-Received: by 2002:a63:f342:: with SMTP id t2mr465315pgj.45.1628535398993; Mon, 09 Aug 2021 11:56:38 -0700 (PDT) MIME-Version: 1.0 References: <20210808160823.3553954-1-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 9 Aug 2021 11:56:28 -0700 Message-ID: Subject: Re: [PATCH v8 1/2] mm: introduce process_mrelease system call To: Shakeel Butt Cc: Andrew Morton , Michal Hocko , Michal Hocko , David Rientjes , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Christoph Hellwig , Oleg Nesterov , David Hildenbrand , Jann Horn , Andy Lutomirski , Christian Brauner , Florian Weimer , Jan Engelhardt , Tim Murray , Linux API , Linux MM , LKML , kernel-team Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5D41C1011D7E Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=bwoE5zej; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of surenb@google.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=surenb@google.com X-Stat-Signature: gmfsg8x7uoutjd6um6rrhkrmu1gi3qnj X-HE-Tag: 1628535400-221620 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 9, 2021 at 9:23 AM Suren Baghdasaryan wrote: > > On Mon, Aug 9, 2021 at 8:23 AM Shakeel Butt wrote: > > > > On Sun, Aug 8, 2021 at 9:08 AM Suren Baghdasaryan wrote: > > > > > > In modern systems it's not unusual to have a system component monitoring > > > memory conditions of the system and tasked with keeping system memory > > > pressure under control. One way to accomplish that is to kill > > > non-essential processes to free up memory for more important ones. > > > Examples of this are Facebook's OOM killer daemon called oomd and > > > Android's low memory killer daemon called lmkd. > > > For such system component it's important to be able to free memory > > > quickly and efficiently. Unfortunately the time process takes to free > > > up its memory after receiving a SIGKILL might vary based on the state > > > of the process (uninterruptible sleep), size and OPP level of the core > > > the process is running. A mechanism to free resources of the target > > > process in a more predictable way would improve system's ability to > > > control its memory pressure. > > > Introduce process_mrelease system call that releases memory of a dying > > > process from the context of the caller. This way the memory is freed in > > > a more controllable way with CPU affinity and priority of the caller. > > > The workload of freeing the memory will also be charged to the caller. > > > The operation is allowed only on a dying process. > > > > > > After previous discussions [1, 2, 3] the decision was made [4] to introduce > > > a dedicated system call to cover this use case. > > > > > > The API is as follows, > > > > > > int process_mrelease(int pidfd, unsigned int flags); > > > > > > DESCRIPTION > > > The process_mrelease() system call is used to free the memory of > > > an exiting process. > > > > > > The pidfd selects the process referred to by the PID file > > > descriptor. > > > (See pidfd_open(2) for further information) > > > > > > The flags argument is reserved for future use; currently, this > > > argument must be specified as 0. > > > > > > RETURN VALUE > > > On success, process_mrelease() returns 0. On error, -1 is > > > returned and errno is set to indicate the error. > > > > > > ERRORS > > > EBADF pidfd is not a valid PID file descriptor. > > > > > > EAGAIN Failed to release part of the address space. > > > > > > EINTR The call was interrupted by a signal; see signal(7). > > > > > > EINVAL flags is not 0. > > > > > > EINVAL The memory of the task cannot be released because the > > > process is not exiting, the address space is shared > > > with another live process or there is a core dump in > > > progress. > > > > > > ENOSYS This system call is not supported, for example, without > > > MMU support built into Linux. > > > > > > ESRCH The target process does not exist (i.e., it has terminated > > > and been waited on). > > > > > > [1] https://lore.kernel.org/lkml/20190411014353.113252-3-surenb@google.com/ > > > [2] https://lore.kernel.org/linux-api/20201113173448.1863419-1-surenb@google.com/ > > > [3] https://lore.kernel.org/linux-api/20201124053943.1684874-3-surenb@google.com/ > > > [4] https://lore.kernel.org/linux-api/20201223075712.GA4719@lst.de/ > > > > > > Signed-off-by: Suren Baghdasaryan > > > > Reviewed-by: Shakeel Butt > > Thanks folks! I'll make the change Christian suggested and will push > the next version carrying Acks along, including the one from David > which I forgot to carry in this one. v9 posted at: https://lore.kernel.org/linux-mm/20210809185259.405936-1-surenb@google.com