From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27CB3E77197 for ; Tue, 7 Jan 2025 18:57:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3B186B0089; Tue, 7 Jan 2025 13:57:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AEA956B0093; Tue, 7 Jan 2025 13:57:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B2C66B0096; Tue, 7 Jan 2025 13:57:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7B5546B0089 for ; Tue, 7 Jan 2025 13:57:52 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2B328C0BB5 for ; Tue, 7 Jan 2025 18:57:52 +0000 (UTC) X-FDA: 82981565184.12.EB7CD0D Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf17.hostedemail.com (Postfix) with ESMTP id 60B4740006 for ; Tue, 7 Jan 2025 18:57:50 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ozSuhuON; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736276270; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5SKBIPKKQgLIfLRfxxGHc6EYpdKJ7CBBxCscjczO2DE=; b=nadLl+rxMEEpWEvmIlngioiLzMYspLNHYaH9ipBybyJ2sKBlqVxnhq3zlnjf/wMi3fI24R wmXZnZLDGB0OGKSZChhm5XJiQNovD34pAxNSJ5juZwZUfN96yYYQQPMpEgudGRuSH60eO5 hucA2X89uQ0LY03fRJspMvCguKNWWX8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ozSuhuON; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736276270; a=rsa-sha256; cv=none; b=W4nhf3/chv/PjnjNxmfUjAYfgB/f4P7mP3HaZtMY4GLVamSscQmNm3ru0VxONaIijTnSs0 vcO4xDiV0jx319uKo3cdfqC1g8CgslWywCg1Um++z8jWLpCswssITuUrujGr8JtfRirMPk ds1ksHBj6wBXMp/xgbwdIInJ0wqePBs= Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4679b5c66d0so21621cf.1 for ; Tue, 07 Jan 2025 10:57:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736276269; x=1736881069; darn=kvack.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5SKBIPKKQgLIfLRfxxGHc6EYpdKJ7CBBxCscjczO2DE=; b=ozSuhuONRx8BlQDPGW6rTxFVvtg5J1vHyRQ///LEFV+6BY3AP4jVYtFC7ePb+2OU77 IS9FlIrHAKIM3PEncGcQciy7wNhqJKbm3yCCjBgf4UXRyhWxfxhnl2cJXlaEhSgjqSkG URH5tfCjzKRqb56cFg0IIjdVIBWzJ4hdXK0EF+bm6INvof+g5e9rw9BZfI6xazfUJr1s c4TUT69mVv8JtOoWjR1AdJ+C1PR+VhmHF0CUlO9vrGatg2q5y8r1MhpyNdOTMB5ClLw9 LPSHhddVxWK5IzXJ7eIvK617PIUJDxxWPQVqWF4ggLHGW6502dyX4Y34Ur4OIhb08bLY KMBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736276269; x=1736881069; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5SKBIPKKQgLIfLRfxxGHc6EYpdKJ7CBBxCscjczO2DE=; b=S4SYCYCQE2eMptvni+21c6wnTs0kHe4BPoA7Hq0o0knEHU4H7QmTLuv4Ozngckl91P ho5+G1WShsZRf6F/sSpEGQq5pWgol/tmvV0DNtNJ9pzPG4Z0ZS6PluFgP4Hn6NmABBaG wTfq3d8rbL6axp8vvuVFcuvtYALpwCmMSVtwwnwvMhrL6QUZCmtxoxP/G1fTnz2fZI+A cdIOvjpMjHHiq3VZ10jI5x/hOhFLH2sFuiS3YZQrSyRZgSnm+uWMJOPr9F45uPnblhOf kpbZhL5KexwnXH3yan3jICt3MX0ngIB5PsC2+zXLpniWiipnYmENEVGex/esKroViZPM WjLQ== X-Forwarded-Encrypted: i=1; AJvYcCUtImaxKoMj/qpELjjCCWMmUC/EUblvEp+KXziNzyV3OQ0ikUYuMwGgHGDgavIWqXzTs+I22chNvQ==@kvack.org X-Gm-Message-State: AOJu0YxfbTKbNqFoEuOYw4WhPz6jsZgBdar715mo+EH+5kd9acquqp3v 5aVGxqecDxha72hA5VLeH0aH72W5vVdzj8Ov69v9yjCBloyu4eUFXvJleOUZMwMedvPpIDVTVSY pM8aJYFOFwqgGaK9RdAUtidjyBBLFjG3Dv4SH X-Gm-Gg: ASbGncsnQ98a3L9hTNGACM4Fivb3RFrHkkqEcnlbQcJfcyuTASOGO+g0ssDSpiMSBxS XHowTIelGDtzdxluGoA/K5c7qwVFcLsD6rWTOaCVMUrktVtpA+zvpnc/4gj7lhl5AfSKV X-Google-Smtp-Source: AGHT+IGu4eKfRmNuFlGQoAQksrtyJ2U/WzguxcOe4y1M95GhtYiONOwbXdNo611kinV+njRzcew1cXndvH0WR4+7TSo= X-Received: by 2002:a05:622a:ca:b0:466:a3ed:bde7 with SMTP id d75a77b69052e-46c70bd562bmr47881cf.6.1736276269196; Tue, 07 Jan 2025 10:57:49 -0800 (PST) MIME-Version: 1.0 References: <20241226200335.1250078-1-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 7 Jan 2025 10:57:38 -0800 X-Gm-Features: AbW1kvbU2YZNkojjppL04xsN0Y5Tj7bZ5w4ozFnvPURcDIO56GPnHZgG4vWz0Qo Message-ID: Subject: Re: [PATCH 1/1] fixup for mm/debug: print vm_refcnt state when dumping the vma To: "Liam R. Howlett" , Suren Baghdasaryan , akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com, kernel test robot Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 60B4740006 X-Rspam-User: X-Stat-Signature: 7iotgjuzh1nch4enokjnitx8bxoref8q X-HE-Tag: 1736276270-930548 X-HE-Meta: U2FsdGVkX1/IxWDx2ljU5rHvMrWJANAE65mABHIKVhxAT6ZAh0IQCtPudXmQLxvWDaZPCxOWvdiKSXRT5TxxNZ+o2hdLnKpedn4EVI9aWKHBSAYh815SvvROXaFJzqBSDNNBZs+24mVOVmuBJ9RhzxDnFhk2QxNNLIJ1pInjAMJza8Nlaqxp4UW+zHuTVczGNMZcM+D5zLDiaDFIybAIS75m7nEhf4M4fn5235M95brIx8txaBIp3bHSIkLP8R5rizUAZRNhuAohiwBKuLfuJvzhNRD5v5XGBNozWvTZ8+1XQSkrKt8UKO6q9S+ToDAvTdiTue9hnRm5IJEY1WdIczepOQ6gkbAULx+vEnbWotcvTlSh1UxaGyjIhhq23erRV85x2dporQrGOR7WL1sLG6KX4MCrHkKB0umF6TpPnaNWdFD87hBhM9KCbrvsdoejDo4rWGGbDBtmADRSfvFQal93AOJPkbaqXS9j2eVrCftEeiwdhuDSOUVnvjA1RVGTmqM2lJ7bC/1iJIqMbjLjS8Zl5GFe2EemC3hzUkIK1UNeT5RpaUFIQxJQhnT6Nck0Qc9W2xUQKJZ29CRFs9FZMBBb7HHZ06Kw8kanFHsjFT1rn8ltxa8w39FuxFACvkwIhOndsF1s9n8UcPpGCVgGYsHbbji/hHkc/jYTVS7T9qm9QQ1Pgt4Na+lZZEayO7byKyCE4uNxciXgYd0Mc1HIBzb4KvJFTd3DvNSCdRXCcTVgcw5ZZVtYFqrr9BMVqe0vZBCMfQ9RMIN5fFJQKswK8G1v3TKgv7oEQvR1qTD/UonZljJnFobJT/0cGcqXOZ2n9CMSVk0U+X9V9ARKncCIuFdFwRJ+SfIFWeRQeB/YKuEw4tKfRlLyarhCpoNQPYepEgY1OuJi50P/tS85qZN3xzqfbdbQ33/+KqSuyG67D9aOd4q06PNxJqkecPnSDOesTmfytOlmGAh5Xkp6iKg SjHi37GU 9IXYnY08bLnwahJ1j11HxpKGFEvCCjtsr16sg8wIjz6saoIgMD1kPTa28W/BEkm2TkBx1IP9ibjXlQVaZ+3OuBd5WPPaS9CVB1TfrJen8IruAxW+dJctPPOIcCSgLGQ0f/rjYD7fnnE/4H/sKJwO9YYlv+BXAT52hVOVLZecocVwxrp8ftjNmnqMGu6xjTxMejlflTjvE4jaX2Zg+U1F6VHdqwYZAoQY2TCtLn0aANkskmrhBsScbh8JO7pI14HJw83nHRX5im0sEzKQ+gU/njJ+IN4splXEbXaZKCh+7u80aTbcGCxRbOnwM41UgPnK9ug+hMBwFQalmSFE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 7, 2025 at 10:50=E2=80=AFAM Liam R. Howlett wrote: > > * Suren Baghdasaryan [241226 15:03]: > > vma->vm_refcnt does not exist when CONFIG_PER_VMA_LOCK=3Dn, therefore > > when CONFIG_PER_VMA_LOCK=3Dn and CONFIG_DEBUG_VM=3Dy we need to avoid i= ts > > usage in dump_vma(). > > It might be worth having a function that decodes the information in the > vma lock and outputs a string that spells out what is going on, You mean something like "attached, 2 reader(s), 0 writer(s)" instead of "refcnt 0x3" ? > and > another that just outputs "not supported" or something. Do you mean we should report "not supported" when CONFIG_PER_VMA_LOCK=3Dn? > > This has the benefit of spelling out the state and only having one place > to update in future dump_vma() changes. > > > > > Reported-by: kernel test robot > > Closes: https://lore.kernel.org/oe-kbuild-all/202412270328.HiJX1mRt-lkp= @intel.com/ > > Signed-off-by: Suren Baghdasaryan > > --- > > Fixes https://lore.kernel.org/all/20241226170710.1159679-14-surenb@goog= le.com/ > > posted over mm-unstable. > > > > mm/debug.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/mm/debug.c b/mm/debug.c > > index 68b3ba3cf603..9c4cbc3733b0 100644 > > --- a/mm/debug.c > > +++ b/mm/debug.c > > @@ -178,6 +178,7 @@ EXPORT_SYMBOL(dump_page); > > > > void dump_vma(const struct vm_area_struct *vma) > > { > > +#ifdef CONFIG_PER_VMA_LOCK > > pr_emerg("vma %px start %px end %px mm %px\n" > > "prot %lx anon_vma %px vm_ops %px\n" > > "pgoff %lx file %px private_data %px\n" > > @@ -187,6 +188,17 @@ void dump_vma(const struct vm_area_struct *vma) > > vma->anon_vma, vma->vm_ops, vma->vm_pgoff, > > vma->vm_file, vma->vm_private_data, > > vma->vm_flags, &vma->vm_flags, refcount_read(&vma->vm_ref= cnt)); > > +#else > > + pr_emerg("vma %px start %px end %px mm %px\n" > > + "prot %lx anon_vma %px vm_ops %px\n" > > + "pgoff %lx file %px private_data %px\n" > > + "flags: %#lx(%pGv)\n", > > + vma, (void *)vma->vm_start, (void *)vma->vm_end, vma->vm_= mm, > > + (unsigned long)pgprot_val(vma->vm_page_prot), > > + vma->anon_vma, vma->vm_ops, vma->vm_pgoff, > > + vma->vm_file, vma->vm_private_data, > > + vma->vm_flags, &vma->vm_flags); > > +#endif > > } > > EXPORT_SYMBOL(dump_vma); > > > > -- > > 2.47.1.613.gc27f4b7a9f-goog > >