From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA9A1C433E1 for ; Thu, 20 Aug 2020 16:47:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8D12F2072D for ; Thu, 20 Aug 2020 16:47:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Crs/WMRP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D12F2072D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 204A18D0035; Thu, 20 Aug 2020 12:47:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B5048D0002; Thu, 20 Aug 2020 12:47:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A4BE8D0035; Thu, 20 Aug 2020 12:47:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0020.hostedemail.com [216.40.44.20]) by kanga.kvack.org (Postfix) with ESMTP id EA04C8D0002 for ; Thu, 20 Aug 2020 12:47:46 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3457B180AD801 for ; Thu, 20 Aug 2020 16:47:46 +0000 (UTC) X-FDA: 77171528532.13.lip12_2e0091c27032 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id F15F018140B60 for ; Thu, 20 Aug 2020 16:47:45 +0000 (UTC) X-HE-Tag: lip12_2e0091c27032 X-Filterd-Recvd-Size: 5137 Received: from mail-vs1-f67.google.com (mail-vs1-f67.google.com [209.85.217.67]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Thu, 20 Aug 2020 16:47:45 +0000 (UTC) Received: by mail-vs1-f67.google.com with SMTP id j188so1433370vsd.2 for ; Thu, 20 Aug 2020 09:47:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nFydOyAQ5fL3vfPVLLh49VOLqsGjFEw91D0MHzilX5M=; b=Crs/WMRP2fmy0A72/nAxgdRh1jfjB94SUBuYbmOq48ob45Uzpcdl5nhkDGqNm7qoA2 TD0b4DY5l/Qw+s+OnoFycCHQUiOIXwSqelSRQpHr1zh8EFDyT3vVeonqlctaneuaw88I oO2pgxaiumGK4NEBocYXkEPI1ZdXcSq/hos4GcXyz1FvH2fj44gjr6nA6FXGRfwKaDpU Dn8WFQDKrdztr09XqxuJP3F6OcosPKMDku0vSq0NBDKqKRiiiE5noOi4Pa3KZgpo5hWf J+unhSgn03KkLd+g1U+cyFBLi34TV4Ny1w1o7utrfI8/zFfa9dTq51x7FpHY6bUT5WB9 B4+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nFydOyAQ5fL3vfPVLLh49VOLqsGjFEw91D0MHzilX5M=; b=bhktFNn7vv7gs8xs2qY29wZXqSV3ncsQ1McySrB2as7oXLRncSijB5SBF42OLA++Z9 RMhF3L1KA7I9zrggTLTMxlrA8+Pn+PO+TqYu6z9+BjmhCP5zGBFYQ7CLnI3Ud58eakWz azCTa2yCUx+UK3wPfO+eT5Oi8gtwxHhg201X5PmmGGVdOamUwJ8KrAQMAA3Chl9uaCBv UoWbgY6Lkh8jz2GLxslUCSgWIzMZ2vVuqN3C43g2uqQfAp2mqUwRwx8jUysghrlnX0NH jSiI+QBROJWlCd0sQfsSfTUrdUCdUht37tQGwhDHoFHoPlPh2jKcSA6MyyN8qjuhr7Zj gK2g== X-Gm-Message-State: AOAM532OiPwQp5XVXTJpA7jAUj+cFDTrzOl3k4j+ynHHUnxzuwripZpB XLNPtEF3A1QXiXHUDb9bXaT3Nit5eJznVDfxh0skLg== X-Google-Smtp-Source: ABdhPJxnUe2uAAoTjmaHQnh8K/T2EFQWZBMt0JSgkurOi8fetLFAZM9cBXHIfYSIjsnKPiy6LTpMFgA9pyZPBi2FClM= X-Received: by 2002:a67:f30e:: with SMTP id p14mr2079034vsf.119.1597942064479; Thu, 20 Aug 2020 09:47:44 -0700 (PDT) MIME-Version: 1.0 References: <87lfi9xz7y.fsf@x220.int.ebiederm.org> <87d03lxysr.fsf@x220.int.ebiederm.org> <20200820132631.GK5033@dhcp22.suse.cz> <20200820133454.ch24kewh42ax4ebl@wittgenstein> <20200820140054.fdkbotd4tgfrqpe6@wittgenstein> <637ab0e7-e686-0c94-753b-b97d24bb8232@i-love.sakura.ne.jp> <87k0xtv0d4.fsf@x220.int.ebiederm.org> <20200820162645.GP5033@dhcp22.suse.cz> <20200820162927.s275qsr4lkwizutu@wittgenstein> In-Reply-To: <20200820162927.s275qsr4lkwizutu@wittgenstein> From: Suren Baghdasaryan Date: Thu, 20 Aug 2020 09:47:32 -0700 Message-ID: Subject: Re: [PATCH 1/1] mm, oom_adj: don't loop through tasks in __set_oom_adj when not necessary To: Christian Brauner Cc: Michal Hocko , "Eric W. Biederman" , Tetsuo Handa , Tim Murray , mingo@kernel.org, Peter Zijlstra , Thomas Gleixner , esyr@redhat.com, christian@kellner.me, areber@redhat.com, Shakeel Butt , cyphar@cyphar.com, Oleg Nesterov , adobriyan@gmail.com, Andrew Morton , gladkov.alexey@gmail.com, Michel Lespinasse , daniel.m.jordan@oracle.com, avagin@gmail.com, bernd.edlinger@hotmail.de, John Johansen , laoar.shao@gmail.com, Minchan Kim , kernel-team , LKML , linux-fsdevel@vger.kernel.org, linux-mm Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: F15F018140B60 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 20, 2020 at 9:29 AM Christian Brauner wrote: > > On Thu, Aug 20, 2020 at 06:26:45PM +0200, Michal Hocko wrote: > > On Thu 20-08-20 08:56:53, Suren Baghdasaryan wrote: > > [...] > > > Catching up on the discussion which was going on while I was asleep... > > > So it sounds like there is a consensus that oom_adj should be moved to > > > mm_struct rather than trying to synchronize it among tasks sharing mm. > > > That sounds reasonable to me too. Michal answered all the earlier > > > questions about this patch, so I won't be reiterating them, thanks > > > Michal. If any questions are still lingering about the original patch > > > I'll be glad to answer them. > > > > I think it still makes some sense to go with a simpler (aka less tricky) > > solution which would be your original patch with an incremental fix for > > vfork and the proper ordering (http://lkml.kernel.org/r/20200820124109.GI5033@dhcp22.suse.cz) > > and then make a more complex shift to mm struct on top of that. The > > former will be less tricky to backport to stable IMHO. > > /me nods Ah, ok. Then I'll incorporate these changes, re-test and re-post as v2. Thanks! > > Christian