From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E5C0C7EE2F for ; Mon, 12 Jun 2023 16:09:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1AC18E0005; Mon, 12 Jun 2023 12:09:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACB068E0002; Mon, 12 Jun 2023 12:09:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BA778E0005; Mon, 12 Jun 2023 12:09:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 87FF68E0002 for ; Mon, 12 Jun 2023 12:09:20 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 257F31602D7 for ; Mon, 12 Jun 2023 16:09:20 +0000 (UTC) X-FDA: 80894580480.06.E6D67CF Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) by imf01.hostedemail.com (Postfix) with ESMTP id 463A540018 for ; Mon, 12 Jun 2023 16:09:18 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=z3EBHkgl; spf=pass (imf01.hostedemail.com: domain of surenb@google.com designates 209.85.161.41 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686586158; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=krHnCQ5CZRMKrSb8ha+/q1/CNtxY7fdiNeyXa88Ch7U=; b=BbnjtZErQl7mtqaUNBDY2KSkqgZ0hU0Ro6h2ESuPzS5mwOEH1lJ4VPZu2k4PZcqlNaNRbw +UinaIEy70SWTO5uWpHVJU1YFqBzKun98oGmC7S+hM1zev5onAeSC4C3jMxItHUM/IpFBd kNjQOp3Kwez0/Q4DydBsgaoqDL5T348= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686586158; a=rsa-sha256; cv=none; b=PXTqD+xNAHXRfysUHkywPvRnSMRWp8hV2YZ3C7DLN8FkqwwuYiMtqpbqcCPBZR2XlMqJxI HpyFfAaaWP0CAdzniMVGEzfm9ThKC1Tkrf03A+CUpUGEWbvl/ejrz93KBFnn4WO1ym2rI+ hB1k886qTFBwpTaxeacu1Ra+Q5qWkJw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=z3EBHkgl; spf=pass (imf01.hostedemail.com: domain of surenb@google.com designates 209.85.161.41 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-55b2fb308bbso2339309eaf.1 for ; Mon, 12 Jun 2023 09:09:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686586157; x=1689178157; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=krHnCQ5CZRMKrSb8ha+/q1/CNtxY7fdiNeyXa88Ch7U=; b=z3EBHkglWnm5rnLT98HaYaM+oGWcCAOyxvug81oE2bBZpjVKxBgN29HUk1J+lwiLiZ HsDVo1ETVzGu1HECjVIGZHpZCo21qG7E2DidskRGb9L67JJFLSKyZl45k4uZssKrn2K0 22ddrL24eEE9G4l8BbFRK+rUzlepuWNLezx5wqPj6QgDytdO1RvOQUV8oYgoVtfucW9M bVrdjiGepr6ge7nbMw65RIYrDhIRac6HeFNdCeJMiaea2G8vm0olD15rTk/lWCWaqa7L dnQq8z6sBAw12YOiMmgwwo7FThPlMXhO0rreAEAlcVOsqt8UuSWBug+vF4r8zpSiVX0I c2Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686586157; x=1689178157; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=krHnCQ5CZRMKrSb8ha+/q1/CNtxY7fdiNeyXa88Ch7U=; b=D+gBCE2viS0NYttHkKzLdsQLpntGGBg5LeMBoce0kLwsfR4G4gdjugP6zS03ZA0GT0 Bxj1OYJgXxsqTleZKkHlZ4ywupPgGb+PXhq2n7taOaXHUiFYKRSxvzOKAMQvqtglQ9Ej jF2S9De2XBB6dZ1Dq0nbX1uE65yPwkEMlw9JJl0dypitqzR3/+U73vn6WUgjxTFbQLIF KYGdg5a7SM+18A8A3NEausUdVa1SQPvmGm0Gs2x8JO81NfSnq/O99SvXAVVsrm7q+6FH QA1Tr9pFJQkCmjQqTOIiImTJBy716oPZWgiBuBEmcx9jKzKz2YH9rWdjhjUruADOWpJp obtQ== X-Gm-Message-State: AC+VfDymGR10YnkvI+l5OFQzzm1Qf3fAqvZ5p/jyQq6i6ku0n3/Po1M3 n4MjbClbbfLsvLedGrarPZR62+wLq4m43e7bv23S6Q== X-Google-Smtp-Source: ACHHUZ4D0xPfFFsu+KArW+MWCrof3osUM2WtDYERfGMacYWgjQS8tjR/ytuDZp0rHDkHYrXTiPuEqxVBQnbyJDiu9gU= X-Received: by 2002:a05:6359:ba3:b0:12b:d6bf:7ac8 with SMTP id gf35-20020a0563590ba300b0012bd6bf7ac8mr635970rwb.29.1686586156856; Mon, 12 Jun 2023 09:09:16 -0700 (PDT) MIME-Version: 1.0 References: <20230609005158.2421285-1-surenb@google.com> <20230609005158.2421285-3-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 12 Jun 2023 09:09:06 -0700 Message-ID: Subject: Re: [PATCH v2 2/6] mm: handle swap page faults under VMA lock if page is uncontended To: Peter Xu Cc: Matthew Wilcox , akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, hdanton@sina.com, apopple@nvidia.com, ying.huang@intel.com, david@redhat.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 463A540018 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 17co7gupomcyidh8u9ug8z3kaude944h X-HE-Tag: 1686586158-614398 X-HE-Meta: U2FsdGVkX1+LLBgfvE9lEx/xi8rdR0E0HDMv7BjzHtK/gmN+PAk8t+GIPreDITQSG0S7D4PdBpUV0q6WtK0jpbhYKPFBZoZvTMsOyhfVuCO8ii0wJ4dj1TTOc3av12yiX4apkeJe5yOjHzSTacRWgUlCJKnSgyZbffdzClIZcS/mQaaFuSz4YsrJWu4qsYvP61lDNEkNLudwDv4iaUhtWT05GHRaoWRfeyfvMjAuh/vMyBGjC2qJpCRO6XOtIyD8PwqCCpsEfrKv5kAYtZM+DRRFHSxC4fBQ95TdYLl4ALguLRVpgk3SR0HcOVJ5fWgz4nMJd9Uy90OUS8OA3vXNF66mRaHJOb5lQkWWZOTY+cmTQanzvSI8X+qSI3x0eDmVUBP3fnfiAELq9vtvaiJk/PsIpREMEUwRDnlaNUZPDXPvGUuZAgsp+/KcCl7mZrApgXxLYaoZ13+gmpnSshebJWRofPU8qfROHHV5iQuKBw/9IGsevVWN7Y4Ad3+xgjMUP2oLKIeGzckPOP2kZzuNn7fLu2bgCE78uHZr1r2c80K5N4jZZja6b1n2TZwiMrV94n8NUN4NMPWvc6AlpoAp7PRP0v0OiDvwu3J5UGbl9wC6aIDwbqQpIgPzAxFZR9TUaOGGK1injvi9ydaBDFxS4uvwOJ8v1swVMrPWMs8k1WbkakwG/Sp0ptJVYLHx578hfxNxn4xohNx2yMtOLmjNTxl93zqXdtalOnC+MQtO4gcrMG6rTf4w4fasqdSHLEFK3Is5EHC8+Q7u2+HrsVsxD/DcHH90ofkr+CDr+arzG7pj5uAClECGrTaGtvRVKteXCCdS5btrxtp2I2K0hPi6V59NDcPg7ApIAqBQwIIr/SUhFIt5+W9yHRvoz0mwPab1YujMXv0ZxlIN6QrkA64YaENEbQAWKG8s4gg/eBin9Z/46tUV8Hyo13lEB3OOxIHbdfCfAl7VFKtbiQKYK+y 9pHHEz0D woHx/rNscgXHvmD2KKU0jccGnVNz7HneytwvprGZ83U8CNSRD924vT1GgekDdgbgWRORcaVw6ZGRSbDPrfOyoLoeIAZMoY/gtRXmF0K7tXRuQRBQS6B6lymhKZHeOEfAQivPZ5HsrTEV3EazuyGWVnSkRUhAkLGCfNqhAPbMBYoshW5JWLfGCgNN7sYlFxdLDfYV0X09OdHV+7TFyG93u0xxTtEGal6/9laiZw/l+DXcKPrTCpx8qrp6lyr6YeQzdrlDKWr1T9bxZVeeE23sqh+fcX/49Jl+J1QjPQ2qahjY+9YM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 6:59=E2=80=AFAM Peter Xu wrote: > > On Fri, Jun 09, 2023 at 03:34:34PM -0700, Suren Baghdasaryan wrote: > > On Fri, Jun 9, 2023 at 1:45=E2=80=AFPM Peter Xu wro= te: > > > > > > On Fri, Jun 09, 2023 at 09:35:49PM +0100, Matthew Wilcox wrote: > > > > On Fri, Jun 09, 2023 at 04:25:42PM -0400, Peter Xu wrote: > > > > > > bool __folio_lock_or_retry(struct folio *folio, struct mm_stru= ct *mm, > > > > > > unsigned int flags) > > > > > > { > > > > > > + /* Can't do this if not holding mmap_lock */ > > > > > > + if (flags & FAULT_FLAG_VMA_LOCK) > > > > > > + return false; > > > > > > > > > > If here what we need is the page lock, can we just conditionally = release > > > > > either mmap lock or vma lock depending on FAULT_FLAG_VMA_LOCK? > > > > > > > > See patch 5 ... > > > > > > Just reaching.. :) > > > > > > Why not in one shot, then? > > > > I like small incremental changes, but I can squash them if that helps > > in having a complete picture. > > Yes that'll be appreciated. IMHO keeping changing semantics of > FAULT_FLAG_VMA_LOCK for the folio lock function in the same small series = is > confusing. Ack. Thanks for the feedback! > > -- > Peter Xu > > -- > To unsubscribe from this group and stop receiving emails from it, send an= email to kernel-team+unsubscribe@android.com. >