From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97DEEC48BCF for ; Thu, 10 Jun 2021 00:38:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1F649613F1 for ; Thu, 10 Jun 2021 00:38:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F649613F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9862E6B0036; Wed, 9 Jun 2021 20:38:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 935F06B006E; Wed, 9 Jun 2021 20:38:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D6A06B0070; Wed, 9 Jun 2021 20:38:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id 4816F6B0036 for ; Wed, 9 Jun 2021 20:38:41 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D86088249980 for ; Thu, 10 Jun 2021 00:38:40 +0000 (UTC) X-FDA: 78235953600.27.A20FC5C Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf12.hostedemail.com (Postfix) with ESMTP id 1E33237C for ; Thu, 10 Jun 2021 00:38:33 +0000 (UTC) Received: by mail-yb1-f182.google.com with SMTP id i6so23477710ybm.1 for ; Wed, 09 Jun 2021 17:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p2/f6S74QIZa+VUWQuoSSzousj3I48cGhlMI5oyO9WI=; b=jNmHpI0GwtQj0ih3Zrhtz0gf2nBWSoCFrw340eiHQOXdrijafJubsgHdqXhRpBb7i4 a9PmfXgVyqzkIwJo1LvHtiF35nXLjTyxsT4tPjfUQVq8KevuiF/CZ8j0nwCw1wqt+yi+ r7sEVtkCbgdFvQD0hkYWtn0CFCtBLxu0xd7IlUhadkGPDvrV0h2x02IDj9vCsFCp/8P1 U9aYtq57VWOMteu5rQf1G9XUGEJ1a6JtBRSVdfEenjlSRQFaWeEruJ8TKbq8Q4b++gZI QmY/jL4KTmbAujwrChfUbVIa+73gkQZwh8wutS/Jxf5ubxZSZ+MBUPWWs8sMcoMo+W9Y uNzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p2/f6S74QIZa+VUWQuoSSzousj3I48cGhlMI5oyO9WI=; b=RDuVJOw1tA9Qw3dwyylyK5mbKWVhPSNCcqSTx5gMLw5+lCxfjQ0fdK2eyhJWXS2xst Anw3cqOEGX0gqGRlukgCpslSOY8aXtwSer694EFNdXgoR0HGBgyFtdcaLn/KbAH2WTws j2LUZ8VkuV7OfErVWtl5qadtGbP+1ymYhEdWQvbrh1xSuM8Uonok1yxJbj/r6pp9yvLX c+dZuN0mmJDqAoxEL9l4aFaVoWf7FbWwM15ztvd7RdFmLU2uOeLBY6FCLWjpNWvRC0/1 2e66fI0OGwQFYez3NOKC0yJsKdD/i29MlidcwhuSHdMjQXgK9ugcLOzf9TQp+SHwcUop //6w== X-Gm-Message-State: AOAM530zx4+UDnBb1Lue39bX6y5FghvNJKvU1LucyU5tyXTooTzhrLf6 v6HDDgNiENFMD87Q9YTrohDrL5e0ErfHB3ivA+WsTA== X-Google-Smtp-Source: ABdhPJzNCnCV2wqj+tijkGyORCUKf+xMwXuX121HHUI0q7dl4yvfPYes2wMYp9v7OJmfJRFpnQfqozcC+tw0hUzL3DY= X-Received: by 2002:a25:ba08:: with SMTP id t8mr3563826ybg.111.1623285519598; Wed, 09 Jun 2021 17:38:39 -0700 (PDT) MIME-Version: 1.0 References: <20210430195232.30491-1-michel@lespinasse.org> <20210430195232.30491-5-michel@lespinasse.org> In-Reply-To: <20210430195232.30491-5-michel@lespinasse.org> From: Suren Baghdasaryan Date: Wed, 9 Jun 2021 17:38:28 -0700 Message-ID: Subject: Re: [PATCH 04/29] do_anonymous_page: use update_mmu_tlb() To: Michel Lespinasse Cc: Linux-MM , Linux-Kernel , Laurent Dufour , Peter Zijlstra , Michal Hocko , Matthew Wilcox , Rik van Riel , Paul McKenney , Andrew Morton , Joel Fernandes , Andy Lutomirski Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=jNmHpI0G; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: mo6txbt7ekzaxjybjyhkx3qf4gdjbx4z X-Rspamd-Queue-Id: 1E33237C X-Rspamd-Server: rspam06 X-HE-Tag: 1623285513-33886 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 30, 2021 at 12:52 PM Michel Lespinasse wrote: > > update_mmu_tlb() can be used instead of update_mmu_cache() when the > page fault handler detects that it lost the race to another page fault. > > (TODO double check with Bibo Mao ) You probably can drop this TODO. It looks like this one call was missed in https://patchwork.kernel.org/project/linux-mips/patch/1590375160-6997-2-git-send-email-maobibo@loongson.cn after Andrew asked to replace all update_mmu_cache() calls with an alias in the previous version of this patch here: https://patchwork.kernel.org/project/linux-mips/patch/1590031837-9582-2-git-send-email-maobibo@loongson.cn/#23374625. > > Signed-off-by: Michel Lespinasse > --- > mm/memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 550405fc3b5e..59ff65cb3ab4 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -3567,7 +3567,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf) > vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, vmf->address, > &vmf->ptl); > if (!pte_none(*vmf->pte)) { > - update_mmu_cache(vma, vmf->address, vmf->pte); > + update_mmu_tlb(vma, vmf->address, vmf->pte); > goto release; > } > > -- > 2.20.1 >