From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48348C52D6F for ; Mon, 19 Aug 2024 16:12:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD22A6B0082; Mon, 19 Aug 2024 12:12:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C807A6B0083; Mon, 19 Aug 2024 12:12:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B488F6B0085; Mon, 19 Aug 2024 12:12:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 96D946B0082 for ; Mon, 19 Aug 2024 12:12:07 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1C4171212C8 for ; Mon, 19 Aug 2024 16:12:07 +0000 (UTC) X-FDA: 82469486694.24.86301AB Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf16.hostedemail.com (Postfix) with ESMTP id 1FB5F180026 for ; Mon, 19 Aug 2024 16:12:04 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=s7+NZ9mS; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of surenb@google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724083862; a=rsa-sha256; cv=none; b=mrfvuUvif9xJ7a2XhWt+q6zh0hEotXl1tBVOe14+PyBBZAwvEJZTJsOt9/N6YaPkXz1yQq oUafIsUvBxu6xdpA4L190aF4Yrui0iI2/RFGa86ltXarTJxtd0MjPgV51dn5EJBcGpNdPT pZ9jyuRJqHLrEE7keEVsH2uNBz7mIyk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=s7+NZ9mS; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of surenb@google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724083862; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1QO7rOXvGcwG/xm+Vg7omaBPUcYU0DZnvYiHuU9lyzA=; b=N+V26IkhiA4wo6ewXIgNJCS8eU5XFQ0CSZM8iE9wY7hRRyG7bgDf5UOjm8kf8ClMUqVhzs +IVIMYqaQz1rDijZXMtRkZdOrTJfcJu3nz0EV1ts4YcNDz1ktP6L7szuYyCiN4aHrr1Avt OWgk0b5fBXYcGGpQV9DS58f03PkKdt8= Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-428ec6c190eso37883565e9.1 for ; Mon, 19 Aug 2024 09:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724083923; x=1724688723; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1QO7rOXvGcwG/xm+Vg7omaBPUcYU0DZnvYiHuU9lyzA=; b=s7+NZ9mSC2nUquhdxall2PQqhAx+cktbiX6Ath8IDaVA+XSGP4w5NbRcgY2X5XW2k1 shLUCipbcjKN6+Z2wzm1WesTF7wUE2yaiCtQrMn5jKsvhhF/6MFiWAhRTkP6TtInNh1N 2U45jEMgxigbPhKevwSaBFa30emkMUAlqXHlZ5sP8rAJ8+oJi5eSM8zKo+OkBK8fCPs7 SJJYIPk2nUQXU0p33orgaUioDmTXKHRDMkrB4AOV5PF9Xz47NRB0tK5XL/MCy/+YSs9G Wc9DtBV3sbjLpgkTNKU5zDUT0bXpRhzyBxP7qBEA0ab99Kj0g+Rr9izAldnxRucSrVRc orew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724083923; x=1724688723; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1QO7rOXvGcwG/xm+Vg7omaBPUcYU0DZnvYiHuU9lyzA=; b=wLinmfSvICvHYJgZcCZDdVCVsptEq26W27WE0FKETru6yfyf518BoZYXc30+v4/OOk 6ILY8nKP0zw285ljFwZ2Vc6NjjtKIhLcsZPv2PM/9k98u99PoHv/GFAlzWvo/pTb+s6r xXdORXg9bPbcDHM4JF0u5c03+fbnMR3HeL9z+l87gmNL8xvIKFZEkLKsMqN5dblKfPyo zYOyxPGS1DgM0JJz10qp86DX5oUJDB0ByfOXMg/hBOos1kg06jggwKIDvLcrFE0d3L1y XMcdAGRhYOMF0+cA4ncelHjYirx6TRj1MdoJ3zEajQRtwgcQtN1BBa653hrM6j9CD5Cf mVLg== X-Forwarded-Encrypted: i=1; AJvYcCWVmP5RU09+zJY0NTmPzy4BUlnbmc8gZBhad51Dfc33y5Qss7atykVvrxmIr1D4p/NUwYtA70GykFXBHrveNIg2dlI= X-Gm-Message-State: AOJu0YxXqbSIrVQc6q1se5mP2WPJwpX23HbPOclck1k/+SeMTyWYFoW3 5cSQT+VLbqW+x/5ifdKzDlIhbbvDmekiLOAtDzZtBrvDHtVs/2OQS174sDEFqzbayKG2aKLxEvl 91acROsWWir2HmIP+HeuOnGszQNqdfa70a2NXQbRsY29OIFvYNQ== X-Google-Smtp-Source: AGHT+IH6oJi9xR5/rkHAwmlPsJloUdfYD3FTZymPOtI9IwfcXJOFs8ZuhfzuvhPvP5Kq9vHrZzGJvPCtUqxij65o2tA= X-Received: by 2002:a5d:4b84:0:b0:371:7dda:d7d9 with SMTP id ffacd0b85a97d-371a73dbc8bmr4733954f8f.9.1724083922647; Mon, 19 Aug 2024 09:12:02 -0700 (PDT) MIME-Version: 1.0 References: <883bf552-f339-474f-805b-4355ef49e526@redhat.com> <905d6a3b-d0ac-4e5a-979b-40a49e345305@redhat.com> In-Reply-To: <905d6a3b-d0ac-4e5a-979b-40a49e345305@redhat.com> From: Suren Baghdasaryan Date: Mon, 19 Aug 2024 09:11:50 -0700 Message-ID: Subject: Re: [PATCH v2] mm: add lazyfree folio to lru tail To: David Hildenbrand Cc: gaoxu , Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Shaohua Li , yipengxiang , fengbaopeng , Kalesh Singh , Yu Zhao Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1FB5F180026 X-Stat-Signature: hq16ydusxeggm6kgcc7n6rcy1d9g9w64 X-Rspam-User: X-HE-Tag: 1724083924-199853 X-HE-Meta: U2FsdGVkX1/EkHivSaXdS0eflECJaRYMl0COsgvrC1Thw1pJlok8J5qcNQIfv6en7KggHIBAzAlDmbvL64+8cEKiJbnVwCciH7G7xmeWF1wbjtMgZVas/12KzGtENCn3GWPCvIChbkixXzE108vyHwa7TkeL5fxJ+7XVw4GeAfXq2aI7uyt1QYSXXQVDCkE+zUeCwocIpOc8EP1zE4tf9ENUeJR8GrS62UM+9jXqFwAB6G0uQMXcKheIACPALInCmIXzhtf5cM2ZhRQY6fSaFf8a6QQl3dDRO3Ws4A5DGSn6Iwdt2DVXPzMQzp0KpkZ2rp2KbPdVbjVAPTZpb89WPzNbB/76lrqaOqDGFBNaKP8wKhC9TNw6qDTXVSPVN4v76A0L3g/cvhUwcgSx9qomQpejXH3xGx+/R8eaRBCrZXqT0BV5BHO2yGYunQaJf5q38LvFrReUgz7yX59SXRiyfkFrXA88yKX5VLbzGTQiTK/6pP/H3xzkOEzQOD+k58i25BiOttzbgIkP9cIjual/QFFYtypQ5DdKRgBAorzK1oOwT/rUQ3JUSaHqnVH2uCLMYoW5SKMhchO7XJWHgdKJ2zwziJzkd+KVH7hh2oL4gnaIPL+zsehMR837QKEOiDbgLDFlqQh2v7sBjI5muEzn2X/gdNcVc2b0mEHUty0DOkOCoa3UpltTIilzsHDXn3kYMD6jYEX7iS03qnm0iV88ZkC66MbZ0peKeUn+gM6+kF8WhkT5zXEcw/8TdcPf40XXRsa9sohmrw90EU8Tw7v16i1AXnct6ZfBVo42oqyhEMwsTtQTFYBnMcCMmeR/kB31jpegIk0iAkdZEKcaNqmK2ujbYk+E8LKxakbkDJ3rzhW5p3O1VFuDsNM9LW8FKklZLkNYYYJGV2tpysDZ82aj+FDs0/guwbX3wLh87m1Ncd0Vu8Eg2iSRfvzYnL+qqkCWBO8rs00gN3K5CI7jj9d uo+PXb8p oyktoB8Ig0lmWRYQffesRFZwcJKL0BIB1IB2xeie9zAhoOsG67oYF0N55TjWBxY90fxQ29VBnc1QI0IY2l+hGI+4W61YwaxdHpsPrAR03i+EIdEWMkU8XMOqU7K4xJ69pYQYHbdnb/IMOOcJKqJmyMJeqJvklAnds43kue96a/8rG/U75TcKze/2KOz0wJXeuN4TZabYehbAzpx9ljmjNvRpTrm1fp9XgQMYC035V3naJ0i0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.063571, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 16, 2024 at 3:21=E2=80=AFAM David Hildenbrand wrote: > > On 16.08.24 12:19, David Hildenbrand wrote: > > On 16.08.24 09:48, gaoxu wrote: > >> Replace lruvec_add_folio with lruvec_add_folio_tail in the lru_lazyfre= e_fn: > >> 1. The lazy-free folio is added to the LRU_INACTIVE_FILE list. If it's > >> moved to the LRU tail, it allows for faster release lazy-free fol= io and > >> reduces the impact on file refault. > >> 2. When mglru is enabled, the lazy-free folio is reclaimabled and shou= ld be > >> added using lru_gen_add_folio(lruvec, folio, true) instead of > >> lru_gen_add_folio(lruvec, folio, false) for adding to gen. > >> > >> With the change in place, workingset_refault_file is reduced by 33% in= the > >> continuous startup testing of the applications in the Android system. Was this improvement recorded with MGLRU enabled or disabled? CC'ing Yu Zhao as well. > >> > > > > The patch subject does not match what you do in the patch -- at all. > > > > "mm/swap: use lruvec_add_folio_tail() in lru_lazyfree()" ? > > Ah, sorry, I read it too fast. Yours does make sense :) > > (mm/swap might make sense, though) > > -- > Cheers, > > David / dhildenb >