From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBFA5EB64DC for ; Tue, 27 Jun 2023 16:27:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49EBF8D0003; Tue, 27 Jun 2023 12:27:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 427B88D0001; Tue, 27 Jun 2023 12:27:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A16F8D0003; Tue, 27 Jun 2023 12:27:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 181558D0001 for ; Tue, 27 Jun 2023 12:27:21 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D01651209B9 for ; Tue, 27 Jun 2023 16:27:20 +0000 (UTC) X-FDA: 80949057840.19.3F859DD Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by imf05.hostedemail.com (Postfix) with ESMTP id F181110001B for ; Tue, 27 Jun 2023 16:27:18 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=itTKOTQ8; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.210.42 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687883239; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pJFRdvLZEJUWCkL2EK4nO+CExAHFvCuxR6yO/np/Csg=; b=lVXHjNTgmAb4oiAEIz9fgtAbtjYGQQ1Aew70eOPW7oJL1q9NxBMWeEwXeaqrmSjoMfOKvc MeIhs2SyQ2WQN7o5vM7CeFUdhmnRkRB1O3EQHREfuaIL6Yhr9Dz9X/UQA6gjfVWY1QQydb YTmuQ44zjxjXuyBqJssFoYPZuMfCYu4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687883239; a=rsa-sha256; cv=none; b=ElDJMqRpLQY6W/QUAaDUb6aFWb7Czpp3LMQLMcaEkSv4e7MvRymb/nnBOgp65iAN42Yo5x L5/XUuYhEpB3303E78nC5NTAYc/jj8Q3DvWJBQRTg+F3y+OXk6PAvkAfFuXy9lfhsM5lwd VTmTrBJWWe9JbeF3fT8SZz29dA27awo= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=itTKOTQ8; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.210.42 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-6b5d57d7db9so3716137a34.3 for ; Tue, 27 Jun 2023 09:27:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687883238; x=1690475238; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pJFRdvLZEJUWCkL2EK4nO+CExAHFvCuxR6yO/np/Csg=; b=itTKOTQ86SntEjnwzI4JoX0BexZJ1pu/XpytRxK4zPckna0jMVyksw9xu+EJszLZeP 8uFIG0vTobqWN5ctzM/QeA/zhhBpfP8gK7w4NzNLu21ddFYzQd5uCJdZLIkHRhDjsPEt cS6icMdVzW99rSPmL/p3rwoFz4jR+q2+SnMdZVLC6e712lumkhlu36B+3aINvRmEV8H3 iPdVy1BUeFBDfdR/QZozT86M6pj52wygB6XXH+6+jFI2kelNI3P10IjmAvJtMlLstYA+ 90GTZKwcFW30u72Q7hXfvi0YvmHa6e7Ovz5y4CwphiczY10m7mo2NMV22k3w/QjhePPk 1H8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687883238; x=1690475238; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pJFRdvLZEJUWCkL2EK4nO+CExAHFvCuxR6yO/np/Csg=; b=HZlUswuTX+L7Rr+44biFVaZ1bcgA3LB5CqJOhSzgnbJ9+chrY0Rd+Qx4Oy1iJ/bgW2 idRy0tyx5laPmFOMg1bZeA/cfbcxQrBnQ+d718groVS0vC/FsXnPPfIzeeyNGdFiyfVH PouHFVdd9JlesnGYDfqHUbiWIpQTZ37YhHrmNMKvUqbRyhFc7zfZM0QWQ6fPv0hjCoOu vdlV5/ykurwJecBfbSnWvHojKR9k68K3tI4p2qhdpBuGC+eRuUh/zwtKuijiicTg1xyD vxQWA69d3F+0CjIeBdW/F0NgDGMIAsIjpIYtIuNykh3ljJBM8JDNy9pP/J2ZIGI8VJyi jgrw== X-Gm-Message-State: AC+VfDwURWA5VbiK9ovwQvD8I/Y2E6DGRjSTy6gwSjIDa9qeyEyp8G24 Uqtfc+9L6fxF3FquK/W37C7ko2/LfjdOCpXHKc6i/w== X-Google-Smtp-Source: ACHHUZ57VoQ12kfJ5zjAGQLFgpBtvhsvnVdfU8lZ1iezcQnh18vfcwTjU+DhFqTazNLmGcrrtgw2UT9xzFgboNl4Akw= X-Received: by 2002:a9d:7510:0:b0:6b7:397a:6342 with SMTP id r16-20020a9d7510000000b006b7397a6342mr7691290otk.16.1687883237932; Tue, 27 Jun 2023 09:27:17 -0700 (PDT) MIME-Version: 1.0 References: <20230627042321.1763765-1-surenb@google.com> <20230627042321.1763765-5-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 27 Jun 2023 09:27:07 -0700 Message-ID: Subject: Re: [PATCH v3 4/8] mm: replace folio_lock_or_retry with folio_lock_fault To: Peter Xu Cc: akpm@linux-foundation.org, willy@infradead.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, hdanton@sina.com, apopple@nvidia.com, ying.huang@intel.com, david@redhat.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: msthk98dnxa81ft67dmm3xz4g83bmoza X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: F181110001B X-Rspam-User: X-HE-Tag: 1687883238-650965 X-HE-Meta: U2FsdGVkX199Pp5Mwch4BeJfVvGuJ5h7b7GwKrcj0BHLvNABbFKu/EIBZqRXbC0802UPeqqA16xrI7vejXi+OysGxJxYRp0Se+KG/hUWo5ROJl/8H+DdYNbtWngS1a3H41z0RD1cnANNjFIq9/2z1djvefKuxQU2SQBXMZQLEdzD0L/MtU82+IZKkLoXF2+uBTdk3nySdelwA39B1fWA31u8Zul1BSubulufPAYRfuJfEeUGTRBsnLz5/FKGa5RgRDVUkOePrZRJb0nbP+tTssvC27Y3OJ5zichzB5l4tqYdTfsPO0bdMus+sdzvHJzB2wWEWwvR0u38WrEMqYtce68vgobcR5r26p9DuMiCKcS1p34mziH8SAC0kuj7Tm1z0UsSZ+3sMD42mj4rgUYCR8wAcH7I1xZ3dUDlg/BGpy7HVnoDq5qE2fUzaa85k3XMFir9SOpOSJVnLQMsRmRTB/QBpoFYmEys7nhnkvucoGKwjygpLssP7qBhP3C7ikh5P/DTzjShd8c/k5g45HEEv4xols01LBN8Gm4OC40dmBc/2XE+lcM96Qp35mFtAjNcN9I30cQh0RKceJ9Z72UUvNpixQym+p1Z4o/8ZoeYzSNDTmhIQiskVVjmMQPsNm/Zm1Ya4BEwSLMZ6bcKPq2nElhOr3f/VSZWYWh2Z3U46RZtS1RWnWDjG+00sTi/7lY0WmhJA5OTYAJPjIdObOwidFMUg3mDqLFkYC0LyzbXlKTo/+hIHulIgo/S1o+cYAPoTwPzVDaxhbdDCptC/sPmz6u/7KsKsZU74pLK2sHI/BFlkXIUx28zzF4aHT6xqGZXdrDmj0w3gmPGEEHFKasY2p6fyrApUdSQr0N7jLi3EQ+NZwTMN328G2xpfKVskrzS89PL1NLpktR+MEI33wrC/PjAxR9nra343x/Isg0GikjRRSPA3ACkTQCrebPwv3fdIYfm5vuyj7WeGmJScFt k2UjWYHB 0HdqGWCJ6oQwsZNdMLS7+3iqASIwZW81qFjSbV02pL7j52UUVYIbzey6IX9SqVGyqVCoUiC0PfSckSFwV26JjIpxvcXiBxelfr87+GMDPHDEHG1t5w5LDSZLsLkn+e5nAOJpRiW2HA1eJU5oaosmPxZRGSnqpO4Oki4/Ib+bFi4lw99+4uBo4jIAfg9LHf98aFlujqEw3VWf1Zx1B9pIfMoRFfU2n4kXSke9IWAg43j66QrM4xu00QLWicFoL+1oiSluGp8PmLmvbyn8AM4Qx/4nh+Oicp4Rqq1E8/hZhvmk9nYQIivpwdSsD6V+Uc4nb46Nkbpx7nF7aPRKciNsj1Qf6EUMxI8C54S5+LwXb64bC1Ht9u5XQnjHZNuQqpEfBfgt4Cp3+pS+HsT1KPC0xFlsgd5j1HH3w+mNtxR1HjoY7Sec= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 27, 2023 at 8:22=E2=80=AFAM Peter Xu wrote: > > On Mon, Jun 26, 2023 at 09:23:17PM -0700, Suren Baghdasaryan wrote: > > Change folio_lock_or_retry to accept vm_fault struct and return the > > vm_fault_t directly. This will be used later to return additional > > information about the state of the mmap_lock upon return from this > > function. > > > > Suggested-by: Matthew Wilcox > > Signed-off-by: Suren Baghdasaryan > > The patch looks all fine to me except on the renaming.. > > *_fault() makes me think of a fault handler, while *_lock_or_retry() was > there for years and it still sounds better than the new one to me. > > Can we still come up with a better renaming, or just keep the name? I thought about alternatives but could not find anything better. I can keep the old name if that is preferred. > > Thanks, > > -- > Peter Xu > > -- > To unsubscribe from this group and stop receiving emails from it, send an= email to kernel-team+unsubscribe@android.com. >