From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9918C3DA7F for ; Mon, 12 Aug 2024 19:11:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A73B6B00BD; Mon, 12 Aug 2024 15:11:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 356BC6B00C0; Mon, 12 Aug 2024 15:11:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21F316B00C2; Mon, 12 Aug 2024 15:11:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F25D96B00BD for ; Mon, 12 Aug 2024 15:11:46 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A65F0A5DA7 for ; Mon, 12 Aug 2024 19:11:46 +0000 (UTC) X-FDA: 82444537812.02.876CD0F Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) by imf12.hostedemail.com (Postfix) with ESMTP id DF8654000A for ; Mon, 12 Aug 2024 19:11:43 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=2y8VBCMY; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.210.46 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723489849; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ddp64rJgdO0xjary+ehUrD62neWvl3gWUy4flarg04k=; b=2Zr0HDOOit1Ebe2Q3GkeTJ6ZTP4eb66H5fZ5IjpxBr2EhUyUW0H3gmqht2FMPoAw3HhYcT kJm8AbNWIUYCsabMYXfts7WLYGUBOWLFc0/TsiyoLmLoKnI+BdgaR+t56B6nQCwobNiiU4 5cDUziAicQADEOcaAofjvmyrNNThdU0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=2y8VBCMY; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.210.46 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723489849; a=rsa-sha256; cv=none; b=cW0DQ/xAL1/xcplgJgsbZIFhJG+ZdO9EuH3YG9X4KBt/ieYXhxuRRrItIS+3o+Xq+gB2LS g7l+TZ5M7ubJ8i+KJkEIJ3pAHhsHb6oDTQGlVZaVSd2tNYwfeOudC/fHSFDb+9qrNkEtSa CTohcngX/jRHmkc6AhW2+pS64XactIA= Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-70943b07c2cso2992883a34.1 for ; Mon, 12 Aug 2024 12:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723489903; x=1724094703; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ddp64rJgdO0xjary+ehUrD62neWvl3gWUy4flarg04k=; b=2y8VBCMYr09C3RnKe+vUARORkEiVvF82eK4qwMhKpPaz+G7NBkcsh+bdhRfGn6A8xw Z4QxzYn8Sx7bW6VKcWvGRn1khj3SWOZOCw2YTXYzPzcLkgebZLRiHkPY9gSMKGk0V56C qMKQd1GoxWZW78JDXg/HDvDD8qlWLSCs86fJiXgVH3apSgS3mBoSnmc/Rp2RyB8QPG0Z lTJwf1Z3MKhf7d9NgjwJC7/t3Ec9hpBRDE9pRj1187FffE2o7NOFi0ekuLhO4UyOnkJe ob2NDOG3KmCMvUMZ9L/0QSpd7LasRH+9MSzue7WasLrgxsEdbR4ocykL3j1ACqa1IJvP z5AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723489903; x=1724094703; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ddp64rJgdO0xjary+ehUrD62neWvl3gWUy4flarg04k=; b=vCTZNRwwUsTJp4bUl7FvR1NS47WKVAxjNOLubSQp+xqDKOwB9lKa+bFgtAXEJB77wR VdXcJAC8i/jPFeA01cW9rkLdSIeq+3qaKzuT+RuAZTfl3SzLu4sP4QVw7yRDGiAuw27H 0AHYgR/xZLCQ88fwYz8EVe/h1GNKd0/n8x0pwdf0SzwturmMfcgwiHB+aMBHbLRxSkf9 Zfi9GFBG2WIvxcG5XIFZ4grVwV+hnwawr34F4xw1nEst4FjAeQxEroUqHNA5NP+mw1t2 pQnPWMMRYbG6J6412BZay2NyuOoUWtGxpEzbfYXjV9Hkzwhso7gZL/MQUjLiV1f17mDI yI4Q== X-Forwarded-Encrypted: i=1; AJvYcCUtiEqNjJZDlI2o/uEiPsBlQ/j/OJaHG5c92INvPc8ZtMS3A/wMPe9o6c9mFui2nzs32V0xheJ06STSF3SaWP5iT7Y= X-Gm-Message-State: AOJu0YzCNLoeoD2GUEjfLPtS3QkCAlSClkvvl1aRGKXiCX4NpQFJm34D nlN9onMPbQsQP/IT23KGLnBGquLOGGiLrCuNrnkAU0zfSZ8qON73sGOgs4DmxoDT96QYklDRIgQ iuZrL3ZZ9N913kv/6B5LFYMbaeQEBRbh2PnZm X-Google-Smtp-Source: AGHT+IHsMOZHQZxd786VilZxK1OHo7ieE7rCGuIWR72I+ELe8SNSwsiuREiwh69sSoCiDqaY/lP7ALuUKioYndTrYBc= X-Received: by 2002:a05:6830:4111:b0:703:6aa3:d091 with SMTP id 46e09a7af769-70c9386796fmr1551866a34.2.1723489902608; Mon, 12 Aug 2024 12:11:42 -0700 (PDT) MIME-Version: 1.0 References: <20240812184455.86580-1-surenb@google.com> In-Reply-To: <20240812184455.86580-1-surenb@google.com> From: Suren Baghdasaryan Date: Mon, 12 Aug 2024 12:11:29 -0700 Message-ID: Subject: Re: [PATCH 1/1] alloc_tag: mark pages reserved during CMA activation as not tagged To: akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, hch@infradead.org, vbabka@suse.cz, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 3abjgwcxh9wpub6w7845586oee7gftai X-Rspam-User: X-Rspamd-Queue-Id: DF8654000A X-Rspamd-Server: rspam02 X-HE-Tag: 1723489903-271865 X-HE-Meta: U2FsdGVkX193KNNI3uypguDuPTlO67lir3qdGnX7u5f6Y/NPUZg3CqyyBDkx+dm48HQKYzr4Z28yy8U+4bS/Gm1uoqchykmFOOmA8MMVjWPWoYvUJ1URyjTGszqkD/ifmMDvAOjQZMhZpfgXxhqqVM7cOjgDC9d/hZZhyn49PNC4DxDaiYwwIuL3yX1sHO92T6aWPH8ToWOUtLOdZk9hzU1KIQ7lSq/1A5hvtkbepRUPBe7/xcNPPm0NfWmu/rzU0IOPwHcXC5rQ/mp6wj9uJ0wBKhzREwawzETVIx4GMY0HnPCBcySiMzj9x20gLHR59466Du64K63XV+5pqUIdwvr9bYFaclJefWqnEZrh9vOMs43+xJ58siBAOgoedBoux3UIiBZI43rTteWhR1+emf/KENtFvsF9WC33tEv9GNjKVtPXp0sWPcXO0xeKIEdwZdyqbx5ZyP4uzkG/0Ni/5jx4p1Uiepq0aC91H7wuqQGcgoXVeFL3Rkig9Q5B7d1OXGYrzpDCUglY4L6Br5vlKYBWlNj1CHhMPO+GsjzCJqCxUVbACv5Hi03l4j6FzfocMQIV8hQyM/ANOlZ1ebmJ9G1buyMhtnvy3ZWxA3wpx//UNnFO8Aqq0NrkSOMcC9EtGlJwNshgdNdiHBVo0zipzUNAFlfwup7TIenZzmPnfOI29r/ShLjW3Ya8dJvA8HyZGkZ+lI2pI7nOfomCwx8NHlHjDfw9NuIPiKsKcgeP5dAD13Il2CpHwDh/AiHly6RVqAuc74ZmtIj4Z+mttb+ZHSW5cKBDzVyKhnqdL2mXYiy1vnrydhSA2whHH9mlnqnYO7i+hh4m9VZ62kapZEQ5SugkXVxSPwlrqB1HlVXjn6Bm/nWnQNReR3BkDdizYim9KxhlC0/k3/WhqY7T/V6NW9f1IflYb6GDrWs+nz/k+lKd/z+6HKG/Pa+xPw8wSv81x4GzcuzZqYLcpGj+O/M 2mavL7PB 9SQBwjKQn5/dMQ7A/a8q4vLtSn68CtWMant23Mkm3gtoPNdLNJoyeAR9OUNnQplarVOq13v8syCcxonT0Do1aRQi3cu3rCpR9vbXDpT6q4euf7E9U0G0bpK1vKUV9EBDafUOb4y06oli4czySfs5cJ4ynOfrRWyYGoKVGskSccStvAw2VuZtY+Buyc1cfDdQf50EFhQzyCZkGG0j4rZjm9ktRpO07bV854HNrxS67FlavwKw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002752, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 12, 2024 at 11:44=E2=80=AFAM Suren Baghdasaryan wrote: > > During CMA activation, pages in CMA area are prepared and then freed > without being allocated. This triggers warnings when memory allocation > debug config (CONFIG_MEM_ALLOC_PROFILING_DEBUG) is enabled. Fix this > by marking these pages not tagged before freeing them. This should also have: Fixes: d224eb0287fb "codetag: debug: mark codetags for reserved pages as em= pty" > > Signed-off-by: Suren Baghdasaryan > --- > mm/mm_init.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 75c3bd42799b..ec9324653ad9 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -2245,6 +2245,16 @@ void __init init_cma_reserved_pageblock(struct pag= e *page) > > set_pageblock_migratetype(page, MIGRATE_CMA); > set_page_refcounted(page); > + > + /* pages were reserved and not allocated */ > + if (mem_alloc_profiling_enabled()) { > + union codetag_ref *ref =3D get_page_tag_ref(page); > + > + if (ref) { > + set_codetag_empty(ref); > + put_page_tag_ref(ref); > + } > + } > __free_pages(page, pageblock_order); > > adjust_managed_page_count(page, pageblock_nr_pages); > > base-commit: d74da846046aeec9333e802f5918bd3261fb5509 > -- > 2.46.0.76.ge559c4bf1a-goog >