From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3E1FCE8E91 for ; Thu, 24 Oct 2024 16:25:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 530E66B009E; Thu, 24 Oct 2024 12:25:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E0D96B009F; Thu, 24 Oct 2024 12:25:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 359E76B00A0; Thu, 24 Oct 2024 12:25:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 177B66B009E for ; Thu, 24 Oct 2024 12:25:42 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B64EBAC089 for ; Thu, 24 Oct 2024 16:25:04 +0000 (UTC) X-FDA: 82709021514.28.CFA9E52 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf29.hostedemail.com (Postfix) with ESMTP id ABE70120005 for ; Thu, 24 Oct 2024 16:25:14 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XJx4QOpx; spf=pass (imf29.hostedemail.com: domain of surenb@google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729786986; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PsKck1YTKCCMRyW5+ku5wUHxij3yPa9weScPb3/oZQY=; b=8k9m+avkAaqbMR+1JFVXjc67Z9Ysw7HmE+BnCkzf2PwuE7OWwMPJl/SveVp0zWPh5VQl6d rgTYwrwiW6j5s/LTHwByPG1nPmMrh3T0dfN6rzEu/hDQmf+G3n6rrkoyDEmE+AKZRIu5UP 26KVz1mhWRoFnE8tMP/x+GiPPYAwGoY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729786986; a=rsa-sha256; cv=none; b=ZdPmkb9HF3/3iLF/L2qNqf+eJjFtni2FOiV3fdaJ7RsXf9xkaKjX+wkN0oWgT4zpyTArWv 9C6rQ4BiRHVGT16DILoZ+PgihpSjdEMC4ptRlu9N9GvILN5NcTNZyL4/IJNVpeZuscBWcK H2XFRzOXM+McsTRdna0YdpDRf2IyX6Y= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XJx4QOpx; spf=pass (imf29.hostedemail.com: domain of surenb@google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4315ee633dcso194675e9.1 for ; Thu, 24 Oct 2024 09:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729787138; x=1730391938; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PsKck1YTKCCMRyW5+ku5wUHxij3yPa9weScPb3/oZQY=; b=XJx4QOpxBXfvJpL6+czc9JZSkTLXgyUFagKEsBSSfyuBbt63HJ0kUL0QpO8GUBxpZM qh5eTPdBRckPvy3upGBDK7TMLLgrbEaU7ko2m1jDt8bJpctn5I4+K4kST7QSDq7fXqKl hLihmhJ99AsyBlpz+dVopyqEsG3ZSzRM73veylXqGmSRP977sMNrWkL2/4WStheGvaMc UD5MCQqX59O/i/YEHStFy9bMdp72iH2//YaeLamFy1tiIxHny9tHk7QayWTmd9PLyHm5 rAII3TgGQDd22fZeNw19IPaS3S2J87S1vpc2B7VZtcIYgiLqX21RMQ1AbcLUir4IZKRu +iYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729787138; x=1730391938; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PsKck1YTKCCMRyW5+ku5wUHxij3yPa9weScPb3/oZQY=; b=qS2bSoYUai+4QgO9Xy12+/1I1ixLcyRA6Q8A983QuPPhuqmjryRefr6a1ifJGxybKD SjVCdP424A9e1Y+yVaThN01g04e7eSogmdzAX+/G8xYrBPT2C7Cou5Plj2TuJr55kZ7b 4pVZqhI+gzXB4YZAJWpQzK3YfKEsn3P6t2kYyjqs/e2UkgIkkb5C3L2kAxH9uneFVVZy a05z2KCs9i/8YuEs/nuETShD1pguM/FzhIg5nFCWovsmKrgnkTPt5tXPVas/H5MdUMa+ AxHkpUu7RXKDmgCknKBNMTNzvtuL0I8+ByN1dMCJdBiWFZf3aNqy7FdFP81JxAhUGyG7 Drbg== X-Forwarded-Encrypted: i=1; AJvYcCUYxD7cUO1ros8XHv3Vq4d0upcVCwgtGv2EZlswDnCCtvovVjrKjrrnf16TFjoILIcpVrBAK3IgTA==@kvack.org X-Gm-Message-State: AOJu0YwMnCyWS2A12UMA6dCxKbnskNmmRZaRPw1mHA6Guq/PDVdo3cSd /88w4LWJy+a3vTVOEdbT3BQCODobPNtLFamb+26tfVFTcDAm6f4TtmAC1coZThduGRagaQrIam5 VOch4lgvbZCznf8PW+zXcNDSkve2BGGPbz2ls X-Google-Smtp-Source: AGHT+IGLBq2yNokN7929g0eN3iBE3/2qdA2DRQWdC4E2LpDfi93QPPEgbNRjYQqJ+XQ+mG7d0keQ7uvVD5LffkbY/lk= X-Received: by 2002:a05:600c:5023:b0:42c:b0b0:513a with SMTP id 5b1f17b1804b1-4318a50525emr5577505e9.2.1729787137882; Thu, 24 Oct 2024 09:25:37 -0700 (PDT) MIME-Version: 1.0 References: <20241023170759.999909-1-surenb@google.com> <20241023170759.999909-6-surenb@google.com> <20241023140017.e165544bf20bcb0c79bfee57@linux-foundation.org> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 24 Oct 2024 09:25:22 -0700 Message-ID: Subject: Re: [PATCH v4 5/6] alloc_tag: introduce pgtag_ref_handle to abstract page tag references To: Andrew Morton Cc: kent.overstreet@linux.dev, corbet@lwn.net, arnd@arndb.de, mcgrof@kernel.org, rppt@kernel.org, paulmck@kernel.org, thuth@redhat.com, tglx@linutronix.de, bp@alien8.de, xiongwei.song@windriver.com, ardb@kernel.org, david@redhat.com, vbabka@suse.cz, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, dennis@kernel.org, jhubbard@nvidia.com, urezki@gmail.com, hch@infradead.org, petr.pavlu@suse.com, samitolvanen@google.com, da.gomez@samsung.com, yuzhao@google.com, vvvvvv@google.com, rostedt@goodmis.org, iamjoonsoo.kim@lge.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, maple-tree@lists.infradead.org, linux-modules@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: ABE70120005 X-Stat-Signature: 1g9fzdceiab7n8o4ztiy446qoreybunc X-HE-Tag: 1729787114-316466 X-HE-Meta: U2FsdGVkX1+OOGXXhIL9a5DPQ3BkTersxMyvqQI4sFfluM3VHNTIWBwkWBRG81aJ+HLtG2U8ZJKkHANdQCn18/En7Cj6dfnaAJuOvXdJY3/gtsovE9UKn0NVQMDI1flFKkjxni203HUVmcytZpC94RVIrwBOwIj0bV56HcWQgu3VO1tmh0sGGoOm3M758873P4REOTZuHpk88DxRn4qEeEXlwAeYgrYHMBbNkkHU4TtM7TFOJiD7KVG1EpN+QHfurzin4hDlqXJdBst7CM3zypjXXx3MxAHpE2fX60JhZA4s0FWSfV/sTXVhAtZ2nl2RFsKcPJNucIhFOtKhrnaKdaMBFiWjtSgK99D0JfMfU5j2WxvkQLSp7DoWvSSeK2FTYkvJJLbg5PPKp5l+SB+26gzUBiYI1xN2Mhs2tamD7flIt7dObmLmDTsO21err7Uvau4UKjn/kT6wzCK7QknuXJ434V2kFbEFPGZ55IGFkSPTMXNzg+Yal5iSljM69y6JAMfAaBSm1oODFhynUB6HDq1qzH/DdGjTpI6mEyH6GWbteoX/2h6ECDQw5Ncaw9LTxzn4M/o9NMsW6gKNX92L9kbH9GcivdDCb1Y9xL936YkBNcXbt65uabiWUoc2W/OaSD0JIuuUaIGIgGckamW2ti5cwoKILs8fHMRAkkGc8r80TSu68bKx67MuA/YvWk1rna3SuS1g9RS00Gv9UonwbbcpytEwWWmu3EPySabxK1+wtv0VK4MSzgIrSshtnH3K5h6veLOL1HUN6Q6QrhKoFg7JF5zvNqFyk+TYtXpP6mpSsrWRDzwFoFZ7JXusZScdPQyDbvGhu1FU2feCV72KvxoSLFtlDko7nMkLSYc9DU6euj3N9bmxGQud+BlK1P/Cs+gVmUTKropSKdLx/jFmpucjO8rGBMcuqhnNN/JZvLQA/iKNAUlJIXKOfypAh7eDna3sRi1+jKMbS0HAqzF 4b9Dw8WD kkLx/AfofMUVhAamXsIQU1kbtisS1cBHkBgsnOy6/ZRv5kFUcyhl9Mlw3b+HkjmhPgKOi1ClFCFQISiC47kYeJoTAXUdpvdFIz6+zJce53QodTqtXjwpIc3r8BIFp00MLX5zem2PHNgremzDZfX8TSH7HpvF9ux32roVlFPfRpBf7mlwv3U16kl/FhGs1CuXsm/+21uKBNTbGCLlMtcr6OmhLu3I3SP2XF/dgLm9B3puRBKqGmG3pIDBAXHjmVBqTQBPbuRMagzPSjw6IiQ+K+xeIWmBTvmzdy8wVxWG8kJwAm/HTTAHURS+rLz2mVVrCtYwphVTc2UYsk8Y/qdxu33PmzkKgi00wqjGK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 23, 2024 at 2:09=E2=80=AFPM Suren Baghdasaryan wrote: > > On Wed, Oct 23, 2024 at 2:00=E2=80=AFPM Andrew Morton wrote: > > > > On Wed, 23 Oct 2024 10:07:58 -0700 Suren Baghdasaryan wrote: > > > > > To simplify later changes to page tag references, introduce new > > > pgtag_ref_handle type. This allows easy replacement of page_ext > > > as a storage of page allocation tags. > > > > > > ... > > > > > > static inline void pgalloc_tag_copy(struct folio *new, struct folio = *old) > > > { > > > + union pgtag_ref_handle handle; > > > + union codetag_ref ref; > > > struct alloc_tag *tag; > > > - union codetag_ref *ref; > > > > > > tag =3D pgalloc_tag_get(&old->page); > > > if (!tag) > > > return; > > > > > > - ref =3D get_page_tag_ref(&new->page); > > > - if (!ref) > > > + if (!get_page_tag_ref(&new->page, &ref, &handle)) > > > return; > > > > > > /* Clear the old ref to the original allocation tag. */ > > > clear_page_tag_ref(&old->page); > > > /* Decrement the counters of the tag on get_new_folio. */ > > > - alloc_tag_sub(ref, folio_nr_pages(new)); > > > - > > > - __alloc_tag_ref_set(ref, tag); > > > - > > > - put_page_tag_ref(ref); > > > + alloc_tag_sub(&ref, folio_nr_pages(new)); > > > > mm-stable has folio_size(new) here, fixed up. > > Oh, right. You merged that patch tonight and I formatted my patchset > yesterday :) > Thanks for the fixup. > > > > > I think we aleady discussed this, but there's a crazy amount of > > inlining here. pgalloc_tag_split() is huge, and has four callsites. > > I must have missed that discussion but I am happy to unline this > function. I think splitting is heavy enough operation that this > uninlining would not have be noticeable. Posted requested uninlining at https://lore.kernel.org/all/20241024162318.1640781-1-surenb@google.com/ > Thanks!