From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 921A2C433EF for ; Thu, 25 Nov 2021 00:01:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06FD06B007B; Wed, 24 Nov 2021 19:01:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 01E7A6B0080; Wed, 24 Nov 2021 19:01:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E29786B0081; Wed, 24 Nov 2021 19:01:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0018.hostedemail.com [216.40.44.18]) by kanga.kvack.org (Postfix) with ESMTP id D3D366B007B for ; Wed, 24 Nov 2021 19:01:28 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8E9A5184E709E for ; Thu, 25 Nov 2021 00:01:18 +0000 (UTC) X-FDA: 78845497878.09.46F2111 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by imf27.hostedemail.com (Postfix) with ESMTP id B84D370009E2 for ; Thu, 25 Nov 2021 00:01:16 +0000 (UTC) Received: by mail-qk1-f177.google.com with SMTP id m186so6342303qkb.4 for ; Wed, 24 Nov 2021 16:01:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PM6s1UNS3WRel4T/MXBtZxxguRSaKWynAztDa9BXClo=; b=Ex4k32MWenEVlvhf9HW4R2UVbIIkdFVFS/9aoLMdUVk0bpn1xxOLzfGJn7J4hPMZjH SYdzmdR5QpKzjcRrogjU0Muz0LpWM3USQ7l7PfNmfZFEkHIP7TubUQ5ia20o9gg17wEb Zg703fso6x4fzeZERSj1l2+ojMe1ZVjMdV4Ch+O+OI0WgE4vjt6RENXoCpDBEQRWqpnQ 2sg73Cpfwg+IHA7MJXO3r3IRt8qF713Z91/C+AobMBxgBCF8zAxpySCkX8acpavKrpPa bgc1Lq9AAV7u77O5geB/nKOPvGxCY11+0wBwGOJxKtmDgsbqvR6N+BY2HFD0uueK6/t4 2A5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PM6s1UNS3WRel4T/MXBtZxxguRSaKWynAztDa9BXClo=; b=JHuURli7qfhxgtifJCLPmT2LNYNkWlG40qv8wZMqVug706hva/O+gh2Xr8F8gXkNqm YsHwqF9HeDKwF48Uqk1TH62/arRl/XzYXxlwdbYJ0RVSlDHUTRUeu/iXIHuZJphFU4L1 QUtnF89lb2bwMA1QiV3K3q/CssoAndmE5dAL0bgGmWY7DAQsmZwgiMHog+JqWwAheJ0f S4YF1z9s8dGsfB25oiqOK6bliSF5jptD7UHIrfUNWuS4zcSjGh+dLvMtZSdRjLXeIKpf qDBPf/4bgYZAgMlzY9H4Zw2ghlWqHRiCYr8PBhavy63G2jAy5Sg7z+eN8u6vblU3o0nz dgjA== X-Gm-Message-State: AOAM532KfzpMgwNuP3KMSvcoSiuANILCxDoc/SF7CmP2oSCSAs8Rjf1w /7cSD02KqkZy4YMMqDjxUekJgLtO4hWYfnn3nWkgWQ== X-Google-Smtp-Source: ABdhPJyNdBioCcc3I/kDV5QhqI6DiPU3l1KaToTwJJNLWCTJO4vu2uQTj78D6eQovkdqobPkOuwSWzu3/ddWt5+4i4A= X-Received: by 2002:a05:6902:1350:: with SMTP id g16mr1349039ybu.202.1637798477126; Wed, 24 Nov 2021 16:01:17 -0800 (PST) MIME-Version: 1.0 References: <20211116215715.645231-1-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 24 Nov 2021 16:01:06 -0800 Message-ID: Subject: Re: [PATCH 1/2] mm: protect free_pgtables with mmap_lock write lock in exit_mmap To: Michal Hocko Cc: Matthew Wilcox , akpm@linux-foundation.org, rientjes@google.com, hannes@cmpxchg.org, guro@fb.com, riel@surriel.com, minchan@kernel.org, kirill@shutemov.name, aarcange@redhat.com, christian@brauner.io, hch@infradead.org, oleg@redhat.com, david@redhat.com, jannh@google.com, shakeelb@google.com, luto@kernel.org, christian.brauner@ubuntu.com, fweimer@redhat.com, jengelh@inai.de, timmurray@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B84D370009E2 X-Stat-Signature: i8ecg76njtjauspee1t9p6siy4ffct8s Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Ex4k32MW; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.222.177 as permitted sender) smtp.mailfrom=surenb@google.com X-HE-Tag: 1637798476-278553 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 24, 2021 at 7:25 AM Suren Baghdasaryan wrote: > > On Wed, Nov 24, 2021 at 4:20 AM Michal Hocko wrote: > > > > On Tue 23-11-21 09:56:41, Suren Baghdasaryan wrote: > > > On Tue, Nov 23, 2021 at 5:19 AM Matthew Wilcox wrote: > > > > > > > > On Tue, Nov 16, 2021 at 01:57:14PM -0800, Suren Baghdasaryan wrote: > > > > > @@ -3170,6 +3172,7 @@ void exit_mmap(struct mm_struct *mm) > > > > > unmap_vmas(&tlb, vma, 0, -1); > > > > > free_pgtables(&tlb, vma, FIRST_USER_ADDRESS, USER_PGTABLES_CEILING); > > > > > tlb_finish_mmu(&tlb); > > > > > + mmap_write_unlock(mm); > > > > > > > > > > /* > > > > > * Walk the list again, actually closing and freeing it, > > > > > > > > Is there a reason to unlock here instead of after the remove_vma loop? > > > > We'll need the mmap sem held during that loop when VMAs are stored in > > > > the maple tree. > > > > > > I didn't realize remove_vma() would need to be protected as well. I > > > think I can move mmap_write_unlock down to cover the last walk too > > > with no impact. > > > Does anyone know if there was any specific reason to perform that last > > > walk with no locks held (as the comment states)? I can track that > > > comment back to Linux-2.6.12-rc2 merge with no earlier history, so not > > > sure if it's critical not to hold any locks at this point. Seems to me > > > it's ok to hold mmap_write_unlock but maybe I'm missing something? > > > > I suspect the primary reason was that neither fput (and callbacks > > invoked from it) nor vm_close would need to be very careful about > > interacting with mm locks. fput is async these days so it shouldn't be > > problematic. vm_ops->close doesn't have any real contract definition AFAIK > > but taking mmap_sem from those would be really suprising. They should be > > mostly destructing internal vma state and that shouldn't really require > > address space protection. > > Thanks for clarification, Michal. I'll post an updated patch with > remove_vma() loop executed under mmap_write_lock protection. v2 is posted at https://lore.kernel.org/all/20211124235906.14437-1-surenb@google.com/ > > > -- > > Michal Hocko > > SUSE Labs