From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7318C7EE29 for ; Fri, 9 Jun 2023 22:34:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A94B8E0005; Fri, 9 Jun 2023 18:34:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 432928E0002; Fri, 9 Jun 2023 18:34:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D2BA8E0005; Fri, 9 Jun 2023 18:34:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1B7658E0002 for ; Fri, 9 Jun 2023 18:34:48 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DDEAD40397 for ; Fri, 9 Jun 2023 22:34:47 +0000 (UTC) X-FDA: 80884665414.21.351DDE5 Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf30.hostedemail.com (Postfix) with ESMTP id 2512780007 for ; Fri, 9 Jun 2023 22:34:45 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Jtv10dsQ; spf=pass (imf30.hostedemail.com: domain of surenb@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686350086; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W81GRpfjhB0fn0UjEwFmdlfLhr9DX7q54fVjX5JcBGg=; b=qX8lqcJlb0MmvxV6OZ4O5GDJYow8kjRlOZBOPi8E/OLga7oomboxRnjNdT5zQ61OtgcNjX pLQCIGC752ChC8PL807QG3xfZ+DL5hw7lwlmgY3ncSuwYNH/jm+yr5xlL9fEiMTPC+uBTt IhsfvZZa5zuR22bex9QDQPI45MWa5+U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686350086; a=rsa-sha256; cv=none; b=nkhlIHl5ynurVBl13VA2FKNIBakL4Mwq+Ynmb3wlUg6GqqsSeuSJCeeTkOaz1bEgQIBY2k kz9TSBhKNwjWWpxb/KxUxvVrygU+1I3hdLwPC0b4NN9/5SAHqMjbcL2aPJR50adtJjFyZX +HjYrsvyri0xQQ9SBbaTFotEFU7Hykw= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Jtv10dsQ; spf=pass (imf30.hostedemail.com: domain of surenb@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f182.google.com with SMTP id 3f1490d57ef6-bacf9edc87bso2153230276.1 for ; Fri, 09 Jun 2023 15:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686350085; x=1688942085; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=W81GRpfjhB0fn0UjEwFmdlfLhr9DX7q54fVjX5JcBGg=; b=Jtv10dsQTSwjnb3KMyeLUwInuJddeKAVXNSlN9syLvz8CxqBISG95KzggDHC3reL2w w1Y7ul4RtKxvRW5N4XVfUlaT8sxd4Lc8Vgj+uh74SpkuHibNLDPnP1EOaAw9aoerEnjb YCG0DrI+e5/HK3bln+hTlFdmyqRhN4T7rAvuDPnQMoK2aTl3IIONYrML5POouJAMgL8K fIHpI38+96N2+JOTHnTmatoXycHOyrhNA6Pq429ZH3RdrXT/rGlv3eFPRCZbmuSX3jVi Wu0ha6MiH4hG9zz4bzkECTS4bs/QhW8CCWyVsh56nIvhOatn/OiSvZgND3QHeYdeOx9/ OHsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686350085; x=1688942085; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W81GRpfjhB0fn0UjEwFmdlfLhr9DX7q54fVjX5JcBGg=; b=QTvhWKsLkUlgZGPSn0UKWblelZ5EeXEhPDxNb/66tBln7C0EloKADhyGSxASlmZ6cs ISVYR9okSs6pPGluKjdIGmJ463DBJcGginL0hCP9TOFsdekap3B1vDFPouTiJvnaib6a UZTiEjJtN9Mr0vfYtJphmKdhbQXFkqpjb4vf8h5BwIJZuBQBmSh3LcCXR6yOrB+6IYok wLNUfVTn10wMT/9W5F9F1huaE5iW8klPxsdx0wqCjdCmS0EiROhUTJGWN16/s3idMV8r SxegmGMwERBoTHvVsJpcyg8kIF32giPL7hKY6saY6EmLx2j+1bnGoVUBV+sXi9QjaOwj F+mg== X-Gm-Message-State: AC+VfDz+3yQJPfWj64nZS+clSclPycVufRag/DwGOYbfTKF1XMXCYW8G PSPWqEtfsWN2WmbAY8rYcllxJCoDpbMfLpmH7o7TlA== X-Google-Smtp-Source: ACHHUZ7hsTTyON0Svm2oxRxKxCgZHMCoT1i24FWMvQdNlGeE+Ok9RI+L6LTUMJj+vWSUjwBi8sB6WPekuQHZJWi3Ud4= X-Received: by 2002:a25:41c4:0:b0:bac:5d73:7f0a with SMTP id o187-20020a2541c4000000b00bac5d737f0amr2420821yba.17.1686350085069; Fri, 09 Jun 2023 15:34:45 -0700 (PDT) MIME-Version: 1.0 References: <20230609005158.2421285-1-surenb@google.com> <20230609005158.2421285-3-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Fri, 9 Jun 2023 15:34:34 -0700 Message-ID: Subject: Re: [PATCH v2 2/6] mm: handle swap page faults under VMA lock if page is uncontended To: Peter Xu Cc: Matthew Wilcox , akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, hdanton@sina.com, apopple@nvidia.com, ying.huang@intel.com, david@redhat.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2512780007 X-Rspam-User: X-Stat-Signature: 1ep3rsbn7zrbzk69gjhs46jb4hsk5bee X-Rspamd-Server: rspam03 X-HE-Tag: 1686350085-726195 X-HE-Meta: U2FsdGVkX1883VKv+5p7HucLTAoeff2enNgy6aRVnAjQ4F4J7q2l6VYS2ewzes7zL+G5NaMBW/7WXJphG5JVU/3aUMEBwAqNeqetlo0IusI2oN+1gPaKyii9WRT1DpGN8zSKbbZCcW7/pzL0+3ZAeL/adFORplXBQVTByCmm9wyUb4SW4ybAe2TBVAiqTOhjDwnWJq2SCPTcZANr2DiBWgOdLHrvk4V4QLPDAXmKKE+y/jGSd59yOCOruZu+YfUNb57VwnV87RY/rIA/mq8td/IR4iHpeTvDQDc/VTXX1KTMPs8+B3Un8kSxoNQU4/A7uxcyd/DiX1CgdADBAu6OfCPHJLPmmn+bBLXvAkwY3+0TdJNJ+/l6L2vSZMG03G4x92bv8NDV+LT9LsmVYfABCNdhYGtNfkVIwZrxa2rfiBbh1kJVje+/GxalA5iR3k8h/dr2x52HY2Tl13UW+h5Q44cASiF0qAnVqgtloLIk/XPPbFIGrbhlbQStHtJZPRakT2DQRDMLXBE2YsIb4Y+YhhhBlYEeL0QR6WYesFw7SVINruHdXW0CkGGZ9JQuWbgc/0NLJ0kc4zAYfmQIs4ahDUEbR3A7z2iKc8DHheyv1aIquxNSUP04d0PX8Sl0BDj9sgnxz+kq2J7qm8twVz7cxSRN0i7WClH2teqGxhvjta15GseYv4hkO8WCiptTJxaNmketnJ9GX1Z5KQ70ESEXEem64ZgFaczlyppnf4GtUg6G887iKxmWLCxAbdFx2CQcyIHLCEhJjHisr9YyvqkbmwHIjMiSFcQKIy4cU8I2QAIy50K+DDbh/S0j+V81SEphLllxD9JumwjDAUe13L8ba/RO2uaM73IZjTAbIMeT+qdBdZ7DOAIkHrShZeayChohsInG5pxza/gvISRcMwzwlizYSEJ4RbYsMsy0WdPMT50jqzp3rCbnoXzhCCpqJK3s0ADgxQBEN428iWe4iP0 Rb0i8wHc okXCZI/+mYMPqtDMzZEQcGTcvXfwPXiCDF0yPtQu3rA+Iow/UVEG7IMyqeQ94CoF5WknavmrCQ+A02p4AYkLs3Fo4tTRHtFGOSVGQWqbPJ4xJZlluG+8aQgE79Eno+nxn1dT0d03b595uCgN9uji1nML5gF4W9LAlm9DhUl4MTEtny+ieyk7RTbYquc96rcgp3+fWrWhLu2W4BgQtpgT09BSX2DUYqW1F6VtgEXgtf2fpu79jOyPTm1PRCEoIF7Imc8mLj8OaeE58UqxJQQGrSDkU5A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 9, 2023 at 1:45=E2=80=AFPM Peter Xu wrote: > > On Fri, Jun 09, 2023 at 09:35:49PM +0100, Matthew Wilcox wrote: > > On Fri, Jun 09, 2023 at 04:25:42PM -0400, Peter Xu wrote: > > > > bool __folio_lock_or_retry(struct folio *folio, struct mm_struct *= mm, > > > > unsigned int flags) > > > > { > > > > + /* Can't do this if not holding mmap_lock */ > > > > + if (flags & FAULT_FLAG_VMA_LOCK) > > > > + return false; > > > > > > If here what we need is the page lock, can we just conditionally rele= ase > > > either mmap lock or vma lock depending on FAULT_FLAG_VMA_LOCK? > > > > See patch 5 ... > > Just reaching.. :) > > Why not in one shot, then? I like small incremental changes, but I can squash them if that helps in having a complete picture. > > -- > Peter Xu >