From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 168B5D41D44 for ; Tue, 12 Nov 2024 00:52:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 984866B009A; Mon, 11 Nov 2024 19:52:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 933966B00AA; Mon, 11 Nov 2024 19:52:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7AD486B00AF; Mon, 11 Nov 2024 19:52:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 591E66B009A for ; Mon, 11 Nov 2024 19:52:42 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D0A23161BA0 for ; Tue, 12 Nov 2024 00:52:41 +0000 (UTC) X-FDA: 82775616798.05.8D026BD Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf12.hostedemail.com (Postfix) with ESMTP id 6E22A40005 for ; Tue, 12 Nov 2024 00:52:21 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Cmq86zwi; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731372585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x6cCgx4AVJ1dH+dX1FVPAJitnY7ihOCkP4FFSYddmJk=; b=kvOFStf6+ZIbtabNUm6neU1LeePIpCbhtdZufPS9iRxiuA6Zu4OV1pUHKBaljF95oF6ZKp UbW+YbkY2iIWPamaRLnxuBETQrdnO+DLjtxs7DRppec6h+weZEIn/GDo/zQEL8lB+ao3s4 sLt1l49m6P9fQvS/GyrF3ILsV/TOlqM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Cmq86zwi; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731372585; a=rsa-sha256; cv=none; b=h3qQZuxo/i/5nNCQwl4F0SfHRVQyMF4a+ps7I3cVOU2FcZxlX+w6bkaHdXqBpN81u8zxQs DYRUFM9JIIttAcLNG1elce86x4yEdx82Azu6sb7FzQl0cXY5K9eQEtP5jwrUFjiqfWC9ch WZD0rzbfgSAXzaPuoCuQNZJzwm90+CE= Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-460a8d1a9b7so65611cf.1 for ; Mon, 11 Nov 2024 16:52:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1731372759; x=1731977559; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=x6cCgx4AVJ1dH+dX1FVPAJitnY7ihOCkP4FFSYddmJk=; b=Cmq86zwiHked7MR4WhJDgJXXF7LL8+nIwQ2VX1uXobH++ylfOfXSepnWy23y5I+SIg eORk0vVB9c93AQaXzGuPIQ107DVBuj7B+BEkCD6MSgJowFLcVw0xYyMgCWyK+33OYR+0 sh94PMjwBm0a15TvD1RIlVA1fx+xVh+gI/gHVZsbD2aVFq4zlbajbTF7W3lpA1zD2ucI a7LCk6A2KdCvCnbx4gt61mU2dfFS/tPuknSLUyoFS9NUImDiH57D2X31EzmzDgMX8ff1 QwVX0uRH8/OYMpwQafx7o00hKagp03yEPRXFHKs/SwUPfq6CNy0V8yf0V2Bl80V/c3Ss fQsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731372759; x=1731977559; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x6cCgx4AVJ1dH+dX1FVPAJitnY7ihOCkP4FFSYddmJk=; b=X4R7N7FP04ThtcfFtMKTiXYvL/PmvgHi+Ax/cOI4qTGmtUz9tP7TMFDzM5pzWsQtj9 2QCHU0ppi7nPodDtXf69k4WqlWI4kxUaniY8cdAL7/XFUvEqJPCMYOnyRfet0QWSmPGx ijfdLy67pE4xvnbK0BUvfS3fr4ZvC09XWMh+sEGfWrMEf6mIhGmIY+AP6ZpsETm9ape8 jmBUt3NU+9DzYvVRO7cUjS5ehUHxArnOeCgMsFPw0YeLOaHPBZIc6r0G2JF5mks2E9f5 vCINlMdjTJ2FPs6KBJDI5TNMYN5gv13D0C0ZU25LoHltaiVkjN8qUaGlEClSpnpYFVVq hzgw== X-Forwarded-Encrypted: i=1; AJvYcCUBicTQ8vldShUTPIOOIO6wuFgNZjy3dF2DiWnIbZDvKcQ4W6QX05p7bUt+20yoWL0ZPCiwkGzdfA==@kvack.org X-Gm-Message-State: AOJu0YxnJWIleGB/d91dEhVy4eSPVYGTZZmAq2AYWyGMlLP4bSe6nio/ FgKVMewSASH5NWDV8/7+lvXmLbmcQUKAtZA/sYNsCg2T65lg23nL6dzG990dDI4J8UNjWgkzwXB 29PnbfdVQR8QhD4gv2wQR1BHOERACnTLSeBM6 X-Gm-Gg: ASbGncuKK/Uu7dTnuXDkFsT5TNPI0N+dBwUgBQBSf151xNdBhQae4xa9fSOqy2XJeHy jb4g7WGLTulooDWP62+TXqyckdChbqAo= X-Google-Smtp-Source: AGHT+IG+zAIYzLTdQ1lwXDTvgz6ll7kQtaxTe66Wa2ZuB18yocTGfTX10sR6zUj2cm7Dae00sJL4gqfTk8oPb8vvcG0= X-Received: by 2002:a05:622a:4e91:b0:461:3083:dbac with SMTP id d75a77b69052e-463427ddeeamr153921cf.5.1731372758867; Mon, 11 Nov 2024 16:52:38 -0800 (PST) MIME-Version: 1.0 References: <20241111205506.3404479-1-surenb@google.com> <20241111205506.3404479-4-surenb@google.com> <20241111160659.14227aaa3481648df9892372@linux-foundation.org> In-Reply-To: <20241111160659.14227aaa3481648df9892372@linux-foundation.org> From: Suren Baghdasaryan Date: Mon, 11 Nov 2024 16:52:27 -0800 Message-ID: Subject: Re: [PATCH 3/4] mm: replace rw_semaphore with atomic_t in vma_lock To: Andrew Morton Cc: willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6E22A40005 X-Stat-Signature: ytb5p4awpas56569edti3j4joebz7huo X-Rspam-User: X-HE-Tag: 1731372741-431517 X-HE-Meta: U2FsdGVkX18ZPnepPuyHfkHpLw0+H4R80fKDO7yJqSU60ju17sLyzAz3hjg0DWSxYNU7YJUwvojR3Vp+VHe6+Mg1y/4t2QntR7YYO5Dp6aiUbs7dotiUFUYzXahRhUL6fnviU+QyQwbHBjAKHfr13Fm3W68Zl5XZbML7suPo3El9R07qPwj8I5KjYMLZ/fOWni3sVs9vp1i0lI+5U5chLbSR+tcZmTQ2PPiq3GSXi97RRPvTEYqOawlrlf38u7vM2cV/eHswA2bapd78z6KMGXibeZB836ykUxF5kgUdZ/ViE3WZnx7y640K9RUYfxNR58ePwBtUrBs957LJinCwTrd92Frr5w1JqN1Db2nA5pNeOboTm5QJFCnmMWGQJkCpv+p0OLGbOuuvT+ELZ3nRf6MZ6e8x4WLcuXy4hGMPu7BRJm9oDr9rJd3gNXrAke3j48hI/NcUAMoxgepvDp4rpbtfZmbv8UqQBgebu/Qr4dw+EtKZxktZHROgV9bIYTW7tv+I+HqRkLYlFnxKCSSBRvqvfIuBkXUPr4uvIxkhMxf+MaCFM6Gq1r9l9bm4PlomF+yjomfiEuH4Q6nbUVpOfOM9IYcj65Ha3LWTHDOdiUmxbchzgWzdj9qh/jNm4YkQWihw0xuP9l3qx0qBRg9C0QouSwPeayuobk2WfYKkrB0O2C6TcbpKqvUJYXLmex3TDXqWm2B0/a85aWcpb4A2AbMkJ+qLiFYUzw7UTjaTNamMNOVRYQ5XvHoUQGAfTtHaUi6hr+/r13qqR+BKJ0Tk7gsdpWTdM8dIz12/ukKKnAs3077cLYIsp+q+ng5mOnxxcVQRUEOAsPSIB3rfSk/JiHBCor4gE/iy5vD2LeRFOk/PV9pDNLsr+hxuZZk0iTOQxrN9XV6S8DyqYxsUbxWxQ5vUshzKu4/uBmPICSTG3BHVYAxp+zyxaMAsdfUoyw2SW+ZSLrdk0kxGgALwvAM pzAjDVbz odjxYasI2YEMne5D91GHeDn8okAPW3FujJ2fRLSxF621QMWs8U3bW9Idue6SXdPc0wLaSqkXnZXOGEJkX8SIPho5wOxHPz5DdA+x8S8ugm9Hn4w+BIyC/KtI9JLXHerjD5AIrYTK2amxRxaMuJmRXVvLxLQF/INJxwleAbnJ3s5Zh4GcMQDRtnzxGUSYm7HVZUa5AXiJtuHXeLqToK9AFMvdoZTS4WPqDswJJjQSMay7j/qzPaLfvdC3oRwnCdylq+Z2mt1aIVUL/bwDhH79Z7rQHcvY8PIdHMCGRgsMTjDdz5FIp4whwUL2CBUpC1o2wHIfU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000284, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 11, 2024 at 4:07=E2=80=AFPM Andrew Morton wrote: > > On Mon, 11 Nov 2024 12:55:05 -0800 Suren Baghdasaryan = wrote: > > > include/linux/mm.h | 142 ++++++++++++++++++++++++++++++++++---- > > There's soooo much inlining happening here. Perhaps we should have a > "default to uninlined, unless a benefit is demonstrated" guideline? Implementing this lock as a separate type as you suggested should help with the amount of inlining here. I'll try to keep it sane once I finalize that.