From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B9DBC369A2 for ; Tue, 8 Apr 2025 17:10:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DD856B0095; Tue, 8 Apr 2025 13:10:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08E286B00B9; Tue, 8 Apr 2025 13:10:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E496A6B00B7; Tue, 8 Apr 2025 13:10:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C32E36B0095 for ; Tue, 8 Apr 2025 13:10:12 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 45740812FB for ; Tue, 8 Apr 2025 17:10:12 +0000 (UTC) X-FDA: 83311514664.30.6A11F6A Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf22.hostedemail.com (Postfix) with ESMTP id 69D07C0003 for ; Tue, 8 Apr 2025 17:10:10 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=INNV0IQ+; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744132210; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vEavw7wISTyL0l6A7aF6Yonm10PQMT8+Weu7nHplJ2g=; b=1eqok6y1hGPXtghDR6BuEKCTLbX3++uQY5cGkxyHjjmj4Y1ZgKxsYjK0MA2cMRPRtoEJiO P/kqhb7IpkKdVpshU5SiBN+jccuZT3tKgZxEUzkILD3daHdZCR5JGRZajguSzYLeE5B1tD nLPrVnZSjhpkwqODRSQSjlu5+6hlg3w= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=INNV0IQ+; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744132210; a=rsa-sha256; cv=none; b=VdD9ZPnfSx6PQPQrTNJn32RCjcSCO3Rq84BQcmzX1UGuSYv6W+OZcsy7eiHUs2Bwc+eoW2 iy0dYYZFeMv7iXv3+5g0pTU7mBeB3tbdA5WgnH5vGJRHUNqL3SegwjVm5NScxo8Vqqz4Ma uCw7DZuVknHERcp7XHJNlNWEaVHCIXY= Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-4769e30af66so5471cf.1 for ; Tue, 08 Apr 2025 10:10:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1744132209; x=1744737009; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vEavw7wISTyL0l6A7aF6Yonm10PQMT8+Weu7nHplJ2g=; b=INNV0IQ+mhMq4Nzjjr8zYtu1JsLMYXA+SbWUqA1h8fhXWpL7PMjv+PXKRmfZMbd0+H NStBLQholoDk1NQNrqRyHvDOtbe1pXl5tqqVJFXGnJjG5n4z5gmw7w2KSJgTDep0O/KD APS6uQVy43kq0zGlpujzamtTp8pjXPxGZV9y48q/W0qY0TLgZtm3yrA2u4ZPtNJb4VwV tJsNLdYjiZUqpflWEAEwu12mrY02kYDtq17BgJauW3V60duu0LZZtn9iUntf9Z8bPkL/ uY8II/7xtvKsO8WCghKz3AkmX0FaQTzyDrozze0/gzzulyRAOS7tDwrMWAaf/Ye6PyGu MCPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744132209; x=1744737009; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vEavw7wISTyL0l6A7aF6Yonm10PQMT8+Weu7nHplJ2g=; b=CSfkXtPSTLohHekOXeUrBkIAotv/xgX//pUCR4bz5kviIAfFceLqi2/CZKMV7F8M7T ygDsZhqp7sv4C4FLS9RK4NwTTSXUg2j7maZGMDvJ/U+SRLVjTjYqbGsfDWi6eTI+fpWY eTDs/34BowGmJJI6SKweU5AY+aLoi/nCgm74kNggt5c1V0iNUqh9EC1edUSmet61LPeF fogcvxYtFECQe1xwuAfQFFqnVYa4kjviGM43BSUuu/vkg6EV4sMB0qkeTZGphZIhBpMk 5oi9uR7A0kOvngHYQz4DHxkPxiEOCFJpb8Cje2w8IibosFQDv4JizR/MK/560kMzpsmJ ZKVQ== X-Forwarded-Encrypted: i=1; AJvYcCXZhpVMQVO3wk+NmT2gmNgFrlcxbGmSbVWFHS5ySQfUAoQgDOo3+dtq/EcOm5SI/pGPqJk2Zbpzow==@kvack.org X-Gm-Message-State: AOJu0YxV4vRXK1WSfUE1dxXkrHElOQJTKHyT9Ckoa/YJ9zOGQlRBZEWe H+qhJ25SCtUMW990b49B+lE83bSs+eIRG16xxVtWLVz77AiNhAswN61S/ColnTyy2DHDgKUo+Ss P5ZwmMSCj5CQtSOqMEhDTIo+ep+a3OheFhsQ5 X-Gm-Gg: ASbGncttphu4IushA8uqh137lBD66OpbVMwROKyq2PX0NK92S/qmusJMZxeAf+aGGRm Z2EIkRkNSKVBf3MBLj0avNCQgw2trC1ZXr7Ob348r199URY7hAlFmwBfkJ0fFjeoOLjdFN8pYtQ wTwB7ByifMyttZvNtyaiNqrpey2aojydQ/fgC9jsDVR2enCD0loxgEH01m X-Google-Smtp-Source: AGHT+IHiqT9WgiUwFoTHaax+N0RSK22VUlJB1BbpqXUuiRr9K/yDngoZwS5ZytcFEj3snPUrxhytOq9VQRJq2krmies= X-Received: by 2002:a05:622a:11d4:b0:477:852d:ead6 with SMTP id d75a77b69052e-4795e9fb0a7mr811cf.0.1744132209130; Tue, 08 Apr 2025 10:10:09 -0700 (PDT) MIME-Version: 1.0 References: <20241226170710.1159679-1-surenb@google.com> <20241226170710.1159679-11-surenb@google.com> <0d36fd53-b817-4bbd-ae38-af094bd301df@suse.cz> <40182b31-95ad-4825-9c0c-0127be1734a6@cachyos.org> <3f9f8a06-a044-4bce-a4e6-f17090cb3c0f@lucifer.local> <182bfb4f-e856-47d8-bc54-d419109cb4ac@cachyos.org> In-Reply-To: <182bfb4f-e856-47d8-bc54-d419109cb4ac@cachyos.org> From: Suren Baghdasaryan Date: Tue, 8 Apr 2025 10:09:57 -0700 X-Gm-Features: ATxdqUFWgfdDczYIBON7DSH20Zy6f02l43BIrke5gpTYWz03ZaaKpgDrA9wykEU Message-ID: Subject: Re: [PATCH v7 10/17] mm: uninline the main body of vma_start_write() To: Eric Naim Cc: Lorenzo Stoakes , Christoph Hellwig , Vlastimil Babka , akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, mhocko@suse.com, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 69D07C0003 X-Stat-Signature: two866jo5ca6ds5qjkztcuqiixmekmxp X-HE-Tag: 1744132210-363258 X-HE-Meta: U2FsdGVkX1+MaLI+yjlilF9KPaIPn27bN+bEQA86O1XJ4r3SIcOvmSF/2dMSyt+lqNW7n4nKZEmYdnGrrCEp2pysjzKio9brWbM5TpsscowCW88xK2TbCUCpfby93acbSLqQ/jj/cLBwmXvQIW4TXPK2XZRfbAZYUe139hc4nEwcmpOaJEPYF7JBInpplj6R9f/QhFYJSYG0KaZ2cUJL1j1xsYcgnJJsugFHCw6LFKpSza6G/WNsXfzWvbBWMVil8qJvnG30GdaIpqONjlOzhV/P5RcnzuxSPkIqJNIoi4t8gAoKRONVzemgXA9v9Ao5tq3CKqiMT4pCbQoE4gT/Lx46zOywJXbkd7Gh9tf7CKt6ZmQ+7VEgCVIymrHk4LP/AnZ16Uoki9ZMu1DrefM1Kdo5fziFK9Z4VXNRYMyp1ABF+XUTjtrXvW8WyRbZnpplePKvmODP4jgf3Fe79hcyTt25U99KP1MB3U5zn0YaEpzZ2tLfYP+Msk6FgxWakLRR2Kx0h34ToZNi0hkLZJfei2zadZjbEKTw6631WOOpI/M/ZcYnQEfZT3bFxNedlA74WgkShgYl/DLWeouBLL3PLFuW7zLWMoY+KMOg3icXwkpO1c9gd6ldfpktABGwCAB6m8MsJvl0dpc1gQg+qjWFEJY/DE/HOgFxw0f6SPelMfO/HZjQa19qYrvOovPaIUMC3oSCWTrm8XdvFGAKMykpmOLfCmjkkFWYRb1c8Ynb5vB7Z/j/vatRa3WDv1/MKkAE8Uku/Kr8yc9+2pOawIKvJgpUXKkvjOzmsvlowfIqIucVsRsTDTz6YQiYI0Ku8tEqRQVbVvCeYhIBXQSJqroDj3gYZv4S6ZhWPr5mVWecVy4ybk6LfL9iDOkUPH/KX/BbLmnxsUz6Bth4T7TLhNT/rbxwyQwSBJtN4S1L3z4OhHR8sQQuYMy7MfKn0ZG2xNOynwoQJm3y/9o2TwPHZsm lCBDXr5J D+uPzDzLv5wxaaFKCjjIY50jMJAXYuD6PyLl9sEbHyyoAjGWgzu1tIC+4G5wH7WrGabA0U6XXsQ6Ks1d1xzV9oXdr0qRNMSy42cO9jfNEXoT/OXOKHZUqSQLUiLgA1Bfra2RQNAf2nk4CBttpIPENxys5AFcdrYaKfbt1+zusXJcApCCnZ5crjkeT/jq2qmngO2TVxUEFKSN5YWWbN5IGBWZj35GSwmzVtBr19velPMmPLVF8ubp6LYgd7eFrTtYuaPefNWBX/3BaTW5lAIudz4KqbH5xn5rVLfCjrrxadh6vzJE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 8, 2025 at 12:52=E2=80=AFAM Eric Naim wrote= : > > On 4/8/25 14:25, Lorenzo Stoakes wrote: > > On Mon, Apr 07, 2025 at 11:01:46PM -0700, Christoph Hellwig wrote: > >> On Tue, Apr 08, 2025 at 12:39:25PM +0800, Eric Naim wrote: > >>> The out-of-tree NVIDIA modules seem to rely on this symbol, is it pos= sible to use EXPORT_SYMBOL() here instead of EXPORT_SYMBOL_GPL(), below is = the modpost error: > >> > >> No. They don't have any business using this. > > > > What on _earth_ are they using this for? Is this just via the VMA flag > > manipulation functions? If it's something else, it's an unintended use = of this. > > > > Anyway, generally speaking - agreed, this is absolutely a no-go Eric. I= n my view > > we simply should not be using EXPORT_SYMBOL() for _any_ new symbols wha= tsoever. > > > > Out-of-tree modules are simply a non-consideration for core mm code, th= is is a > > GPL open source project. If I had my way we'd simply revoke _all_ > > EXPORT_SYMBOL()'s, not add new ones. > > > >> > >> In fact vma_start_write should not be exported at all, just the > >> vm_flags_{set,clear,mod} helpers. > > > > Yup, I'd rather we just kept vma_start_write() mm-internal, though of c= ourse > > kernel/fork.c (ugh) needs it (we could probably refactor that in some w= ay to > > avoid), and literally just the PPC arch (again maybe we can find a way = round > > that). > > > > Maybe one for me to look at actually... hmm. > > > > Anyway Eric - I wonder if this is simply the nvidia OOT driver doing a > > vm_flags_...() call and then having an issue because the lock is uninli= ned now? > > > > I guess you are jut noticing this is breaking and don't know since - pr= oprietary > > code. > > > This seems to be the case, upon looking a bit deeper it looks like the dr= iver code > is calling atleast one of vm_flags_set. I couldn't find any direct calls = to {,__}vma_start_write > at first and was bit confused. I agree that EXPORT_SYMBOL_GPL() should be enough as far as exporting goes. > > > > > Anyway in this case, the OOT driver should just write some GPL wrapper = code or > > something here. Or better yet - make the driver open source :) > > Yeah, as obvious as it seems it doesn't happen on their open-sourced code= :) > > Either way, I'm thankful for the replies. NVIDIA *should* have probably n= oticed > this already and it would probably fixed in the next driver or two so I'l= l just > let sleeping dogs lie. > > > -- > Regards, > Eric