From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDF9AC02180 for ; Mon, 13 Jan 2025 17:53:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 825AB6B0088; Mon, 13 Jan 2025 12:53:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D59D6B0089; Mon, 13 Jan 2025 12:53:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 651CB6B008A; Mon, 13 Jan 2025 12:53:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3BD5F6B0088 for ; Mon, 13 Jan 2025 12:53:35 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E8E1E1A01D9 for ; Mon, 13 Jan 2025 17:53:34 +0000 (UTC) X-FDA: 83003175948.02.8A371FE Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf07.hostedemail.com (Postfix) with ESMTP id 1E2444000E for ; Mon, 13 Jan 2025 17:53:32 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=y5GbuFwX; spf=pass (imf07.hostedemail.com: domain of surenb@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736790813; a=rsa-sha256; cv=none; b=3yCKyiLkuFPROv/FJWMJdGntfhasagOQwBUDmNo60ZHiHzfIXc8DtQfw+lxDdHRGYAehRN X+LI8NzXNsUtlS/cek+7knE0MtrBW1YJYlSCe1OHJs1spgswWHRmHivkXxJZMhjubwUCnp J1pSM6JGaIdVDkrvmin48gij6ei4N5I= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=y5GbuFwX; spf=pass (imf07.hostedemail.com: domain of surenb@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736790813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bpKLo8I+x2NMmVMaXpT3x4XbSRmSmku74RXCgUimyzo=; b=gmlwranyDntTFS0OWErKLofunlfF7Gus0KLIyCar4+BR4fq7HLCYcjkfkpkKhyIXkRfd8T 5mMkk+K2OpX+Wq3fHbwg+AH6TFZnbHLqJvxf21+3mA8r6XQxztPDuozI3ha78KzPlsY3Od agOdajEFIvVD8tpJ99K5tH5t3N6QEhM= Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-467abce2ef9so3301cf.0 for ; Mon, 13 Jan 2025 09:53:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736790812; x=1737395612; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bpKLo8I+x2NMmVMaXpT3x4XbSRmSmku74RXCgUimyzo=; b=y5GbuFwXKE6+1TOW1cOzeR2+sFh4cu7f5+PWe01IHYfGReP51YpWXEYpXqM3FnpUe/ 45CQnf8wgpjM23tnxqn8s+CGis0gjt9bwdsAToHnDhOSluYQu2YSI6sskwroBPR55hor X9okpymfwIE0YwJXdJUvX5bqq5umeSD3CDI8wmBCjyst5Rg6G4X86Y0ranY7kPtKXw+F 4IsBsNPtqjKmMO2BsFxUJGI9XaEMJQqNS3abGKa1XvKAVNyZ1fcdihCm6d+KLD8YQLU9 ze1M41WmNVtCnlJJLmsWDyXiw27pafuGs2rqjVeLb72W6Qaw4bQTI/9dRa2yH+A7yEhQ tMiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736790812; x=1737395612; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bpKLo8I+x2NMmVMaXpT3x4XbSRmSmku74RXCgUimyzo=; b=Vv3XKhAleMO7q3aaOtk20AVvK7Tr57ktkVDlDJQrH9KGA2ZMareDHysgFBEu7YVpVD GBtcCDRpGQh/z/xALsnUuh4+5yfw6EUWmxFk+aQufPzhY6eWF0skkCXh6IpD3AFOfhD+ WQaIjfqIuvnjGHNzoc6E5SRDD4HYZWGaESKiMVcF8rhgoAZ2Y72mWV8429A/LLXCrHHi ExBafSElb6H0lkOAMlrqjXJrWesDKOuw0JO8qtRM3KrAwBd1s6+YzN6tFqLv44GPQj9T g2zL6bCviVLURIFUMuiJMuGvmpxYTHz3X8jThdC2Mwde1fRiDejpsj4+RWJ2iaqNmT5B zghw== X-Forwarded-Encrypted: i=1; AJvYcCU4NQIx8DRWfzkAUUim7wTODAajbVeSQvePjENU0jVY57ksDcgqbg+yQ2I7eVxwdDIpdR16uY6xzA==@kvack.org X-Gm-Message-State: AOJu0Yx5n/3QVw6Ljz/tVOaBhVfldj4aooPbi1JbSQXhS46ENT92zyam D6VVOyUu3nfIvuSNezBbPPnlc8Af7i1Ej93/xVLT7AP6OeTdczIFZ+Gax3RgF+Sig92AwRopYIp bIsdlGuB/0aeUPHRKr8Ljf1PWcnOHFognohK7 X-Gm-Gg: ASbGnct5KqcRZB6KrtrAIlsqdTCa8GS6OcDcYhnZuUnhoSfxTsag/ALPDlcpKMhp4zz qyYuYaSNN20r8HwTrja7j/ELJWgrVsUiX727Ohg== X-Google-Smtp-Source: AGHT+IE9bvQsLLb+uRt43rih0ZWtO0dvnxOVozNdIDXNbbVchkDaW0+lHeKJScBz/NRraVQozMNx+L2DJN2XAa5jZzk= X-Received: by 2002:ac8:7e8e:0:b0:46c:7cf2:d7b2 with SMTP id d75a77b69052e-46c87f3c1d4mr12959201cf.18.1736790811921; Mon, 13 Jan 2025 09:53:31 -0800 (PST) MIME-Version: 1.0 References: <20250111042604.3230628-1-surenb@google.com> <20250111042604.3230628-9-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 13 Jan 2025 09:53:21 -0800 X-Gm-Features: AbW1kvbPHzqR-A2uBg-PFCUGff_wGAZVqmOcd3vz6WT6gl-V0Z2NiuC_dffkKe4 Message-ID: Subject: Re: [PATCH v9 08/17] mm: move mmap_init_lock() out of the header file To: Lorenzo Stoakes Cc: akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, david.laight.linux@gmail.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, richard.weiyang@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1E2444000E X-Stat-Signature: i7jnqjhzr1gxycj8c69xr4hoswpounji X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736790812-213988 X-HE-Meta: U2FsdGVkX1+0SzlDP98GyQIRGE33AWHYGg3eVDJOz7RfIOwpOiVu7Cias3zBUEQEJ4kwGT35Yy3VTzz8gTzeQgnaiEiDrWn5mBPdBWEYWgpfEAqZbwSLZtjtmO/WUiTrYXuAGAmBY/oEd3A7xE143soU6jLfFGNYyuBPUwgkEkAJDUopS8gcjMQUjQfibUTq4Fste7jwZB3Poal3Y6vivftStdnLIqXV9ODDGdGdRPdKaCBzc7ziR6eAzRpLkewa4h+wQduWLOHPT0Rni3S/X5k7BgGKn6hZLc0TunhNH8RglY24GOOH8sf2hEfjkVT4Pymw9P6T+/LnIzoFHNPBXIhvBW7V9XCajbXIH1CHaQE0WC1u7AFqpB7lIIiUtalqBckjwiyPHPG5mgI/WWomRAf9I2xc/OT9XrS5HFDcX6+LOnR8D5BCoRp/aEjn3N0kTVK5PdgQoJZWxAeIkQeSAPRJGgUwwbTXCTWVLei67zUrZ+wQBC/FVeqtgIB2NLl4YgWhWFhtIv0SwRIWJBohsi/BQ6SyxJ4fyC8AQSmcRWBWx69sFAkjl7BoQm+1nI258KByo5RE+7wnLTl01pPARlbLZEg/iYp4uoXyDkhcSFS8GY9XnbVHgopcU8emn37hOdhIHn9W4Th6/poQgpWfxqeHj21O3g2DeUeghOMj7tOXQa2r7vwXqsjmyveImM3On+BrgW8ukXsMOHMkIaQlitfhQTsaRUi7T82U+GaKPwVYHpG0HxPGbEG+OnOkz/UGRQkl6c1TnqDdeG6w/zCCxEtS8RJv4zaMpM8utaSeQC0hgHYUUF8XDhqIGzHUG7LcmMoykOfyJFzg5PUUT6cAOSWR0FqO/rReRE68IHeSZVYdfskX/0WgokcgzirOaJKJ67HDhfy3fqpZkHIGFu+PAO/oChJZEcdwXEs5DC8IfI6sMOUwejsqDFADF31ZYqTV/NHdvmeog2taoTxs15/ 77CGhjGx xhcRcsJ4fVE6xGX7jEC7bh/jgUw1SC/ZPhRM5C70TES3HOYeMUwvBboEtc8CG9S549Rv1eq562KRFqyyeIzSZtmr4QANQqrUKMk2XZ+SwnZTGoZkNvDB+UI74Y6spkOE6+Vlw7WQKUBYmOgOk1nD4m5z3JMdok0jn5/MbzhUvuihBvA5B+d4XC0WJBymIAB1wVVxAu+liLilQNrKRmUsUgVWFwSw1afd1dYEDNPh2xwJchlsUDKYng8SyxUFcormCCkcl+gwRtayC6/1ii2i4YiElr1Phv9xlsJqq2QJ4ZtUghlb27LIgUfFWFHf1dUcJNBhHxi11D6mwtV4PaZaBWJXV8/sQRL9Nt4hv3+hAUF9uJfQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 13, 2025 at 7:27=E2=80=AFAM Lorenzo Stoakes wrote: > > On Fri, Jan 10, 2025 at 08:25:55PM -0800, Suren Baghdasaryan wrote: > > mmap_init_lock() is used only from mm_init() in fork.c, therefore it do= es > > not have to reside in the header file. This move lets us avoid includin= g > > additional headers in mmap_lock.h later, when mmap_init_lock() needs to > > initialize rcuwait object. > > > > Signed-off-by: Suren Baghdasaryan > > Reviewed-by: Vlastimil Babka > > Aside from nit below, LGTM: > > Reviewed-by: Lorenzo Stoakes > > > --- > > include/linux/mmap_lock.h | 6 ------ > > kernel/fork.c | 6 ++++++ > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/include/linux/mmap_lock.h b/include/linux/mmap_lock.h > > index 45a21faa3ff6..4706c6769902 100644 > > --- a/include/linux/mmap_lock.h > > +++ b/include/linux/mmap_lock.h > > @@ -122,12 +122,6 @@ static inline bool mmap_lock_speculate_retry(struc= t mm_struct *mm, unsigned int > > > > #endif /* CONFIG_PER_VMA_LOCK */ > > > > -static inline void mmap_init_lock(struct mm_struct *mm) > > -{ > > - init_rwsem(&mm->mmap_lock); > > - mm_lock_seqcount_init(mm); > > -} > > - > > static inline void mmap_write_lock(struct mm_struct *mm) > > { > > __mmap_lock_trace_start_locking(mm, true); > > diff --git a/kernel/fork.c b/kernel/fork.c > > index f2f9e7b427ad..d4c75428ccaf 100644 > > --- a/kernel/fork.c > > +++ b/kernel/fork.c > > @@ -1219,6 +1219,12 @@ static void mm_init_uprobes_state(struct mm_stru= ct *mm) > > #endif > > } > > > > +static inline void mmap_init_lock(struct mm_struct *mm) > > we don't need inline here, please drop it. Ack. > > > +{ > > + init_rwsem(&mm->mmap_lock); > > + mm_lock_seqcount_init(mm); > > +} > > + > > static struct mm_struct *mm_init(struct mm_struct *mm, struct task_str= uct *p, > > struct user_namespace *user_ns) > > { > > -- > > 2.47.1.613.gc27f4b7a9f-goog > >