From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37F39C02193 for ; Tue, 4 Feb 2025 18:14:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B23176B0095; Tue, 4 Feb 2025 13:14:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AD2D26B0096; Tue, 4 Feb 2025 13:14:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C3556B0098; Tue, 4 Feb 2025 13:14:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7C4936B0095 for ; Tue, 4 Feb 2025 13:14:25 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F24E01A0BC8 for ; Tue, 4 Feb 2025 18:14:24 +0000 (UTC) X-FDA: 83083062048.10.DD479E7 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by imf19.hostedemail.com (Postfix) with ESMTP id 0BA991A000A for ; Tue, 4 Feb 2025 18:14:22 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="V9FjLV/n"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of surenb@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738692863; a=rsa-sha256; cv=none; b=VjOT2wQ+JTt3uvbcGoEjbtje6YGS5xA037zXtGgB5EHfHRrG59pPeD8wPiOE0+emwiRK9s 2HSBh3u+jzf0yZB2TfEDIGRCO0yfDLcodjvAmwh1zHv+b+y6aYKL4evNcRUAwWCz65jBRA k8MceyIXQp89K4gJb+TM1a2/xu+wjN4= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="V9FjLV/n"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of surenb@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738692863; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NT8D/ASvroySCOIUqc+sWLUBAVfNqfn5SXuV0Op8oME=; b=aFst80jgn8iPkbD6hPNF7WrMPu+5WNZjEDuSU0llDwJb9ONZhvVv3fGABFgEVqX/oDvciS EMpPSyF3hT+Q6VuvM5bG1upfK+PN1epwKLC78RXGQhVfTIIk1/lq9AhGUI9mRfwsENPAXA EHDKwElfbRidve6DjcCkxCUSfvGgwSo= Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-4678c9310afso272591cf.1 for ; Tue, 04 Feb 2025 10:14:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738692862; x=1739297662; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NT8D/ASvroySCOIUqc+sWLUBAVfNqfn5SXuV0Op8oME=; b=V9FjLV/nF/qNRkxUxGDtUwQooIyKxR2JKYAARo2uu5mVqPTlkQDHSPXebtHDy2+5tV yTrFB+2vffzbOVwc4KV77Kq7pyg1+fb3F7JTgRL4ORo46kxhnljjWKJcMGpGg6XLaISk +VK0dStfKIyecmmZzQE4qm7zoudhUIUR8P4vDM0XBCpkq+QOhBNc0AyFQsr7ILY4RsC4 HMhaB5jcdfQ2lRS/RCHt2lk/Ze8hyJ6entNBOSWdLfx31+FDkcVKsOyBy8IIe9rza6G0 DcQCvR/0mJdHNoKPfiB9NMd0KmPQ/JLmXTIYsINd8+f6EU0JIDCAdKTdfpihQ5JKfiCl mD1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738692862; x=1739297662; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NT8D/ASvroySCOIUqc+sWLUBAVfNqfn5SXuV0Op8oME=; b=h1kCCTdMDqQklz7kXDqdgKl9HQ1wymqbJTErLJa70YDuawvFePp5A5gxO+B8W4OpuM aWXSY21iVYt8+cOSGSUsfWtDN7TnY42pGQRKlUFcoAPjLAw2jldZNwtjGW/yzDI34CLH jxyrAcj0KnoUg58+4q1mfltctFUGvXBRL9JsSCPWRpymtc/WY+D71cUoOtxC++/VcILq U89md2IpVyqispnC/8pWZSEbmmp0/loW2Tpvb4O9UnHZPHkDzDHKNGB5eVTe2otOaO16 EsFF3YouBcqRSK7FsrfVeGPXfnk3vqTjXPo3YVWAgbHNZnjBCynY1Eje3SssUvMVNbzg XKaw== X-Forwarded-Encrypted: i=1; AJvYcCWZL0Vs4/VFA8icasuj76Y6L26fRKcNYFKTIN0TGs3hlv2KuGc7KA5JXpkq37Ht+8e/32Z2A3CxPg==@kvack.org X-Gm-Message-State: AOJu0YzLLItmLy6svPaWmEzbcJzDjIrEN1qyf/vLfLk0AR7FWq3GUCtd jJNWZ6m8nSJoot+qGxgmdBrhh5dIRnSlwrtxW+OTZYh73rrCs+Mb9P58SD09GqUyGTT32hZgpJe lAP015WKwcIyDJ/unGOOJroI/7GE0ObEgycHt X-Gm-Gg: ASbGncuNKsdTcCPjDAWpGLlc2+wevX7+Ki3aShJnmyHmoRUpjYUAavH6dved5flyEvg Nc1CDwo1/kG+Na3VNBERXmjPXE9vua5t8KHRt73MlOIYzB+oE0jKsoSUl4/RB3Fs3Ap8r2r1MqF 1rcIhOTZY+KegMAqqQxDjkmQomwZ0= X-Google-Smtp-Source: AGHT+IEa8EF3C+YHh8oZA7uFjt7+K2oPsJl2Mr0RZipOfR+N7UZXzleg+vqdkoHPNT/b3Uym/WPIFDlXOM7/ddZ2/GQ= X-Received: by 2002:ac8:58c2:0:b0:465:c590:ed18 with SMTP id d75a77b69052e-4701ab47861mr3818331cf.9.1738692861900; Tue, 04 Feb 2025 10:14:21 -0800 (PST) MIME-Version: 1.0 References: <20250201231803.2661189-1-surenb@google.com> <20250201231803.2661189-3-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 4 Feb 2025 10:14:10 -0800 X-Gm-Features: AWEUYZlMAX96jgJPDOCW65ebrkqnWSx56hEvpAm8q11zGEvqTSZ7NeWFSDeqdLs Message-ID: Subject: Re: [PATCH v2 3/3] alloc_tag: uninline code gated by mem_alloc_profiling_key in page allocator To: Shakeel Butt Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, vbabka@suse.cz, rostedt@goodmis.org, peterz@infradead.org, yuzhao@google.com, minchan@google.com, souravpanda@google.com, pasha.tatashin@soleen.com, 00107082@163.com, quic_zhenhuah@quicinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 0BA991A000A X-Stat-Signature: 4pefza3zkpis8p8qdiusz5dghspm5bsi X-HE-Tag: 1738692862-416366 X-HE-Meta: U2FsdGVkX19frJ7SmT6uGHZsQvqaRnWiK3ihS9l5+RUzl9K6Q7jEclOOq/nGJZXRL7fM8CFfAQAy+1xyec3qVyNGWLo9CbcS2FfmebSetc80UCfoVi7zmKhu3+DGSIjI2V9DLvp7qxUWZxw83wn+sJUaxMtBmjYB+K4TuFL9YwFoUNdlF5g8xU24wmEmaCWtuopK0ma4QTEInHMdccNvuMiiHG8T7C0jy87tsPGjwJN7p8ycpOhZWgYqpuI2I0vUjSLqb6BcaJK8R95Na1Q5sg2tAW9A1uSXvOiSnzL/nofqWwTrc1CuiCT8g+95x62zA1xhMg1X0dzFUubPVwpCbg4hDgUOAsyvp4kZd7chDIHUonzvdglegBDYbbEbQ8E136UbAM6XHiMkvRjfs4UJnj2Ntgv1lTtXM1YA6xJ1J4EomOvqdc7dQbKZfOnCcoV6mmdMI8g0V1Mq4ZraD/vpbvO+6BRkCvAl/6pL9G4PqkuK+FUasS9Rl+jFQTyuZiiX+1CBIjGs4s5o1iq5ugyxHdfnvyH8gaUy22H0yHFi1sU1jHIGDjkyPm+TVgaRBUGJFg5fRPCeeqhYt7yqTHh7Rbpy8l27gNZCMBNxYwW0FwxCneLnvbbH7O+0/JrRYss1e7zptg/fyetFYNfrk3EH/p+/mBuglCRnW5X4NBRmJGIhCnvO/3JFskBjjOgtzV08cu3bfpjzXv8RJv7PyyDUyS7Ia4uFs1qXvFFnAS3CeHwFjUisXhPoavFDO3mtCzv4fOWuONj606NBC6etqBceGZmTVVzSjg8sJNMH/eMraLjQ+XdTMhisuLdF9GnD8wM3s7860Rsm0/TnjOb4XcSQCcqXAgBbwrzDskyft5oCVBp2ICi5hCsx83DQl0Q/jFKY9XyVWVExuoTWhHFzGeva4oV74GNEXk6ydi1nfGskvuZSPTFfHNpnvupelu97TnizH18PqB/3VTho55pn5A7 ZJbcVXTM 4E/j+aT//duqL4H80JS5jiwQpX6xK2xdsP7GBbI0aduUpfWXAhNVDCdtEiLgkOqsbIGkC62/e8090D6bS6Oi9eRM4CiuNYa2w4j5UEBd7JFGbt5hscaDvfKZxnqjSYwqqs4UmLACjfYWCLyjUwZKu5VE8t5maWWeH2MeW+5Plw3dAPPebBXoCe2/brTVMwE8Vi/YwX5dcb/F7JohZ/Iv0SdFuLkfHo9ZkDqqHGASNKyVm30gDif+JOyhgt4bghMmsphqpHjxmv1A5DHY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.045416, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 3, 2025 at 4:47=E2=80=AFPM Shakeel Butt wrote: > > On Sat, Feb 01, 2025 at 03:18:02PM -0800, Suren Baghdasaryan wrote: > > When a sizable code section is protected by a disabled static key, that > > code gets into the instruction cache even though it's not executed and > > consumes the cache, increasing cache misses. This can be remedied by > > moving such code into a separate uninlined function. > > On a Pixel6 phone, page allocation profiling overhead measured with > > CONFIG_MEM_ALLOC_PROFILING=3Dy and profiling disabled is: > > > > baseline modified > > Big core 4.93% 1.53% > > Medium core 4.39% 1.41% > > Little core 1.02% 0.36% > > > > This improvement comes at the expense of the configuration when profili= ng > > gets enabled, since there is now an additional function call. The overh= ead > > from this additional call on Pixel6 is: > > > > Big core 0.24% > > Middle core 0.63% > > Little core 1.1% > > > > However this is negligible when compared with the overall overhead of t= he > > memory allocation profiling when it is enabled. > > On x86 this patch does not make noticeable difference because the overh= ead > > with mem_alloc_profiling_key disabled is much lower (under 1%) to start > > with, so any improvement is less visible and hard to distinguish from t= he > > noise. The overhead from additional call when profiling is enabled is a= lso > > within noise levels. > > > > Signed-off-by: Suren Baghdasaryan > > Reviewed-by: Shakeel Butt > > One question: Is there any plan to enable MEM_ALLOC_PROFILING by default > in future? It's left up to each distribution. In Android Common Kernel we are enabling it with CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT=3Dn and allow vendors to enable it using kernel command line parameters. >