From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D28DCD128A for ; Thu, 4 Apr 2024 01:50:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB03C6B0093; Wed, 3 Apr 2024 21:50:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B60F26B0098; Wed, 3 Apr 2024 21:50:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A279B6B0099; Wed, 3 Apr 2024 21:50:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 860B16B0093 for ; Wed, 3 Apr 2024 21:50:19 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5022E1A0D34 for ; Thu, 4 Apr 2024 01:50:19 +0000 (UTC) X-FDA: 81970169358.03.79EBE94 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf24.hostedemail.com (Postfix) with ESMTP id 52988180007 for ; Thu, 4 Apr 2024 01:50:17 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LW44UgOL; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of surenb@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712195417; a=rsa-sha256; cv=none; b=Gwri+/FHeaDhbkvPj67EvDve4zc41ixfElHUjaeOz3Csb5Iwzq8fQDitJF5yZyTepTRsgh Iddfn3SbSS3dvOAhHwIUb4e4MnhN9pZhHnRocxufvOxkSQuyPqDBBiJ/RcJPSTEUvBPznU YYKAIxkmJoW3Ql1KZs1rFCHoHB1FL6w= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LW44UgOL; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of surenb@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712195417; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DjyUXBEbZolu4R+4mdtK858xY7CCuNq3MZLz81KaKUo=; b=MI9F572rHGqdoqYCNar0Hw5DeftOO/S1lfGGLsAFhKMaWIi1J77NQR5Kj5bjQgOfUaJk8A GMIR4HtUv1J7bO7mzwC2CYiEPI20KR238P+DoTiawtGKtPeFNPx2oNiT3ZOrSpxsWh/Dcr WYUv8RmJduAF4IHjMuGf6NW0KrE5Qfo= Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-dcc6fc978ddso408213276.0 for ; Wed, 03 Apr 2024 18:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712195416; x=1712800216; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DjyUXBEbZolu4R+4mdtK858xY7CCuNq3MZLz81KaKUo=; b=LW44UgOLw41yGlWIY6rO+ZIYe25ZZuWkr0zn+HAxX9SegYzS4R9K2OIZJE9OiNakE4 sLc53QTwR2ursz7AteshDoRCGGU415H8KQzatm3AhQAExKJ0g3Ta9SIfI+vcTnLlfjF7 wqwvWTsBFsmtTV8yOU7U7nuiQvetKXoaNhiiBm8G8+OOEcvFA/J4eB8yocaOaXiEYW2+ ihKafpWI4Sbxms9sLrKcmdDNvP0HUSZR3ST3n4PZMJjLrz51h6Y2e19Cvn3+KC8yEg3t gzG9MwYVQ45psEFC3Zj5lu5o4uH1oDjNxXnFKp3uv1XtrpXact4AY5cAnesD+kakgUUD R50A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712195416; x=1712800216; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DjyUXBEbZolu4R+4mdtK858xY7CCuNq3MZLz81KaKUo=; b=egxHEb+96f+GfBgf1/+zP6e3rmPvp9ZANiVF/S8pxDDAHac+ngOjQUG5vvSE3ovYF/ EJ8StgTtoVAJ4osjIvFqR0miDpFmBI1HAXmyNyNVpaPsmakdcCsKIXIQi9uKozGRxYZB q42hMyR81jSP4mWQrgx2LgEgq8BKMORA14f22PqKoQRuEWfpyaN+RfA2NLcEvtcBFdYh tS83IG8YHS/GHGfuk2fE3bK7k0lr1VqVgQQvP/ixYUfMlwLRMp/C+DX7ZlnwepA9Z7Gd l38ZyR3VB47xQIM4k9i0igSkvfc3OGsr2HAT1EjNKQPiChx8KsHYbwTYjiZ8YUt6FvVu jQZw== X-Forwarded-Encrypted: i=1; AJvYcCXnc3K6z6N/p2XcfeAu1gqEt9K0WMgbZee6E9laeM9dXFhuPUBDuLNFzU8vfJs5tq9SL3cryB3DmMl5XdiT9qUQaqA= X-Gm-Message-State: AOJu0YzGfhUjKPF8fq1BxlDSXnCnb+dc+RsZK78IT6Xt1UbKYtqSkH76 sqimoDYLQzj79Q6QXoBPH5pUnx4zXts4Ivugrc7RgUj94z2cq5kaDsPPfoRKQ3r5DxF//mkR5TC 71xpOJxl7aC956MkTauSo6uSoKaWk8eASiywS X-Google-Smtp-Source: AGHT+IGAysqV52BGyDKFLUgTf4MFZje3HOcB4AeU6v5pQmUTWzkKvYVZpzsr+kl5yzUdyGDkX/R09oJNrbzta/FQWNg= X-Received: by 2002:a25:8085:0:b0:ddd:7ab7:2320 with SMTP id n5-20020a258085000000b00ddd7ab72320mr3162428ybk.27.1712195416050; Wed, 03 Apr 2024 18:50:16 -0700 (PDT) MIME-Version: 1.0 References: <20240328020711.125070-1-jiapeng.chong@linux.alibaba.com> <20240403182320.93491c23ed5ae19e94158ceb@linux-foundation.org> In-Reply-To: <20240403182320.93491c23ed5ae19e94158ceb@linux-foundation.org> From: Suren Baghdasaryan Date: Wed, 3 Apr 2024 18:50:03 -0700 Message-ID: Subject: Re: [PATCH] mm/slab_common: Modify mismatched function name To: Andrew Morton Cc: Jiapeng Chong , cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Abaci Robot , Kent Overstreet , Randy Dunlap Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 52988180007 X-Stat-Signature: o5s3gym1miy8spdpjpoxwu7s99t8qcw5 X-HE-Tag: 1712195417-597543 X-HE-Meta: U2FsdGVkX1/wkakSM19fcxDdYBQRWxVgxXDitJIavMzTmJ/PBEETz6aoynmQfV+6wuc2DTDOUhuZN7lQzMGUDP/w724Sus9c//ip7RcDmNSejOwPT2QgPR90fac71Jtgy6L4r/+ku9aCamo4Qm0pou1DdJQd3Ue1YA7cyJI/2qNyHYfhTyFUEsH1EkYbVyZhQ5PkuCsuv2PHsyRx4KApPZtXmJ/EbDFSw+jt6/l+WAlFoo3lpJ9ZR1aCdcLufmi+p/0wyu4zli7HFgDwgCadSqMB6puraFEtDYEj0G99qKkre2ZPTcOsCGI/5WBSh7U0tJ/WgjrNS5dRKwHrRXlFRgHqKjvzQLWO3xwvtP/LgiHLklKEBfvzywTWnbfEcuW/YW18fVW34xwx6Y1mXFCHbhVY0XveJIXKz56EaO0w/Qzrjz+oT83VboN+sYLxT5Q+p9qMaUlIdW9ofGkqWiGEXqHRg7JD4zrsnVRbnYYumlGquhvgJpFNYF2VuHC+l0erVB0k03f6UpBMXP/DvrYyi5iy4GA+dyWfFRpdTFTmcHG5sz1Nhe9Wfdobcg0SZ1CmEN0y7A4f8sAa2JUx2mRI33v7hxjWqIkVB2ct+61MUvAW+6JnWDeeqnqHDcMv774zDAJWuNgrSeI4a8tz7k7N3YdIjKm9VIikO7bed7kx1T25YwosAA7u7vOAzyLkNEEkMn8xEJtT4EeNzRhloRrTb73CNPMXKdD0CjW5Lw03mODrPOjZ4qYf3S3YZQyp1aRUvLbrnk8q++vp4WpQ1mSrhbP6MEJSKjWAZWtqUykON32gwnN1PBohuhPGKN1WjeOlxq/ZY8/Dtvry5FGmymXkKCWPtVIrpFgp3ZDJ2LZ6tknLaweufg9zta4Sc2Ye+rjChfdqi9flUjt+U7TQngVqcLcjL/hfP7J1UTyVk0z0EldclNHoVwDZ9aR0D6LaQ3yZveU6SFzWWJRg1joEvQl dAgK0jzx HFxjIacTCi72hazu6cVn/Nf6bZsOItD99rVNNGxCpOoRwflIMeRJ+yvBJcglhMuk6qbhZoduRkHXYoRjimXAFGy5CH2YQ+8RNB/wuRwjBerAwOnlPgEZ3gHMHefyw1uLlnMmQNJQdpWlQC8WeSz68uQVIX5TU6Qac6A/TQx85/c3uz5KdjbhowTRD+rV1JdZFuKWgIYf42aUcZqx+T1ybjElTDV8bi/SyFMS52bpZvFYsN6/jkoxmAg0jXl93G0uUIlG205GkCEKnd3UjuHiBZZcX9N9/U9/LUmog8v6c6BA2HIfLmV7nhT1Z829ZfMZ/OqoMrOQUkVM+qqZGaE5LGtQXVGaYYbSylvF1rvJ/VpQGf19igc1rI/mCJqFfnXlDwyomq0CVbim1lqVsLUJ7j7m5olkrYey+M/fVq5dfZCnLXXdERHHe9osq1asRxBi2UWUFx8hAXYS3V815qKlmhPLmOVP7XnWcj1K4kx4Xe6qQPKS6GPUXs88Bw87XN8q7L0EBJf0WSbtwbHqA5Z4SKP1WXjDTjflkxqG0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 3, 2024 at 6:23=E2=80=AFPM Andrew Morton wrote: > > On Thu, 28 Mar 2024 10:07:11 +0800 Jiapeng Chong wrote: > > > No functional modification involved. > > > > mm/slab_common.c:1215: warning: expecting prototype for krealloc(). Pro= totype was for krealloc_noprof() instead. > > > > ... > > > > --- a/mm/slab_common.c > > +++ b/mm/slab_common.c > > @@ -1199,7 +1199,7 @@ __do_krealloc(const void *p, size_t new_size, gfp= _t flags) > > } > > > > /** > > - * krealloc - reallocate memory. The contents will remain unchanged. > > + * krealloc_noprof - reallocate memory. The contents will remain uncha= nged. > > * @p: object to reallocate memory for. > > * @new_size: how many bytes of memory are required. > > * @flags: the type of memory to allocate. Nack. > > Well ok, but krealloc_noprof() is just an internal implementation > detail. I suggest this documentation be moved to the new krealloc() > wrapper site. Because krealloc() remains the thing which people > actually call. > > Presumably the same applies to more of the new _noprof functions. We don't need this fixup. Randy Dunlap's change [1] should handle _noprof suffixes correctly. The warning was likely generated because his change was not yet picked up. [1] https://lore.kernel.org/all/20240326054149.2121-1-rdunlap@infradead.org= /