From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C577C4829E for ; Tue, 13 Feb 2024 00:47:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 193776B0085; Mon, 12 Feb 2024 19:47:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1438F6B0087; Mon, 12 Feb 2024 19:47:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00A8F6B0088; Mon, 12 Feb 2024 19:47:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E68E66B0085 for ; Mon, 12 Feb 2024 19:47:19 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B26641C1475 for ; Tue, 13 Feb 2024 00:47:19 +0000 (UTC) X-FDA: 81784941798.14.FA86469 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf09.hostedemail.com (Postfix) with ESMTP id BDCF6140005 for ; Tue, 13 Feb 2024 00:47:17 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=l9XQ94B8; spf=pass (imf09.hostedemail.com: domain of surenb@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707785237; a=rsa-sha256; cv=none; b=GRys+KkAiH+KqjuzMrjUa9cy/ttVoWLhiH31VzuoLp73im3nsAUw4VjgmqiUXNF7KQZEaa GehvhuACxUq3PW2mL4MYDfmLUyE8RCez5NCw1S+GqZG0HO3piWE23cC2H5aDk8tRdRIZOj 1eDFODD8DNKu27C/oJIAYZKWUnx09EI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=l9XQ94B8; spf=pass (imf09.hostedemail.com: domain of surenb@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707785237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6sfE4CKDsYgzSNtG/2Z/eISWKsnaJqJipJlJ0mll8gM=; b=QBHNxWZfF5jlLe3sJZz2YiIhatBmSArO0X9pbEAR2OfQ/64ZNw6KSNqSmPQikwrUZSRjmb RoIn15mkktT7Mkbr+nB6075Rq5LEC/wH6GKhSl5IdPgN1aN91Nfs3KAcmlOeXJUYICOIsp Um1g6js7D6vVNKQB3f872yG/1ZGsppk= Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-dcc80d6004bso125226276.0 for ; Mon, 12 Feb 2024 16:47:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707785237; x=1708390037; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6sfE4CKDsYgzSNtG/2Z/eISWKsnaJqJipJlJ0mll8gM=; b=l9XQ94B8BbuLc7cPBByC0QKow9qxYXZmvaWAK2V6RALYyyCrFObovyXxFwvhwyoadb GI68jtlIekDpG1vpIbNdS7oo13Fmv5qMWO4FyPSHgmCverMcEJ9oJFW8SchWP0kcs114 o374FXHLKuUdCW+SLVHCgVaJ5huTsdWABi0FiWXbI06XfYgJqbFUWBbzCeLAfkfr0HCQ MX7TYG7WQYTTdsLpT+njho7VDjCz54sAZjUrhKav4sP9/6yZqSlTP146wsBPfzkgLK3B 8xfhYslILea93bqkzPO3Ns6BMtHG5GkXGH3UG99mb4rc5ntqceEY+T3AuiJtNTnKr5t0 UIUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707785237; x=1708390037; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6sfE4CKDsYgzSNtG/2Z/eISWKsnaJqJipJlJ0mll8gM=; b=CYPtt4U47E/97Q9UbIDSyxxoqMqrPyrCua2+h/LMNsXPjqJ9FRN83xtIlL3N4bv9mG L4crppR6y8nnhkTrq6TBPbKkQWneB3PmdxFR1UDE4V9xJj90pdXfMPAoKYu2f2hqU4KY vp+irhQ+vtwsw3aTwBvZu58mefTMHG+EIC8JyKqoy7+/krE8TwIJweSxB71eQE8/t5st 3i0cNIFNsmjUPRLNKUqPGvZbWVtlKdK7LICMfGibstaVWPeyvMzfawQnxX+peoSn1e4O 6DHSxbAlRzS+X8VGogfOXRX4oga20Aia1QKlrrwmwWJarIotPSlTpZDbkH+LbAVdWFNu e6hw== X-Forwarded-Encrypted: i=1; AJvYcCXW0g2RHpWIZ46bslOxwBH8d+NZICkJ7Se4HDsOuTQ6zHOk4xUG8XwzGYBpSmuaIOBq4O8qWYqAXwxQme8eIDxcxag= X-Gm-Message-State: AOJu0YxK3Qh0KmQ/ck+JkLOhficaWkW2POunF3Y6vyiuDvEkmctwpH9H XlTYX+FWEQ3BV06ryChJZsqX0nVmV7cQljcYEddCS6P0OpTUEUc2yZYKesutzbXFLn3Ab0vXUn3 ksEwIwaj3yP1qYJEi4B8qVNCdMi+a+WaSft48 X-Google-Smtp-Source: AGHT+IEd+FNtHN/ZZbzmP1f2A4KejGHdBoOnJaz/mv/ay/4vdGzg6uBQFsFNAQAmwG2iUWNQFb7fDd1J4oxNlZWT4bQ= X-Received: by 2002:a25:848d:0:b0:dc2:50ca:7d03 with SMTP id v13-20020a25848d000000b00dc250ca7d03mr6944337ybk.1.1707785236496; Mon, 12 Feb 2024 16:47:16 -0800 (PST) MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <202402121602.CC62228@keescook> In-Reply-To: <202402121602.CC62228@keescook> From: Suren Baghdasaryan Date: Mon, 12 Feb 2024 16:47:05 -0800 Message-ID: Subject: Re: [PATCH v3 00/35] Memory allocation profiling To: Kees Cook Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: BDCF6140005 X-Stat-Signature: urxmfknrpnczwtk8mq7on4pjjnebsmrk X-Rspam-User: X-HE-Tag: 1707785237-24836 X-HE-Meta: U2FsdGVkX1+FynoljPux9FiO26sKqanFcscM22fZZ+oOfbLGaXgeFxJRzD+Gq/jx0vSV8SDpvWOEwSc1/nj36dgEPdQBYZZyM22nDeryykLyXbrqdc5We+FZS7RzHmsNRf3HlE1otMk5cZLAyW1onjaubCUyzfVMJ2abdn53ESH/O4WOszRUOU3BHv0PawoMOTjRZq+gsQbQwIFVO580gGh4VHjw/Vzkwcg3PV9wPcifvtMgqftwwnZdGuHFYZuxLCgMIE99+9LLgtJ/VVgZ92tyjYgO/3bJrb46tmkI6IC28R0SIzeQQy4qER8jf9sYHSoqZJRxCMcQw8AhjKcRRaqEWIallCeQ01W1iAZ7xPU1TwCjJz9IeUgN8AvccjN0592ndWKh6g1kBQPsOQ0y6h0t1kIyy96cyP+lhy+ClHuS00q1+KP2pqMRRUTU26oTN9yR9/T3q+xlEPKs5loYweL+7TdreZVFcKfLf45XhqIgHXPNIaUngdJik/b3WriON8VrIqOX6QPjMC9noLwv8gnsiQgq2CpzMIGqKJWJvunaPs/fXM2iUcFN5AZ3kOX+1V16tvWGK69sUENhEJ4fAnITfEdf9gYOGJZAsBZRQ063cPyoh5gXG2iXmTu9up5OYNjIJFbtJSb0dkERzRvmPyk36fm8edlC6DKLJb3Ch7iJ8dtIdKkIu/0PI5z0yaV92Y4Os8/hjujkWCVPOnVWZWLdscQODNaZMsXz1uDEbo/gESLXUg8BkuT5eFglKnoqU9vvEPy5A52Qb1BlPZOUQ1qA9RddMXCd+cx6hd6re9NX00eGFGm28kY5wqCydEgel4pm00eK+qKWCgu6ZxEOEbma2K6dvW5mFKEJpz15R6AbdTLiSosKRD4RLTvnOia+gZapZ4vzxO/EMGVn6kF9MqiKxB5P/KEur9C0XmpzVwX9mgSn5MhSVxDCvmMU7pNawH8MqH2CnqERDziIIeH +exMJla7 CGQrHKIAMVnUPbRaYSAln7qIIj8TzNgepEKAl1nxkxHOWC6YrCYCz0YIrxWV3bzegKnxPb4L6Y5qg14ixtrsJMclRLYkUXKubCDXOcN20vVtU16FqQZgOCVn9CbKUwY5q3Bx4WdZ3oXPRLd7xy4mnI92/CcX74JYvSkuJ+POgWkggQXuXZeYd0XwKPJ7mQAf2ZaIFK2+mL0UbP/TUAu6Nq/mFW3F7Jq8+Pm3FjcPqKuKJDtvVVD63hiDXujxRc6K5/4RhRuKkiVBXGElDVmFz//Xnp/quc2Ysic0+ew+F/CE+i+hwzA5VQufvRV1XsiiRNq/f9+tQsOh1/ObXodgwhgzq1+gF/Qeo0mOHWYSd9ifFsj5dVTWHKu3oFNJvfRmMXBR6lTKZXiYxOBeqBdTrMXvyR3zizie2AxTP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 4:29=E2=80=AFPM Kees Cook w= rote: > > On Mon, Feb 12, 2024 at 01:38:46PM -0800, Suren Baghdasaryan wrote: > > Low overhead [1] per-callsite memory allocation profiling. Not just for= debug > > kernels, overhead low enough to be deployed in production. > > What's the plan for things like devm_kmalloc() and similar relatively > simple wrappers? I was thinking it would be possible to reimplement at > least devm_kmalloc() with size and flags changing helper a while back: > > https://lore.kernel.org/all/202309111428.6F36672F57@keescook/ > > I suspect it could be possible to adapt the alloc_hooks wrapper in this > series similarly: > > #define alloc_hooks_prep(_do_alloc, _do_prepare, _do_finish, \ > ctx, size, flags) \ > ({ \ > typeof(_do_alloc) _res; \ > DEFINE_ALLOC_TAG(_alloc_tag, _old); \ > ssize_t _size =3D (size); = \ > size_t _usable =3D _size; = \ > gfp_t _flags =3D (flags); = \ > \ > _res =3D _do_prepare(ctx, &_size, &_flags); = \ > if (!IS_ERR_OR_NULL(_res) \ > _res =3D _do_alloc(_size, _flags); = \ > if (!IS_ERR_OR_NULL(_res) \ > _res =3D _do_finish(ctx, _usable, _size, _flags, _res); = \ > _res; \ > }) > > #define devm_kmalloc(dev, size, flags) \ > alloc_hooks_prep(kmalloc, devm_alloc_prep, devm_alloc_finish, \ > dev, size, flags) > > And devm_alloc_prep() and devm_alloc_finish() adapted from the URL > above. > > And _do_finish instances could be marked with __realloc_size(2) devm_kmalloc() is definitely a great candidate to account separately. Looks like it's currently using alloc_dr()->kmalloc_node_track_caller(), so this series will account the internal kmalloc_node_track_caller() allocation. We can easily apply alloc_hook to devm_kmalloc() and friends and replace the kmalloc_node_track_caller() call inside alloc_dr() with kmalloc_node_track_caller_noprof(). That will move accounting directly to devm_kmalloc(). > > -Kees > > -- > Kees Cook