From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EB29C0218F for ; Fri, 31 Jan 2025 22:51:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D16B46B007B; Fri, 31 Jan 2025 17:51:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C9F396B0082; Fri, 31 Jan 2025 17:51:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF2136B0083; Fri, 31 Jan 2025 17:51:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8E3646B007B for ; Fri, 31 Jan 2025 17:51:40 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3AF30B14BC for ; Fri, 31 Jan 2025 22:51:40 +0000 (UTC) X-FDA: 83069245560.06.A5E35AD Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf20.hostedemail.com (Postfix) with ESMTP id 562D81C0016 for ; Fri, 31 Jan 2025 22:51:38 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=WK4KHWM6; spf=pass (imf20.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738363898; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CRVZdM+iGM9ixXB9jH54KsnnAGGH880gk3OgBWFCBzc=; b=uILYjcmgKvLpHONCCFIRPYlWTgm/qoLRpOgCcVs8brFQqGE9EkWVI8JVvXc9NHJVFzs3HC JaBJwWKu0VMVDH+Bsi9pE/9TLkAG5MEe/dfGjhUZ0EUTSCLlsbjbAdzD5LB/i8bpjP7UwY xFsHQMKTll8Z/+8Vgo/mP21YLh8WZlM= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=WK4KHWM6; spf=pass (imf20.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738363898; a=rsa-sha256; cv=none; b=1utjb5P6zVL4QrAS8cv3WpKH+2PZ4aI+zxZ0t/yTCClPRgnu4vuNgu2ogBChxhuEH1gbjL ZN5LjerQnmM3JTx/Q9HCtRA7ktp7Eis/PYsrtfNK7D5TzKK4LoOVKxj9rCRrEXEAqXwVXM cV0qv4DrNQALZxK90ZI55wqP6xlptP0= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-467896541e1so74761cf.0 for ; Fri, 31 Jan 2025 14:51:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738363897; x=1738968697; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CRVZdM+iGM9ixXB9jH54KsnnAGGH880gk3OgBWFCBzc=; b=WK4KHWM60Q6OIupk8zdXc0Q6JpfP/BQsHRQXFrGX1KV2dO9/sQa7nRsxkhFPzVfX1V f5GeagRo+hYsv6tcLtvRtmNYBJXyNdwWTnR18vDVBqaUSZsK/OoybrHAaeIj2vM4Fp9b Jf8Q4wsQpsPnCUx2zwvOuHZ44FNPgdtqctKPwBz8WQbsnb74Q35q0vcv6VNIWfSpQo4c keB86CbjITwFfIaNeNwN9fSdlx5ei0AbLSIf1IY60ox/4wbILgkrc+zA/TtLdkZVadl6 DNioggNPXKXaS5Ucv9m5vXOOMQoCv88MEVeQSEI7EP7YnXp1Sjn8j+ML9ClWdraWEEs9 1kbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738363897; x=1738968697; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CRVZdM+iGM9ixXB9jH54KsnnAGGH880gk3OgBWFCBzc=; b=DlJGs1do3kKn8ufrnli+e/GKrpzMs638vKsZxDB9b2F5k134gaRZOKO8a1TfmYvtBT pcE/OCW7q84X1f0t03Hc+JCRna8a61Ums03gdzvUaKtUrDp/HfY8dt68Mr+ZWwQvLYQm hkXT0Ih0HvwKvJh+B5FrHidMsOKMzE2SnjvlwKMdCMblSOqt+dcI59aVmUOlTtZiFeIU ivAw8Uvs72g3CLs+ZlRTpJAs2A11u9ONZWFi0mBXNIJe6FX7DyqJU7lbl0wioxWALsWO rLfF+iJV2TBJ3rOZrD8KH3eGednDbZ5Yu57Md92IV4yoVk+EUMR12kXRAFI6rUfE8LUi BHYA== X-Forwarded-Encrypted: i=1; AJvYcCX5GoTUFJW75ym1jAmOz1AvkxPPVaFmAcrC0ebnm52xWvCU72z9hMQKTOOsOsgQQ3dSrQZkKWCXRA==@kvack.org X-Gm-Message-State: AOJu0Yz7Gty7HVCmZCwlBmtXR+imHBJlc1r9nvSugiBTLmWYVznOyrGT hDL5/8t+jCYSIeZUCZ7RGZ3+QjQgxvfFebQZMccBWweDYmQSwiKCHIAKzCriiGoOTWQ3hnRzTEQ T499rAUfCY3rwLOT429NZVbS4O5OvPbEHRPsU X-Gm-Gg: ASbGncuxF7JArz5VDKv8/9WUuC/9QvuvzgNt8e+U5GfnJkhipuD9pEtPBYurlJuZ9rb wPFu5aMvoyb0MydNGoI2d75ZvWmPGyVEq9wLxLyrpi006HOhBO2p3OvHCKBm5TYtXERaUGvLw X-Google-Smtp-Source: AGHT+IFn95EDOnLUL1dUh/vKQ/WcHaa4smXqFzp8XNAWIroKTAhFFlnSIRV81inl9dFmq/5Ed0TXvh8N3q1yC6FeJQc= X-Received: by 2002:a05:622a:5888:b0:466:90dd:19f3 with SMTP id d75a77b69052e-46ffa8a3422mr323001cf.7.1738363897110; Fri, 31 Jan 2025 14:51:37 -0800 (PST) MIME-Version: 1.0 References: <202501310832.kiAeOt2z-lkp@intel.com> In-Reply-To: From: Suren Baghdasaryan Date: Fri, 31 Jan 2025 14:51:26 -0800 X-Gm-Features: AWEUYZlLsJlinlpuc_ktKy61kMuqHR2WwvZrzqjG4qkcCrG5A1g2N4iZxUIhXLA Message-ID: Subject: Re: drivers/auxdisplay/panel.c:1454:2: error: call to __compiletime_assert_309 declared with 'error' attribute: BUILD_BUG_ON failed: !__builtin_constant_p(_dest_len) || _dest_len == (size_t)-1 To: kernel test robot Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List , Kent Overstreet , Kees Cook Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 562D81C0016 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 4rprfwfx3jmpbmtzpgipht4tdka9p46j X-HE-Tag: 1738363898-794569 X-HE-Meta: U2FsdGVkX1+voPLDZtRAi+80c9lSl1PIjsVQvLbJXUpc+evnUPsd+n2Y0pd/btVouRT3/g/Zao2yARKFJQUK1F4XtnTkDbingbBlCpLKYtbdxkJqbIkBgAX3xnZE8n9o7MXLMRWR17TnCvGEMZwbsNC8lN2E6IYaQnv2BP4MwxeIUo6MkYy7eVNiaMeaXce69IWjGnSNseb12bId6KE63sKeHHcZcBe4QyVhCQqkT3g/ak+bTE/71QuR6v2t/3c+PqNZoT/jLesO2vY58jV3q/ybD8RPAozvBa29//HYeVw9oRKDVAkgMjf6TjXr0lmhTKlAAoENI5g/kSEUhvoaBxMAcM5SyhLMjtvh3XIXEwzhf61kkqmWIOcuNQtPcBFahY9Jlw7CGV8JbojCwGg965Vbqb2AXF//goDoeMbARdHUx5Xp9wpblMt7fCK5BhTpiEyoZ6M0M5lM25wXBdLPhOoegrLVOt0pYvZL0V5kTzRNKJ83/Bh5LxNQm00yxmtymCKXEJlPnGUU8QkIsW50dYoHmnA5r1b/YKbSPoX1U/ncVvPkK4ujl0GKr1WGJYfmCna2n0r1QM4erwDgc9aIZ5+tMC8xdolVCRc125qFpAkf2hOMy61+RT3JVvEptcFpDrS8abdTuI8QnVELA4Q1ZXPmW1I0N7cA56AMwTvAX+7TF7wFFnMxbejv9SgbbbSnlPRqWBdq0FFo5Y9AhUMjrz8+yesCKU/LYogI/8ocWf+XDlX5LWkmPriIzNGuNEML0TbZ1Dv2L03kWxrwdb5RJPOFuFVCmk7d48d4tZqr5ouhaur6B+zW4NO8MrDWyts29F5Gu7s6rt2yXPXo7ieiaf+dtUPRV0412MVQY4+PRyiz2513p9arDlbzQTN6zeDNlJ/2hDIfa0XWhcZTf1bUyiMwXX/8MuhwxDVSYz3ZriJru+cZoDecPS5LxmLh9dh/ww5NBADbJpF7ZMZioZj P79saYr9 /gVWNJjkFFysQNAJIdNe9UjEd2u8WWOswIfFV4XKlFGwm9UO/7XXdqvyAm5apWi8PBrQ44SeouWoZqRWD94358kIWEa7KNPSsptwahShY3BB5Iod2EAdSkd8TCU4xtFMHgdWxSJ+zwwzTkwgBdbI8EhQLaQzB6yPhZgcmtB9RcaB/2Rx/gzKmpzDvNwUvEVdYwuPrXVkKa12X+nCSZTFfkoYe4322B4EafjVE2qAAhsdzkCShLwGC+uCFW4NLzyI4e2auhQvt9ENwMsrD0hwqsk7BC9CLjTqi++oZOGo715OghHOzCSldx1F5FT3DLy4Pcbr26vnhLbBgMZTKqPrPTWvoOOSgFRy6YPgOjv3VY4hQ5aT6Y6xbgJn1X9ZrTjyVlsZMnVup9YRfB4ko4hCDRHW2LiKL0DDqa99eV95jUo4Z7C/9QXEypJYIyIrzi62RSI2bEaKTtAyHz4I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 31, 2025 at 8:55=E2=80=AFAM Suren Baghdasaryan wrote: > > On Thu, Jan 30, 2025 at 4:06=E2=80=AFPM kernel test robot = wrote: > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.= git master > > head: b4b0881156fb8209bf5ef6cb63211bb0ad6e1a6b > > commit: 07438779313caafe52ac1a1a6958d735a5938988 alloc_tag: avoid curre= nt->alloc_tag manipulations when profiling is disabled > > date: 5 days ago > > config: hexagon-randconfig-r133-20250131 (https://download.01.org/0day-= ci/archive/20250131/202501310832.kiAeOt2z-lkp@intel.com/config) > > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f2= 8c006a5895fc0e329fe15fead81e37457cb1d1) > > reproduce: (https://download.01.org/0day-ci/archive/20250131/2025013108= 32.kiAeOt2z-lkp@intel.com/reproduce) > > Just saw this report (was on vacation). Will try to figure out what's goi= ng on. I confirmed that my change at https://lore.kernel.org/all/20241226211639.1357704-1-surenb@google.com indeed causes this. Looks like due to the additional mem_alloc_profiling_enabled() check, the compiler considers allocation size as unknown at compile time (__builtin_object_size(obj) returns -1) even though both branches of that condition make the same exact allocation. I tried changing it to: #define alloc_hooks_tag(_tag, _do_alloc) \ ({ \ typeof(_do_alloc) _res; \ struct alloc_tag * __maybe_unused _old; \ if (mem_alloc_profiling_enabled()) \ _old =3D alloc_tag_save(_tag); \ _res =3D _do_alloc; \ if (mem_alloc_profiling_enabled()) \ alloc_tag_restore(_tag, _old); \ _res; \ }) and that fixes the problem, however this would require two static key checks... I wonder if there is a way to tell the compiler that both branches cause the same result. Let me dig around. > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new ve= rsion of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202501310832.kiAeOt2z-l= kp@intel.com/ > > > > All errors (new ones prefixed by >>): > > > > >> drivers/auxdisplay/panel.c:1454:2: error: call to __compiletime_asse= rt_309 declared with 'error' attribute: BUILD_BUG_ON failed: !__builtin_con= stant_p(_dest_len) || _dest_len =3D=3D (size_t)-1 > > strtomem_pad(key->u.kbd.release_str, release, '\0'); > > ^ > > include/linux/string.h:417:2: note: expanded from macro 'strtomem_pa= d' > > BUILD_BUG_ON(!__builtin_constant_p(_dest_len) || = \ > > ^ > > include/linux/build_bug.h:50:2: note: expanded from macro 'BUILD_BUG= _ON' > > BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #conditi= on) > > ^ > > include/linux/build_bug.h:39:37: note: expanded from macro 'BUILD_BU= G_ON_MSG' > > #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) > > ^ > > note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-lim= it=3D0 to see all) > > include/linux/compiler_types.h:530:2: note: expanded from macro '_co= mpiletime_assert' > > __compiletime_assert(condition, msg, prefix, suffix) > > ^ > > include/linux/compiler_types.h:523:4: note: expanded from macro '__c= ompiletime_assert' > > prefix ## suffix(); = \ > > ^ > > :127:1: note: expanded from here > > __compiletime_assert_309 > > ^ > > 1 error generated. > > > > > > vim +/error +1454 drivers/auxdisplay/panel.c > > > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-13 1426 > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-13 1427 /* tries to bind a key to the signal name . The key = will send the > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-13 1428 * strings , , for these respecti= ve events. > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-13 1429 * Returns the pointer to the new key if ok, NULL if the k= ey could not be bound. > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-13 1430 */ > > 36d2041a3d57b9 drivers/staging/panel/panel.c Peter Huewe 2= 013-02-15 1431 static struct logical_input *panel_bind_key(const char *na= me, const char *press, > > 36d2041a3d57b9 drivers/staging/panel/panel.c Peter Huewe 2= 013-02-15 1432 const char *re= peat, > > 36d2041a3d57b9 drivers/staging/panel/panel.c Peter Huewe 2= 013-02-15 1433 const char *re= lease) > > 698b1515f03914 drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-22 1434 { > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-13 1435 struct logical_input *key; > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-13 1436 > > fdf4a4948ca8a1 drivers/staging/panel/panel.c Dominique van den Broeck 2= 014-05-21 1437 key =3D kzalloc(sizeof(*key), GFP_KERNEL); > > eb073a9bf2b6ed drivers/staging/panel/panel.c Toshiaki Yamane 2= 012-07-12 1438 if (!key) > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-13 1439 return NULL; > > eb073a9bf2b6ed drivers/staging/panel/panel.c Toshiaki Yamane 2= 012-07-12 1440 > > 698b1515f03914 drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-22 1441 if (!input_name2mask(name, &key->mask, &key->value= , &scan_mask_i, > > cb46f472cbb08c drivers/staging/panel/panel.c Kulikov Vasiliy 2= 010-07-12 1442 &scan_mask_o)) { > > cb46f472cbb08c drivers/staging/panel/panel.c Kulikov Vasiliy 2= 010-07-12 1443 kfree(key); > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-13 1444 return NULL; > > cb46f472cbb08c drivers/staging/panel/panel.c Kulikov Vasiliy 2= 010-07-12 1445 } > > 698b1515f03914 drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-22 1446 > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-13 1447 key->type =3D INPUT_TYPE_KBD; > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-13 1448 key->state =3D INPUT_ST_LOW; > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-13 1449 key->rise_time =3D 1; > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-13 1450 key->fall_time =3D 1; > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-13 1451 > > a952abcdaa2211 drivers/auxdisplay/panel.c Justin Stitt 2= 023-09-11 1452 strtomem_pad(key->u.kbd.press_str, press, '\0'); > > a952abcdaa2211 drivers/auxdisplay/panel.c Justin Stitt 2= 023-09-11 1453 strtomem_pad(key->u.kbd.repeat_str, repeat, '\0'); > > a952abcdaa2211 drivers/auxdisplay/panel.c Justin Stitt 2= 023-09-11 @1454 strtomem_pad(key->u.kbd.release_str, release, '\0'= ); > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-13 1455 list_add(&key->list, &logical_inputs); > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-13 1456 return key; > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-13 1457 } > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau 2= 008-11-13 1458 > > > > :::::: The code at line 1454 was first introduced by commit > > :::::: a952abcdaa22116d940ca9cb9253caad1622ae93 auxdisplay: panel: Repl= ace deprecated strncpy() with strtomem_pad() > > > > :::::: TO: Justin Stitt > > :::::: CC: Kees Cook > > > > -- > > 0-DAY CI Kernel Test Service > > https://github.com/intel/lkp-tests/wiki