From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA2A9C48260 for ; Fri, 16 Feb 2024 07:22:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 498F98D0010; Fri, 16 Feb 2024 02:22:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 420348D0001; Fri, 16 Feb 2024 02:22:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24BF18D0010; Fri, 16 Feb 2024 02:22:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0E1A68D0001 for ; Fri, 16 Feb 2024 02:22:35 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2CC72A0225 for ; Fri, 16 Feb 2024 07:22:33 +0000 (UTC) X-FDA: 81796824186.20.47A8C85 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by imf25.hostedemail.com (Postfix) with ESMTP id 38C2BA0002 for ; Fri, 16 Feb 2024 07:22:31 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0WKqehF0; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of surenb@google.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708068151; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+9+B+H3K0W9pJd8bNryL7B75GoSzScPALIXqjy44UEE=; b=XkxQSP4GDOI7WmemdAlFq3lhct4KZI0SvQf0/0v0eCCwD0HqNSMktaSslOCfDjsqdvUB7T OLIFrJG8z47AcP+bMZWoRr+2JIghAduzs6pxzM3YrMCxg5KdcBDyFj8V1GViTWQlBW67r3 yvVN2EHPn+CvQ4ac1fSU+xNAS/+SQqw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0WKqehF0; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of surenb@google.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708068151; a=rsa-sha256; cv=none; b=TobRebQLYfb/dQhoOw/MG2QZODxzMvgRHZCeOBlpm8YcR3Cxl0HZqf5Kt3WzxXNUaKQy8M HqT9b4XXwNgVkXqb0khdZoM46hCmAlFrJRMdSKcgIaRnDqFt6FpqLaLz9kR8mdk7Tueepu eQlU4pleryyG33O4hPEj9n8xTWJyJ1U= Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-607f8b96580so3933777b3.0 for ; Thu, 15 Feb 2024 23:22:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708068150; x=1708672950; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+9+B+H3K0W9pJd8bNryL7B75GoSzScPALIXqjy44UEE=; b=0WKqehF0sR+a7uzTzBSOClrcg9QDchzRPhcUxl+VNo2J1CBcf2Jn5c8+mEHXZWIFZl H+F+issqoCr9voUwsCHmQ/KJvnvSQWZ2sZ4tRGuhJx5YSLXe9600DBX/dpK594FGgJ8l cwv0pvV16M53cUf2mg5UFS2xvnHrRtmGP3CowTyDEXG51XvDqeuAYUJpej6eBQ6YZxmA O8kfC3WRFR5MqsmVjImfpsJyFNNa2lgD2/VMY8SIr73yHsQQiCZIcwxNq2WvgjIs54ov GYIb4l1dabaZoxWH4zyI0ZPDR9P6wBXE1Punk89jwDZTBx3/jBIMqfeBsPMNPNI394bg iKbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708068150; x=1708672950; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+9+B+H3K0W9pJd8bNryL7B75GoSzScPALIXqjy44UEE=; b=fswSp4cV0feig+7jxvW7g0UMcDDSi23qAgZdEPb//JkX3OA4CDQ+FmZ3swv+g0c/v9 xKM25NrPW5M0XH+hGU0RG+agJ6Wov4MwFyynJeIVq9pOrzGMVIO2GjY9AlqIV2sDQ93O 0KbxXc/g5Z2Yv1aNmQu5aX9jyHq6bPDd9XIfLuxmaU3XLDqkY/PEUr5upLjGyydrIDlr UGbdRwRaLEAJBhOZkZZdBe6DPqxbQWfnK/f4v0PKXvum9s3H2RmQ3hI+hfg18bEIYLi8 zvOAkkIRPIAAh8BwzOmUHY7b/Ag9JwCwjFxXMAqFjwKXUHH8B+NtzVKZKQ4eir6y0FOJ 57Kw== X-Forwarded-Encrypted: i=1; AJvYcCXQltaurc0v43fynX12C3gSIZ5k/cSUm52IRgP9xK2rJNl2PIQo8G1D09G1Ae6jd5DHO0qzfOUk1VG2MJGL7LXsFCQ= X-Gm-Message-State: AOJu0YyHZere0+o6Ri7Gjtd+aUIvrw/zrl4Aiqduvubx4H9xmVKOPSFL +msDNK9SmOnMZEFH1ss0kQOnmBklxNwEnZb5C3Lnvavg79CLbOZzVH6hszCDV5T65nfmmXkrozN An2/T9MN3tdCQfyTi7KBoH3k40HNgZsdPSUSY X-Google-Smtp-Source: AGHT+IGfhuzMecQLi+9TByo09qAXuYZmPn6jEQ/sIt9UYOpmXa2s1LS2SB61X5cRfaySalDuNypcx8p5p8IuAu0EvA8= X-Received: by 2002:a0d:cc81:0:b0:5f6:d447:b85a with SMTP id o123-20020a0dcc81000000b005f6d447b85amr4793609ywd.7.1708068149910; Thu, 15 Feb 2024 23:22:29 -0800 (PST) MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-11-surenb@google.com> <202402121419.7C4AAF27ED@keescook> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 15 Feb 2024 23:22:16 -0800 Message-ID: Subject: Re: [PATCH v3 10/35] lib: code tagging framework To: Kees Cook Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 38C2BA0002 X-Stat-Signature: aabzccnf68muojqimstfoqdscx9y5ka6 X-HE-Tag: 1708068151-830290 X-HE-Meta: U2FsdGVkX19FKHTZihbePiwgsjg+gRqu32u24wdoI5CdXkDQXPfhaQbMR94h9ouZx3B+LqpxWHEXGWX1o6LWgrPD2qfQdQjLgeUk+avhWYKmJ/S6O4+leeYHaNqLuZXTxYyPSgMFvoLyNDb5QMlhc4Se0UKxve1AnJ9aS73xexpePuT/x0jz8WDxXzm6IvusAZr1cdkIk+w+XLZKBHkNupBt4KQhuTwDZ4NxzXj17q+w84TFmDWLuoXidhxdB39RvNqseb58W/NquIbfurpY/umiVPYoypYiUjZoIK9HNjkZWHh3hlnJnmp+6Dg/wuz0/7R/ppLUQt2tNgDyI1XN3N1uphI1hrL9RrpNy6jOg+axuZXtelKmv30q0iteU0iMntcYqoJMp50X2rXSsQ0UWwziMzKR2+bRU2JDQgpvhInsKI5qGdEObgsyyfP60tWaC/LEmhN7ah+dtzNDIzvLXR8Oyp9xEPizxsulAJn5bpebgst+KTLQNvaE8JrzPiudNVZZ5iRfTr6WO0mxho/81GDw1y/z7WtQqqJN3bu531WEaBH5cJ33zleNcvDC78fUr0B1qC539YGuJ5sLDqkakl+ndpWyEr/xaC3I4L2s9zN5IX+DgrptaBYstbIVwXAtI0MxgUPIgYdBlsbS8mcLGZhVl9VijJPNdg8doxkAhdqJ6JTXTsVj11Evo10B6mBQSOQDyjAssRae8UIC2xh33DDtZhqqEdRAcxexCxuimcVmzAmetJMZnsI1zxjn29lGgA/gQ5NL1zlp3FD56Y7VYng9BucnOoNhUYtk8aPv389lcm0GrQL7IarTJIp+ZhneAuHHCJNRUFRc6RrGa1fNI6zLbaDRIoy/g1UPj039KrQF9jHWyJa9nz9pBjtM3h+2rif7gyfQeNUKr7DONB9gPWtPIZEDrnnmweiyywxIKDYun9f0ef5ms2L9XjNX6fIvYdoW1JdWVS9neRCq5qj dMkfPuQF WsIL7akKM3WdSjRJJM2RnZGBvikw4Dt5peM/YUrm2artZALs+eVNuy8X+zKij7moZuVfbMb+z+kbCo7XsC3aM+FRxq/ZWw9XZ2F9SN0drd7F3G3L3sT6zC2Pnf5LUZJN3Z7u9y9iEZ1pZ4FR9Gvs7mVa7Hc2hQp3YEZEONFd3J0I49ezpqvT5Frw333IPyWtj3dPsEQiqjNypmQBrFdr4wNonB20QlrYuOscux0449Ge/E3EKX++Kctk/1+LN4fsJcC81ShkCaicf8aYI0iaAQrq+pMQ6ZBwBhLsxtXHtaNbnRV60DWMmzjwWyQMa2YVOaN/zyml5ZIBfcs4AWSQeIH/HyI2ZsY0WDpN32Iq5TbCPqTWTRU+3nKMzejAEcx40eI5Z0GjFcZyflWN1FZYFvlUCgUn/jiCTfhd9YuMKFLxdbS2SaKnGjroYpA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 6:04=E2=80=AFPM Suren Baghdasaryan wrote: > > On Mon, Feb 12, 2024 at 2:27=E2=80=AFPM Kees Cook = wrote: > > > > On Mon, Feb 12, 2024 at 01:38:56PM -0800, Suren Baghdasaryan wrote: > > > Add basic infrastructure to support code tagging which stores tag com= mon > > > information consisting of the module name, function, file name and li= ne > > > number. Provide functions to register a new code tag type and navigat= e > > > between code tags. > > > > > > Co-developed-by: Kent Overstreet > > > Signed-off-by: Kent Overstreet > > > Signed-off-by: Suren Baghdasaryan > > > --- > > > include/linux/codetag.h | 71 ++++++++++++++ > > > lib/Kconfig.debug | 4 + > > > lib/Makefile | 1 + > > > lib/codetag.c | 199 ++++++++++++++++++++++++++++++++++++++= ++ > > > 4 files changed, 275 insertions(+) > > > create mode 100644 include/linux/codetag.h > > > create mode 100644 lib/codetag.c > > > > > > diff --git a/include/linux/codetag.h b/include/linux/codetag.h > > > new file mode 100644 > > > index 000000000000..a9d7adecc2a5 > > > --- /dev/null > > > +++ b/include/linux/codetag.h > > > @@ -0,0 +1,71 @@ > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > +/* > > > + * code tagging framework > > > + */ > > > +#ifndef _LINUX_CODETAG_H > > > +#define _LINUX_CODETAG_H > > > + > > > +#include > > > + > > > +struct codetag_iterator; > > > +struct codetag_type; > > > +struct seq_buf; > > > +struct module; > > > + > > > +/* > > > + * An instance of this structure is created in a special ELF section= at every > > > + * code location being tagged. At runtime, the special section is t= reated as > > > + * an array of these. > > > + */ > > > +struct codetag { > > > + unsigned int flags; /* used in later patches */ > > > + unsigned int lineno; > > > + const char *modname; > > > + const char *function; > > > + const char *filename; > > > +} __aligned(8); > > > + > > > +union codetag_ref { > > > + struct codetag *ct; > > > +}; > > > + > > > +struct codetag_range { > > > + struct codetag *start; > > > + struct codetag *stop; > > > +}; > > > + > > > +struct codetag_module { > > > + struct module *mod; > > > + struct codetag_range range; > > > +}; > > > + > > > +struct codetag_type_desc { > > > + const char *section; > > > + size_t tag_size; > > > +}; > > > + > > > +struct codetag_iterator { > > > + struct codetag_type *cttype; > > > + struct codetag_module *cmod; > > > + unsigned long mod_id; > > > + struct codetag *ct; > > > +}; > > > + > > > +#define CODE_TAG_INIT { \ > > > + .modname =3D KBUILD_MODNAME, \ > > > + .function =3D __func__, \ > > > + .filename =3D __FILE__, \ > > > + .lineno =3D __LINE__, \ > > > + .flags =3D 0, \ > > > +} > > > + > > > +void codetag_lock_module_list(struct codetag_type *cttype, bool lock= ); > > > +struct codetag_iterator codetag_get_ct_iter(struct codetag_type *ctt= ype); > > > +struct codetag *codetag_next_ct(struct codetag_iterator *iter); > > > + > > > +void codetag_to_text(struct seq_buf *out, struct codetag *ct); > > > + > > > +struct codetag_type * > > > +codetag_register_type(const struct codetag_type_desc *desc); > > > + > > > +#endif /* _LINUX_CODETAG_H */ > > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > > index 975a07f9f1cc..0be2d00c3696 100644 > > > --- a/lib/Kconfig.debug > > > +++ b/lib/Kconfig.debug > > > @@ -968,6 +968,10 @@ config DEBUG_STACKOVERFLOW > > > > > > If in doubt, say "N". > > > > > > +config CODE_TAGGING > > > + bool > > > + select KALLSYMS > > > + > > > source "lib/Kconfig.kasan" > > > source "lib/Kconfig.kfence" > > > source "lib/Kconfig.kmsan" > > > diff --git a/lib/Makefile b/lib/Makefile > > > index 6b09731d8e61..6b48b22fdfac 100644 > > > --- a/lib/Makefile > > > +++ b/lib/Makefile > > > @@ -235,6 +235,7 @@ obj-$(CONFIG_OF_RECONFIG_NOTIFIER_ERROR_INJECT) += =3D \ > > > of-reconfig-notifier-error-inject.o > > > obj-$(CONFIG_FUNCTION_ERROR_INJECTION) +=3D error-inject.o > > > > > > +obj-$(CONFIG_CODE_TAGGING) +=3D codetag.o > > > lib-$(CONFIG_GENERIC_BUG) +=3D bug.o > > > > > > obj-$(CONFIG_HAVE_ARCH_TRACEHOOK) +=3D syscall.o > > > diff --git a/lib/codetag.c b/lib/codetag.c > > > new file mode 100644 > > > index 000000000000..7708f8388e55 > > > --- /dev/null > > > +++ b/lib/codetag.c > > > @@ -0,0 +1,199 @@ > > > +// SPDX-License-Identifier: GPL-2.0-only > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +struct codetag_type { > > > + struct list_head link; > > > + unsigned int count; > > > + struct idr mod_idr; > > > + struct rw_semaphore mod_lock; /* protects mod_idr */ > > > + struct codetag_type_desc desc; > > > +}; > > > + > > > +static DEFINE_MUTEX(codetag_lock); > > > +static LIST_HEAD(codetag_types); > > > + > > > +void codetag_lock_module_list(struct codetag_type *cttype, bool lock= ) > > > +{ > > > + if (lock) > > > + down_read(&cttype->mod_lock); > > > + else > > > + up_read(&cttype->mod_lock); > > > +} > > > + > > > +struct codetag_iterator codetag_get_ct_iter(struct codetag_type *ctt= ype) > > > +{ > > > + struct codetag_iterator iter =3D { > > > + .cttype =3D cttype, > > > + .cmod =3D NULL, > > > + .mod_id =3D 0, > > > + .ct =3D NULL, > > > + }; > > > + > > > + return iter; > > > +} > > > + > > > +static inline struct codetag *get_first_module_ct(struct codetag_mod= ule *cmod) > > > +{ > > > + return cmod->range.start < cmod->range.stop ? cmod->range.start= : NULL; > > > +} > > > + > > > +static inline > > > +struct codetag *get_next_module_ct(struct codetag_iterator *iter) > > > +{ > > > + struct codetag *res =3D (struct codetag *) > > > + ((char *)iter->ct + iter->cttype->desc.tag_size= ); > > > + > > > + return res < iter->cmod->range.stop ? res : NULL; > > > +} > > > + > > > +struct codetag *codetag_next_ct(struct codetag_iterator *iter) > > > +{ > > > + struct codetag_type *cttype =3D iter->cttype; > > > + struct codetag_module *cmod; > > > + struct codetag *ct; > > > + > > > + lockdep_assert_held(&cttype->mod_lock); > > > + > > > + if (unlikely(idr_is_empty(&cttype->mod_idr))) > > > + return NULL; > > > + > > > + ct =3D NULL; > > > + while (true) { > > > + cmod =3D idr_find(&cttype->mod_idr, iter->mod_id); > > > + > > > + /* If module was removed move to the next one */ > > > + if (!cmod) > > > + cmod =3D idr_get_next_ul(&cttype->mod_idr, > > > + &iter->mod_id); > > > + > > > + /* Exit if no more modules */ > > > + if (!cmod) > > > + break; > > > + > > > + if (cmod !=3D iter->cmod) { > > > + iter->cmod =3D cmod; > > > + ct =3D get_first_module_ct(cmod); > > > + } else > > > + ct =3D get_next_module_ct(iter); > > > + > > > + if (ct) > > > + break; > > > + > > > + iter->mod_id++; > > > + } > > > + > > > + iter->ct =3D ct; > > > + return ct; > > > +} > > > + > > > +void codetag_to_text(struct seq_buf *out, struct codetag *ct) > > > +{ > > > + seq_buf_printf(out, "%s:%u module:%s func:%s", > > > + ct->filename, ct->lineno, > > > + ct->modname, ct->function); > > > +} > > > > Thank you for using seq_buf here! > > > > Also, will this need an EXPORT_SYMBOL_GPL()? Missed this question. I don't think we need EXPORT_SYMBOL_GPL() here at least for now. Modules don't use these functions. The "alloc_tags" sections will be generated for each module at compile time but they themselves do not use it. > > > > > + > > > +static inline size_t range_size(const struct codetag_type *cttype, > > > + const struct codetag_range *range) > > > +{ > > > + return ((char *)range->stop - (char *)range->start) / > > > + cttype->desc.tag_size; > > > +} > > > + > > > +static void *get_symbol(struct module *mod, const char *prefix, cons= t char *name) > > > +{ > > > + char buf[64]; > > > > Why is 64 enough? I was expecting KSYM_NAME_LEN here, but perhaps this > > is specialized enough to section names that it will not be a problem? > > This buffer is being used to hold the name of the section containing > codetags appended with "__start_" or "__stop_" and the only current > user is alloc_tag_init() which sets the section name to "alloc_tags". > So, this buffer currently holds either "alloc_tags__start_" or > "alloc_tags__stop_". When more codetag applications are added (like > the ones we have shown in the original RFC [1]), there would be more > section names. 64 was chosen as a big enough value to reasonably hold > the section name with the suffix. But you are right, we should add a > check for the section name size to ensure it always fits. Will add > into my TODO list. > > [1] https://lore.kernel.org/all/20220830214919.53220-1-surenb@google.com/ > > If so, please document it clearly with a comment. > > Will do. > > > > > > + int res; > > > + > > > + res =3D snprintf(buf, sizeof(buf), "%s%s", prefix, name); > > > + if (WARN_ON(res < 1 || res > sizeof(buf))) > > > + return NULL; > > > > Please use a seq_buf here instead of snprintf, which we're trying to ge= t > > rid of. > > > > DECLARE_SEQ_BUF(sb, KSYM_NAME_LEN); > > char *buf; > > > > seq_buf_printf(sb, "%s%s", prefix, name); > > if (seq_buf_has_overflowed(sb)) > > return NULL; > > > > buf =3D seq_buf_str(sb); > > Will do. Thanks! > > > > > > + > > > + return mod ? > > > + (void *)find_kallsyms_symbol_value(mod, buf) : > > > + (void *)kallsyms_lookup_name(buf); > > > +} > > > + > > > +static struct codetag_range get_section_range(struct module *mod, > > > + const char *section) > > > +{ > > > + return (struct codetag_range) { > > > + get_symbol(mod, "__start_", section), > > > + get_symbol(mod, "__stop_", section), > > > + }; > > > +} > > > + > > > +static int codetag_module_init(struct codetag_type *cttype, struct m= odule *mod) > > > +{ > > > + struct codetag_range range; > > > + struct codetag_module *cmod; > > > + int err; > > > + > > > + range =3D get_section_range(mod, cttype->desc.section); > > > + if (!range.start || !range.stop) { > > > + pr_warn("Failed to load code tags of type %s from the m= odule %s\n", > > > + cttype->desc.section, > > > + mod ? mod->name : "(built-in)"); > > > + return -EINVAL; > > > + } > > > + > > > + /* Ignore empty ranges */ > > > + if (range.start =3D=3D range.stop) > > > + return 0; > > > + > > > + BUG_ON(range.start > range.stop); > > > + > > > + cmod =3D kmalloc(sizeof(*cmod), GFP_KERNEL); > > > + if (unlikely(!cmod)) > > > + return -ENOMEM; > > > + > > > + cmod->mod =3D mod; > > > + cmod->range =3D range; > > > + > > > + down_write(&cttype->mod_lock); > > > + err =3D idr_alloc(&cttype->mod_idr, cmod, 0, 0, GFP_KERNEL); > > > + if (err >=3D 0) > > > + cttype->count +=3D range_size(cttype, &range); > > > + up_write(&cttype->mod_lock); > > > + > > > + if (err < 0) { > > > + kfree(cmod); > > > + return err; > > > + } > > > + > > > + return 0; > > > +} > > > + > > > +struct codetag_type * > > > +codetag_register_type(const struct codetag_type_desc *desc) > > > +{ > > > + struct codetag_type *cttype; > > > + int err; > > > + > > > + BUG_ON(desc->tag_size <=3D 0); > > > + > > > + cttype =3D kzalloc(sizeof(*cttype), GFP_KERNEL); > > > + if (unlikely(!cttype)) > > > + return ERR_PTR(-ENOMEM); > > > + > > > + cttype->desc =3D *desc; > > > + idr_init(&cttype->mod_idr); > > > + init_rwsem(&cttype->mod_lock); > > > + > > > + err =3D codetag_module_init(cttype, NULL); > > > + if (unlikely(err)) { > > > + kfree(cttype); > > > + return ERR_PTR(err); > > > + } > > > + > > > + mutex_lock(&codetag_lock); > > > + list_add_tail(&cttype->link, &codetag_types); > > > + mutex_unlock(&codetag_lock); > > > + > > > + return cttype; > > > +} > > > -- > > > 2.43.0.687.g38aa6559b0-goog > > > > > > > -- > > Kees Cook