From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90D53C3ABC0 for ; Thu, 8 May 2025 15:33:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E0AC6B0088; Thu, 8 May 2025 11:33:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 869816B008A; Thu, 8 May 2025 11:33:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E33B6B0093; Thu, 8 May 2025 11:33:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4B2FF6B0088 for ; Thu, 8 May 2025 11:33:21 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 829C31A08FE for ; Thu, 8 May 2025 15:33:22 +0000 (UTC) X-FDA: 83420134644.22.541B2D9 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf14.hostedemail.com (Postfix) with ESMTP id 9A95910000B for ; Thu, 8 May 2025 15:33:20 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LGLa9Als; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of surenb@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746718400; a=rsa-sha256; cv=none; b=zzfDm+Q9UsSNnvw0t6bvzO3wMxHDOaoYzFs3Lcofed/+O5P2u28VgDAxGRUl6YBh40sFlr 9c7rYkxzqeXBpLhWwhqRfGYQfnyPzcTKzln5MUCkhnkE0ACelxg+B81+U3rxJ0Kijj3jc9 YC+UYEQfOJxg2Ob4ZUrH2xgFwiN3WtY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LGLa9Als; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of surenb@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746718400; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i7UrJwqHyN6nLieuB0CXSWSKswqxfYhUPDWRmN9QmMs=; b=dLGddL/bN6K/qbUHvhR8tnPvcnALSOq3kLnWhlliwQtcJY7dsOQdUcOUapIOFZfwICW5V1 899sF8o1A2GgTRNsIOKBe8z9MhHTjBz+TghBzvDV7xkCBazIMorBwjPS9xDMc+letFF+ZI BHgZW/g5iKwdcl1ZeW2aEriqtQHwDFo= Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-47666573242so386141cf.0 for ; Thu, 08 May 2025 08:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746718400; x=1747323200; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=i7UrJwqHyN6nLieuB0CXSWSKswqxfYhUPDWRmN9QmMs=; b=LGLa9Alshm9YpfMtk2a8YTvmU8wHDiqehAgk20JvRr6MM+C7KYiIre0osDgh2t1Vft rtQGRYis+KKaA+NNqG22SqVGo3Y/AviBc9D04JBlga0e1zM4WjAY4710FPXESeCOgSjr OsZU47ngruAFb2oQOJQQjzcJOfHVVQ5jEt93KWr5kdvYVwoHagcPZnwY8kzGDHLp8eGY uA//rBCrBhy8XpzBjK7Rqc3RrhAh52lERzeVgLvSmAJjnzMaDYFQRZhIR0KE3vhCXK+K rhY/thO/Qhkiy5xuObqVYDQwPgEmMAfl7VPqS0sOytFfG1RAWOk1py0q2qwH7PaaJ9Q/ z2VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746718400; x=1747323200; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i7UrJwqHyN6nLieuB0CXSWSKswqxfYhUPDWRmN9QmMs=; b=Doh0+/gDNyTFkvnajbghHKvU/eldY0mGcVNeHMoNFFSoDiW+7PmlIjVm2M7kcwM/CC 6+TcWLjPRBsEhkQR5tsH0+s1mtYtwwqwkAXxyD4G9lKdjdRaR9ynv89JARhI5BIWuPXU bu2U7/gSleLpRKu5HzkeBkMaLemIRBKdUQfCtzVUw6meWUS4yvKW4ywp0esev5Ny9JLF 6HIXlz6MHdZEatNc3uzOHCgSiE2JCQSRtRgiJF7qseUHlbz1vNY9RFId8kaE0l/MW16Z qHU7Tk7SgIUhDDMbr+n0PRpiJqpOhNdB5bLnCH02tbbFCasXMweM9pN2OjXtdWIG6OlU 1boQ== X-Forwarded-Encrypted: i=1; AJvYcCV1Ms9+gZf/F2Wc3nFfbnvAn3FoeXAGVP97Sr0JTGXQJDd+mTCOWT0xdhGbdkf1urB34PqCuWGGnQ==@kvack.org X-Gm-Message-State: AOJu0YziQ68bpPjGle+BZDdhQ2cBjsTIqbdnN0SC7wRQ7Ihxx32+wNJ/ nHN/g1bWqytPI23e2MKjFaYPq9wYmd50ayC4wHtdc6wAo/MWKoXM4TyMbHWK7lNhesd2i0Q3YrG fMfgxCNyh8WLhxFx41V2MNzugWf3I98irfxbr X-Gm-Gg: ASbGncsjwgOlVgrUFR1jquWVnXbtjeCM9ADeQiDLyPRcGSBwPp5nS9uZukD8c0Xu3Dh PGstqzjmTHvnlcQno1STA9pf6VW4juNtft9UN930XUkQpOffl7jr0m7kv0iaD1CINjrX7THjgdv TlBGC6YVcF4qDmNoeV5LwQqKRN3LFUVzJYLOAErFdWJTlLPRjedxA= X-Google-Smtp-Source: AGHT+IE4OkzE3XHXp4+6aW8TNjQUp5iW7YxwFqtVgU8d1NQstvfcrpdZRx67gM/walW7wD4fOOwCumAvE0yErbBTLqI= X-Received: by 2002:ac8:578a:0:b0:48a:7cd7:7e21 with SMTP id d75a77b69052e-494499ec7b9mr5044651cf.20.1746718399217; Thu, 08 May 2025 08:33:19 -0700 (PDT) MIME-Version: 1.0 References: <20250508090735.39756-1-21cnbao@gmail.com> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 8 May 2025 08:33:08 -0700 X-Gm-Features: ATxdqUGxHcqt4ekvzUe2MnoOqj_5fDVgUtsq734BNASUrqc9o3A8YKRQls1Ed2w Message-ID: Subject: Re: [PATCH RFC] mm: userfaultfd: correct dirty flags set for both present and swap pte To: Peter Xu Cc: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , David Hildenbrand , Lokesh Gidra Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9A95910000B X-Stat-Signature: b9j6wtttta56c8p3m5puyi9y93wd8439 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746718400-652795 X-HE-Meta: U2FsdGVkX1/U+4Y6HXVJm0uRpigMqhBbanHjXEVZtwnd1qzrRTv5A50TV/rdk3O4qEkKaiQjkZNNL3zyjZWb22KkP8Wz4+zGQi4DmN7E1oRqMcUp4PAZHvjaXoxEUfIumpimv6H2mZP4Q8O50NRqeOx7gcvdEJ3ehyoZr85+H6W0BASDOuPSd3kE1+dCroGQGytHw6saH6Nb3chpz8+8JK0t2KPX4wXd/qStCZ/tqDDFKk/UWkw8iPLlrBGZ+diCPgrFJzBti0Zz+iF/d+CrzjctqpxI242nxTNze9jBz198ZpbwsV+/OsymAXHJbQBwPXBpsrsC9CFTW3cc2DD//vhztsL8yCmOrA4cVdRFK7w+IkdSVaY3rRD1evZtf9p6R08dDZ+vxHl9c0ZXLTeC1iny0kjHQLYnOQraG/MF7ZnbZzo961mYglbQ5DKSs1uIZoV8yoyQGxPIfpa1Fln6A8m9IPhfbaNJEf9t/raFt+oSmcCMK7IDEZF3AKn4e0owN8eq7GDhFYpCvX7TOLua5N9PCFYCZfi43JV1RzOfP75jTKFCLwsR/AANlan8/l8CgDk+uZ9OFK4pTF+tKh1HLVMYeYx/avxtAj4thk9U7F3j8DPwmmuHtQ7NWP95vpTwElttrXyP5gJ0Hes0IhWWFm3g715OLcBY2TiI9tYIHRKCf1uf97X76CWHFydgO/zRtGPYkN/qIidXGV7Dys9+rNngDXL+xV7sz4cojwCp8qirDNtAEY8o3jNYxRPRp8DMjGVLWdaF8ExY/7UeDTucw4KOlVpH5EvzqoQY2IAycrqUMgX04GcwgE0j3CQwiJMGn1HfhT8Gg8/KYZy5icAUpF7pxJjR9UprSy7xdZkISjFZ5R+U5FnYw7AGaQyfKatDIlRYAo4+Go4ogi5yAXHRBmdezoNsFd3zKPLF5VGpdsDBhjuhkK3kQAPUDhrkJTk0PfAu4vkV0v76qSQJUmd 6wl0RqSs C3H6bY+++tEnco6BxTuoYwIUoVUd2FQBgdt1EL3WzRn4hSQxP9SsaLYGlJ8tnhXLKWri8+CVEcf/96u5QBAWnhAVc6HDenpAp9wUT6ec2yAGBrY4bWu0OH+FPCRwRLJuBO8e+PBEsVlkhfnDn6VUtwqIVunRYDSf+mGxypWp6owB8fdZCLvPoK/ykM0YiGHr6Tta1LRACb8ehLhJWf05p1IA2JmmXml5r+/Tuyial7mDAONgyUKtUdfXDJpH2OBeO4hV5jK0H98v3iZXhzKzsW3Cxlu72fx50VcmW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 8, 2025 at 8:23=E2=80=AFAM Peter Xu wrote: > > On Thu, May 08, 2025 at 09:07:35PM +1200, Barry Song wrote: > > From: Barry Song > > > > As David pointed out, what truly matters for mremap and userfaultfd > > move operations is the soft dirty bit. The current comment and > > implementation=E2=80=94which always sets the dirty bit for present PTEs > > and fails to set the soft dirty bit for swap PTEs=E2=80=94are incorrect= . > > This patch updates the behavior to correctly set the soft dirty bit > > for both present and swap PTEs in accordance with mremap. > > > > Reported-by: David Hildenbrand > > Closes: https://lore.kernel.org/linux-mm/02f14ee1-923f-47e3-a994-4950af= b9afcc@redhat.com/ > > Cc: Peter Xu > > Cc: Suren Baghdasaryan > > Cc: Lokesh Gidra > > Signed-off-by: Barry Song > > Acked-by: Peter Xu Reviewed-by: Suren Baghdasaryan The function was introduced in 6.8. We should probably CC stable as well. > > -- > Peter Xu >